clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
632 commits 1 branch 0 tags 11 MiB
Commit graph

55 commits

Author SHA1 Message Date
ragnarok-clanker
88d8e9e378 Decompile 2 functions in Source/Contents/EffectResourceSwitcher.cpp, Source/Contents/EffectResourceSwitcher.h, ... 
Batch #1977 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03113 EffectResourceSwitcher::Slot16: logic confirmed by peer review
- fn_03115 Singleton<CEZ2STREffectMgr>::GetInstance: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Reviewed-by: ragnarok-clanker
 2026-10-29 08:58:09 +00:00
ragnarok-clanker
4e738dea03 Decompile fn_20416 (MD5State::Init) 
Batch #1868 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_20416 MD5State::Init: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Utility/Md5.cpp
 2026-10-28 23:05:27 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:49:51 +00:00
ragnarok-clanker
e6834bc146 Decompile fn_09430 (UICashEmotionMiniWnd::Refresh) 
Batch #1767 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_09430 UICashEmotionMiniWnd::Refresh: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:10:32 +00:00
ragnarok-clanker
e8a6a7d816 Decompile 4 functions in Source/Contents/NavigationRoute.cpp, Source/Contents/NavigationManager.h, ... 
Batch #1397 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_19376 NavigationManager::FindObject: logic confirmed by peer review
- fn_19434 NavigationObject::HasName: logic confirmed by peer review
- fn_19613 NavigationManager::LoadSettings: logic confirmed by peer review
- fn_19618 NavigationManager::FitToSquare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/NavigationRoute.cpp
 2026-10-28 12:35:52 +00:00
ragnarok-clanker
9f6fb7853f Decompile fn_02021 (??0AngleTables@?A0x87babb67@@QAE@XZ) 
Batch #1298 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02021 ??0AngleTables@?A0x87babb67@@QAE@XZ: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
 2026-10-28 11:06:58 +00:00
ragnarok-clanker
611a78a1e9 Decompile 2 functions in Source/Utility/GGHash.cpp, Source/Utility/GGHash.h 
Batch #1350 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00116 CGGHash::VerifyBuffer: logic confirmed by peer review
- fn_00117 CGGHash::VerifyFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:05:16 +00:00
ragnarok-clanker
8be53994ff Decompile 2 functions in Source/Utility/GGHash.cpp, Source/Utility/GGHash.h 
Batch #1349 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00119 CGGHash::VerifyBuffer: logic confirmed by peer review
- fn_00120 CGGHash::VerifyFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:05:05 +00:00
ragnarok-clanker
d0e1791277 Decompile fn_00115 (CGGHash::Load) 
Batch #1348 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_00115 CGGHash::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:04:53 +00:00
ragnarok-clanker
1b8deb39b1 Decompile 2 functions in Source/Utility/Cipher/Rijndael.cpp, Source/Utility/Cipher/Rijndael.h 
Batch #1234 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04399 DecryptRijndael192: logic confirmed by peer review
- fn_04400 DecryptRijndael256: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-27 22:32:59 +00:00
ragnarok-clanker
10629c8c31 Decompile 2 functions in Source/Utility/Cipher/Rijndael.cpp, Source/Utility/Cipher/Rijndael.h 
Batch #1232 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04399 DecryptAes192: logic confirmed by peer review
- fn_04400 DecryptAes256: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-27 22:13:46 +00:00
ragnarok-clanker
1f93a13078 Decompile fn_04413 (EncodeBase64) 
Batch #1225 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04413 EncodeBase64: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-27 21:46:03 +00:00
ragnarok-clanker
00a5524b60 Decompile 18 functions in Source/Utility/XxHash3.cpp, Source/Utility/XxHash3.h 
Batch #1104 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_00164 XXH3_128bits: logic confirmed by peer review
- fn_00165 XXH3_128bits_withSecret: logic confirmed by peer review
- fn_00166 XXH3_128bits_withSeed: logic confirmed by peer review
- fn_00167 XXH3_64bits: logic confirmed by peer review
- fn_00168 XXH3_64bits_withSecret: logic confirmed by peer review
- fn_00169 XXH3_64bits_withSeed: logic confirmed by peer review
- fn_00170 XXH3_hashLong_128b_default: logic confirmed by peer review
- fn_00171 XXH3_hashLong_128b_withSeed: logic confirmed by peer review
- fn_00172 XXH3_hashLong_64b_default: logic confirmed by peer review
- fn_00173 XXH3_hashLong_64b_withSeed: logic confirmed by peer review
- fn_00174 XXH3_len_129to240_128b: logic confirmed by peer review
- fn_00175 XXH3_len_129to240_64b: logic confirmed by peer review
- fn_00176 XXH3_mergeAccs: logic confirmed by peer review
- fn_00177 XXH3_reset_internal: logic confirmed by peer review
- fn_00178 XXH3_rrmxmx: logic confirmed by peer review
- fn_00179 XXH64_avalanche: logic confirmed by peer review
- fn_00180 XXH64_finalize: logic confirmed by peer review
- fn_00181 XXH64_round: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-27 21:08:21 +00:00
ragnarok-clanker
86c790f5b6 Decompile 13 functions in Source/Utility/Async/NRecycleObject.h 
Batch #1146 by eAthena: 0 byte-identical, 13 confirmed by peer review.

- fn_02553 NRecycleObjectPool<CLoadPartyInfoAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02554 NRecycleObjectPool<CChangePartyMasterAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02555 NRecycleObjectPool<CStopRecruitingAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02556 NRecycleObjectPool<CRegisterPartyAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02557 NRecycleObjectPool<CLoadMyPartyAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02558 NRecycleObjectPool<CLoadPartyListAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02559 NRecycleObjectPool<CMCStoreInfoBackupSaveAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02560 NRecycleObjectPool<CMCStoreInfoBackupLoadAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02561 NRecycleObjectPool<CEmblemDataDownloadAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02562 NRecycleObjectPool<CEmblemDataUploadAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02563 NRecycleObjectPool<CCharacterLinkedUserDataSaveAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02564 NRecycleObjectPool<CCharacterLinkedUserDataLoadAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)
- fn_02565 NRecycleObjectPool<CAccountLinkedUserDataSaveAsyncWork>::Acquire: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
 2026-10-27 21:05:59 +00:00
ragnarok-clanker
176df73ee4 Decompile 2 functions in Source/Utility/GGHash.cpp, Source/Utility/GGHash.h 
Batch #1127 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_00109 CGGHash::CGGHash: logic confirmed by peer review
- fn_00118 CGGHash::`scalar deleting destructor': logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 20:13:40 +00:00
ragnarok-clanker
ed6851d07c Decompile 2 functions in Source/Utility/GGHash.cpp, Source/Utility/GGHash.h 
Batch #1128 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_00113 CGGHash::GetSize: byte-identical
- fn_00114 CGGHash::GetError: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Utility/GGHash.cpp
 2026-10-27 20:09:58 +00:00
ragnarok-clanker
62e3755d74 Decompile fn_00182 (XXH_versionNumber) 
Batch #1105 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_00182 XXH_versionNumber: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Utility/XxHash3.cpp
 2026-10-27 18:04:52 +00:00
ragnarok-clanker
1d0e5dc05e Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Utility headers (Async, Math, Threading) 
Batch #1057 by ragnarok-clanker: no function's compiled code changes; checked with 75 compiled unit(s), including every includer of Source/Utility/Async/AsyncDiagnostic.h, Source/Utility/Async/NAsyncWorkQueue.h, Source/Utility/Async/NMessageQueue.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/Math/AffineMatrix.h, Source/Utility/Threading/CSyncObject.h, Source/Utility/Threading/NSyncObject.h.
 2026-10-27 13:40:06 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
6188ab372a Decompile fn_04414 (EncodeBase64) 
Batch #1029 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_04414 EncodeBase64: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 10:04:17 +00:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00
ragnarok-clanker
279b86f980 Merge branch 'main' of http://forgejo:3000/clank/rodecomp 2026-10-27 08:58:12 +00:00
ragnarok-clanker
9886d0e91c 📝 docs(ScalarConversion): added inlined comment to TruncateToInt 2026-10-27 09:54:24 +01:00
ragnarok-clanker
d54f050f5b Decompile 3 functions in Source/Utility/Tokenizer.cpp, Source/Utility/Tokenizer.h 
Batch #988 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_07779 CTokenizer::operator[]: logic confirmed by peer review
- fn_18248 CTokenizer::Parse: logic confirmed by peer review
- fn_18261 CTokenizer::Parse: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/Tokenizer.cpp
 2026-10-27 08:50:11 +00:00
ragnarok-clanker
35b31fdf7b Decompile 6 functions in Source/Archive/PakRegistry.h, Source/Render/DeviceContext/DCSurface.h, ... 
Batch #937 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_17771 LanguageCharset: logic confirmed by peer review (annotation added to existing code)
- fn_17773 LanguageCodePage: logic confirmed by peer review (already on main)
- fn_02102 GetRenderSystemHolder: logic confirmed by peer review
- fn_18112 PakRegistry::Read: logic confirmed by peer review (already on main)
- fn_18114 PakRegistry::ReadArchive: logic confirmed by peer review (already on main)
- fn_04728 CMouse::Center: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-26 23:29:56 +00:00
ragnarok-clanker
bb091ae751 Decompile 4 functions in Source/File/FileCreation.cpp, Source/File/FileCreation.h, ... 
Batch #869 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18255 CreateDirectoryPath: logic confirmed by peer review
- fn_18256 CreateUniqueFileName: logic confirmed by peer review
- fn_18252 FormatOwnedString: logic confirmed by peer review
- fn_03451 StringFormat: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/File/FileCreation.cpp
 2026-10-26 22:55:38 +00:00
ragnarok-clanker
7b9898cab9 Decompile 3 functions in Source/Utility/SHA3.cpp, Source/Utility/SHA3.h 
Batch #866 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_04423 SHA3::Add: logic confirmed by peer review
- fn_04424 SHA3::GetHash: logic confirmed by peer review
- fn_04425 SHA3::ProcessBlock: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/SHA3.cpp
 2026-10-26 22:55:21 +00:00
ragnarok-clanker
d985a63065 Decompile 4 functions in Source/Utility/RegistryKey.cpp, Source/Utility/RegistryKey.h 
Batch #864 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18150 RegistryKey::Create: logic confirmed by peer review
- fn_18151 RegistryKey::Open: logic confirmed by peer review
- fn_18152 RegistryKey::Query: logic confirmed by peer review
- fn_18153 RegistryKey::Set: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/RegistryKey.cpp
 2026-10-26 22:54:37 +00:00
ragnarok-clanker
daa7e4690a Confirm fn_17773 (LanguageCodePage) 
Batch #861 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17773 LanguageCodePage: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-26 22:54:07 +00:00
ragnarok-clanker
315559e0b8 Decompile 14 functions in Source/Utility/MD5.cpp, Source/Utility/MD5.h 
Batch #859 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_00122 MD5::~MD5: logic confirmed by peer review
- fn_00123 MD5::Decode: logic confirmed by peer review
- fn_00124 MD5::Initialize: logic confirmed by peer review
- fn_00125 MD5::Transform: logic confirmed by peer review
- fn_00126 MD5::Update: logic confirmed by peer review
- fn_00127 MD5::Finalize: logic confirmed by peer review
- fn_00128 MD5::DigestBuffer: logic confirmed by peer review
- fn_00129 MD5::HashBuffer: logic confirmed by peer review
- fn_00130 MD5::HashString: logic confirmed by peer review
- fn_00131 MD5::HashString: logic confirmed by peer review
- fn_00132 MD5::HashFile: logic confirmed by peer review
- fn_00133 MD5::HashStringLower: logic confirmed by peer review
- fn_00134 MD5::HashStringLower: logic confirmed by peer review
- fn_00135 MD5::HashFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/MD5.cpp
 2026-10-26 22:53:51 +00:00
ragnarok-clanker
3a5e3ddd15 Decompile 6 functions in Source/Utility/FileSignatureVerifier.cpp, Source/Utility/FileSignatureVerifier.h 
Batch #858 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_00136 FileSignatureVerifier::FileSignatureVerifier: logic confirmed by peer review
- fn_45444 FileSignatureVerifier::~FileSignatureVerifier: logic confirmed by peer review
- fn_00138 FileSignatureVerifier::VerifyBuffer: logic confirmed by peer review
- fn_00139 FileSignatureVerifier::VerifyFile: logic confirmed by peer review
- fn_00140 FileSignatureVerifier::VerifyBuffer: logic confirmed by peer review
- fn_00141 FileSignatureVerifier::VerifyFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/FileSignatureVerifier.cpp
 2026-10-26 22:53:49 +00:00
ragnarok-clanker
94eb5ab852 Decompile fn_07589 (NFileLog::Initialize) 
Batch #857 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07589 NFileLog::Initialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/NFileLog.cpp
 2026-10-26 22:53:19 +00:00
ragnarok-clanker
e99b978f19 Decompile 3 functions in Source/Utility/NIPAddr.cpp, Source/Utility/NIPAddr.h 
Batch #853 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_07599 NIPAddr::NIPAddr: logic confirmed by peer review
- fn_07601 NIPAddr::~NIPAddr: logic confirmed by peer review
- fn_07603 NIPAddr::IsPrivateAddress: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/NIPAddr.cpp
 2026-10-26 22:53:01 +00:00
ragnarok-clanker
81e3560708 Decompile 6 functions in Source/Utility/AES.cpp, Source/Utility/AES.h 
Batch #851 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_04417 AES::~AES: logic confirmed by peer review
- fn_04418 AES::Decrypt: logic confirmed by peer review
- fn_04419 AES::Initialize: logic confirmed by peer review
- fn_04420 AES::Initialize: logic confirmed by peer review
- fn_04421 AES::SetIV: logic confirmed by peer review
- fn_04422 AES::SetMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/AES.cpp
 2026-10-26 22:52:29 +00:00
ragnarok-clanker
8268da4030 Decompile 4 functions in Source/Utility/Math/AffineMatrix.cpp, Source/Utility/Math/AffineMatrix.h 
Batch #848 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02026 AffineMatrix::IsIdentity: logic confirmed by peer review
- fn_02028 AffineMatrix::SetScale: logic confirmed by peer review
- fn_02031 AffineMatrix::SetAxisRotation: logic confirmed by peer review
- fn_02032 AffineMatrix::SetTranslation: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:52:27 +00:00
ragnarok-clanker
0e34f07e13 Decompile 10 functions in Source/Utility/CRC32.cpp, Source/Utility/CRC32.h 
Batch #850 by ragnarok-clanker: 0 byte-identical, 10 confirmed by peer review.

- fn_00142 CRC32::CRC32: logic confirmed by peer review
- fn_00143 CRC32::~CRC32: logic confirmed by peer review
- fn_00144 CRC32::Update: logic confirmed by peer review
- fn_00145 CRC32::UpdateFile: logic confirmed by peer review
- fn_00146 CRC32::Calculate: logic confirmed by peer review
- fn_00147 CRC32::Calculate: logic confirmed by peer review
- fn_00148 CRC32::CalculateLowercase: logic confirmed by peer review
- fn_00149 CRC32::CalculateLowercase: logic confirmed by peer review
- fn_00150 CRC32::Calculate: logic confirmed by peer review
- fn_00151 CRC32::CalculateFile: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/CRC32.cpp
 2026-10-26 22:52:17 +00:00
ragnarok-clanker
a74163aa29 Decompile fn_18259 (FormatGuid) 
Batch #849 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18259 FormatGuid: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 22:52:03 +00:00
ragnarok-clanker
34640f204c Decompile 4 functions in Source/Utility/ProcessSecurity.cpp, Source/Utility/ProcessSecurity.h 
Batch #845 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18122 RemoveProtectionTools: logic confirmed by peer review
- fn_18123 SetDebugPrivilege: logic confirmed by peer review
- fn_18124 LoadLibraryFunctions: logic confirmed by peer review
- fn_18125 IsLegacyWindows: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/ProcessSecurity.cpp
 2026-10-26 22:51:40 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance 
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
 2026-10-26 23:41:07 +01:00
ragnarok-clanker
e5031b68a9 Decompile fn_17631 (MatchLexicon) 
Batch #842 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17631 MatchLexicon: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/LexiconMatcher.cpp
 2026-10-26 22:06:51 +00:00
ragnarok-clanker
3897c27241 Decompile 4 functions in Source/Contents/ActorGeometry.cpp, Source/Contents/Actors/RenderObject.h, ... 
Batch #837 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_21007 CRenderObject::Heading: logic confirmed by peer review
- fn_21008 CRenderObject::Face: logic confirmed by peer review
- fn_21009 CRenderObject::HorizontalDistance: logic confirmed by peer review
- fn_21010 CRenderObject::Distance: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ActorGeometry.cpp
 2026-10-26 21:51:37 +00:00
ragnarok-clanker
9e8afe0df6 Decompile 2 functions in Source/Utility/LexiconSerializer.cpp, Source/Utility/LexiconSerializer.h 
Batch #841 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17630 LexiconSerializer::Destroy: logic confirmed by peer review
- fn_17633 LexiconSerializer::Serialize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/LexiconSerializer.cpp
 2026-10-26 21:51:25 +00:00
ragnarok-clanker
c029673ec9 Decompile 3 functions in Source/Utility/TextTokens.cpp, Source/Utility/TextTokens.h 
Batch #840 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_01963 IsPipeColorToken: logic confirmed by peer review
- fn_01964 IsHexColorToken: logic confirmed by peer review
- fn_13883 StripColorTokens: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/TextTokens.cpp
 2026-10-26 21:50:40 +00:00
ragnarok-clanker
02d760984c Decompile fn_18244 (DecodeTextEscapes) 
Batch #835 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18244 DecodeTextEscapes: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/TextEscapes.cpp
 2026-10-26 21:49:45 +00:00
ragnarok-clanker
f66874c19f Decompile fn_17634 (LexiconBoundary::Matches) 
Batch #834 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17634 LexiconBoundary::Matches: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/LexiconBoundary.cpp
 2026-10-26 21:49:26 +00:00
ragnarok-clanker
5a761209d2 Decompile 2 functions in Source/Utility/XxHash32.cpp, Source/Utility/XxHash32.h 
Batch #832 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00162 XxHash32: logic confirmed by peer review
- fn_00163 FinalizeXxHash32: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/XxHash32.cpp
 2026-10-26 21:49:13 +00:00
ragnarok-clanker
740b67081d Decompile 10 functions in Source/Utility/Timestamp.cpp, Source/Utility/Timestamp.h 
Batch #830 by ragnarok-clanker: 0 byte-identical, 10 confirmed by peer review.

- fn_18085 Timestamp::ToSqlTimestamp: logic confirmed by peer review
- fn_18086 Timestamp::IsBefore: logic confirmed by peer review
- fn_18087 Timestamp::IsBeforeNow: logic confirmed by peer review
- fn_18088 Timestamp::Day: logic confirmed by peer review
- fn_18089 Timestamp::Hour: logic confirmed by peer review
- fn_18090 Timestamp::Minute: logic confirmed by peer review
- fn_18091 Timestamp::Month: logic confirmed by peer review
- fn_18092 Timestamp::Second: logic confirmed by peer review
- fn_18093 Timestamp::Year: logic confirmed by peer review
- fn_18094 Timestamp::SetDate: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:48:54 +00:00
ragnarok-clanker
820df68d42 Decompile fn_18251 (GenerateRadialGrid) 
Batch #829 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18251 GenerateRadialGrid: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Utility/RadialGrid.cpp
 2026-10-26 21:48:52 +00:00
ragnarok-clanker
1dccbfbae5 Maintenance: Annotate globals on their definitions only; drop annotations from header externs 
Batch #904 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/Contents/MessageTable.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemDataMgr.h, Source/Contents/Hotkeys/UserHotkeyMgr.h, Source/Contents/Messenger/WhisperBlockMgr.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/CharacterLinkedUserDataMgr.h, Source/Network/TextEncoding.h, Source/Network/Http/CURLMgr.h, Source/Render/Textures/Texture.h, Source/UI/Layout/SnapMgr.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIWindow.h, Source/Utility/Async/NMessageMgr.h.
 2026-10-26 18:25:54 +00:00
ragnarok-clanker
5fcef82f97 Decompile fn_00121 (MD5::MD5) 
Batch #860 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_00121 MD5::MD5: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Utility/MD5.cpp
 2026-10-25 19:41:16 +00:00