Commit graph

7 commits

Author SHA1 Message Date
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
8ef10a001a Decompile 3 functions in Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameCard.h, ...
Batch #3101 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_03508 CActorNameCardHolder::SetValue3: logic confirmed by peer review
- fn_03509 CActorNameCardHolder::SetValue4: logic confirmed by peer review
- fn_03557 UINavigationV4Wnd::DrawMapTexture: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:32:03 +00:00
ragnarok-clanker
ab16915c1e Decompile 2 functions in Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameCard.h
Batch #1248 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_03505 CActorNameCardHolder::Set: logic confirmed by peer review
- fn_03507 CActorNameCardHolder::SetName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 23:23:10 +00:00
ragnarok-clanker
e0997ca0e5 Decompile 3 functions in Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameCard.h
Batch #890 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_03484 CActorNameCard::CActorNameCard: logic confirmed by peer review
- fn_03485 CActorNameCard::~CActorNameCard: logic confirmed by peer review
- fn_03493 CActorNameCardHolder::~CActorNameCardHolder: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 22:55:47 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
710d01dd99 Decompile fn_03502 (CActorNameCardHolder::Clear)
Batch #891 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03502 CActorNameCardHolder::Clear: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-26 12:02:11 +00:00
ragnarok-clanker
1deabc9a4d Decompile fn_03487 (CActorNameCard::Reset)
Batch #887 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_03487 CActorNameCard::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameDirectory.cpp
2026-10-26 11:54:34 +00:00