Commit graph

58 commits

Author SHA1 Message Date
ragnarok-clanker
a364ce2b77 Decompile fn_02011 (ModelMesh::CalculateNormals)
Batch #15915 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_02011 ModelMesh::CalculateNormals: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 12:08:40 +00:00
ragnarok-clanker
3f31288fe8 Decompile fn_08007 (AnimatedModelNode::Shade)
Batch #15344 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_08007 AnimatedModelNode::Shade: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 21:31:57 +00:00
ragnarok-clanker
399245234c Decompile 2 functions in Source/Resource/Models/ModelResource.cpp
Batch #15319 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_08008 C3dGrannyModelRes::ProjectBounds: logic confirmed by peer review
- fn_08009 C3dGrannyModelRes::InstantiateModel: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 21:03:21 +00:00
ragnarok-clanker
e69af98c77 Decompile 2 functions in Source/Resource/Models/ModelResourceV2.cpp
Batch #15309 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:50:58 +00:00
ragnarok-clanker
72496ab386 Decompile fn_07996 (ModelNode::~ModelNode)
Batch #14948 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 00:48:11 +00:00
ragnarok-clanker
fdbebbba25 Maintenance: Second pass on unknown_XXXX members: 140 more renamed (61 files), named from the original binary (accesses at this+offse
Batch #14947 by ragnarok-clanker: no function's compiled code changes; checked with 596 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/EquipWindowLook.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GraffiSkill.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/Camera/Camera.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/Items/ItemInfo.h, Source/Render/SpriteQuad.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/World/WorldResource.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/MiniPartyGrid.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UIWindowMgr.h.
2026-11-08 18:16:10 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
88d157a5df Decompile fn_08005 (GrannyAnimationLibrary::Load)
Batch #14902 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_08005 GrannyAnimationLibrary::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, ntrl, codeplay, NYD
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-08 06:27:47 +00:00
ragnarok-clanker
f42c9f1149 Decompile fn_07963 (C3dGrannyModelRes::Load)
Batch #14867 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_07963 C3dGrannyModelRes::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, codeplay, NYD
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-08 00:15:28 +00:00
ragnarok-clanker
3ab8543361 Decompile fn_08007 (AnimatedModelNode::Shade)
Batch #14855 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_08007 AnimatedModelNode::Shade: logic confirmed by peer review

Peer-reviewed-by: eAthena, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 19:24:19 +00:00
ragnarok-clanker
ab9a85e6c3 Decompile fn_07963 (C3dGrannyModelRes::Load)
Batch #14138 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_07963 C3dGrannyModelRes::Load: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, secret, Tanke, codeplay, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 18:00:19 +00:00
ragnarok-clanker
adbe1db7e1 Decompile 3 functions in Source/Resource/Models/ModelResourceV2.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #14636 by secret: 0 byte-identical, 3 confirmed by peer review.

- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review

Peer-reviewed-by: Tanke, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:22:36 +00:00
ragnarok-clanker
ffbeee0f2a Maintenance: Forced maintainer submission (resubmission of 14678 after td sync to 8deac7a3; replaces 14460 and 14473). Native-run fix
Batch #14681 by ragnarok-clanker: forced by an admin (6 lower score(s), 70 changed function(s)); checked with 555 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObject.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/CartCannon.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Ground/GroundGeometry.h, Source/Network/Connection/Connection.h, Source/Resource/Audio/WaveResource.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/EZeffectResource.h, Source/Resource/EmblemResource.h, Source/Resource/GifResource.h, Source/Resource/ImfResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelResource.h, Source/Resource/PaletteResource.h, Source/Resource/RmaResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/Sprites/SpriteResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/TerrainResource.h, Source/Resource/World/WorldResource.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UITextButton.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UINewSelectCharWnd.h.
2026-11-07 14:05:21 +00:00
ragnarok-clanker
3ee8568d9e Decompile fn_07958 (C3dAnimModelRes::Load)
Batch #14063 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:13:13 +00:00
ragnarok-clanker
1a6cbc49fd Decompile fn_07954 (C3dModelResV2::Load)
Batch #14045 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_07954 C3dModelResV2::Load: logic confirmed by peer review

Peer-reviewed-by: secret, codeplay, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 07:27:23 +00:00
ragnarok-clanker
31d3235e2d Decompile fn_08019 (GrannyAnimationLibrary::ReadAnimationFile)
Batch #13951 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_08019 GrannyAnimationLibrary::ReadAnimationFile: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:27:14 +00:00
ragnarok-clanker
60829bdc23 Decompile 2 functions in Source/Resource/Models/ModelResourceV2.cpp
Batch #14022 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review

Peer-reviewed-by: Yommy, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 04:27:38 +00:00
ragnarok-clanker
1bac0f0e72 Decompile fn_07954 (C3dModelResV2::Load)
Batch #13851 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_07954 C3dModelResV2::Load: logic confirmed by peer review

Peer-reviewed-by: Yommy, codeplay, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 03:53:29 +00:00
ragnarok-clanker
2563fa3731 Decompile fn_07963 (C3dGrannyModelRes::Load)
Batch #13936 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_07963 C3dGrannyModelRes::Load: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 01:18:53 +00:00
ragnarok-clanker
17369e909a Decompile fn_08055 (CSprRes::Unload)
Batch #13600 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_08055 CSprRes::Unload: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 20:35:57 +00:00
ragnarok-clanker
ecaa16016a Decompile fn_08006 (C3dGrannyModelRes::RebindMeshes)
Batch #13344 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_08006 C3dGrannyModelRes::RebindMeshes: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 13:37:44 +00:00
ragnarok-clanker
b17c136a61 Decompile fn_07996 (ModelNode::~ModelNode)
Batch #12626 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review

Peer-reviewed-by: Yommy, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 02:09:42 +00:00
ragnarok-clanker
702bd4e00e Decompile fn_08012 (C3dModelRes::FindNode)
Batch #12627 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_08012 C3dModelRes::FindNode: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 23:04:26 +00:00
ragnarok-clanker
4b9974561d Decompile fn_07958 (C3dAnimModelRes::Load)
Batch #12101 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 10:34:21 +00:00
ragnarok-clanker
e8adf5429d Decompile 2 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h
Batch #11833 by Yommy: 1 byte-identical, 1 confirmed by peer review.

- fn_08012 C3dModelRes::FindNode: logic confirmed by peer review
- fn_08016 C3dGrannyModelRes::GetRigidVertices: byte-identical

Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 04:52:59 +00:00
ragnarok-clanker
5a0b30c669 Decompile 4 functions in Source/Resource/Models/ModelResourceV2.cpp, Source/Resource/Models/ModelResource.h
Batch #11599 by SapitoSucio: 0 byte-identical, 4 confirmed by peer review.

- fn_07954 C3dModelResV2::Load: logic confirmed by peer review
- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:49:21 +00:00
ragnarok-clanker
869f91aff6 Decompile 2 functions in Source/Resource/Models/AnimatedModelResource.cpp
Batch #11765 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_08023 C3dAnimModelRes::Unload: byte-identical
- fn_07994 AnimatedModelFrame::~AnimatedModelFrame: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-05 03:38:31 +00:00
ragnarok-clanker
2212490ac8 Confirm 2 functions in Source/Resource/Models/ModelResource.cpp
Batch #11488 by StrawberrysherbetIX: 2 byte-identical, 0 confirmed by peer review.

- fn_07949 C3dModelResV1::Create: byte-identical (already on main)
- fn_07983 C3dModelResV1::C3dModelResV1: byte-identical (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Merged automatically: every function is byte-identical to the original.
2026-11-05 00:47:31 +00:00
ragnarok-clanker
7cc4fdd58e Decompile 2 functions in Source/Contents/Models/ModelActorBounds.cpp, Source/Resource/Models/ModelResource.h
Batch #10504 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17512 C3dActorV1::UpdateBounds: logic confirmed by peer review
- fn_17513 C3dActorV2::UpdateBounds: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:57:59 +00:00
ragnarok-clanker
bd4feba269 Confirm fn_07950 (C3dModelResV1::Load)
Batch #10656 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.

- fn_07950 C3dModelResV1::Load: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:50:24 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
85414e2012 Maintenance: [forced, user-approved] R1 (resubmit of 10219 on 4cf7a69f): remove invented resource contexts ActionResourceContext, Spr
Batch #10229 by ragnarok-clanker: forced by an admin (4 lower score(s), 45 changed function(s)); checked with 314 compiled unit(s), including every includer of Source/Resource/Bitmap/BitmapImage.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/Bitmap/IJL15Runtime.h, Source/Resource/EmblemResource.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/Sprites/SpriteResource.h, Source/UI/Buttons/UIBmpRadioBtn.h.
2026-11-03 09:38:10 +00:00
ragnarok-clanker
32b94f16e5 Decompile 5 functions in Source/Resource/GifResource.cpp, Source/Resource/GifResource.h, ...
Batch #8072 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_07862 CGifRes::CGifRes: logic confirmed by peer review
- fn_07981 C3dGrannyModelRes::C3dGrannyModelRes: logic confirmed by peer review
- fn_09931 UINpcSprWnd::UINpcSprWnd: logic confirmed by peer review
- fn_10387 UISwapEquipmentWnd::UISwapEquipmentWnd: logic confirmed by peer review
- fn_11109 UIStaticItem::`scalar deleting destructor': logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 14:05:56 +00:00
ragnarok-clanker
d5970c262b Decompile 6 functions in Source/Contents/Actors/RenderObject.cpp, Source/Resource/Models/ModelResource.cpp, ...
Batch #3345 by eAthena: 0 byte-identical, 6 confirmed by peer review.

- fn_21193 CGameActor::ProcessHitMessage: logic confirmed by peer review
- fn_21180 C3dGrannyGameActor::Slot08: logic confirmed by peer review
- fn_08025 C3dGrannyModelRes::GetMeshRenderData: logic confirmed by peer review
- fn_08026 C3dGrannyModelRes::GetMeshRenderData: logic confirmed by peer review
- fn_08027 C3dGrannyModelRes::FindHairPivot: logic confirmed by peer review
- fn_08029 C3dGrannyModelRes::Animate: logic confirmed by peer review

Peer-reviewed-by: meitogi, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:33:16 +00:00
ragnarok-clanker
b7bcecf7db Decompile fn_21173 (CGrannyCorpse3d::CGrannyCorpse3d)
Batch #3186 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21173 CGrannyCorpse3d::CGrannyCorpse3d: logic confirmed by peer review

Peer-reviewed-by: meitogi, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:46:39 +00:00
ragnarok-clanker
87bb32cef8 Decompile 48 functions in Source/Client/ModeFade.cpp, Source/Client/ModeFade.h, ...
Batch #2457 by ragnarok-clanker: 0 byte-identical, 48 confirmed by peer review.

- fn_00152 TextureCache::TextureCache: logic confirmed by peer review
- fn_01952 DrawAlphaRectangle: logic confirmed by peer review
- fn_01953 DrawBlendedRectangle: logic confirmed by peer review
- fn_01954 DrawTexturedRectangle: logic confirmed by peer review
- fn_01955 DrawTextureRegion: logic confirmed by peer review
- fn_02237 CRendererDX9::SaveLogo: logic confirmed by peer review
- fn_02353 CRenderSystemDX9::CRenderSystemDX9: logic confirmed by peer review
- fn_02447 TextureCache::~TextureCache: logic confirmed by peer review (already on main)
- fn_02449 TextureCache::Upload: logic confirmed by peer review
- fn_02451 TextureCache::Clear: logic confirmed by peer review (already on main)
- fn_02452 TextureCache::Remove: logic confirmed by peer review (already on main)
- fn_02453 TextureCache::Default: logic confirmed by peer review
- fn_02454 TextureCache::Load: logic confirmed by peer review (already on main)
- fn_02455 TextureCache::Create: logic confirmed by peer review
- fn_02456 TextureCache::Reload: logic confirmed by peer review
- fn_02457 TextureCache::ClearUnused: logic confirmed by peer review
- fn_07897 EZeffectClip::Texture: logic confirmed by peer review
- fn_07898 EZeffectClip::Texture: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07996 ModelNode::~ModelNode: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review
- fn_09166 BinkMovies::Update: logic confirmed by peer review
- fn_10122 UIRPData::DrawNamed: logic confirmed by peer review
- fn_12091 UIWhisperWnd::Slot43: logic confirmed by peer review
- fn_17556 GroundGeometry::Build: logic confirmed by peer review
- fn_17565 GroundGeometry::BuildLightmaps: logic confirmed by peer review
- fn_17581 GroundWaterState::Update: logic confirmed by peer review
- fn_17587 GroundGeometry::DrawGrid: logic confirmed by peer review
- fn_17599 GroundWaterState::Import: logic confirmed by peer review
- fn_17842 ModeFade::Draw: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_20019 CRagEffect::Blessing: logic confirmed by peer review
- fn_20023 CRagEffect::Bottom: logic confirmed by peer review
- fn_20024 CRagEffect::BowlingBash: logic confirmed by peer review
- fn_20025 CRagEffect::CartRevolution: logic confirmed by peer review
- fn_20042 CRagEffect::Entry: logic confirmed by peer review
- fn_20054 CRagEffect::FrostDiver: logic confirmed by peer review
- fn_20058 CRagEffect::GrimTooth: logic confirmed by peer review
- fn_20066 CRagEffect::Hit4: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20105 CRagEffect::SonicBlowHit: logic confirmed by peer review
- fn_20109 CRagEffect::SprayPond: logic confirmed by peer review
- fn_20124 CRagEffect::Yufitel: logic confirmed by peer review
- fn_20132 CRagEffect::AirTexture: logic confirmed by peer review
- fn_20133 CRagEffect::AttackEnergy2: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 18:23:21 +00:00
ragnarok-clanker
dc2f3a8f88 Align method names with DHXJ (call-graph matches): CEffectPrim::Prim3DParticle/Prim3DParticleNoMaster/Prim3DParticleOrbit, matrix::AppendScale/AppendXRotation/AppendZRotation/AppendTranslate/MakeYRotation/MakeZRotation, CRenderObject::CalcDist (2 overloads). Pure rename, codegen unchanged (504/504 functions identical with includers). 2026-10-29 13:12:37 +01:00
ragnarok-clanker
e9b98b8c69 Rename AffineMatrix -> matrix (DHXJ); clashes with variables named matrix use the elaborated form 'struct matrix'. Pure rename, codegen unchanged (383/383 functions identical with includers). 2026-10-29 12:33:14 +01:00
ragnarok-clanker
e4be8f4190 Decompile 18 functions in Source/Client/Application/UnhandledExceptionHandler.cpp, Source/Client/Session.h, ...
Batch #2077 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review (already on main)
- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_09315 UIRequestJoinPartyWnd::SendMsg: logic confirmed by peer review
- fn_19761 EffectParticle::EffectParticle: logic confirmed by peer review
- fn_19768 EffectParticle::InitializeRecords: logic confirmed by peer review
- fn_20007 AttachedEffect::AttachedEffect: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20991 CRenderObject::CRenderObject: logic confirmed by peer review
- fn_21069 ?CreatePartyEffect@?A0xba063134@@YAPAUAttachedEffect@@AAUEffectActor@@AAUPartyEffectMode@@@Z: logic confirmed by peer review
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_23396 CSession::GetJobName: logic confirmed by peer review
- fn_23495 CSession::InitJobNameTable: logic confirmed by peer review
- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_20987 EffectActor::EffectActor: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 09:48:08 +00:00
ragnarok-clanker
755f1d6eb6 Decompile fn_08019 (GrannyAnimationLibrary::ReadAnimationFile)
Batch #1983 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08019 GrannyAnimationLibrary::ReadAnimationFile: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:27 +00:00
ragnarok-clanker
95a451f8e5 Decompile 2 functions in Source/Resource/Models/AnimatedModelResource.cpp, Source/Resource/Models/GrannyModelResource.h
Batch #1888 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_07961 C3dGrannyModelRes::Create: logic confirmed by peer review
- fn_07963 C3dGrannyModelRes::Load: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:17:16 +00:00
ragnarok-clanker
b68718f749 Decompile 5 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #1850 by Yommy: 2 byte-identical, 3 confirmed by peer review.

- fn_08014 C3dModelRes::ForEachRootName: logic confirmed by peer review
- fn_08015 C3dGrannyModelRes::GetTriangleCount: logic confirmed by peer review
- fn_08016 C3dGrannyModelRes::GetRigidVertices: logic confirmed by peer review
- fn_08017 GrannyAnimationLibrary::Initialize: byte-identical
- fn_08018 C3dModelRes::Load: byte-identical

Reviewed-by: ragnarok-clanker
2026-10-28 22:53:13 +00:00
ragnarok-clanker
731d1b60ce Decompile 4 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/ModelResource.h, ...
Batch #1726 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_08005 GrannyAnimationLibrary::Load: logic confirmed by peer review
- fn_08007 AnimatedModelNode::Shade: logic confirmed by peer review
- fn_08008 C3dGrannyModelRes::ProjectBounds: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 21:43:00 +00:00
ragnarok-clanker
e45536a0bf Decompile 4 functions in Source/Resource/Models/ModelResource.cpp, Source/Resource/Models/GrannyModelResource.h
Batch #1691 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_08006 C3dGrannyModelRes::RebindMeshes: logic confirmed by peer review
- fn_08009 C3dGrannyModelRes::InstantiateModel: logic confirmed by peer review
- fn_08010 C3dGrannyModelRes::CreateTexture: logic confirmed by peer review
- fn_08011 C3dGrannyModelRes::FreeControl: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:21:13 +00:00
ragnarok-clanker
f0050dbf61 Decompile 3 functions in Source/Resource/Models/ModelResourceV2.cpp, Source/Resource/Models/ModelResource.h
Batch #1548 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_08020 C3dModelResV2::ReadVersion1: logic confirmed by peer review
- fn_08021 C3dModelResV2::ReadVersion2: logic confirmed by peer review
- fn_08022 C3dModelResV2::ReadVersion3: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 18:21:44 +00:00
ragnarok-clanker
96acca76c3 Decompile fn_02010 (ModelFace::~ModelFace)
Batch #1356 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_02010 ModelFace::~ModelFace: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 11:42:53 +00:00
ragnarok-clanker
c5a61bd331 Decompile fn_07994 (AnimatedModelFrame::~AnimatedModelFrame)
Batch #1151 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_07994 AnimatedModelFrame::~AnimatedModelFrame: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:34:49 +00:00
ragnarok-clanker
eb3e3b8b08 Decompile 11 functions in Source/Contents/Models/ModelLighting.cpp, Source/Contents/Models/ModelNode.cpp, ...
Batch #1082 by ragnarok-clanker: 0 byte-identical, 11 confirmed by peer review.

- fn_02007 ModelMesh::ModelMesh: logic confirmed by peer review
- fn_02009 ModelMesh::~ModelMesh: logic confirmed by peer review
- fn_02011 ModelMesh::CalculateNormals: logic confirmed by peer review
- fn_07958 C3dAnimModelRes::Load: logic confirmed by peer review
- fn_07997 AnimatedModelRecord::~AnimatedModelRecord: logic confirmed by peer review
- fn_08023 C3dAnimModelRes::Unload: logic confirmed by peer review
- fn_17482 C3dNodeV1::Initialize: logic confirmed by peer review
- fn_17484 C3dNodeV2::Initialize: logic confirmed by peer review
- fn_17514 C3dNode::AccumulateBounds: logic confirmed by peer review
- fn_17515 C3dNode::SampleGroundColors: logic confirmed by peer review
- fn_17521 C3dNode::Prepare: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 16:31:29 +00:00
ragnarok-clanker
5ec8920fd4 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Resource headers
Batch #1067 by ragnarok-clanker: no function's compiled code changes; checked with 83 compiled unit(s), including every includer of Source/Resource/Audio/WaveResource.h, Source/Resource/BinkRuntime.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/Bitmap/IJL15Runtime.h, Source/Resource/Models/ModelResource.h, Source/Resource/Resource.h, Source/Resource/ResourceAliases.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/WorldResource.h.
2026-10-27 14:00:13 +00:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00