Commit graph

19 commits

Author SHA1 Message Date
ragnarok-clanker
86a5142dbd Decompile 15 functions in Source/Client/Browser/BrowserCursor.cpp, Source/Client/Input/Language.cpp, ...
Batch #12875 by KWDev: 15 byte-identical, 0 confirmed by peer review.

- fn_03576 UINavigationV4Wnd::RefreshLayout: byte-identical
- fn_05441 CRenewQuestMgr::GetIconTooltip: byte-identical
- fn_10202 UIRuneSetReWard::Slot31: byte-identical
- fn_13844 UITagButton::Slot31: byte-identical
- fn_14354 CUIListBox<AdventureGuide::CUISubTab>::SelectItem: byte-identical
- fn_14355 CUIListBox<AdventureGuide::CUITab>::SelectItem: byte-identical
- fn_14417 CUIDropDownBox::HasChild: byte-identical
- fn_14420 CUIDropDownBox::Attach: byte-identical (already on main)
- fn_14685 CUITab::Select: byte-identical
- fn_16497 CQuestItemSelector::SetHighlighted: byte-identical
- fn_17063 ContainsValue: byte-identical
- fn_17764 CLanguageBase::Paste: byte-identical
- fn_18377 GetMessageString: byte-identical
- fn_19310 Replay::Cipher: byte-identical
- fn_45438 CWebBrowser::PollCursor: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 02:20:45 +00:00
ragnarok-clanker
97b862f0b0 Decompile fn_18368 (FillMessageBuckets)
Batch #12299 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_18368 FillMessageBuckets: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:29:06 +00:00
ragnarok-clanker
953c59d2f9 Decompile 2 functions in Source/Contents/MessageTable.cpp
Batch #12301 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_18370 FindMessageId: byte-identical
- fn_18372 InsertMessageRow: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-11-05 13:08:45 +00:00
ragnarok-clanker
930e5c1300 Decompile 3 functions in Source/Contents/MessageTable.cpp
Batch #12058 by SapitoSucio: 0 byte-identical, 3 confirmed by peer review.

- fn_03416 CCommonObject::ReadCsvRow: logic confirmed by peer review
- fn_03420 CCommonObject::OpenCsv: logic confirmed by peer review
- fn_03421 ?DecodeField@?A0x89bc9bd1@@YAXAAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@AAV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@3@_N@Z: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 09:12:41 +00:00
ragnarok-clanker
3364b49789 Decompile fn_18373 (?TransformFields@?A0x2a9fa6c1@@YA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@ABV23@@Z)
Batch #11401 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_18373 ?TransformFields@?A0x2a9fa6c1@@YA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@ABV23@@Z: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:00:20 +00:00
ragnarok-clanker
1c6f6776cd Decompile fn_18368 (FillMessageBuckets)
Batch #11264 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_18368 FillMessageBuckets: logic confirmed by peer review

Peer-reviewed-by: kyoshi, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 23:37:30 +00:00
ragnarok-clanker
b15e8b4199 Confirm 3 functions in Source/Contents/MessageTable.cpp, Source/Contents/MessageTable.h
Batch #10617 by kyoshi: 0 byte-identical, 3 confirmed by peer review.

- fn_18376 LookupMessage: logic confirmed by peer review (already on main)
- fn_18374 ImportMessageTable: logic confirmed by peer review (already on main)
- fn_18377 GetMessageString: logic confirmed by peer review (already on main)

Peer-reviewed-by: Tanke, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:51:01 +00:00
ragnarok-clanker
5c0eb3d28b Decompile 2 functions in Source/Contents/ActorNameRequests.cpp, Source/Contents/ActorNameCard.h, ...
Batch #1864 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03504 CActorNameCardHolder::ProcessRequests: logic confirmed by peer review
- fn_03419 CCommonObject::LoadCsv: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:09:00 +00:00
ragnarok-clanker
4c22f54ad0 🔥 refactor(effects): removed unused header includes 2026-10-28 23:13:11 +01:00
ragnarok-clanker
e310f19bcb Inline MessageNames.inc into MessageTable.cpp
Move the message-name table from Source/Contents/MessageNames.inc into the messageNames definition in MessageTable.cpp, with its STATIC 0x0115AA88 / GLOBAL gl_13433 provenance, and delete the .inc. No other change: compiled code of every MessageTable function is unchanged (checked against main).
2026-10-28 21:58:50 +01:00
ragnarok-clanker
2845c3431d Decompile 7 functions in Source/Contents/MessageTable.cpp, Source/Contents/MessageTable.h, ...
Batch #1710 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_18371 DecodeMessageRot: logic confirmed by peer review
- fn_18372 InsertMessageRow: logic confirmed by peer review
- fn_18374 ImportMessageTable: logic confirmed by peer review
- fn_03416 CCommonObject::ReadCsvRow: logic confirmed by peer review
- fn_03418 CCommonObject::LoadCsv: logic confirmed by peer review
- fn_03420 CCommonObject::OpenCsv: logic confirmed by peer review
- fn_18373 ?TransformFields@?A0x79e5ab67@@YA?AV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@ABV23@@Z: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:46:36 +00:00
ragnarok-clanker
838c0044d2 Decompile 70 functions in Source/Client/Browser/BrowserFactory.cpp, Source/Contents/Emblems/EmblemUpload.cpp, ...
Batch #1665 by ragnarok-clanker: 0 byte-identical, 70 confirmed by peer review.

- fn_10904 UIEditCtrl::UpdateLinks: logic confirmed by peer review
- fn_10905 EditViewport::Synchronize: logic confirmed by peer review
- fn_10950 UIBalloonText::SetText: logic confirmed by peer review
- fn_11216 ItemLinkDisplay::Convert: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review (already on main)
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review (already on main)
- fn_11366 UIListBox::Paint: logic confirmed by peer review
- fn_11367 UIListBoxEx::Paint: logic confirmed by peer review
- fn_11392 UITextButton::Paint: logic confirmed by peer review
- fn_11394 UITextViewer::Paint: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review (already on main)
- fn_11471 UITextButton::Slot27: logic confirmed by peer review (already on main)
- fn_11494 UITextButton::Slot33: logic confirmed by peer review (already on main)
- fn_11562 UITextViewer::SendMsg: logic confirmed by peer review (already on main)
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review (already on main)
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review (already on main)
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review (already on main)
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review (already on main)
- fn_12680 ShortcutPainting::Paint: logic confirmed by peer review
- fn_13829 WrapPlainText: logic confirmed by peer review
- fn_13833 WrapRichText: logic confirmed by peer review
- fn_16941 UIWindow::DrawAmount: logic confirmed by peer review
- fn_16971 UIWindow::TextHeight: logic confirmed by peer review
- fn_16972 UIWindow::VerticalTextHeight: logic confirmed by peer review
- fn_16973 UIWindow::TextSize: logic confirmed by peer review
- fn_16974 UIWindow::VerticalTextSize: logic confirmed by peer review
- fn_16975 UIWindow::TextWidth: logic confirmed by peer review
- fn_16993 WrapPixelText: logic confirmed by peer review
- fn_17007 FitText: logic confirmed by peer review
- fn_17009 UIWindow::DrawTextAt: logic confirmed by peer review
- fn_17013 DrawOutlinedColoredText: logic confirmed by peer review
- fn_17014 DrawStyledColoredText: logic confirmed by peer review
- fn_17015 DrawColoredText: logic confirmed by peer review
- fn_17016 DrawOutlinedText: logic confirmed by peer review
- fn_17136 BrowserFactory::Create: logic confirmed by peer review
- fn_18376 LookupMessage: logic confirmed by peer review
- fn_01934 TextContext::TextContext: logic confirmed by peer review
- fn_01957 TextContext::Marker: logic confirmed by peer review
- fn_01961 TextContext::Measure: logic confirmed by peer review
- fn_01966 TextContext::SetFont: logic confirmed by peer review
- fn_01970 TextContext::DrawPair: logic confirmed by peer review
- fn_01971 TextContext::Draw: logic confirmed by peer review
- fn_01983 TextContext::MeasurePart: logic confirmed by peer review
- fn_01984 TextContext::DrawPart: logic confirmed by peer review
- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review
- fn_24191 EmotionHotkeys::LoadDefaults: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03666 CAdventurerAgencyMgr::CompleteRegistration: logic confirmed by peer review
- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_04239 CMCStoreInfoBackup::CompleteSave: logic confirmed by peer review
- fn_04262 CPlayerNameDictionary::Lookup: logic confirmed by peer review
- fn_06581 ItemNaming::DisplayName: logic confirmed by peer review (already on main)
- fn_06583 ItemNamingContext::Element: logic confirmed by peer review (already on main)
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review (already on main)
- fn_06585 ItemNaming::Creator: logic confirmed by peer review (already on main)
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review (already on main)
- fn_06587 ItemNaming::Suffixes: logic confirmed by peer review (already on main)
- fn_06588 ItemNaming::Prefixes: logic confirmed by peer review (already on main)
- fn_09299 UIApplyForPartyWnd::Slot15: logic confirmed by peer review
- fn_09300 UIRegisterPartyWnd::Slot15: logic confirmed by peer review
- fn_09301 UIRequestJoinPartyWnd::Slot15: logic confirmed by peer review
- fn_09303 UIApplyForPartyWnd::Paint: logic confirmed by peer review
- fn_09304 UIPartyInfoWnd::Paint: logic confirmed by peer review
- fn_10748 UIEditCtrl::RemoveInvalidLink: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review (already on main)
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review (already on main)
- fn_10794 UIBasicButton::Paint: logic confirmed by peer review
- fn_10799 UIBmpTextButton::Paint: logic confirmed by peer review
- fn_10823 UITransBalloonText::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:35:29 +00:00
ragnarok-clanker
bce0cc6603 Decompile fn_18368 (FillMessageBuckets)
Batch #1207 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18368 FillMessageBuckets: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:09:06 +00:00
ragnarok-clanker
f491ad1deb Decompile 2 functions in Source/Contents/MessageTable.cpp, Source/Contents/MessageTable.h
Batch #1204 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18375 IsObfuscatedMessage: logic confirmed by peer review
- fn_18377 GetMessageString: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:08:47 +00:00
ragnarok-clanker
c956ff35dc Decompile fn_18370 (FindMessageId)
Batch #1106 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18370 FindMessageId: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 18:09:50 +00:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
ragnarok-clanker
d456e8f64a Initial rodecomp source snapshot 2026-10-24 00:35:19 +00:00