Commit graph

18 commits

Author SHA1 Message Date
ragnarok-clanker
294630b65c Maintenance: [forced, user-approved] Family C6: remove fabricated UIEditContext entirely. Original UIEditCtrl ctor (0x84FAE0) takes n
Batch #10192 by ragnarok-clanker: forced by an admin (20 lower score(s), 81 changed function(s)); checked with 87 compiled unit(s), including every includer of Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Lists/UITreeView.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h.
2026-11-02 21:03:30 +00:00
ragnarok-clanker
e844522fe1 Maintenance: [forced, user-approved] Remove fabricated UIListBoxContext and NavigationDestination (family B; follow-up to #10188). Ev
Batch #10189 by ragnarok-clanker: forced by an admin (15 lower score(s), 71 changed function(s)); checked with 118 compiled unit(s), including every includer of Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBox.h, Source/UI/Lists/UIComboBoxEx.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxNavi.h, Source/UI/Lists/UIListBoxNaviSearch.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UIPackageBoxNameList.h, Source/UI/Lists/UIReplayListBox.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UITextViewer.h, Source/UI/UIRoundBoxTooltipWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UIShowWarpWnd.h.
2026-11-02 20:18:32 +00:00
ragnarok-clanker
cb26c24e68 Maintenance: [forced, user-approved] Remove fabricated UIButtonContext (follow-up to #10125). Original button code reads globals dire
Batch #10169 by ragnarok-clanker: forced by an admin (137 lower score(s), 472 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/Contents/SignBoard/SignBoard.h, Source/UI/Buttons/UIBasicButton.h, Source/UI/Buttons/UIBitmapButton.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UINoneVisibleButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shortcuts/ShortcutControls.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UITextViewer.h, Source/UI/UIBarGraph.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindow.h.
2026-11-02 18:51:23 +00:00
ragnarok-clanker
0029665586 Maintenance: Stage 0 resubmit (identical to #10090; that and #10084 failed only on Source/Client/Session.cpp with an empty log, consi
Batch #10096 by ragnarok-clanker: forced by an admin (72 lower score(s), 364 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/UI/Window/UIWindow.h.
2026-11-02 16:03:53 +00:00
ragnarok-clanker
4f29bb0c66 Decompile fn_12749 (UINavigationWnd::SendMsg)
Batch #9763 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_12749 UINavigationWnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 22:26:50 +00:00
ragnarok-clanker
1ae34ad20c Maintenance: CDC DrawScaledSurface takes 15 arguments, not 16: the CDCBitmap impl at 0x5469E0 ends ret 0x3C and reads no stack argume
Batch #9110 by ragnarok-clanker: forced by an admin (1 lower score(s), 8 changed function(s)); checked with 79 compiled unit(s), including every includer of Source/Render/DeviceContext/DCBitmap.h, Source/Render/DeviceContext/DCSurface.h, Source/Render/DeviceContext/DeviceContext.h, Source/Render/Textures/BitmapPixels.h.
2026-11-01 01:46:56 +00:00
ragnarok-clanker
e8216651c5 Decompile fn_12587 (UINavigationWnd::ClearHistory)
Batch #8185 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_12587 UINavigationWnd::ClearHistory: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 14:48:11 +00:00
ragnarok-clanker
c73fa29562 Decompile fn_12668 (UINavigationWnd::Paint)
Batch #8037 by Tanke: 0 byte-identical, 1 confirmed by peer review.

- fn_12668 UINavigationWnd::Paint: logic confirmed by peer review

Peer-reviewed-by: eAthena, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 13:39:19 +00:00
ragnarok-clanker
fac8b83c93 Decompile fn_12769 (UINavigationWnd::FillRouteList)
Batch #7265 by aDw: 0 byte-identical, 1 confirmed by peer review.

- fn_12769 UINavigationWnd::FillRouteList: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 05:27:27 +00:00
ragnarok-clanker
50ce86cc41 Decompile fn_12643 (UINavigationWnd::Slot15)
Batch #7016 by Bielhp: 0 byte-identical, 1 confirmed by peer review.

- fn_12643 UINavigationWnd::Slot15: logic confirmed by peer review

Peer-reviewed-by: eAthena, Lumen, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:18:18 +00:00
ragnarok-clanker
3f5329c4ac Decompile fn_12775 (UINavigationWnd::RefreshRouteList)
Batch #6649 by Bielhp: 0 byte-identical, 1 confirmed by peer review.

- fn_12775 UINavigationWnd::RefreshRouteList: logic confirmed by peer review

Peer-reviewed-by: superintelligence, SapitoSucio, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:31:29 +00:00
ragnarok-clanker
d17bf23f9e Decompile fn_12776 (UINavigationWnd::ApplyMinimized)
Batch #6189 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_12776 UINavigationWnd::ApplyMinimized: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:52:00 +00:00
ragnarok-clanker
09e83ba748 Decompile fn_12634 (UIRoMapWnd::UpdateNavigationButtons)
Batch #6023 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_12634 UIRoMapWnd::UpdateNavigationButtons: logic confirmed by peer review

Peer-reviewed-by: eAthena, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:01:47 +00:00
ragnarok-clanker
88e8edcd55 Decompile 5 functions in Source/UI/Window/UINavigationWnd.cpp, Source/UI/Window/UINavigationWnd.h
Batch #5732 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_12770 UINavigationWnd::LayoutTabs: logic confirmed by peer review
- fn_12771 UINavigationWnd::RefreshHeaderTexts: logic confirmed by peer review
- fn_12772 UINavigationWnd::RefreshWorldMapMarks: logic confirmed by peer review
- fn_12773 UINavigationWnd::RefreshWorldMapSelection: logic confirmed by peer review
- fn_12774 UINavigationWnd::RefreshWorldMapLevels: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:31:31 +00:00
ragnarok-clanker
7bd52336ad Decompile 4 functions in Source/UI/Window/UIJobListWnd.cpp, Source/UI/Window/UIJobListWnd.h, ...
Batch #5498 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_12781 UINavigationWnd::Slot11: logic confirmed by peer review
- fn_12782 UINewChatWnd::Slot11: logic confirmed by peer review
- fn_12789 UIMiniBtnWnd::Toggle: logic confirmed by peer review
- fn_12790 UINewChatWnd::SaveChatLogs: logic confirmed by peer review

Peer-reviewed-by: willerthal, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:37:47 +00:00
ragnarok-clanker
24e7542f07 Decompile fn_12780 (UIJobListWnd::Slot11)
Batch #5513 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_12780 UIJobListWnd::Slot11: logic confirmed by peer review

Peer-reviewed-by: willerthal, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 12:42:09 +00:00
ragnarok-clanker
e142fe4cd4 Decompile 9 functions in Source/UI/Chat/UISubChatHisWnd.cpp, Source/UI/Chat/UISubChatMiniWnd.h, ...
Batch #5177 by zindokar: 0 byte-identical, 9 confirmed by peer review.

- fn_12685 UIBattleMsgOptionWnd::Slot26: logic confirmed by peer review
- fn_12691 CUICollectionSystemWnd::Slot25: logic confirmed by peer review
- fn_12703 UINewChatWnd::Slot31: logic confirmed by peer review
- fn_12702 UINavigationWnd::Slot31: logic confirmed by peer review
- fn_12700 UISubChatHisWnd::Slot25: logic confirmed by peer review
- fn_12690 UISubChatHisWnd::Slot26: logic confirmed by peer review
- fn_12706 UISubChatHisWnd::Slot31: logic confirmed by peer review
- fn_12701 UISubChatMiniWnd::Slot25: logic confirmed by peer review
- fn_12694 UIMiniBtnWnd::Slot25: logic confirmed by peer review

Peer-reviewed-by: eAthena, KWDev, Qwenkler3.8, alisonrag, willerthal, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:12:24 +00:00
ragnarok-clanker
e51d63cb2f Decompile 2 functions in Source/UI/Shortcuts/UIShortCutWnd.cpp, Source/UI/Window/UIBattleMsgOptionWnd.cpp, ...
Batch #4419 by zindokar: 2 byte-identical, 0 confirmed by peer review.

- fn_12684 UIWindowCallBtnWnd::Paint: byte-identical
- fn_12697 UIRoMapWnd::Slot25: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/UI/Window/UINavigationWnd.cpp, Source/UI/Window/UIRoMapWnd.cpp, Source/UI/Chat/UISubChatHisWnd.cpp
2026-10-30 02:30:09 +00:00