Commit graph

60 commits

Author SHA1 Message Date
ragnarok-clanker
b30b72eee9 Maintenance: [forced, user-approved] Remove fabricated UIEditContext scalar fields and InputFocus wrapper (family C1-C4). focus -> UI
Batch #10190 by ragnarok-clanker: forced by an admin (25 lower score(s), 87 changed function(s)); checked with 554 compiled unit(s), including every includer of Source/UI/Chat/ChatSuggestions.h, Source/UI/Edit/ItemTagRetirement.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/InputFocus.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h.
2026-11-02 20:47:58 +00:00
ragnarok-clanker
e844522fe1 Maintenance: [forced, user-approved] Remove fabricated UIListBoxContext and NavigationDestination (family B; follow-up to #10188). Ev
Batch #10189 by ragnarok-clanker: forced by an admin (15 lower score(s), 71 changed function(s)); checked with 118 compiled unit(s), including every includer of Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBox.h, Source/UI/Lists/UIComboBoxEx.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxNavi.h, Source/UI/Lists/UIListBoxNaviSearch.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UIPackageBoxNameList.h, Source/UI/Lists/UIReplayListBox.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UITextViewer.h, Source/UI/UIRoundBoxTooltipWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UIShowWarpWnd.h.
2026-11-02 20:18:32 +00:00
ragnarok-clanker
45b5ebd97e Maintenance: [forced, user-approved] CLanguage step 6 (follow-up to #10184): edit-input methods move from the reference struct CLangu
Batch #10185 by ragnarok-clanker: forced by an admin (5 lower score(s), 39 changed function(s)); checked with 66 compiled unit(s), including every includer of Source/Client/Input/Language.h.
2026-11-02 19:49:06 +00:00
ragnarok-clanker
044035f45d Maintenance: [forced, user-approved] CLanguage step 5 (follow-up to #10183): the remaining text helpers lose their code-page paramete
Batch #10184 by ragnarok-clanker: forced by an admin (3 lower score(s), 26 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/UI/Text/ColoredText.h, Source/UI/Text/PixelTextWrapping.h, Source/UI/Window/UIWindow.h.
2026-11-02 19:45:30 +00:00
ragnarok-clanker
309774e67b Maintenance: [forced, user-approved] CLanguage steps 2-4 (resubmit of #10182, which was returned only for the global rule). Fix: the
Batch #10183 by ragnarok-clanker: forced by an admin (6 lower score(s), 50 changed function(s)); checked with 115 compiled unit(s), including every includer of Source/Client/Input/InputCharset.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/UI/Chat/ChatNotifications.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Text/TextWrapping.h, Source/Client/Input/ImeInput.h.
Deletes: Source/Client/Input/ImeInput.h
2026-11-02 19:33:35 +00:00
ragnarok-clanker
bf37a5bd1f Maintenance: [forced, user-approved] CLanguage step 1 (resubmit of #10178): g_serverLanguage (0x16D3B0C) points to CLanguage with a 1
Batch #10179 by ragnarok-clanker: forced by an admin (0 lower score(s), 2 changed function(s)); checked with 55 compiled unit(s), including every includer of Source/Client/Input/InputCharset.h, Source/Client/Input/LanguageTC.h.
2026-11-02 19:20:05 +00:00
ragnarok-clanker
cb26c24e68 Maintenance: [forced, user-approved] Remove fabricated UIButtonContext (follow-up to #10125). Original button code reads globals dire
Batch #10169 by ragnarok-clanker: forced by an admin (137 lower score(s), 472 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/Contents/SignBoard/SignBoard.h, Source/UI/Buttons/UIBasicButton.h, Source/UI/Buttons/UIBitmapButton.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UINoneVisibleButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shortcuts/ShortcutControls.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UITextViewer.h, Source/UI/UIBarGraph.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindow.h.
2026-11-02 18:51:23 +00:00
ragnarok-clanker
316d625be1 Maintenance: [forced, user-approved] Resubmit of #10124 (returned only for 143 changed peer-confirmed scores). Remove fabricated UIFr
Batch #10125 by ragnarok-clanker: forced by an admin (143 lower score(s), 416 changed function(s)); checked with 475 compiled unit(s), including every includer of Source/UI/Acceptance/UIJoinPartyAcceptWnd.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIDisconnectedServerMsgWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UINoticeConfirmWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIPetTamingDeceiveWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIToolTipWnd.h, Source/UI/Dialogs/UIWaitWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/FrameSkin.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UINotifyItemObtainWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Layout/SnapMgr.h, Source/UI/Lists/UIComboBoxWnd.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/MiniPartyManager.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIMiniPartyWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantItemWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shop/UInCash_CallWnd.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIBartermarketWnd.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UIRoundBoxTooltipWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMessageBoxAutoreturn.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMiniBtnWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINormalMB.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRPImageWnd2.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWordDisplayWnd.h, Source/UI/Window/WindowDialogs.h, Source/UI/Layout/WindowSnapping.h.
Deletes: Source/UI/Layout/WindowSnapping.h
2026-11-02 17:48:48 +00:00
ragnarok-clanker
0029665586 Maintenance: Stage 0 resubmit (identical to #10090; that and #10084 failed only on Source/Client/Session.cpp with an empty log, consi
Batch #10096 by ragnarok-clanker: forced by an admin (72 lower score(s), 364 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/UI/Window/UIWindow.h.
2026-11-02 16:03:53 +00:00
ragnarok-clanker
7480af6235 Decompile 3 functions in Source/UI/Window/WindowRegistration.cpp, Source/UI/Window/UIWindow.cpp, ...
Batch #9956 by seumadruga: 0 byte-identical, 3 confirmed by peer review.

- fn_17236 UIWindowMgr::UnregisterWindow: logic confirmed by peer review
- fn_17231 UIWindowMgr::InvalidateRegisteredWindows: logic confirmed by peer review
- fn_16917 UIWindow::~UIWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, cremane
Reviewed-by: ragnarok-clanker
2026-11-02 13:08:46 +00:00
ragnarok-clanker
61aecaffdd Decompile 3 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h
Batch #9931 by Toshiro: 0 byte-identical, 3 confirmed by peer review.

- fn_03581 UINavigationV4Wnd::Slot15: logic confirmed by peer review
- fn_03590 UIPrivateAirplaneWnd::Paint: logic confirmed by peer review
- fn_17010 UIWindow::sub_A84400: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-11-02 11:30:06 +00:00
ragnarok-clanker
ff2ff3de76 Decompile fn_16958 (UIWindow::WrapText)
Batch #9740 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_16958 UIWindow::WrapText: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, Romain, Montyla
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 21:15:55 +00:00
ragnarok-clanker
12ab7a5eeb Decompile fn_03626 (UINavigationV4Wnd::SendMsg)
Batch #9670 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03626 UINavigationV4Wnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, Romain, Montyla
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 19:08:06 +00:00
ragnarok-clanker
3246e9793d Decompile fn_16992 (UIWindow::WrapTextWithBreaks)
Batch #9633 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_16992 UIWindow::WrapTextWithBreaks: logic confirmed by peer review

Peer-reviewed-by: alisonrag, Romain, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 17:17:22 +00:00
ragnarok-clanker
16f71ee31c Decompile fn_03588 (UINavigationV4Wnd::Paint)
Batch #9606 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03588 UINavigationV4Wnd::Paint: logic confirmed by peer review

Peer-reviewed-by: secret, Romain, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 16:32:56 +00:00
ragnarok-clanker
ccc85e1fda Decompile fn_03631 (UINavigationV4Wnd::LoadRoute)
Batch #9520 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03631 UINavigationV4Wnd::LoadRoute: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, dori, seumadruga
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 14:46:06 +00:00
ragnarok-clanker
064f6853f3 Decompile fn_03555 (UINavigationV4Wnd::ClearRouteTexts)
Batch #9496 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03555 UINavigationV4Wnd::ClearRouteTexts: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 14:26:33 +00:00
ragnarok-clanker
1e32b3232a Decompile fn_16959 (UIWindow::WrapFormattedText)
Batch #9418 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_16959 UIWindow::WrapFormattedText: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, Bielhp
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 12:50:33 +00:00
ragnarok-clanker
5cf2d9789a Decompile fn_03558 (UINavigationV4Wnd::DrawTargetSprite)
Batch #9417 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_03558 UINavigationV4Wnd::DrawTargetSprite: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, Bielhp
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 12:49:48 +00:00
ragnarok-clanker
cce2da4a44 Decompile fn_16930 (UIWindow::CreateItemTagButton)
Batch #9415 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_16930 UIWindow::CreateItemTagButton: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 12:45:17 +00:00
ragnarok-clanker
1ae34ad20c Maintenance: CDC DrawScaledSurface takes 15 arguments, not 16: the CDCBitmap impl at 0x5469E0 ends ret 0x3C and reads no stack argume
Batch #9110 by ragnarok-clanker: forced by an admin (1 lower score(s), 8 changed function(s)); checked with 79 compiled unit(s), including every includer of Source/Render/DeviceContext/DCBitmap.h, Source/Render/DeviceContext/DCSurface.h, Source/Render/DeviceContext/DeviceContext.h, Source/Render/Textures/BitmapPixels.h.
2026-11-01 01:46:56 +00:00
ragnarok-clanker
3890468297 Maintenance: UIWindow::Slot44 returns std::vector<unsigned char>: its caller SaveReplayWindows (fn_17244) computes the chunk length a
Batch #9107 by ragnarok-clanker: forced by an admin (1 lower score(s), 1 changed function(s)); checked with 390 compiled unit(s), including every includer of Source/UI/Window/UIWindow.h, Source/UI/Window/UIFrameWnd.h.
2026-11-01 01:40:26 +00:00
ragnarok-clanker
4a2a123364 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ...
Batch #8557 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_16955 UIWindow::ColoredTextWidth: logic confirmed by peer review
- fn_03628 UIPrivateAirplaneWnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: eAthena, SapitoSucio, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 19:00:07 +00:00
ragnarok-clanker
3a85044a78 Decompile fn_03535 (UIListBox_NaviSearch::UIListBox_NaviSearch)
Batch #7872 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_03535 UIListBox_NaviSearch::UIListBox_NaviSearch: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, secret, Romain, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 13:00:35 +00:00
ragnarok-clanker
ff78fb0af0 Decompile fn_16991 (UIWindow::TruncateText)
Batch #7400 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_16991 UIWindow::TruncateText: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:52:02 +00:00
ragnarok-clanker
d78beba148 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Buttons/UIButton.h, ...
Batch #6853 by superintelligence: 0 byte-identical, 2 confirmed by peer review.

- fn_03635 UINavigationV4Wnd::SetRoadIcon: logic confirmed by peer review
- fn_03583 UIPrivateAirplaneWnd::Slot15: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 02:00:04 +00:00
ragnarok-clanker
900697ac05 Decompile 4 functions in Source/UI/Window/UIWindow.cpp
Batch #6802 by alisonrag: 4 byte-identical, 0 confirmed by peer review.

- fn_03528 sub_5C2260: byte-identical
- fn_03529 sub_5C22D0: byte-identical
- fn_03530 sub_5C22E0: byte-identical
- fn_03531 sub_5C22F0: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-31 01:56:16 +00:00
ragnarok-clanker
ba3f05c98c Decompile fn_16925 (UIWindow::PlaceBeside)
Batch #6549 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.

- fn_16925 UIWindow::PlaceBeside: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:16:30 +00:00
ragnarok-clanker
9aa5bce0ec Decompile fn_17017 (UIWindow::sub_A85850)
Batch #6468 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17017 UIWindow::sub_A85850: logic confirmed by peer review

Peer-reviewed-by: willerthal, Lumen, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 23:28:53 +00:00
ragnarok-clanker
340c07343a Decompile 8 functions in Source/Contents/NavigationRoute.cpp, Source/Contents/NavigationManager.h, ...
Batch #6091 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_19623 CNavigationManager::AddWrappedRouteLines: logic confirmed by peer review
- fn_19624 CNavigationManager::SelectState: logic confirmed by peer review
- fn_19625 CNavigationManager::SelectNodeState: logic confirmed by peer review
- fn_19628 CNavigationManager::SetDestinationMap: logic confirmed by peer review
- fn_19632 CNavigationManager::LoadTargetPreview: logic confirmed by peer review
- fn_19633 CNavigationManager::BuildTargetRouteLines: logic confirmed by peer review
- fn_03576 UINavigationV4Wnd::RefreshLayout: logic confirmed by peer review
- fn_03637 UINavigationV4Wnd::SelectRouteNode: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Lumen, superintelligence, KWDev, Romain, Snow, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 20:27:17 +00:00
ragnarok-clanker
747bf15435 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h
Batch #6003 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_03596 UINavigationV4Wnd::Slot31: logic confirmed by peer review
- fn_03636 UINavigationV4Wnd::InsertNavigationLink: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:33:35 +00:00
ragnarok-clanker
9ff36b8181 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h, ...
Batch #5646 by zindokar: 0 byte-identical, 2 confirmed by peer review.

- fn_03580 UINavigationRuideWnd::Slot15: logic confirmed by peer review
- fn_03630 UINavigationRuideWnd::RefreshRoute: logic confirmed by peer review

Peer-reviewed-by: Yommy, willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:14:00 +00:00
ragnarok-clanker
63b248083a Decompile fn_03625 (UINavigationRuideWnd::SendMsg)
Batch #5678 by zindokar: 0 byte-identical, 1 confirmed by peer review.

- fn_03625 UINavigationRuideWnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: Yommy, willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 14:30:41 +00:00
ragnarok-clanker
8a845affae Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h, ...
Batch #5668 by zindokar: 0 byte-identical, 2 confirmed by peer review.

- fn_03619 UIListBox_NaviSearch::Refresh: logic confirmed by peer review
- fn_03624 UIListBox_NaviSearch::SendMsg: logic confirmed by peer review

Peer-reviewed-by: Yommy, Snow, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 14:25:50 +00:00
ragnarok-clanker
2f72e3aada Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ...
Batch #5472 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_16977 UIWindow::FitDisplayText: logic confirmed by peer review
- fn_16978 UIWindow::FitVerticalDisplayText: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:23:42 +00:00
ragnarok-clanker
3b9e20f397 Decompile 6 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ...
Batch #5165 by Yommy: 0 byte-identical, 6 confirmed by peer review.

- fn_16959 UIWindow::WrapFormattedText: logic confirmed by peer review
- fn_09912 UIRefining_Notice::Paint: logic confirmed by peer review
- fn_10812 UINameBalloonText::Paint: logic confirmed by peer review
- fn_10824 UIVerticalNameBalloonText::Paint: logic confirmed by peer review
- fn_10845 UIResizer::Slot25: logic confirmed by peer review
- fn_10869 UIResizer::Slot27: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:09:20 +00:00
ragnarok-clanker
a50c9c5fa4 Decompile fn_16956 (UIWindow::ToScreen)
Batch #5042 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_16956 UIWindow::ToScreen: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:13:52 +00:00
ragnarok-clanker
f03de6e713 Decompile fn_03634 (UINavigationV4Wnd::FillRouteGroups)
Batch #4947 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_03634 UINavigationV4Wnd::FillRouteGroups: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:25:27 +00:00
ragnarok-clanker
e073e51669 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h
Batch #4691 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_17023 UIWindow::DrawFormattedText: logic confirmed by peer review
- fn_16976 UIWindow::FormattedTextWidth: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, Millenium, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:02:31 +00:00
ragnarok-clanker
5b8477a798 Decompile fn_03633 (UINavigationV4Wnd::SelectRoute)
Batch #4888 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_03633 UINavigationV4Wnd::SelectRoute: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, alisonrag, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:35:58 +00:00
ragnarok-clanker
59dbbe396f Decompile fn_03554 (UIListBox_NaviSearch::Clear)
Batch #4833 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_03554 UIListBox_NaviSearch::Clear: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:11:47 +00:00
ragnarok-clanker
368f287e8d Decompile fn_16926 (UIWindow::ResetStates)
Batch #4292 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_16926 UIWindow::ResetStates: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 02:21:18 +00:00
ragnarok-clanker
bb81a1a972 Decompile 6 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ...
Batch #3928 by youko: 0 byte-identical, 6 confirmed by peer review.

- fn_17018 UIWindow::DrawCenteredOutlinedText: logic confirmed by peer review
- fn_17020 UIWindow::DrawVerticalOutlinedText: logic confirmed by peer review
- fn_17021 UIWindow::DrawRightAlignedText: logic confirmed by peer review
- fn_17022 UIWindow::DrawShadowedText: logic confirmed by peer review
- fn_17024 UIWindow::DrawEmboldenedText: logic confirmed by peer review
- fn_17062 StripColorCodes: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:14:00 +00:00
ragnarok-clanker
8ef10a001a Decompile 3 functions in Source/Contents/ActorNameCard.cpp, Source/Contents/ActorNameCard.h, ...
Batch #3101 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_03508 CActorNameCardHolder::SetValue3: logic confirmed by peer review
- fn_03509 CActorNameCardHolder::SetValue4: logic confirmed by peer review
- fn_03557 UINavigationV4Wnd::DrawMapTexture: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:32:03 +00:00
ragnarok-clanker
961a8a0c45 Decompile fn_17011 (UIWindow::DrawVerticalText)
Batch #2119 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17011 UIWindow::DrawVerticalText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 12:07:36 +00:00
ragnarok-clanker
74b3ce59b3 Decompile fn_17012 (UIWindow::DrawCenteredText)
Batch #2116 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17012 UIWindow::DrawCenteredText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 11:00:43 +00:00
ragnarok-clanker
e0311aac48 Decompile fn_16918 (RunWindowAction)
Batch #1984 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_16918 RunWindowAction: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:36 +00:00
ragnarok-clanker
9fb77c2661 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ...
Batch #1960 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03617 UINavigationV4Wnd::ObjectLabel: logic confirmed by peer review
- fn_16947 UIWindow::DrawActionSprite: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 00:13:49 +00:00
ragnarok-clanker
0fbfcb20bd Decompile 9 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ...
Batch #1910 by Yommy: 0 byte-identical, 9 confirmed by peer review.

- fn_03579 UIListBox_NaviSearch::Slot15: logic confirmed by peer review
- fn_03582 UINavigationroadiconWnd::Slot15: logic confirmed by peer review
- fn_03586 UIListBox_NaviSearch::Paint: logic confirmed by peer review
- fn_03587 UINavigationRuideWnd::Paint: logic confirmed by peer review
- fn_03589 UINavigationroadiconWnd::Paint: logic confirmed by peer review
- fn_03616 UINavigationV4Wnd::ObjectName: logic confirmed by peer review
- fn_03618 UINavigationV4Wnd::MobName: logic confirmed by peer review
- fn_03627 UINavigationroadiconWnd::SendMsg: logic confirmed by peer review
- fn_17004 UIWindow::RecordEditTexts: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 23:52:33 +00:00
ragnarok-clanker
65eb389b7b Decompile 6 functions in Source/UI/Window/InputFocus.cpp, Source/UI/Window/InputFocus.h, ...
Batch #1689 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_17197 InputFocus::IsLast: logic confirmed by peer review
- fn_17260 InputFocus::Previous: logic confirmed by peer review
- fn_16960 UIWindow::NextFocusable: logic confirmed by peer review
- fn_16969 UIWindow::PreviousFocusable: logic confirmed by peer review
- fn_10911 UIEditCtrl2::SendMsg: logic confirmed by peer review
- fn_10913 UIEditCtrl5::SendMsg: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:12:41 +00:00