clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
4,042 commits 1 branch 0 tags 39 MiB
Commit graph

10 commits

Author SHA1 Message Date
ragnarok-clanker
cb26c24e68 Maintenance: [forced, user-approved] Remove fabricated UIButtonContext (follow-up to #10125). Original button code reads globals dire 
Batch #10169 by ragnarok-clanker: forced by an admin (137 lower score(s), 472 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/Contents/SignBoard/SignBoard.h, Source/UI/Buttons/UIBasicButton.h, Source/UI/Buttons/UIBitmapButton.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UINoneVisibleButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shortcuts/ShortcutControls.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UITextViewer.h, Source/UI/UIBarGraph.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindow.h.
 2026-11-02 18:51:23 +00:00
ragnarok-clanker
0029665586 Maintenance: Stage 0 resubmit (identical to #10090; that and #10084 failed only on Source/Client/Session.cpp with an empty log, consi 
Batch #10096 by ragnarok-clanker: forced by an admin (72 lower score(s), 364 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/UI/Window/UIWindow.h.
 2026-11-02 16:03:53 +00:00
ragnarok-clanker
03d558b9d3 Decompile 11 functions in Source/UI/Buttons/UINoneVisibleButton.cpp, Source/UI/Buttons/UINoneVisibleButton.h, ... 
Batch #7713 by Yommy: 0 byte-identical, 11 confirmed by peer review.

- fn_10665 UIEmblemWnd::UIEmblemWnd: logic confirmed by peer review
- fn_10667 UIMerchantShopTitle::UIMerchantShopTitle: logic confirmed by peer review
- fn_10668 UINameBalloonText::UINameBalloonText: logic confirmed by peer review
- fn_10669 UINoneVisibleButton::UINoneVisibleButton: logic confirmed by peer review
- fn_10670 UIRadioBtn::UIRadioBtn: logic confirmed by peer review
- fn_10671 UIResizer::UIResizer: logic confirmed by peer review
- fn_10672 UISlotBitmap::UISlotBitmap: logic confirmed by peer review
- fn_10673 UISlotBitmap::UISlotBitmap: logic confirmed by peer review
- fn_10677 UIStaticText3::UIStaticText3: logic confirmed by peer review
- fn_10679 UITab::UITab: logic confirmed by peer review
- fn_10682 UIWordDisplayWnd::UIWordDisplayWnd: logic confirmed by peer review

Peer-reviewed-by: eAthena, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 11:30:08 +00:00
ragnarok-clanker
1e071d5028 Decompile 8 functions in Source/UI/Edit/UIEditVariants.cpp, Source/Contents/CashEmotionMgr.cpp, ... 
Batch #5346 by eAthena: 0 byte-identical, 8 confirmed by peer review.

- fn_10943 UIEditCtrl4::SetPlaceholder: logic confirmed by peer review
- fn_10944 UIEditCtrl4::SetPlaceholderColor: logic confirmed by peer review
- fn_10945 UISpriteButton::SetPalette: logic confirmed by peer review
- fn_10949 UIBalloonText::WrapText: logic confirmed by peer review
- fn_10954 UIRadioBtn::SetText: logic confirmed by peer review
- fn_10956 UIWhisperEditCtrl::SetText: logic confirmed by peer review
- fn_10957 UITransBalloonText::SetLine: logic confirmed by peer review
- fn_10958 UIEditCtrl3::Trim: logic confirmed by peer review

Peer-reviewed-by: willerthal, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 11:47:58 +00:00
ragnarok-clanker
3bcf274d29 Decompile 3 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Window/UIWindow.h, ... 
Batch #5106 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_10811 UIMerchantShopTitle::Paint: logic confirmed by peer review
- fn_10818 UIStaticText2::Paint: logic confirmed by peer review
- fn_10861 UIRadioBtn::Slot28: logic confirmed by peer review

Peer-reviewed-by: youko, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 08:13:51 +00:00
ragnarok-clanker
a50c9c5fa4 Decompile fn_16956 (UIWindow::ToScreen) 
Batch #5042 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_16956 UIWindow::ToScreen: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 07:13:52 +00:00
ragnarok-clanker
9136dd8094 Decompile 9 functions in Source/UI/Buttons/UIRadioBtn.cpp, Source/UI/Buttons/UIRadioBtn.h, ... 
Batch #4429 by eAthena: 0 byte-identical, 9 confirmed by peer review.

- fn_10915 UIEditCtrlVarId::SendMsg: logic confirmed by peer review
- fn_10916 UIEditCtrl_OldList::SendMsg: logic confirmed by peer review
- fn_10917 UIEmblemWnd::SendMsg: logic confirmed by peer review
- fn_10919 UIRadioBtn::SendMsg: logic confirmed by peer review
- fn_10920 UISlotBitmap::SendMsg: logic confirmed by peer review
- fn_10921 UITab::SendMsg: logic confirmed by peer review
- fn_10923 UIWordDisplayWnd::SendMsg: logic confirmed by peer review
- fn_10935 UIBalloonText::SetFontHeight: logic confirmed by peer review
- fn_10936 UIStaticText::SetFont: logic confirmed by peer review

Peer-reviewed-by: alisonrag, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 03:03:29 +00:00
ragnarok-clanker
5b831e2426 Decompile fn_10696 (UIRadioBtn::~UIRadioBtn) 
Batch #4058 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_10696 UIRadioBtn::~UIRadioBtn: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 00:59:37 +00:00
ragnarok-clanker
090e7d817c Decompile 4 functions in Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UITextureButton.h, ... 
Batch #3917 by youko: 0 byte-identical, 4 confirmed by peer review.

- fn_10814 UIRadioBtn::Paint: logic confirmed by peer review
- fn_10876 UIChatRoomTitle::ResetCursor: logic confirmed by peer review
- fn_10878 UIMerchantShopTitle::ResetCursor: logic confirmed by peer review
- fn_10879 UIResizer::ResetCursor: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 00:01:15 +00:00
ragnarok-clanker
cca267e5e8 Decompile 8 functions in Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UITextureButton.h, ... 
Batch #3721 by youko: 5 byte-identical, 3 confirmed by peer review.

- fn_10813 UINoneVisibleButton::Paint: byte-identical
- fn_10822 UITextureButton::Paint: byte-identical
- fn_10827 UIEditCtrlVarId::Slot24: byte-identical
- fn_10833 UISlotBitmap::Slot26: byte-identical
- fn_10844 UIRadioBtn::Slot25: logic confirmed by peer review
- fn_10846 UISlotBitmap::Slot25: logic confirmed by peer review
- fn_10862 UIResizer::Slot28: byte-identical
- fn_10887 UISlotBitmap::Slot32: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Buttons/UIBmpTextButton2.cpp, Source/UI/Buttons/UIColorButton.cpp, Source/UI/Buttons/UINoneVisibleButton.cpp, Source/UI/Buttons/UIRadioBtn.cpp, Source/UI/Buttons/UITextureButton.cpp, Source/UI/Chat/UIChatRoomTitle.cpp, Source/UI/Shop/UIMerchantShopTitle.cpp, Source/UI/UISlotBitmap.cpp, Source/UI/Window/UIBitmapTab.cpp, Source/UI/Window/UIEmblemWnd.cpp, Source/UI/Window/UIResizer.cpp, Source/UI/Window/UITab.cpp, Source/UI/Window/UIWordDisplayWnd.cpp
 2026-10-29 23:07:25 +00:00