Commit graph

7 commits

Author SHA1 Message Date
ragnarok-clanker
cb26c24e68 Maintenance: [forced, user-approved] Remove fabricated UIButtonContext (follow-up to #10125). Original button code reads globals dire
Batch #10169 by ragnarok-clanker: forced by an admin (137 lower score(s), 472 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/Contents/SignBoard/SignBoard.h, Source/UI/Buttons/UIBasicButton.h, Source/UI/Buttons/UIBitmapButton.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UINoneVisibleButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shortcuts/ShortcutControls.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UITextViewer.h, Source/UI/UIBarGraph.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindow.h.
2026-11-02 18:51:23 +00:00
ragnarok-clanker
573f015775 Decompile fn_11081 (UITVBitmapButton::UITVBitmapButton)
Batch #8198 by Montyla: 0 byte-identical, 1 confirmed by peer review.

- fn_11081 UITVBitmapButton::UITVBitmapButton: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, gordaoprogramas, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 15:03:04 +00:00
ragnarok-clanker
7dbb23ed26 Decompile 8 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Lists/UIListBox.cpp, ...
Batch #5841 by Yommy: 0 byte-identical, 8 confirmed by peer review.

- fn_11276 UIListBoxNavi::LineOffset: logic confirmed by peer review
- fn_11289 UIComboBoxV2Wnd::SelectedText: logic confirmed by peer review
- fn_11291 UIListBox::CopyText: logic confirmed by peer review
- fn_11292 UIListBox::TextLength: logic confirmed by peer review
- fn_11293 UITreeView::HideNodes: logic confirmed by peer review
- fn_11294 UIItemTagCtrl::SetTaggedText: logic confirmed by peer review
- fn_11296 UITreeView::AddNodeButtons: logic confirmed by peer review
- fn_11297 UITreeView::AddNodeLabel: logic confirmed by peer review

Peer-reviewed-by: bigodeira, tayoba, SapitoSucio, willerthal, ragnarok-clanker, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 16:38:16 +00:00
ragnarok-clanker
1d3b73372d Decompile 13 functions in Source/UI/Gauges/UIPlayerGage.cpp, Source/UI/UIBarGraph.cpp, ...
Batch #5221 by Yommy: 0 byte-identical, 13 confirmed by peer review.

- fn_11568 UIRechargeGage::SetValues: logic confirmed by peer review
- fn_11569 UIPlayerGage::SetFourthValues: logic confirmed by peer review
- fn_11578 UIPlayerGage::SetFirstValues: logic confirmed by peer review
- fn_11579 UIPlayerGage::SetThirdValues: logic confirmed by peer review
- fn_11580 UIMonsterGage::SetMode: logic confirmed by peer review
- fn_11587 UIPlayerGage::SetSecondValues: logic confirmed by peer review
- fn_11593 UIBarGraphHomun::SetValues: logic confirmed by peer review
- fn_11594 UIBarGraphPlayer::SetValues: logic confirmed by peer review
- fn_11570 UIBmpRadioBtn::SetBitmap: logic confirmed by peer review
- fn_11573 UITextButton::CenterIn: logic confirmed by peer review
- fn_11590 UITVTextButton::SetLabel: logic confirmed by peer review
- fn_11592 UIBmpRadioBtn::AddText: logic confirmed by peer review
- fn_11595 UIItemTagOnMail::SetLines: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Gauges/UIPlayerGage.cpp
2026-10-30 09:33:02 +00:00
ragnarok-clanker
0052c1f56b Decompile 7 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Lists/UIComboBoxDefWnd.cpp, ...
Batch #4921 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_11526 UIChatHisBox3::Resize: logic confirmed by peer review
- fn_11536 UITVTextButton::ResizeToText: logic confirmed by peer review
- fn_11537 UITextButton::ResizeToText: logic confirmed by peer review
- fn_11539 UITabControl::FitToTabs: logic confirmed by peer review
- fn_11540 TableBox::SendMsg: logic confirmed by peer review
- fn_11547 UIComboBoxV2Wnd::SendMsg: logic confirmed by peer review
- fn_11551 UIItemStoreComboBoxWnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:06:19 +00:00
ragnarok-clanker
d539847a8b Decompile 7 functions in Source/UI/Buttons/UIBitmapButton2.h, Source/UI/Buttons/UIBmpRadioBtn.h, ...
Batch #3679 by eAthena: 6 byte-identical, 1 confirmed by peer review.

- fn_11400 UIComboBox::Slot26: byte-identical
- fn_11402 UIComboBoxID::Slot26: byte-identical
- fn_11413 UIComboBox::Slot25: byte-identical
- fn_11415 UIComboBoxID::Slot25: byte-identical
- fn_11427 UITVTextButton::Slot25: logic confirmed by peer review
- fn_11432 UIChatHisBox::Slot31: byte-identical
- fn_11437 UIComboBoxV2Wnd::Slot31: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:58:30 +00:00
ragnarok-clanker
b999ef7e2c Decompile 2 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Buttons/UIItemMoveInfo.h, ...
Batch #2817 by youko: 2 byte-identical, 0 confirmed by peer review.

- fn_11483 UISlotBmpButton::Slot32: byte-identical
- fn_11490 UIMemberListBox::Slot33: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 19:18:29 +00:00