Commit graph

6 commits

Author SHA1 Message Date
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
7c5bf24c91 Decompile 2 functions in Source/UI/MiniPartyManager.cpp, Source/UI/Window/UIWindowFactory.cpp, ...
Batch #8210 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17183 UIWindowMgr::RebuildMiniPartyWindows: logic confirmed by peer review
- fn_17208 UIWindowMgr::CreateLayoutWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, System4z, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 15:12:59 +00:00
ragnarok-clanker
11b441389e Decompile fn_17119 (UIWindowMgr::AddMiniPartyWindow)
Batch #8103 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17119 UIWindowMgr::AddMiniPartyWindow: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIWindowFactory.cpp
2026-10-31 14:04:10 +00:00
ragnarok-clanker
b1aa77332d Decompile 5 functions in Source/UI/MiniPartyManager.cpp, Source/UI/Window/WindowMgrState.cpp, ...
Batch #5479 by Yommy: 1 byte-identical, 4 confirmed by peer review.

- fn_17270 UIWindowMgr::RearrangeMiniPartyWindows: logic confirmed by peer review
- fn_17271 Nullsub371: byte-identical
- fn_17281 UIWindowMgr::SaveVisibleWindowIds: logic confirmed by peer review
- fn_17283 UIWindowMgr::SaveShortcutItems: logic confirmed by peer review
- fn_17284 UIWindowMgr::SaveUIRectInfo: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:34:16 +00:00
ragnarok-clanker
efb38781a2 Decompile 6 functions in Source/UI/Window/WindowAncestry.cpp, Source/UI/MiniPartyManager.cpp, ...
Batch #5179 by eAthena: 2 byte-identical, 4 confirmed by peer review.

- fn_16989 UIWindow::BroadcastMsg4: byte-identical
- fn_16990 UIWindow::BroadcastMsg3: byte-identical
- fn_16924 UIWindow::PropagateMsg: logic confirmed by peer review
- fn_17214 UIWindowMgr::ArrangeMiniPartyWindows: logic confirmed by peer review
- fn_17164 UIWindowMgr::FindItemWindow: logic confirmed by peer review
- fn_17230 UIWindowMgr::NotifyMemberWindows: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:23:29 +00:00
ragnarok-clanker
20dbe4bc34 Decompile 2 functions in Source/UI/MiniPartyManager.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1455 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_07745 CMiniPartyWndAreaMgr::Instance: logic confirmed by peer review
- fn_17263 UIWindowMgr::SetScreenSize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/MiniPartyManager.cpp
2026-10-28 13:15:47 +00:00