Commit graph

30 commits

Author SHA1 Message Date
ragnarok-clanker
8986b7cdda Decompile fn_17250 (UIWindowMgr::ClearWindow01B8)
Batch #4683 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_17250 UIWindowMgr::ClearWindow01B8: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 05:59:45 +00:00
ragnarok-clanker
b7f45f78a0 Decompile 4 functions in Source/UI/Window/WindowMgrState.cpp, Source/UI/Window/UIWindowMgr.h
Batch #4669 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_17272 UIWindowMgr::ScaleToViewportWidth: logic confirmed by peer review
- fn_17273 UIWindowMgr::CenterOnViewportX: logic confirmed by peer review
- fn_17274 UIWindowMgr::CenterOnViewportY: logic confirmed by peer review
- fn_17275 UIWindowMgr::ConfirmActiveDialog: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:51:33 +00:00
ragnarok-clanker
11c43b8c0d Decompile 2 functions in Source/UI/Window/WindowRetirement.cpp, Source/UI/Window/UIWindowMgr.h
Batch #4656 by eAthena: 1 byte-identical, 1 confirmed by peer review.

- fn_17145 UIWindowMgr::DestroyWindow0478: byte-identical
- fn_17147 UIWindowMgr::SubmitActiveDialog: logic confirmed by peer review

Peer-reviewed-by: Snow, Bruwuno, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:44:29 +00:00
ragnarok-clanker
09fc72c090 Decompile 7 functions in Source/UI/Window/FrameFocus.cpp, Source/UI/Window/UIWindowMgr.h
Batch #4641 by eAthena: 3 byte-identical, 4 confirmed by peer review.

- fn_17191 UIWindowMgr::IsDropDownChild: logic confirmed by peer review
- fn_17194 UIWindowMgr::IsHoverParentVisible: byte-identical
- fn_17195 UIWindowMgr::IsFriend: logic confirmed by peer review
- fn_17196 UIWindowMgr::IsSharedWindowId: logic confirmed by peer review
- fn_17198 UIWindowMgr::HasNavigationBlocker: byte-identical
- fn_17203 UIWindowMgr::HasPendingDialog: byte-identical
- fn_17204 UIWindowMgr::CancelActiveDialog: logic confirmed by peer review

Peer-reviewed-by: youko, Lumen, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:27:37 +00:00
ragnarok-clanker
5427b2bdad Decompile 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h
Batch #4594 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17267 UIWindowMgr::SetWindows189Visible: logic confirmed by peer review
- fn_17268 UIWindowMgr::ShowWindowsWithId: logic confirmed by peer review

Peer-reviewed-by: youko, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 04:20:53 +00:00
ragnarok-clanker
e8191f0606 Decompile 7 functions in Source/UI/Window/WindowMgrState.cpp, Source/UI/Window/UIWindowMgr.h
Batch #4434 by eAthena: 5 byte-identical, 2 confirmed by peer review.

- fn_17156 UIWindowMgr::NotifyHoverWindow: byte-identical
- fn_17159 UIWindowMgr::GetGuildWindow: byte-identical
- fn_17162 UIWindowMgr::FindMiniPartyCell: logic confirmed by peer review
- fn_17163 UIWindowMgr::GetHoverWindow: byte-identical
- fn_17169 UIWindowMgr::GetRenderedWindowIds: logic confirmed by peer review
- fn_17170 UIWindowMgr::HideWindow01C8: byte-identical
- fn_17172 UIWindowMgr::HasUnknown030C: byte-identical

Peer-reviewed-by: youko, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/WindowMgrState.cpp
2026-10-30 03:10:16 +00:00
ragnarok-clanker
9f52ceb7a0 Decompile 9 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h
Batch #4106 by youko: 0 byte-identical, 9 confirmed by peer review.

- fn_17116 UIWindowMgr::ShowTransient: logic confirmed by peer review
- fn_17117 UIWindowMgr::RequestAddFriend: logic confirmed by peer review
- fn_17118 UIWindowMgr::AddOverlay: logic confirmed by peer review
- fn_17126 UIWindowMgr::AddRenderedFront: logic confirmed by peer review
- fn_17129 UIWindowMgr::ShowWindows189: logic confirmed by peer review
- fn_17131 UIWindowMgr::DestroyPersistentWindows: logic confirmed by peer review
- fn_17140 UIWindowMgr::RemoveSnapRectangle: logic confirmed by peer review
- fn_17141 UIWindowMgr::ReleaseRetainedWindow: logic confirmed by peer review
- fn_17142 UIWindowMgr::UnregisterNamedWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:10:51 +00:00
ragnarok-clanker
9dec76358c Decompile 11 functions in Source/UI/Guild/UIGuildWnd.cpp, Source/UI/Guild/UIGuildWnd.h, ...
Batch #3406 by eAthena: 11 byte-identical, 0 confirmed by peer review.

- fn_13073 UIGuildLeaveReasonDescWnd::Paint: byte-identical
- fn_13082 UICreateGuildWnd::Slot25: byte-identical
- fn_13094 UICreateGuildWnd::Slot31: byte-identical
- fn_13097 UICreateGuildWnd::Slot27: byte-identical
- fn_13108 UIGuildMemberManageWnd::Slot33: byte-identical
- fn_13109 UIGuildSkillWnd::Slot33: byte-identical
- fn_13044 UIGuildBanishedMemberWnd::Tab: byte-identical
- fn_13045 UIGuildInfoManageWnd::Tab: byte-identical
- fn_13046 UIGuildMemberManageWnd::Tab: byte-identical
- fn_13049 UIGuildSkillWnd::Tab: byte-identical
- fn_13050 UIGuildTotalInfoWnd::Tab: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/UI/Guild/UIGuildWnd.cpp, Source/UI/Guild/UIGuildHelperWnd.cpp, Source/UI/Guild/UIAgitWnd.cpp
2026-10-29 21:49:18 +00:00
ragnarok-clanker
96e1c5982b Decompile fn_11457 (UIListBox::Slot28)
Batch #3258 by willerthal: 0 byte-identical, 1 confirmed by peer review.

- fn_11457 UIListBox::Slot28: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:39:23 +00:00
ragnarok-clanker
8239d51c2f Confirm fn_13386 (UIItemWnd::Slot19)
Batch #3272 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_13386 UIItemWnd::Slot19: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-10-29 21:13:22 +00:00
ragnarok-clanker
2eae918704 Decompile fn_07657 (CMiniPartyWndAreaMgr::FindFreeCell)
Batch #2612 by willerthal: 0 byte-identical, 1 confirmed by peer review.

- fn_07657 CMiniPartyWndAreaMgr::FindFreeCell: logic confirmed by peer review

Peer-reviewed-by: youko
Reviewed-by: ragnarok-clanker
2026-10-29 18:09:28 +00:00
ragnarok-clanker
c683b68ec1 Decompile 4 functions in Source/UI/Acceptance/UIChooseSellBuyWnd.cpp, Source/UI/Items/UIItemCollectionWnd.h, ...
Batch #1913 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_12271 UIItemCollectionWnd::Slot25: logic confirmed by peer review
- fn_12280 UICombinedCardItemCollectionWnd::Slot31: logic confirmed by peer review
- fn_12283 UIItemCollectionWnd::Slot31: logic confirmed by peer review
- fn_12299 UIProhibitListWnd::Slot19: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 23:53:13 +00:00
ragnarok-clanker
2765db8635 Decompile fn_11826 (UILoginWnd::Slot11)
Batch #1811 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_11826 UILoginWnd::Slot11: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:35:31 +00:00
ragnarok-clanker
ff83912b6b Decompile 9 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h, ...
Batch #1711 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_23304 SessionMessengerContext::UpdateRandomStats: logic confirmed by peer review
- fn_05603 EquipmentPropertyStore::EquipmentPropertyStore: logic confirmed by peer review
- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review
- fn_05740 EquipmentPropertyStore::~EquipmentPropertyStore: logic confirmed by peer review
- fn_05807 EquipmentPropertyGroup::~EquipmentPropertyGroup: logic confirmed by peer review
- fn_06013 EquipmentProperties::CEquipmentPropertiesMgr::CEquipmentPropertiesMgr: logic confirmed by peer review
- fn_06170 EquipmentProperties::CEquipmentPropertiesMgr::Clear: logic confirmed by peer review
- fn_17276 UIWindowMgr::NotifyItemWindows: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:41:46 +00:00
ragnarok-clanker
9aea62bd9b Decompile 47 functions in Source/Client/ClientOptions.cpp, Source/Client/Session.h, ...
Batch #1675 by ragnarok-clanker: 2 byte-identical, 45 confirmed by peer review.

- fn_10839 UIButton::Slot25: logic confirmed by peer review
- fn_10852 UIButton::Slot31: logic confirmed by peer review
- fn_10868 UIButton::Slot27: logic confirmed by peer review
- fn_10930 UIStaticBitmap::SetBitmap: logic confirmed by peer review
- fn_10931 UIBitmapButton::SetBitmap: logic confirmed by peer review
- fn_11320 UIComboBoxEx2::Slot15: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review
- fn_11381 UIScrollBar::Paint: logic confirmed by peer review
- fn_11383 UIScrollBar_Navi::Paint: logic confirmed by peer review
- fn_11425 UIScrollBar::Slot25: logic confirmed by peer review
- fn_11440 UIScrollBar::Slot31: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review
- fn_11468 UIScrollBar::Slot27: logic confirmed by peer review
- fn_11471 UITextButton::Slot27: logic confirmed by peer review
- fn_11494 UITextButton::Slot33: logic confirmed by peer review
- fn_11779 UIFrameWnd::Slot25: logic confirmed by peer review
- fn_11781 UIFrameWnd::Slot31: logic confirmed by peer review
- fn_11786 UIFrameWnd::Slot27: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
- fn_12689 ActivateShortcut: logic confirmed by peer review
- fn_12711 ShortcutTooltip::Hover: logic confirmed by peer review
- fn_12724 ShortcutDetails::Open: logic confirmed by peer review (already on main)
- fn_12760 UIShortCutWnd::SendMsg: logic confirmed by peer review
- fn_17144 UIWindowMgr::RemoveOrder: logic confirmed by peer review
- fn_17158 UIWindowMgr::Capture: byte-identical
- fn_17180 UIWindowMgr::BringToFront: logic confirmed by peer review
- fn_17192 UIWindowMgr::IsOrderFixed: logic confirmed by peer review
- fn_17232 UIWindowMgr::ReleaseCapture: byte-identical
- fn_17255 UIWindowMgr::SetCapture: logic confirmed by peer review
- fn_20382 CConnection::CConnection: logic confirmed by peer review
- fn_20383 CRagConnection::CRagConnection: logic confirmed by peer review
- fn_20384 CConnection::~CConnection: logic confirmed by peer review (already on main)
- fn_20389 CConnection::Connect: logic confirmed by peer review
- fn_20390 CConnection::Close: logic confirmed by peer review
- fn_20409 GetRagConnection: logic confirmed by peer review
- fn_21406 AutomaticSkills::Complete: logic confirmed by peer review
- fn_03927 CCharacterLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_11073 UIScrollBar::UIScrollBar: logic confirmed by peer review
- fn_11102 UIComboBoxEx2::~UIComboBoxEx2: logic confirmed by peer review (already on main)
- fn_09150 AutomaticSkills::DisableAll: logic confirmed by peer review
- fn_09153 AutomaticSkills::Use: logic confirmed by peer review
- fn_10689 UIBitmapButton::~UIBitmapButton: logic confirmed by peer review (already on main)
- fn_10795 UIBitmapButton::Paint: logic confirmed by peer review
- fn_10817 UIStaticBitmap::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:01:00 +00:00
ragnarok-clanker
377623e86d Decompile fn_17166 (UIWindowMgr::GetMiniPartyUsableArea)
Batch #1585 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17166 UIWindowMgr::GetMiniPartyUsableArea: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/MiniPartyUsableArea.cpp
2026-10-28 19:11:08 +00:00
ragnarok-clanker
3d4b2c79dc Decompile 2 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UIMerInfoWnd.h, ...
Batch #1553 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11712 UIBank_NewWnd::TransactionAmount: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 18:50:35 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ...
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:45:10 +00:00
ragnarok-clanker
20dbe4bc34 Decompile 2 functions in Source/UI/MiniPartyManager.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1455 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_07745 CMiniPartyWndAreaMgr::Instance: logic confirmed by peer review
- fn_17263 UIWindowMgr::SetScreenSize: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/MiniPartyManager.cpp
2026-10-28 13:15:47 +00:00
ragnarok-clanker
dd7b67cbe3 Decompile 2 functions in Source/UI/Edit/UIEditCtrl.cpp, Source/UI/Edit/UIEditCtrl.h, ...
Batch #1333 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_10977 UIEditCtrl::MoveCandidateWindow: logic confirmed by peer review
- fn_10978 UIEditCtrl::MoveReadingWindow: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:08:44 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems)
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
2026-10-28 11:42:30 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
e9b6837e97 Decompile 2 functions in Source/UI/Buttons/UIBasicButton.cpp, Source/UI/Buttons/UIBitmapButton.cpp, ...
Batch #1102 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_16953 UIWindow::Root: byte-identical
- fn_16983 UIWindow::Invalidate: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
2026-10-27 18:04:02 +00:00
ragnarok-clanker
cb8da61c98 Decompile fn_17154 (UIWindowMgr::ProcessDialogKey)
Batch #1078 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17154 UIWindowMgr::ProcessDialogKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 16:05:51 +00:00
ragnarok-clanker
a55dd8b8e5 Decompile 4 functions in Source/UI/Window/WindowOrdering.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1076 by ragnarok-clanker: 4 byte-identical, 0 confirmed by peer review.

- fn_17185 UIWindowMgr::RefreshClanWnd: byte-identical
- fn_17186 UIWindowMgr::RefreshGuildWindows: byte-identical
- fn_17187 UIWindowMgr::RefreshRouletteWnd: byte-identical
- fn_17188 UIWindowMgr::EnableRouletteWnd: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 15:19:07 +00:00
ragnarok-clanker
4e5f7335ff Decompile fn_17124 (UIWindowMgr::RegisterNamedWindow)
Batch #1049 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17124 UIWindowMgr::RegisterNamedWindow: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 12:14:55 +00:00
ragnarok-clanker
fbdc231444 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1048 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_17219 UIWindowMgr::Schedule: logic confirmed by peer review
- fn_17235 UIWindowMgr::DismissTransient: logic confirmed by peer review
- fn_17237 UIWindowMgr::Destroy: logic confirmed by peer review
- fn_17833 ModeTooltip::Clear: logic confirmed by peer review
- fn_17843 ModeTooltip::Expire: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-27 12:07:15 +00:00
ragnarok-clanker
44f60ba6ca Decompile 6 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1038 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_07649 CMiniPartyWndAreaMgr::CMiniPartyWndAreaMgr: logic confirmed by peer review
- fn_17099 UIWindowMgr::~UIWindowMgr: logic confirmed by peer review
- fn_17233 UIWindowMgr::Shutdown: logic confirmed by peer review
- fn_09716 CSnapMgr::MoveEdge: logic confirmed by peer review
- fn_06318 ServiceOptions::Get: logic confirmed by peer review (already on main)
- fn_06325 ServiceOptions::Set: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
2026-10-27 11:01:30 +00:00
ragnarok-clanker
d73c3c1296 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1025 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_17831 CWorld::ActiveGameMode: byte-identical
- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)
- fn_17835 CMode::Slot7: byte-identical
- fn_17838 CMode::Slot5: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 09:38:13 +00:00
ragnarok-clanker
0d7e98ce6d Confirm 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ...
Batch #1011 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/UI/Window/UIWindowMgr.cpp
2026-10-27 09:02:57 +00:00