clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
5,805 commits 2 branches 0 tags 61 MiB
Commit graph

4 commits

Author SHA1 Message Date
ragnarok-clanker
3f8411389e Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids 
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
 2026-11-06 16:08:47 +00:00
ragnarok-clanker
ea04b91a56 Decompile 4 functions in Source/Contents/Effects/MapChainEffect.cpp, Source/Contents/Effects/MapChainEffect.h 
Batch #4896 by Millenium: 2 byte-identical, 2 confirmed by peer review.

- fn_18947 CMapChainEffect::sub_B4AB90: logic confirmed by peer review
- fn_18948 CMapChainEffect::Close: byte-identical
- fn_18949 CMapChainEffect::Slot01: byte-identical
- fn_18950 CMapChainEffect::Slot07: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 05:47:48 +00:00
ragnarok-clanker
99e5605fb5 Decompile fn_18952 (CMapChainEffect::Slot03) 
Batch #4224 by Millenium: 0 byte-identical, 1 confirmed by peer review.

- fn_18952 CMapChainEffect::Slot03: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 01:53:08 +00:00
ragnarok-clanker
1865b689c5 Decompile 4 functions in Source/Contents/Effects/MagnumBreak.cpp, Source/Contents/Effects/MagnumBreak.h, ... 
Batch #3836 by eAthena: 4 byte-identical, 0 confirmed by peer review.

- fn_18951 CMapChainEffect::Slot06: byte-identical
- fn_18957 CMappillarEffect::Slot06: byte-identical
- fn_18966 CSquareRangeEffect::Slot04: byte-identical
- fn_18975 CSteal::Slot04: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Effects/MagnumBreak.cpp, Source/Contents/Effects/MapChainEffect.cpp, Source/Contents/Effects/MappillarEffect.cpp, Source/Contents/Effects/SquareRangeEffect.cpp, Source/Contents/Effects/StealEffect.cpp, Source/Contents/Effects/MagicFloorEffect.cpp
 2026-10-29 23:37:28 +00:00