Commit graph

12 commits

Author SHA1 Message Date
ragnarok-clanker
3f8411389e Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
2026-11-06 16:08:47 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
aac2a14cd1 Decompile fn_05583 (EnchantMgrUnknown689250)
Batch #8664 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_05583 EnchantMgrUnknown689250: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-31 20:04:57 +00:00
ragnarok-clanker
881ad363aa Decompile 2 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h, ...
Batch #7514 by Toshiro: 0 byte-identical, 2 confirmed by peer review.

- fn_05544 CEnchantMgr::OpenEnchant: logic confirmed by peer review
- fn_05551 CEnchantMgr::HandleEnchantResult: logic confirmed by peer review

Peer-reviewed-by: eAthena, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 09:44:21 +00:00
ragnarok-clanker
60400dc579 Decompile 5 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h
Batch #5293 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_05543 CEnchantMgr::Init: logic confirmed by peer review
- fn_05552 CEnchantMgr::SetEnchant: logic confirmed by peer review
- fn_05567 L_AddPerfectUpgradeEnchant: logic confirmed by peer review
- fn_05577 L_SetRandomUpgradeRequire: logic confirmed by peer review
- fn_05579 L_SetReset: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:20:42 +00:00
ragnarok-clanker
17098046c3 Decompile 3 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h
Batch #5942 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_05570 L_AddUpgradeEnchant: logic confirmed by peer review
- fn_05575 L_SetEnchant: logic confirmed by peer review
- fn_05578 L_SetRequire: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, tayoba, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 17:47:13 +00:00
ragnarok-clanker
edca875fc8 Decompile 2 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h
Batch #5749 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_05542 CEnchantMgr::ConvertMaterials: logic confirmed by peer review
- fn_05566 L_AddPerfectEnchant: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, tayoba, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:18:28 +00:00
ragnarok-clanker
f0a4feef5c Decompile 3 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h
Batch #5743 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_05538 CEnchantMgr::AddPerfectUpgradeEnchant: logic confirmed by peer review
- fn_05539 CEnchantMgr::CallScript: logic confirmed by peer review
- fn_05541 CEnchantMgr::GetEnchantInfo: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, tayoba, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:14:28 +00:00
ragnarok-clanker
66056bebc0 Decompile fn_05537 (CEnchantMgr::AddPerfectEnchant)
Batch #5665 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_05537 CEnchantMgr::AddPerfectEnchant: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, sherollyner
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 14:25:06 +00:00
ragnarok-clanker
4db2512471 Decompile 9 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h, ...
Batch #4803 by youko: 0 byte-identical, 9 confirmed by peer review.

- fn_05568 L_AddRandomUpgradeEnchant: logic confirmed by peer review
- fn_05569 L_AddTargetItem: logic confirmed by peer review
- fn_05571 L_ApproveRandomOption: logic confirmed by peer review
- fn_05572 L_GetSlotCount: logic confirmed by peer review
- fn_05573 L_SetCaution: logic confirmed by peer review
- fn_05574 L_SetCondition: logic confirmed by peer review
- fn_05576 L_SetGradeBonus: logic confirmed by peer review
- fn_05580 L_SetSlotOrder: logic confirmed by peer review
- fn_05581 L_SetSuccessRate: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, Millenium
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:28:31 +00:00
ragnarok-clanker
d794e3645d Decompile 7 functions in Source/Contents/EnchantMgr.cpp, Source/Contents/EnchantMgr.h
Batch #4243 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_05540 CEnchantMgr::SendCloseEnchant: logic confirmed by peer review
- fn_05545 CEnchantMgr::RequestPerfectEnchant: logic confirmed by peer review
- fn_05546 CEnchantMgr::RequestRandomEnchant: logic confirmed by peer review
- fn_05547 CEnchantMgr::RequestResetEnchant: logic confirmed by peer review
- fn_05548 CEnchantMgr::RequestUpgradePerfectEnchant: logic confirmed by peer review
- fn_05549 CEnchantMgr::RequestUpgradeEnchant: logic confirmed by peer review
- fn_05550 CEnchantMgr::RequestUpgradeRandomEnchant: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:29:54 +00:00
ragnarok-clanker
f549757b9e Decompile fn_05523 (CEnchantMgr::CEnchantMgr)
Batch #3528 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_05523 CEnchantMgr::CEnchantMgr: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/EnchantMgr.cpp
2026-10-29 22:45:14 +00:00