clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
574 commits 1 branch 0 tags 11 MiB
Commit graph

95 commits

Author SHA1 Message Date
ragnarok-clanker
86b21d5ec7 Decompile fn_17848 (CMode::TakeScreenshot) 
Batch #1895 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_17848 CMode::TakeScreenshot: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 23:22:44 +00:00
ragnarok-clanker
20a2647c7a Decompile fn_21269 (CGameMode::SubcellPosition) 
Batch #1886 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21269 CGameMode::SubcellPosition: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 23:17:28 +00:00
ragnarok-clanker
3ec1742a36 Decompile fn_23562 (CSession::IsExchangeItemListFull) 
Batch #1887 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23562 CSession::IsExchangeItemListFull: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 23:16:52 +00:00
ragnarok-clanker
0cffe990b0 Decompile fn_17832 (CWorld::ActiveLoginMode) 
Batch #1890 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_17832 CWorld::ActiveLoginMode: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 23:15:57 +00:00
ragnarok-clanker
ec71daa13b Decompile fn_23815 (CSession::GetPetTalkText) 
Batch #1885 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23815 CSession::GetPetTalkText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 23:15:39 +00:00
ragnarok-clanker
8836dc5137 Decompile 3 functions in Source/Contents/EquipmentResources.cpp, Source/Contents/EquipmentResourceMgr.h, ... 
Batch #1858 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_19746 EquipmentResourceMgr::GetAccessoryResourceName: logic confirmed by peer review
- fn_23357 CSession::GetAccessoryActName: logic confirmed by peer review
- fn_23358 CSession::GetAccessorySprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 23:00:12 +00:00
ragnarok-clanker
ef21913c3f Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.h, ... 
Batch #1842 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23837 CSession::GetWeaponActName: logic confirmed by peer review
- fn_23838 CSession::GetWeaponEffectActName: logic confirmed by peer review
- fn_23839 CSession::GetWeaponEffectSprName: logic confirmed by peer review
- fn_23840 CSession::GetWeaponSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:51:51 +00:00
ragnarok-clanker
f05827650a Decompile 2 functions in Source/Contents/ClientState.cpp, Source/Contents/ClientState.h, ... 
Batch #1835 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_24222 CSession::SetHomunculusAutoFeed: logic confirmed by peer review
- fn_24223 CSession::SetPetAutoFeed: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:51:20 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ... 
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:49:51 +00:00
ragnarok-clanker
4739b61323 Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h 
Batch #1828 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_23763 CSession::DeleteProhibitionLog: logic confirmed by peer review
- fn_23771 CSession::DecodePlayerName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 22:48:17 +00:00
ragnarok-clanker
34541f64a8 Decompile 6 functions in Source/Contents/HeadResources.cpp, Source/Client/Session.h, ... 
Batch #1721 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19751 EquipmentResourceMgr::GetHeadName: logic confirmed by peer review
- fn_23373 CSession::GetHeadActName: logic confirmed by peer review
- fn_23374 CSession::GetPlayerHeadActName: logic confirmed by peer review
- fn_23375 CSession::GetHeadPalName: logic confirmed by peer review
- fn_23376 CSession::GetPlayerHeadPalName: logic confirmed by peer review
- fn_23377 CSession::GetHeadSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/HeadResources.cpp
 2026-10-28 21:11:05 +00:00
ragnarok-clanker
8125ad1ce1 Decompile fn_06623 (BuildReplayTaggedRecord) 
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:43:04 +00:00
ragnarok-clanker
ff83912b6b Decompile 9 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h, ... 
Batch #1711 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_23304 SessionMessengerContext::UpdateRandomStats: logic confirmed by peer review
- fn_05603 EquipmentPropertyStore::EquipmentPropertyStore: logic confirmed by peer review
- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review
- fn_05740 EquipmentPropertyStore::~EquipmentPropertyStore: logic confirmed by peer review
- fn_05807 EquipmentPropertyGroup::~EquipmentPropertyGroup: logic confirmed by peer review
- fn_06013 EquipmentProperties::CEquipmentPropertiesMgr::CEquipmentPropertiesMgr: logic confirmed by peer review
- fn_06170 EquipmentProperties::CEquipmentPropertiesMgr::Clear: logic confirmed by peer review
- fn_17276 UIWindowMgr::NotifyItemWindows: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:41:46 +00:00
ragnarok-clanker
b677bdbc59 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h, ... 
Batch #1704 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_24179 CSession::IsDoramJob: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review
- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:33:49 +00:00
ragnarok-clanker
b23d368372 Maintenance: Resubmit of batch 1702, which reported merged at 0bc2089 but that commit does not contain Replay.cpp changes. Source hyg 
Batch #1703 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s).
 2026-10-28 20:28:07 +00:00
ragnarok-clanker
0bc20896db Decompile 4 functions in Source/Contents/SpriteFrameSynchronization.cpp, Source/Contents/NpcLocationRadius.cpp, ... 
Batch #1694 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23819 CSession::GetSyncedFrame: logic confirmed by peer review
- fn_23467 CSession::GetNpcLocationRadius: logic confirmed by peer review
- fn_23823 CSession::GetRidingJob: logic confirmed by peer review
- fn_24152 CSession::GetSpriteJob: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SpriteFrameSynchronization.cpp, Source/Contents/NpcLocationRadius.cpp, Source/Contents/SpriteJob.cpp
 2026-10-28 20:24:26 +00:00
ragnarok-clanker
7a88edb84c Decompile fn_23848 (CSession::LoadXmlTables) 
Batch #1684 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23848 CSession::LoadXmlTables: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientXmlTables.cpp
 2026-10-28 20:23:55 +00:00
ragnarok-clanker
b7bd70ab06 Decompile 2 functions in Source/Contents/PetTalk.cpp, Source/Contents/EnemyMonsterTalk.cpp, ... 
Batch #1692 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23805 CSession::GetPetTalkActionName: logic confirmed by peer review
- fn_23834 CSession::GetMonsterTalkEventName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/PetTalk.cpp, Source/Contents/EnemyMonsterTalk.cpp
 2026-10-28 20:12:56 +00:00
ragnarok-clanker
9aea62bd9b Decompile 47 functions in Source/Client/ClientOptions.cpp, Source/Client/Session.h, ... 
Batch #1675 by ragnarok-clanker: 2 byte-identical, 45 confirmed by peer review.

- fn_10839 UIButton::Slot25: logic confirmed by peer review
- fn_10852 UIButton::Slot31: logic confirmed by peer review
- fn_10868 UIButton::Slot27: logic confirmed by peer review
- fn_10930 UIStaticBitmap::SetBitmap: logic confirmed by peer review
- fn_10931 UIBitmapButton::SetBitmap: logic confirmed by peer review
- fn_11320 UIComboBoxEx2::Slot15: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review
- fn_11381 UIScrollBar::Paint: logic confirmed by peer review
- fn_11383 UIScrollBar_Navi::Paint: logic confirmed by peer review
- fn_11425 UIScrollBar::Slot25: logic confirmed by peer review
- fn_11440 UIScrollBar::Slot31: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review
- fn_11468 UIScrollBar::Slot27: logic confirmed by peer review
- fn_11471 UITextButton::Slot27: logic confirmed by peer review
- fn_11494 UITextButton::Slot33: logic confirmed by peer review
- fn_11779 UIFrameWnd::Slot25: logic confirmed by peer review
- fn_11781 UIFrameWnd::Slot31: logic confirmed by peer review
- fn_11786 UIFrameWnd::Slot27: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
- fn_12689 ActivateShortcut: logic confirmed by peer review
- fn_12711 ShortcutTooltip::Hover: logic confirmed by peer review
- fn_12724 ShortcutDetails::Open: logic confirmed by peer review (already on main)
- fn_12760 UIShortCutWnd::SendMsg: logic confirmed by peer review
- fn_17144 UIWindowMgr::RemoveOrder: logic confirmed by peer review
- fn_17158 UIWindowMgr::Capture: byte-identical
- fn_17180 UIWindowMgr::BringToFront: logic confirmed by peer review
- fn_17192 UIWindowMgr::IsOrderFixed: logic confirmed by peer review
- fn_17232 UIWindowMgr::ReleaseCapture: byte-identical
- fn_17255 UIWindowMgr::SetCapture: logic confirmed by peer review
- fn_20382 CConnection::CConnection: logic confirmed by peer review
- fn_20383 CRagConnection::CRagConnection: logic confirmed by peer review
- fn_20384 CConnection::~CConnection: logic confirmed by peer review (already on main)
- fn_20389 CConnection::Connect: logic confirmed by peer review
- fn_20390 CConnection::Close: logic confirmed by peer review
- fn_20409 GetRagConnection: logic confirmed by peer review
- fn_21406 AutomaticSkills::Complete: logic confirmed by peer review
- fn_03927 CCharacterLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_11073 UIScrollBar::UIScrollBar: logic confirmed by peer review
- fn_11102 UIComboBoxEx2::~UIComboBoxEx2: logic confirmed by peer review (already on main)
- fn_09150 AutomaticSkills::DisableAll: logic confirmed by peer review
- fn_09153 AutomaticSkills::Use: logic confirmed by peer review
- fn_10689 UIBitmapButton::~UIBitmapButton: logic confirmed by peer review (already on main)
- fn_10795 UIBitmapButton::Paint: logic confirmed by peer review
- fn_10817 UIStaticBitmap::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:01:00 +00:00
ragnarok-clanker
faae91cc6d Decompile fn_17826 (CMode::DrawTexture) 
Batch #1600 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17826 CMode::DrawTexture: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:49:26 +00:00
ragnarok-clanker
c934fe7820 Decompile 2 functions in Source/UI/Shortcuts/ShortcutCooldowns.cpp, Source/Client/Session.h 
Batch #1653 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23876 CSession::IsSkillIdInRange6018: logic confirmed by peer review
- fn_23877 CSession::IsSkillIdInRange6001: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 19:47:58 +00:00
ragnarok-clanker
94649ccac7 Decompile 5 functions in Source/Client/ReplayPacketRecorder.cpp, Source/Client/ReplayPacketRecorder.h, ... 
Batch #1630 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_17000 WindowReplayRecorder::RecordDrop: logic confirmed by peer review
- fn_17001 WindowReplayRecorder::RecordData: logic confirmed by peer review
- fn_17002 WindowReplayRecorder::RecordValues: logic confirmed by peer review
- fn_17003 WindowReplayRecorder::RecordText: logic confirmed by peer review
- fn_19331 Replay::RecordPacket: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:46:26 +00:00
ragnarok-clanker
4bce141e4c Decompile fn_23811 (CSession::GetPetHungryStateString) 
Batch #1625 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23811 CSession::GetPetHungryStateString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:45:56 +00:00
ragnarok-clanker
6ebe295226 Decompile fn_23814 (CSession::GetPetTalkName) 
Batch #1621 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23814 CSession::GetPetTalkName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetTalkNames.cpp
 2026-10-28 19:45:23 +00:00
ragnarok-clanker
96c3974f4c Decompile fn_17830 (SanitizeScreenshotName) 
Batch #1616 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17830 SanitizeScreenshotName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeScreenshot.cpp
 2026-10-28 19:44:47 +00:00
ragnarok-clanker
4f43f6132f Decompile fn_17829 (ShowErrorDialog) 
Batch #1611 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17829 ShowErrorDialog: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:44:24 +00:00
ragnarok-clanker
4f48baf914 Decompile 2 functions in Source/Client/ModeTransitions.cpp, Source/Client/Mode/ActiveGameMode.h 
Batch #1610 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17845 CWorld::Quit: logic confirmed by peer review
- fn_17851 CWorld::Switch: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeTransitions.cpp
 2026-10-28 19:44:21 +00:00
ragnarok-clanker
499d5b8558 Decompile 2 functions in Source/Contents/MonsterResources.cpp, Source/Client/Session.h 
Batch #1608 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23790 CSession::GetMonsterSprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterResources.cpp
 2026-10-28 19:44:03 +00:00
ragnarok-clanker
c3fe24e020 Decompile 2 functions in Source/Contents/ActorMovementRoute.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #1601 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_19317 Replay::DelayScale: logic confirmed by peer review
- fn_21028 CGameActor::FindRoute: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ActorMovementRoute.cpp
 2026-10-28 19:42:58 +00:00
ragnarok-clanker
1ebead0e33 Decompile fn_21632 (CGameMode::ReceiveActorNameAll) 
Batch #1591 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21632 CGameMode::ReceiveActorNameAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ActorNamePacket.cpp
 2026-10-28 19:42:41 +00:00
ragnarok-clanker
838c0044d2 Decompile 70 functions in Source/Client/Browser/BrowserFactory.cpp, Source/Contents/Emblems/EmblemUpload.cpp, ... 
Batch #1665 by ragnarok-clanker: 0 byte-identical, 70 confirmed by peer review.

- fn_10904 UIEditCtrl::UpdateLinks: logic confirmed by peer review
- fn_10905 EditViewport::Synchronize: logic confirmed by peer review
- fn_10950 UIBalloonText::SetText: logic confirmed by peer review
- fn_11216 ItemLinkDisplay::Convert: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review (already on main)
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review (already on main)
- fn_11366 UIListBox::Paint: logic confirmed by peer review
- fn_11367 UIListBoxEx::Paint: logic confirmed by peer review
- fn_11392 UITextButton::Paint: logic confirmed by peer review
- fn_11394 UITextViewer::Paint: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review (already on main)
- fn_11471 UITextButton::Slot27: logic confirmed by peer review (already on main)
- fn_11494 UITextButton::Slot33: logic confirmed by peer review (already on main)
- fn_11562 UITextViewer::SendMsg: logic confirmed by peer review (already on main)
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review (already on main)
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review (already on main)
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review (already on main)
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review (already on main)
- fn_12680 ShortcutPainting::Paint: logic confirmed by peer review
- fn_13829 WrapPlainText: logic confirmed by peer review
- fn_13833 WrapRichText: logic confirmed by peer review
- fn_16941 UIWindow::DrawAmount: logic confirmed by peer review
- fn_16971 UIWindow::TextHeight: logic confirmed by peer review
- fn_16972 UIWindow::VerticalTextHeight: logic confirmed by peer review
- fn_16973 UIWindow::TextSize: logic confirmed by peer review
- fn_16974 UIWindow::VerticalTextSize: logic confirmed by peer review
- fn_16975 UIWindow::TextWidth: logic confirmed by peer review
- fn_16993 WrapPixelText: logic confirmed by peer review
- fn_17007 FitText: logic confirmed by peer review
- fn_17009 UIWindow::DrawTextAt: logic confirmed by peer review
- fn_17013 DrawOutlinedColoredText: logic confirmed by peer review
- fn_17014 DrawStyledColoredText: logic confirmed by peer review
- fn_17015 DrawColoredText: logic confirmed by peer review
- fn_17016 DrawOutlinedText: logic confirmed by peer review
- fn_17136 BrowserFactory::Create: logic confirmed by peer review
- fn_18376 LookupMessage: logic confirmed by peer review
- fn_01934 TextContext::TextContext: logic confirmed by peer review
- fn_01957 TextContext::Marker: logic confirmed by peer review
- fn_01961 TextContext::Measure: logic confirmed by peer review
- fn_01966 TextContext::SetFont: logic confirmed by peer review
- fn_01970 TextContext::DrawPair: logic confirmed by peer review
- fn_01971 TextContext::Draw: logic confirmed by peer review
- fn_01983 TextContext::MeasurePart: logic confirmed by peer review
- fn_01984 TextContext::DrawPart: logic confirmed by peer review
- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review
- fn_24191 EmotionHotkeys::LoadDefaults: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03666 CAdventurerAgencyMgr::CompleteRegistration: logic confirmed by peer review
- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_04239 CMCStoreInfoBackup::CompleteSave: logic confirmed by peer review
- fn_04262 CPlayerNameDictionary::Lookup: logic confirmed by peer review
- fn_06581 ItemNaming::DisplayName: logic confirmed by peer review (already on main)
- fn_06583 ItemNamingContext::Element: logic confirmed by peer review (already on main)
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review (already on main)
- fn_06585 ItemNaming::Creator: logic confirmed by peer review (already on main)
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review (already on main)
- fn_06587 ItemNaming::Suffixes: logic confirmed by peer review (already on main)
- fn_06588 ItemNaming::Prefixes: logic confirmed by peer review (already on main)
- fn_09299 UIApplyForPartyWnd::Slot15: logic confirmed by peer review
- fn_09300 UIRegisterPartyWnd::Slot15: logic confirmed by peer review
- fn_09301 UIRequestJoinPartyWnd::Slot15: logic confirmed by peer review
- fn_09303 UIApplyForPartyWnd::Paint: logic confirmed by peer review
- fn_09304 UIPartyInfoWnd::Paint: logic confirmed by peer review
- fn_10748 UIEditCtrl::RemoveInvalidLink: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review (already on main)
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review (already on main)
- fn_10794 UIBasicButton::Paint: logic confirmed by peer review
- fn_10799 UIBmpTextButton::Paint: logic confirmed by peer review
- fn_10823 UITransBalloonText::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:35:29 +00:00
ragnarok-clanker
f464cd3f17 Decompile 41 functions in Source/Client/Input/InputCharset.cpp, Source/Client/Input/InputCharset.h, ... 
Batch #1607 by ragnarok-clanker: 0 byte-identical, 41 confirmed by peer review.

- fn_11718 DrawItemIconById: logic confirmed by peer review
- fn_11719 DrawItemSlotBackground: logic confirmed by peer review
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review
- fn_12089 UIWindow::DrawButtonBarAt: logic confirmed by peer review
- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12120 UIWindow::LoadStyledBitmap: logic confirmed by peer review
- fn_12219 UIDisconnectedServerMsgWnd::Paint: logic confirmed by peer review
- fn_12233 UINoticeConfirmWnd::Paint: logic confirmed by peer review
- fn_12245 UIQuitWnd::Paint: logic confirmed by peer review
- fn_12246 UIRestartWnd::Paint: logic confirmed by peer review
- fn_12258 UIWaitWnd::Paint: logic confirmed by peer review
- fn_14470 CUIFrameWnd::RefreshSkinColors: logic confirmed by peer review
- fn_14471 CUIFrameWnd::Paint: logic confirmed by peer review
- fn_14472 CUIFrameWnd::SetSkinColors: logic confirmed by peer review
- fn_14635 CUIControl::LoadBitmapResource: logic confirmed by peer review
- fn_17781 InputCharset::Prefix: logic confirmed by peer review
- fn_17788 InputCharset::ServiceName: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_18378 Resolve: logic confirmed by peer review
- fn_02111 RendererDX7Operations::SaveLogo: logic confirmed by peer review
- fn_09446 UICashEmotionPack::Paint: logic confirmed by peer review
- fn_09453 UICashEmotionPack::SetSaleBadge: logic confirmed by peer review
- fn_09483 UICashEmotionPiece::Paint: logic confirmed by peer review
- fn_45445 CSkinMgr::CSkinMgr: logic confirmed by peer review
- fn_09681 CSkinMgr::~CSkinMgr: logic confirmed by peer review
- fn_09683 CSkinMgr::Prepare: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review
- fn_09686 CSkinMgr::Name: logic confirmed by peer review
- fn_09687 CSkinMgr::Prefix: logic confirmed by peer review
- fn_09688 CSkinMgr::Name: logic confirmed by peer review
- fn_09690 CSkinMgr::Selected: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SkinMgr.cpp
 2026-10-28 19:13:07 +00:00
ragnarok-clanker
b496a618dc Decompile 2 functions in Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp, ... 
Batch #1582 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23486 CSession::GetRobeAlpha: logic confirmed by peer review
- fn_24176 CSession::IsTopLayerRobe: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp
 2026-10-28 19:10:37 +00:00
ragnarok-clanker
9312817430 Maintenance: Define two globals that main reads but never defines. g_applicationDirectory (gl_24584, 0x173AD78, char[0x80]) has one w 
Batch #1570 by ragnarok-clanker: no function's compiled code changes; checked with 5 compiled unit(s), including every includer of Source/Client/Application/Launcher.h, Source/Client/Input/InputCharset.h.
 2026-10-28 18:59:30 +00:00
ragnarok-clanker
3d4b2c79dc Decompile 2 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UIMerInfoWnd.h, ... 
Batch #1553 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11712 UIBank_NewWnd::TransactionAmount: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 18:50:35 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ... 
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
 2026-10-28 18:48:31 +00:00
ragnarok-clanker
943d22d0b8 Decompile fn_11762 (UICntWnd::Paint) 
Batch #1544 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_11762 UICntWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 17:58:13 +00:00
ragnarok-clanker
d525ec0c0a Maintenance: Define the window handle global hWnd (gl_24399, 0x173AD68, 4 bytes, zero-initialized .data with no file backing). Its on 
Batch #1489 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/Client/Application/ApplicationWindow.h.
 2026-10-28 16:47:41 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ... 
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 16:45:10 +00:00
ragnarok-clanker
16b72c624f Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ... 
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:32:17 +00:00
ragnarok-clanker
447fa8b9f6 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #1470 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23590 IsVisibleJob: logic confirmed by peer review
- fn_23841 GetWeaponViewValue: logic confirmed by peer review
- fn_23906 ResetHotkeySlots: logic confirmed by peer review
- fn_23910 CSession::SetPairValue: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 14:13:00 +00:00
ragnarok-clanker
c351db5d57 Decompile 4 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h 
Batch #1467 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23466 CSession::GetServerTime: logic confirmed by peer review
- fn_23605 CSession::AddPingSample: logic confirmed by peer review
- fn_23637 CSession::SetServerTime: logic confirmed by peer review
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/ClientTiming.cpp
 2026-10-28 14:02:41 +00:00
ragnarok-clanker
b9474e7c82 Decompile fn_23379 (CSession::HomunSkillLevel) 
Batch #1465 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23379 CSession::HomunSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 13:55:33 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ... 
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
 2026-10-28 12:59:53 +00:00
ragnarok-clanker
4595841b32 Decompile fn_17789 (TextInputBuffer::AdvanceCursor) 
Batch #1387 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17789 TextInputBuffer::AdvanceCursor: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 12:36:28 +00:00
ragnarok-clanker
26ff979bde Decompile 3 functions in Source/UI/Window/UIWindow.cpp, Source/Client/Mode/CGameMode.h, ... 
Batch #1400 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_03560 UIWindow::Slot44: logic confirmed by peer review
- fn_03565 CGameMode::MapName: logic confirmed by peer review
- fn_03568 UINavigationV4Wnd::IsListShown: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:35:57 +00:00
ragnarok-clanker
ee280b667b Decompile fn_23401 (CSession::MercSkillLevel) 
Batch #1324 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23401 CSession::MercSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 12:06:46 +00:00
ragnarok-clanker
648ae44d9d Decompile 2 functions in Source/Contents/AdventureGuideMgr.cpp, Source/Contents/AdventureGuideMgr.h, ... 
Batch #1377 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05237 CAdventureGuideMgr::GetEpisodeList: logic confirmed by peer review
- fn_05238 CAdventureGuideMgr::GetContentsList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:06:16 +00:00
ragnarok-clanker
e541c278b4 Decompile fn_17786 (TextInputBuffer::SetFlag8C) 
Batch #1372 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17786 TextInputBuffer::SetFlag8C: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:44:54 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems) 
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
 2026-10-28 11:42:30 +00:00