Commit graph

12 commits

Author SHA1 Message Date
ragnarok-clanker
41e29dee49 Decompile 4 functions in Source/Contents/Items/ItemNaming.cpp, Source/Contents/Effects/EffectLists.cpp, ...
Batch #4201 by willerthal: 0 byte-identical, 4 confirmed by peer review.

- fn_06596 LoadItemNameTables: logic confirmed by peer review
- fn_18776 CreateEffectMgr: logic confirmed by peer review
- fn_18561 ?ThunderingOrbName@@YAAAV?$EncryptedName@$0EE@$0CPILAPDHBBINBFHP@@?A0xb1221624@@XZ: logic confirmed by peer review
- fn_18655 ?Create@?$CEffectAllocator@VCThunderingOrb@?A0xb1221624@@@?A0xb1221624@@UAEPAVCEffect@@XZ: logic confirmed by peer review

Peer-reviewed-by: Yommy, superintelligence, OrangeCat
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:47:23 +00:00
ragnarok-clanker
3841fddaf8 Decompile fn_18775 (EffectLists::SpawnLevel99)
Batch #3585 by willerthal: 0 byte-identical, 1 confirmed by peer review.

- fn_18775 EffectLists::SpawnLevel99: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, bigodeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:51:44 +00:00
ragnarok-clanker
979eb0d7dc Decompile 5 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #3335 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_18803 DirectionAngle: logic confirmed by peer review
- fn_18804 ScreenAngle: logic confirmed by peer review
- fn_18805 CurrentMapScriptName: logic confirmed by peer review
- fn_18806 EffectFunctionName: logic confirmed by peer review
- fn_18794 EffectLists::Render: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:28:34 +00:00
ragnarok-clanker
2ba833f291 Decompile 2 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #2985 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_24180 CSession::IsEffectRenderEnabled: byte-identical
- fn_24194 CSession::ResetUnknownState: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:09:59 +00:00
ragnarok-clanker
76ac1d4c92 Decompile 3 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/Effect.cpp, ...
Batch #2114 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18774 EffectLists::Spawn: logic confirmed by peer review
- fn_18991 CEffect::SetActor: logic confirmed by peer review
- fn_18992 CEffect::SetSourceActor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:47:33 +00:00
ragnarok-clanker
fdabefeb7f Decompile fn_18576 (?Create@?$CEffectAllocator@VCChopChopClawMarks@@@?A0x3d349e23@@UAEPAVCEffect@@XZ)
Batch #2088 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_18576 ?Create@?$CEffectAllocator@VCChopChopClawMarks@@@?A0x3d349e23@@UAEPAVCEffect@@XZ: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 09:57:46 +00:00
ragnarok-clanker
c8c22a1db2 Decompile 4 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/GravityControlEffect.h, ...
Batch #2071 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18604 ?Create@?$CEffectAllocator@VCGravityControlEffect@@@?A0xe7faba0d@@UAEPAVCEffect@@XZ: logic confirmed by peer review
- fn_18618 ?Create@?$CEffectAllocator@VCMeteorEffect@@@?A0xe7faba0d@@UAEPAVCEffect@@XZ: logic confirmed by peer review
- fn_18637 ?Create@?$CEffectAllocator@VCShadowExceedNew@@@?A0xe7faba0d@@UAEPAVCEffect@@XZ: logic confirmed by peer review
- fn_18642 ?Create@?$CEffectAllocator@VCSprArrowEffect@@@?A0xe7faba0d@@UAEPAVCEffect@@XZ: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 09:55:51 +00:00
ragnarok-clanker
6d568f53db Decompile 6 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/EffectLists.h, ...
Batch #1818 by Yommy: 0 byte-identical, 6 confirmed by peer review.

- fn_18772 EffectLists::RetireActor: logic confirmed by peer review
- fn_18777 EffectLists::Retire: logic confirmed by peer review
- fn_18778 EffectLists::Retire: logic confirmed by peer review
- fn_18779 EffectLists::Retire: logic confirmed by peer review
- fn_18780 EffectLists::Clear: logic confirmed by peer review
- fn_18781 EffectLists::Release: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:37:37 +00:00
ragnarok-clanker
0f7843e7c6 Decompile 2 functions in Source/Contents/Effects/EffectLists.cpp, Source/Contents/Effects/EffectLists.h
Batch #1724 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_18781 EffectLists::Release: logic confirmed by peer review
- fn_18782 DestroyEffectMgr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 21:43:07 +00:00
ragnarok-clanker
db00a48497 🛠️ refactor(effects): replaced magic number 2343 with EF_UNK_2343 enum constant 2026-10-27 09:26:08 +01:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
Renamed from Source/Contents/EffectLists.cpp (Browse further)