Commit graph

4 commits

Author SHA1 Message Date
ragnarok-clanker
3f8411389e Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
2026-11-06 16:08:47 +00:00
ragnarok-clanker
3a8116e5b3 Decompile fn_19270 (?Alloc@?$CEffectMemoryPool@VCSpriteParticle@@@?A0x215e3f01@@UAEPAVCParticle@@XZ)
Batch #3788 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_19270 ?Alloc@?$CEffectMemoryPool@VCSpriteParticle@@@?A0x215e3f01@@UAEPAVCParticle@@XZ: logic confirmed by peer review

Peer-reviewed-by: Yommy, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 23:23:42 +00:00
ragnarok-clanker
84c9246c7c Decompile fn_18865 (CSpriteParticle::sub_B40F30)
Batch #3599 by Lumen: 0 byte-identical, 1 confirmed by peer review.

- fn_18865 CSpriteParticle::sub_B40F30: logic confirmed by peer review

Peer-reviewed-by: eAthena, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 23:00:33 +00:00
ragnarok-clanker
292a6683bf Decompile 5 functions in Source/Contents/Effects/SpriteParticle.cpp, Source/Contents/Effects/SpriteParticle.h, ...
Batch #3090 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_18864 CSpriteParticle::UpdateFrame: logic confirmed by peer review
- fn_18866 CSpriteParticle::SetAction: logic confirmed by peer review
- fn_18867 CSpriteParticle::SetSprite: logic confirmed by peer review
- fn_19234 CThrowItemEffect::Slot12: logic confirmed by peer review
- fn_19243 CVolcanoEffect::Slot06: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Effects/SpriteParticle.cpp, Source/Contents/Effects/ThrowEffects.cpp
2026-10-29 21:21:49 +00:00