Commit graph

15 commits

Author SHA1 Message Date
ragnarok-clanker
e235d90a62 Maintenance: [forced, user-approved] Family G29: WindowMouseHit (inventory row, header of former bundle). The header only declared tw
Batch #10255 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 5 compiled unit(s), including every includer of Source/UI/Window/WindowMouseHit.h.
Deletes: Source/UI/Window/WindowMouseHit.h
2026-11-03 12:54:24 +00:00
ragnarok-clanker
2b755e795a Maintenance: [forced, user-approved] Family F6 (closes family F): delete the four headers left empty or orphaned by F1-F5. WindowDial
Batch #10239 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 494 compiled unit(s), including every includer of Source/UI/GameSettings/GameSettingsUI.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowDialogs.h, Source/Client/Mode/ModeTooltip.h, Source/Client/Mode/ModeCursor.h, Source/UI/Window/WindowRegistration.h.
Deletes: Source/UI/Window/WindowDialogs.h, Source/Client/Mode/ModeTooltip.h, Source/Client/Mode/ModeCursor.h, Source/UI/Window/WindowRegistration.h
2026-11-03 11:10:29 +00:00
ragnarok-clanker
14a432d922 Maintenance: [forced, user-approved] Family F3: remove WindowDialogs, WindowResponseRecorder, UIMessageBoxContext, UIEntryQueueContex
Batch #10232 by ragnarok-clanker: forced by an admin (22 lower score(s), 263 changed function(s)); checked with 562 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/ReplayPacketRecorder.h, Source/Client/Session.h, Source/Contents/NavigationManager.h, Source/UI/Acceptance/UIJoinPartyAcceptWnd.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowDialogs.h.
2026-11-03 10:23:36 +00:00
ragnarok-clanker
7a7f70953a Maintenance: Make CStoveMgr a real polymorphic class instead of a void* vtable field set to 0x0110C63C: CStoveMgr derives from Single
Batch #9473 by ragnarok-clanker: forced by an admin (1 lower score(s), 2 changed function(s)); checked with 4 compiled unit(s), including every includer of Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h.
2026-11-01 14:17:34 +00:00
ragnarok-clanker
1067987d45 Maintenance: Replace raw address calls: StovePCSDK.h inline wrappers that jumped to 0x00E6CD71 / 0x00E6CD5F (fn_25069 j_IAP_FetchTerm
Batch #8907 by ragnarok-clanker: forced by an admin (2 lower score(s), 5 changed function(s)); checked with 1 compiled unit(s), including every includer of Source/Client/Stove/StovePCSDK.h.
2026-10-31 23:02:52 +00:00
ragnarok-clanker
7c3303b781 Decompile 2 functions in Source/Client/Stove/StoveMgr.cpp
Batch #7908 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_04800 CStoveMgr::FetchAllProducts: logic confirmed by peer review
- fn_45460 CStoveMgr::FetchCategoryProducts: logic confirmed by peer review

Peer-reviewed-by: secret, Romain, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 12:33:45 +00:00
ragnarok-clanker
56f450c4df Decompile 5 functions in Source/Client/Stove/StoveMgr.cpp, Source/Client/Stove/StoveMgr.h, ...
Batch #7521 by secret: 0 byte-identical, 5 confirmed by peer review.

- fn_04781 ShutdownCallback::operator(): logic confirmed by peer review
- fn_04784 CategoryProductsCallback::operator(): logic confirmed by peer review
- fn_04791 ConfirmPurchaseCallback::operator(): logic confirmed by peer review
- fn_04795 CStoveMgr::Initialize: logic confirmed by peer review
- fn_04799 CStoveMgr::StartPurchase: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:00:32 +00:00
ragnarok-clanker
8bd7ff9b7b Decompile 2 functions in Source/Client/Stove/StoveMgr.cpp, Source/Client/Stove/StoveMgr.h, ...
Batch #7357 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_04782 FetchProductsCallback::operator(): logic confirmed by peer review
- fn_04783 PurchaseResultCallback::operator(): logic confirmed by peer review

Peer-reviewed-by: secret, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 08:07:51 +00:00
ragnarok-clanker
488a4e4df3 Decompile fn_04785 (CStoveMgr::OnOpenUrlCallback)
Batch #7327 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_04785 CStoveMgr::OnOpenUrlCallback: logic confirmed by peer review

Peer-reviewed-by: meitogi, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:32:52 +00:00
ragnarok-clanker
98ea8744d1 Decompile fn_04801 (FetchStoveTermsAgreement)
Batch #7330 by alisonrag: 0 byte-identical, 1 confirmed by peer review.

- fn_04801 FetchStoveTermsAgreement: logic confirmed by peer review

Peer-reviewed-by: Yommy, meitogi, Lumen, superintelligence, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:13:10 +00:00
ragnarok-clanker
03cc5a84fd Decompile fn_04778 (CStoveMgr::CStoveMgr)
Batch #6902 by alisonrag: 0 byte-identical, 1 confirmed by peer review.

- fn_04778 CStoveMgr::CStoveMgr: logic confirmed by peer review

Peer-reviewed-by: superintelligence, Snow, Landruca
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:21:46 +00:00
ragnarok-clanker
939ceb44b3 Decompile fn_04789 (CStoveMgr::OnInitializeCallback)
Batch #5973 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_04789 CStoveMgr::OnInitializeCallback: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:18:25 +00:00
ragnarok-clanker
c2656d423a Decompile fn_04794 (CSession::AddItem1784)
Batch #5206 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_04794 CSession::AddItem1784: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, Bruwuno
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:56:04 +00:00
ragnarok-clanker
4f72d7364c Decompile 3 functions in Source/Client/Stove/StoveMgr.cpp, Source/Client/Stove/StoveMgr.h, ...
Batch #5062 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_04796 CStoveMgr::GetAccessToken: logic confirmed by peer review
- fn_04797 CStoveMgr::FetchUser: logic confirmed by peer review
- fn_04802 CStoveMgr::WaitForCallback: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 08:31:55 +00:00
ragnarok-clanker
f85200f65b Decompile 4 functions in Source/Client/Stove/StoveMgr.cpp
Batch #4180 by youko: 0 byte-identical, 4 confirmed by peer review.

- fn_04786 AccessTokenFailureMessage::operator(): logic confirmed by peer review
- fn_04787 UserFailureMessage::operator(): logic confirmed by peer review
- fn_04788 TokenCallbackFailureMessage::operator(): logic confirmed by peer review
- fn_04790 PurchaseCheckingMessage::operator(): logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence, OrangeCat
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Stove/StoveMgr.cpp
2026-10-30 02:42:02 +00:00