clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
1,741 commits 1 branch 0 tags 18 MiB
Commit graph

14 commits

Author SHA1 Message Date
ragnarok-clanker
c1b0236af5 Decompile 12 functions in Source/Contents/ClientItemLists.cpp 
Batch #5074 by Bruwuno: 0 byte-identical, 12 confirmed by peer review.

- fn_21643 sub_D1FBA0: logic confirmed by peer review
- fn_23339 ClientItemLists::RemoveItem1710: logic confirmed by peer review
- fn_23340 ClientItemLists::RemoveItem1768: logic confirmed by peer review
- fn_23341 ClientItemLists::RemoveItem1740: logic confirmed by peer review
- fn_23344 ClientItemLists::RemoveItem1760: logic confirmed by peer review
- fn_23345 ClientItemLists::RemoveItem1718ByItemId: logic confirmed by peer review
- fn_23346 ClientItemLists::RemoveItem1718: logic confirmed by peer review
- fn_23347 ClientItemLists::RemoveItem1720ByName: logic confirmed by peer review
- fn_23348 ClientItemLists::RemoveItem1720: logic confirmed by peer review
- fn_23349 ClientItemLists::RemoveItem1730: logic confirmed by peer review
- fn_23350 ClientItemLists::ReduceItem1718: logic confirmed by peer review
- fn_23351 ClientItemLists::RemoveItem1738: logic confirmed by peer review

Peer-reviewed-by: Yommy, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 07:24:28 +00:00
ragnarok-clanker
05be22bdcf Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ... 
Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.

- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp
 2026-10-30 06:43:59 +00:00
ragnarok-clanker
4d63693f2b Decompile fn_24164 (CSession::FindItemByIdentity) 
Batch #4632 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24164 CSession::FindItemByIdentity: logic confirmed by peer review

Peer-reviewed-by: alisonrag, Bruwuno, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 05:25:04 +00:00
ragnarok-clanker
cd54b65ff6 Decompile 10 functions in Source/Client/Mode/CGameMode.h, Source/Client/Mode/GameModePackets.cpp, ... 
Batch #4422 by eAthena: 3 byte-identical, 7 confirmed by peer review.

- fn_21638 CGameMode::IgnoreRemovedPacket3: byte-identical
- fn_21649 CGameMode::IgnoreRemovedPacket4: byte-identical
- fn_21653 CGameMode::IgnoreRemovedPacket5: byte-identical
- fn_21657 CGameMode::ReceiveUnknown05C4Result: logic confirmed by peer review
- fn_21640 CGameMode::ReceiveItem1738Add: logic confirmed by peer review
- fn_21644 CGameMode::ReceiveItem1740Add: logic confirmed by peer review
- fn_21645 CGameMode::ReceiveItem1740AddOptions: logic confirmed by peer review
- fn_21646 CGameMode::ReceiveItem1740AddGrade: logic confirmed by peer review
- fn_21647 CGameMode::ReceiveItem1738AddOptions: logic confirmed by peer review
- fn_21648 CGameMode::ReceiveItem1738AddGrade: logic confirmed by peer review

Peer-reviewed-by: willerthal, KWDev, Qwenkler3.8
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 04:00:21 +00:00
ragnarok-clanker
8a56488e17 Decompile fn_24149 (ClientItemLists::EquipItem6B68) 
Batch #4475 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24149 ClientItemLists::EquipItem6B68: logic confirmed by peer review

Peer-reviewed-by: willerthal, youko, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 03:25:20 +00:00
ragnarok-clanker
cc96dd3c6f Decompile 17 functions in Source/Contents/ClientItemLists.cpp 
Batch #3317 by youko: 0 byte-identical, 17 confirmed by peer review.

- fn_23313 ClientItemLists::ClearInventory: logic confirmed by peer review
- fn_23314 ClientItemLists::ClearItems1760And1748: logic confirmed by peer review
- fn_23315 ClientItemLists::ClearItems1768: logic confirmed by peer review
- fn_23316 ClientItemLists::ClearItems1740: logic confirmed by peer review
- fn_23317 ClientItemLists::ClearItems1750: logic confirmed by peer review
- fn_23318 ClientItemLists::ClearItems1758: logic confirmed by peer review
- fn_23319 ClientItemLists::ClearItems1760: logic confirmed by peer review
- fn_23320 ClientItemLists::ClearItems1748: logic confirmed by peer review
- fn_23322 ClientItemLists::ClearItems1784: logic confirmed by peer review
- fn_23325 ClientItemLists::ClearPartyMembers: logic confirmed by peer review
- fn_23327 ClientItemLists::ClearItems1720: logic confirmed by peer review
- fn_23328 ClientItemLists::ResetHotkeyDescriptions: logic confirmed by peer review
- fn_23329 ClientItemLists::ClearItems1738: logic confirmed by peer review
- fn_23330 ClientItemLists::CopyItems1740To1750: logic confirmed by peer review
- fn_23331 ClientItemLists::CopyItems1760To1770: logic confirmed by peer review
- fn_23332 ClientItemLists::FindItem1750: logic confirmed by peer review
- fn_23333 ClientItemLists::IsDifferentName: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Reviewed-by: ragnarok-clanker
 2026-10-29 22:24:48 +00:00
ragnarok-clanker
28fa4a27bb Decompile 4 functions in Source/Contents/ClientItemLists.cpp 
Batch #3319 by youko: 4 byte-identical, 0 confirmed by peer review.

- fn_23321 ClientItemLists::ClearRecords0734: byte-identical
- fn_23323 ClientItemLists::ClearItemSlotQuantities: byte-identical
- fn_23324 ClientItemLists::ResetEquipped: byte-identical
- fn_23326 ClientItemLists::ResetUnknown166C: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 21:22:45 +00:00
ragnarok-clanker
c77bf2f4d8 Decompile fn_23359 (CSession::GetUnknown8134) 
Batch #3307 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_23359 CSession::GetUnknown8134: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 21:20:13 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
018dee6278 Decompile 15 functions in Source/Client/Session.h, Source/Client/Replay.cpp, ... 
Batch #1712 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.

- fn_06570 ItemInfo::AssignBasic: logic confirmed by peer review
- fn_06607 SearchItemIds: logic confirmed by peer review
- fn_06608 MatchItemName: logic confirmed by peer review
- fn_06582 FindMetalProcessItems: logic confirmed by peer review
- fn_06590 ItemInfo::Serialize: logic confirmed by peer review
- fn_06544 FindItemCardName: logic confirmed by peer review
- fn_23291 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23297 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review
- fn_23588 CSession::IsSlotItemIdentity: logic confirmed by peer review
- fn_23589 CSession::HasInventoryItem: logic confirmed by peer review
- fn_23591 CSession::HasItemId: logic confirmed by peer review
- fn_23592 CSession::HasItemCount: logic confirmed by peer review
- fn_23582 IsScreenShakeActive: logic confirmed by peer review
- fn_23908 CSession::SetPlayerNameKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:47:17 +00:00
ragnarok-clanker
8125ad1ce1 Decompile fn_06623 (BuildReplayTaggedRecord) 
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:43:04 +00:00
ragnarok-clanker
5807cc52c4 Decompile fn_23282 (ClientItemLists::AddItem1710) 
Batch #1345 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23282 ClientItemLists::AddItem1710: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:03:07 +00:00
ragnarok-clanker
d30c7a352d Decompile fn_17229 (RefreshItemWindows) 
Batch #1268 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_17229 RefreshItemWindows: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 01:25:20 +00:00
ragnarok-clanker
f1bdb5d5df Decompile 16 functions in Source/Contents/ClientItemLists.cpp 
Batch #1154 by eAthena: 0 byte-identical, 16 confirmed by peer review.

- fn_23232 ?Decode@EquipSlotDecoder@?A0x7377eef8@@QBE?AUEquipSlots@2@H@Z: logic confirmed by peer review
- fn_23284 ClientItemLists::AddItem1768: logic confirmed by peer review
- fn_23285 ClientItemLists::AddItem1740: logic confirmed by peer review
- fn_23286 ClientItemLists::AddItem1750: logic confirmed by peer review
- fn_23287 ClientItemLists::AddItem1758: logic confirmed by peer review
- fn_23288 ClientItemLists::AddItem1760: logic confirmed by peer review
- fn_23289 ClientItemLists::AddItem1748: logic confirmed by peer review
- fn_23290 ClientItemLists::Equip: logic confirmed by peer review
- fn_23292 ClientItemLists::AppendItem1718: logic confirmed by peer review
- fn_23293 ClientItemLists::MergeItem1718ByName: logic confirmed by peer review
- fn_23294 ClientItemLists::MergeItem1720ByName: logic confirmed by peer review
- fn_23295 ClientItemLists::MergeItem1720: logic confirmed by peer review
- fn_23296 ClientItemLists::AddItem1730: logic confirmed by peer review
- fn_23298 ClientItemLists::MergeItem1718: logic confirmed by peer review
- fn_23299 ClientItemLists::AddItem1738: logic confirmed by peer review
- fn_23300 ?GetEquipSlots@ClientItemLists@@QAE?AUEquipSlots@?A0x7377eef8@@H@Z: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientItemLists.cpp
 2026-10-27 21:06:04 +00:00