Commit graph

11 commits

Author SHA1 Message Date
ragnarok-clanker
d530ba1819 Decompile 2 functions in Source/Contents/Skills/PlayerSkillBundle.cpp
Batch #12808 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_08287 CPlayerSkillBundle::ForEachGrouped: logic confirmed by peer review
- fn_08290 CPlayerSkillBundle::FindGrouped: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 04:52:04 +00:00
ragnarok-clanker
ace21574e0 Decompile 25 functions in Source/Render/DX9/DeviceStateDX9.cpp, Source/Contents/Items/BarterMarketItemMgr.cpp, ...
Batch #12861 by KWDev: 25 byte-identical, 0 confirmed by peer review.

- fn_01999 DeviceStateDX9::SetFVF: byte-identical
- fn_03738 CBarterMarketItemMgr::GetAmountById: byte-identical
- fn_03765 CExpandedBarterMarketItemMgr::GetItemValueById: byte-identical
- fn_03768 CExpandedBarterMarketItemMgr::GetItemFactorById: byte-identical
- fn_03771 CExpandedBarterMarketItemMgr::GetValueById: byte-identical
- fn_04794 CSession::AddItem1784: byte-identical
- fn_08113 CTagData::UpdateActiveCount: byte-identical
- fn_08269 CPlayerSkillBundle::UpdatePending: byte-identical
- fn_08277 CPlayerSkillBundle::FindExtra: byte-identical
- fn_09851 UIMacroReporterWnd::Slot31: byte-identical
- fn_10062 UIRodexInboxWnd::RemoveInboxMail: byte-identical
- fn_11524 UIChatHisBox::Resize: byte-identical
- fn_16039 GameSettingsUI::CUIGroupSkin::Refresh: byte-identical
- fn_16979 UIWindow::FindUid: byte-identical
- fn_17144 UIWindowMgr::RemoveOrder: byte-identical
- fn_17165 UIWindowMgr::FindSnapExcludedWindow: byte-identical
- fn_17414 CWebBrowser::Normalize: byte-identical
- fn_18045 GuildInfo::UpdateMemberStatus: byte-identical
- fn_18046 GuildInfo::SetMemberOnline: byte-identical
- fn_18309 TELEXInputMode::IsModifierKey: byte-identical
- fn_21008 CRenderObject::Face: byte-identical
- fn_23740 CSession::UpdateAdditionalSkill: byte-identical
- fn_23741 CSession::UpdateHomunSkill: byte-identical
- fn_23742 CSession::UpdateMercSkill: byte-identical
- fn_23777 CSession::FindUnknown0778: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 02:07:05 +00:00
ragnarok-clanker
c358f10563 Decompile 5 functions in Source/Contents/Skills/PlayerSkillBundle.cpp
Batch #12811 by cremane: 5 byte-identical, 0 confirmed by peer review.

- fn_08278 CPlayerSkillBundle::NumberExtra: byte-identical
- fn_08283 CPlayerSkillBundle::MarkLevelChanges: byte-identical
- fn_08284 CPlayerSkillBundle::HasHigherLevel: byte-identical
- fn_08291 CPlayerSkillBundle::Group: byte-identical
- fn_08292 CPlayerSkillBundle::GroupSize: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 01:01:21 +00:00
ragnarok-clanker
e5ed6ffe3c Confirm fn_08280 (CPlayerSkillBundle::Lookup)
Batch #12081 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.

- fn_08280 CPlayerSkillBundle::Lookup: logic confirmed by peer review (already on main)

Peer-reviewed-by: KWDev, SapitoSucio, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 09:37:06 +00:00
ragnarok-clanker
cfea5b10f4 Decompile 7 functions in Source/Contents/Skills/PlayerSkillBundle.cpp
Batch #12008 by Yommy: 0 byte-identical, 7 confirmed by peer review.

- fn_08272 CPlayerSkillBundle::Remove: logic confirmed by peer review
- fn_08281 CPlayerSkillBundle::FindIndexed: logic confirmed by peer review (already on main)
- fn_08280 CPlayerSkillBundle::Lookup: logic confirmed by peer review
- fn_08277 CPlayerSkillBundle::FindExtra: logic confirmed by peer review
- fn_08278 CPlayerSkillBundle::NumberExtra: logic confirmed by peer review
- fn_08270 CPlayerSkillBundle::RecordLevelChange: logic confirmed by peer review
- fn_08295 CPlayerSkillBundle::ApplyLevelChange: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 08:21:00 +00:00
ragnarok-clanker
b8f652c74b Decompile 4 functions in Source/Contents/Skills/PlayerSkillBundle.cpp
Batch #11926 by Yommy: 2 byte-identical, 2 confirmed by peer review.

- fn_08309 CPlayerSkillBundle::Add: logic confirmed by peer review
- fn_08279 CPlayerSkillBundle::Find: logic confirmed by peer review
- fn_08282 CPlayerSkillBundle::Pending: byte-identical
- fn_08286 CPlayerSkillBundle::ResetFirstLevelChange: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 05:31:57 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
9b04a3cae5 Maintenance: [forced, user-approved] Family G18: remove the Skills bundle family (ClientSkills, SkillUseLevels, SkillWindows, Compani
Batch #10230 by ragnarok-clanker: forced by an admin (9 lower score(s), 42 changed function(s)); checked with 339 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/UIBasicCtrl.h, Source/Network/Packets/SkillUpdatePacket.h.
Deletes: Source/Network/Packets/SkillUpdatePacket.h
2026-11-03 09:49:00 +00:00
ragnarok-clanker
a13f7d9125 Decompile fn_08285 (IsIndexedSkill)
Batch #1690 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_08285 IsIndexedSkill: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:21:09 +00:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
Renamed from Source/Contents/PlayerSkillBundle.cpp (Browse further)