Commit graph

28 commits

Author SHA1 Message Date
ragnarok-clanker
c932ad6499 Maintenance: Resubmission of 15134 without the 12 struct/type renames (their new names changed mangled symbols in 17 functions). Rena
Batch #15141 by ragnarok-clanker: no function's compiled code changes; checked with 537 compiled unit(s), including every includer of Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/EnchantMgr.h, Source/Contents/GuildInfo.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TableMng.h, Source/Contents/World/SkyBox.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl.
2026-11-09 12:21:09 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
0b479d380c Decompile 4 functions in Source/Contents/NavigationSource.cpp
Batch #13075 by cremane: 1 byte-identical, 3 confirmed by peer review.

- fn_19567 CNavigationManager::ReadTargetObject: logic confirmed by peer review
- fn_19569 CNavigationManager::WriteObject: logic confirmed by peer review
- fn_19578 CNavigationManager::GetMobInfo: logic confirmed by peer review
- fn_19579 CNavigationManager::FindNodePath: byte-identical

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 04:57:33 +00:00
ragnarok-clanker
98608626b9 Decompile 2 functions in Source/Contents/NavigationSource.cpp
Batch #12355 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review
- fn_19574 CNavigationManager::ClearRouteNodes: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 15:19:23 +00:00
ragnarok-clanker
be25f25660 Decompile 2 functions in Source/Contents/NavigationSource.cpp
Batch #12388 by cremane: 1 byte-identical, 1 confirmed by peer review.

- fn_19429 CNaviInfo::~CNaviInfo: byte-identical
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:35:34 +00:00
ragnarok-clanker
a7f4379ce6 Confirm 2 functions in Source/Contents/NavigationSource.cpp
Batch #10770 by dori: 0 byte-identical, 2 confirmed by peer review.

- fn_19562 CNavigationManager::AddState: logic confirmed by peer review (already on main)
- fn_19568 CNavigationManager::WriteTarget: logic confirmed by peer review (already on main)

Peer-reviewed-by: Tanke, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:17:11 +00:00
ragnarok-clanker
5903e7603e Maintenance: Fold alias global gl_24769 g_navigationWindow (0x14a67f4) into its evidenced owner member g_windowMgr.window_4F174. 0x14
Batch #10400 by ragnarok-clanker: no function's compiled code changes; checked with 13 compiled unit(s), including every includer of Source/UI/Window/UINavigationWnd.h.
2026-11-03 21:51:45 +00:00
ragnarok-clanker
7bf787c1ed Decompile fn_03544 (NavigationTarget::~NavigationTarget)
Batch #9516 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_03544 NavigationTarget::~NavigationTarget: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: secret, dori, seumadruga
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 14:52:37 +00:00
ragnarok-clanker
65b02eb4c2 Decompile 3 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #8551 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_19626 CNavigationManager::BuildNodePaths: logic confirmed by peer review
- fn_19627 CNavigationManager::BuildSingleNodePaths: logic confirmed by peer review
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review

Peer-reviewed-by: Yommy, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 18:58:00 +00:00
ragnarok-clanker
1422899c9e Decompile 3 functions in Source/Contents/NavigationRoute.cpp, Source/Contents/NavigationSource.cpp, ...
Batch #7526 by secret: 0 byte-identical, 3 confirmed by peer review.

- fn_19616 CNavigationManager::LoadReplayState: logic confirmed by peer review
- fn_19617 CNavigationManager::ResumeRoute: logic confirmed by peer review
- fn_19573 CNavigationManager::RouteFromPlayer: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:21:05 +00:00
ragnarok-clanker
bdcc7352e2 Decompile fn_19602 (CNavigationManager::Navigate)
Batch #7557 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_19602 CNavigationManager::Navigate: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:20:32 +00:00
ragnarok-clanker
50b431a92b Decompile fn_19570 (CNavigationManager::CheckArrival)
Batch #7464 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19570 CNavigationManager::CheckArrival: logic confirmed by peer review

Peer-reviewed-by: secret, meitogi, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 09:56:31 +00:00
ragnarok-clanker
b13ac6ac22 Decompile fn_19595 (CNavigationManager::ResetCurrentTarget)
Batch #7311 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19595 CNavigationManager::ResetCurrentTarget: logic confirmed by peer review

Peer-reviewed-by: meitogi, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:31:51 +00:00
ragnarok-clanker
c2ee33405d Decompile 2 functions in Source/Contents/NavigationSource.cpp
Batch #5110 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_19567 CNavigationManager::ReadTargetObject: logic confirmed by peer review
- fn_19578 CNavigationManager::GetMobInfo: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, Bruwuno, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 08:16:24 +00:00
ragnarok-clanker
dc275e1b3a Decompile fn_19565 (CNavigationManager::ReadTarget)
Batch #4946 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_19565 CNavigationManager::ReadTarget: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:26:00 +00:00
ragnarok-clanker
981e82647d Decompile fn_19363 (NaviDataEntry::NaviDataEntry)
Batch #4780 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_19363 NaviDataEntry::NaviDataEntry: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 04:56:04 +00:00
ragnarok-clanker
dfe4c2ff24 Decompile 6 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #4560 by eAthena: 3 byte-identical, 3 confirmed by peer review.

- fn_19582 CNavigationManager::GetRouteResult: byte-identical
- fn_19583 CNavigationManager::GetState: logic confirmed by peer review
- fn_19584 CNavigationManager::StateMapName: logic confirmed by peer review
- fn_19585 CNavigationManager::GetRouteFlag: byte-identical
- fn_19586 CNavigationManager::GetSelectedNode: byte-identical
- fn_19587 CNavigationManager::GetNode: logic confirmed by peer review

Peer-reviewed-by: willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 03:47:54 +00:00
ragnarok-clanker
840c168e23 Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #2076 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19554 NavigationTarget::NavigationTarget: logic confirmed by peer review
- fn_19566 CNavigationManager::ReadObject: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 09:56:08 +00:00
ragnarok-clanker
bdd504eb67 Decompile fn_19370 (NaviDataEntry::Reset)
Batch #2060 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_19370 NaviDataEntry::Reset: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 03:02:55 +00:00
ragnarok-clanker
fcc5fcbcaf Decompile fn_19552 (NaviRouteLine::NaviRouteLine)
Batch #1934 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19552 NaviRouteLine::NaviRouteLine: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:59:40 +00:00
ragnarok-clanker
d0614a545c Decompile 10 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #1751 by Yommy: 0 byte-identical, 10 confirmed by peer review.

- fn_19558 NaviRouteLine::~NaviRouteLine: logic confirmed by peer review
- fn_19562 CNavigationManager::AddState: logic confirmed by peer review
- fn_19563 CNavigationManager::ParseFlags: logic confirmed by peer review
- fn_19564 CNavigationManager::ParseCell: logic confirmed by peer review
- fn_19568 CNavigationManager::WriteTarget: logic confirmed by peer review
- fn_19569 CNavigationManager::WriteObject: logic confirmed by peer review
- fn_19571 CNavigationManager::ClearSavedTarget: logic confirmed by peer review
- fn_19576 CNavigationManager::ClearStates: logic confirmed by peer review
- fn_19579 CNavigationManager::FindNodePath: logic confirmed by peer review
- fn_19580 CNavigationManager::SelectNodePath: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:02:26 +00:00
ragnarok-clanker
e38b027ea1 Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #1754 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_19572 CNavigationManager::ClearCurrentObject: byte-identical
- fn_19577 CNavigationManager::ClearNodes: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:01:45 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
2026-10-28 18:48:31 +00:00
ragnarok-clanker
4c1960b206 Decompile 14 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ...
Batch #1540 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_19436 CNavi_Link::`scalar deleting destructor': logic confirmed by peer review
- fn_19483 CNavi_Link::GetCell: logic confirmed by peer review
- fn_19497 CNavi_Link::GetInfo: logic confirmed by peer review
- fn_19387 CNaviData::SetDestination: logic confirmed by peer review
- fn_19638 CNavigationManager::UpdateGround: logic confirmed by peer review
- fn_19364 CNaviData::CNaviData: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review
- fn_19429 CNaviInfo::~CNaviInfo: logic confirmed by peer review
- fn_19551 CNavigationManager::CNavigationManager: logic confirmed by peer review
- fn_19574 CNavigationManager::ClearRouteNodes: logic confirmed by peer review
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review
- fn_19593 CNavigationManager::Reset: logic confirmed by peer review
- fn_45448 CNavigationManager::~CNavigationManager: logic confirmed by peer review
- fn_45452 CNavigationManager::GetLinkedPlayerInfo: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 17:40:11 +00:00
ragnarok-clanker
dfadb24ce5 Decompile 5 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ...
Batch #1541 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_19473 CNavi_Link::GetTitle: byte-identical
- fn_19475 CNavi_Link::GetName: byte-identical
- fn_19487 CNavi_Link::GetIndex: byte-identical
- fn_19492 CNavi_Link::GetType: byte-identical
- fn_19494 CNavi_Link::GetId: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/NavigationLink.cpp
2026-10-28 17:38:51 +00:00
ragnarok-clanker
3c5e940a6d Decompile 31 functions in Source/Contents/NavigationManager.h, Source/Contents/NavigationRequest.cpp, ...
Batch #1503 by ragnarok-clanker: 12 byte-identical, 19 confirmed by peer review.

- fn_19461 CNavi_Object::GetFlag: logic confirmed by peer review
- fn_19474 CNavi_Object::GetTitle: byte-identical
- fn_19476 CNaviInfo::GetTitle: byte-identical
- fn_19477 CNavi_Object::GetName: byte-identical
- fn_19484 CNavi_Object::GetCell: logic confirmed by peer review
- fn_19485 CNaviInfo::GetName: byte-identical
- fn_19488 CNavi_Object::GetIndex: byte-identical
- fn_19493 CNavi_Object::GetType: byte-identical
- fn_19495 CNavi_Object::GetId: byte-identical
- fn_19498 CNavi_Object::GetInfo: byte-identical
- fn_19376 CNavigationManager::FindObject: logic confirmed by peer review
- fn_19378 CNaviData::GetCell: logic confirmed by peer review
- fn_19380 CNaviData::GetInfo: byte-identical
- fn_19430 CNavi_Object::~CNavi_Object: logic confirmed by peer review
- fn_19434 CNaviInfo::HasName: logic confirmed by peer review
- fn_19604 CNavigationManager::SelectedNodeText: logic confirmed by peer review
- fn_19605 CNavigationManager::SubDestinationText: logic confirmed by peer review
- fn_19606 CNavigationManager::DestinationText: logic confirmed by peer review
- fn_19607 CNavigationManager::DestinationTitle: logic confirmed by peer review
- fn_19613 CNavigationManager::LoadSettings: logic confirmed by peer review
- fn_19618 CNavigationManager::FitToSquare: logic confirmed by peer review
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19588 CNavigationManager::GetCurrentTarget: logic confirmed by peer review
- fn_19589 CNavigationManager::GetCurrentTargetName: logic confirmed by peer review
- fn_19590 CNavigationManager::GetSavedTarget: logic confirmed by peer review
- fn_19591 CNavigationManager::GetDestinationInfo: byte-identical
- fn_19592 CNavigationManager::GetDestinationCell: logic confirmed by peer review
- fn_19594 CNavigationManager::ClearData: logic confirmed by peer review
- fn_19596 CNavigationManager::IsCurrentTarget: logic confirmed by peer review
- fn_19597 CNavigationManager::GetCurrentTargetType: byte-identical
- fn_19635 CNavigationManager::SaveCurrentTarget: byte-identical

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/NavigationRequest.cpp
2026-10-28 17:20:17 +00:00
ragnarok-clanker
2c4164fc4d Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #1394 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_19588 NavigationManager::GetCurrentTarget: logic confirmed by peer review
- fn_19590 NavigationManager::GetSavedTarget: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:16:00 +00:00
ragnarok-clanker
9d3e6d1668 Decompile 2 functions in Source/Contents/NavigationSource.cpp, Source/Contents/NavigationManager.h
Batch #1395 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_19597 NavigationManager::GetCurrentTargetType: byte-identical
- fn_19635 NavigationManager::SaveCurrentTarget: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/NavigationSource.cpp
2026-10-28 12:13:49 +00:00