Batch #10811 by Tanke: 2 byte-identical, 0 confirmed by peer review.
- fn_45514 CloseWindow10005A: byte-identical
- fn_45513 CloseWindow10005B: byte-identical
Peer-reviewed-by: Yommy, KWDev, dori, StrawberrysherbetIX
Merged automatically: every function is byte-identical to the original.
Batch #11372 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_12587 UINavigationWnd::ClearHistory: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11273 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_12638 UIEscOptionWnd::Slot15: logic confirmed by peer review
- fn_12744 UIEscOptionWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Yommy, kyoshi, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11319 by cremane: 2 byte-identical, 4 confirmed by peer review.
- fn_14504 CUIResizer::Slot25: logic confirmed by peer review
- fn_14505 CUIResizer::Slot31: logic confirmed by peer review
- fn_14506 CUIResizer::Slot27: logic confirmed by peer review
- fn_14507 CUIResizer::ResetCursor: byte-identical
- fn_14633 CUIButton::ResetCursor: logic confirmed by peer review
- fn_14714 CUIThumb::ResetCursor: byte-identical
Peer-reviewed-by: kyoshi, SapitoSucio, StrawberrysherbetIX, Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11033 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_10879 UIResizer::ResetCursor: logic confirmed by peer review
Peer-reviewed-by: Yommy, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10924 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_10087 UIRoulletteWnd::Paint: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11271 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_09624 UIHairStyleButton::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10972 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_12758 UISelCharForUServerWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10787 by StrawberrysherbetIX: 0 byte-identical, 4 confirmed by peer review.
- fn_17099 UIWindowMgr::~UIWindowMgr: logic confirmed by peer review (already on main)
- fn_17220 UIWindowMgr::ProcessHotkeyAction: logic confirmed by peer review (already on main)
- fn_17225 UIWindowMgr::CycleWindowVisibility: logic confirmed by peer review (already on main)
- fn_17253 UIWindowMgr::SendNotice: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10964 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_16943 DrawFilledRoundedBorder: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11246 by cremane: 1 byte-identical, 1 confirmed by peer review.
- fn_12627 CFlyingShipRouteInfo::IsRouteMap: byte-identical
- fn_12623 CFlyingShipRouteInfo::UpdateRoute: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11238 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12652 UISelCharForUServerWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11228 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_13807 UINewSkillListWnd::VisibleSkill: logic confirmed by peer review (already on main)
- fn_13813 UINewSkillListWnd::IsSkillArea: logic confirmed by peer review (already on main)
Peer-reviewed-by: kyoshi, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11226 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_13807 UINewSkillListWnd::VisibleSkill: logic confirmed by peer review
- fn_13813 UINewSkillListWnd::IsSkillArea: logic confirmed by peer review
Peer-reviewed-by: kyoshi, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11206 by dori: 0 byte-identical, 5 confirmed by peer review.
- fn_11743 UIMakeCharWnd::Slot15: logic confirmed by peer review
- fn_11814 UIReplayRECControlWnd::SendMsg: logic confirmed by peer review
- fn_11815 UISelectReplayDataWnd::SendMsg: logic confirmed by peer review
- fn_11816 UISelectServerWnd::SendMsg: logic confirmed by peer review
- fn_11804 UILoginOTPWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11197 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_09598 UINewSelectCharWnd::sub_7D9310: logic confirmed by peer review (already on main)
Peer-reviewed-by: ragnarok-clanker, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
Batch #11170 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_17178 UIWindowMgr::LoadUIRectInfo: logic confirmed by peer review
Peer-reviewed-by: Tanke, Toshiro, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #11106 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_10917 UIEmblemWnd::SendMsg: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11094 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_11892 FrameTextHash::operator(): byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11099 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_14047 CUIControl::CanHitTest: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #11062 by StrawberrysherbetIX: 1 byte-identical, 0 confirmed by peer review.
- fn_17180 UIWindowMgr::BringToFront: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #11011 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_14408 CUIBasicButton::SetAutoWidth: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10921 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_11791 UIMessageBox::Slot19: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10813 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_12778 UIRoMapWnd::DrawKafraMarkers: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10798 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.
- fn_03557 UINavigationV4Wnd::DrawMapTexture: logic confirmed by peer review (already on main)
- fn_03586 UIListBox_NaviSearch::Paint: logic confirmed by peer review (already on main)
- fn_03588 UINavigationV4Wnd::Paint: logic confirmed by peer review (already on main)
- fn_03589 UINavigationroadiconWnd::Paint: logic confirmed by peer review (already on main)
- fn_03587 UINavigationRuideWnd::Paint: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10774 by kyoshi: 2 byte-identical, 0 confirmed by peer review.
- fn_09589 UIWindowMgr::HasModalWindow: byte-identical
- fn_17332 UIWindowMgr::IsHoverOnWindow01C8Button: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10735 by kyoshi: 1 byte-identical, 0 confirmed by peer review.
- fn_12622 UIRoMapWnd::ClearRecords: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10684 by kyoshi: 0 byte-identical, 2 confirmed by peer review.
- fn_16978 UIWindow::FitVerticalDisplayText: logic confirmed by peer review
- fn_16997 UIWindow::RemoveChild: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10691 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_17171 UIWindowMgr::HitTestWindows: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10685 by kyoshi: 3 byte-identical, 0 confirmed by peer review.
- fn_17226 UIWindowMgr::DeferDeletion: byte-identical
- fn_17130 UIWindowMgr::ForgetWindowReferences: byte-identical
- fn_16985 UIWindow::IsDescendantOf: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10634 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_17235 UIWindowMgr::DismissTransient: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10502 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_11768 UIMessageBox::Paint: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, vinnyamancio, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10534 by cremane: 4 byte-identical, 0 confirmed by peer review.
- fn_03622 UIListBox_NaviSearch::Resize: byte-identical (already on main)
- fn_16998 UIWindow::Resize: byte-identical
- fn_16927 UIWindow::ClearSurface: byte-identical
- fn_16929 UIWindow::SetSize: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10453 by Toshiro: 0 byte-identical, 1 confirmed by peer review.
- fn_17207 UIWindowMgr::sub_A978D0: logic confirmed by peer review
Peer-reviewed-by: secret, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10444 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_21595 CGameMode::sub_D08910: logic confirmed by peer review
Peer-reviewed-by: secret, willerthal, KWDev, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10442 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_22297 CLoginMode::Slot7: logic confirmed by peer review
Peer-reviewed-by: willerthal, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10434 by ragnarok-clanker: no function's compiled code changes; checked with 266 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Window/UISeekPartyWnd.h.
Batch #10430 by ragnarok-clanker: no function's compiled code changes; checked with 530 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/RenderObject.h, Source/Contents/ClientState.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Messenger/MessengerMember.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/UIBartermarketWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindowMgr.h.
Batch #10425 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12939 UIBalloonOpenBtn::SendMsg: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, cremane, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10414 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10403 by ragnarok-clanker: no function's compiled code changes; checked with 508 compiled unit(s), including every includer of Source/UI/Window/UIWindowMgr.h.
Batch #10400 by ragnarok-clanker: no function's compiled code changes; checked with 13 compiled unit(s), including every includer of Source/UI/Window/UINavigationWnd.h.
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10391 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10377 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_17221 UIWindowMgr::sub_AA35F0: logic confirmed by peer review
- fn_12582 UINewChatWnd::ToggleInput: logic confirmed by peer review (already on main)
Peer-reviewed-by: gordaoprogramas, Toshiro, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10388 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_17216 ToggleGameSettingsTab4: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, Toshiro, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10367 by ragnarok-clanker: no function's compiled code changes; checked with 507 compiled unit(s), including every includer of Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/UIWindowMgr.h.
Batch #10366 by Lumen: 0 byte-identical, 1 confirmed by peer review.
- fn_11805 UILoginWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: youko, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
