Commit graph

59 commits

Author SHA1 Message Date
ragnarok-clanker
c932ad6499 Maintenance: Resubmission of 15134 without the 12 struct/type renames (their new names changed mangled symbols in 17 functions). Rena
Batch #15141 by ragnarok-clanker: no function's compiled code changes; checked with 537 compiled unit(s), including every includer of Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/EnchantMgr.h, Source/Contents/GuildInfo.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TableMng.h, Source/Contents/World/SkyBox.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl.
2026-11-09 12:21:09 +00:00
ragnarok-clanker
b5fbeb58a5 Decompile 2 functions in Source/Client/Application/Launcher.cpp, Source/Utility/EncryptedName.h, ...
Batch #15040 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_24371 ReplaceClientExecutable: byte-identical
- fn_24363 RestartFromCommandLine: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-09 07:31:20 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
953a3946d1 Maintenance: Remove 3 more aliased globals inside g_session (0x01732638) and use the real fields. g_whisperRecord gl_25102 (0x01737B8
Batch #14883 by ragnarok-clanker: no function's compiled code changes; checked with 204 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/UI/GameSettings/GameSettingsUI.h.
2026-11-07 22:49:54 +00:00
ragnarok-clanker
982f440936 Maintenance: Remove aliased globals that live inside g_session in the original and use the real fields (each alias address == g_sessi
Batch #14882 by ragnarok-clanker: forced by an admin (1 lower score(s), 1 changed function(s)); checked with 523 compiled unit(s), including every includer of Source/Client/Application/Launcher.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UIWindowMgr.h.
2026-11-07 22:33:39 +00:00
ragnarok-clanker
5b61e6f90c Decompile fn_04703 (InitUnhandledExceptionHandler)
Batch #14611 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_04703 InitUnhandledExceptionHandler: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, secret, codeplay, raiken
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 18:11:11 +00:00
ragnarok-clanker
a7ef5eb92a Decompile fn_24380 (COMDAT)
Batch #14244 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_24380 COMDAT: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 18:00:42 +00:00
ragnarok-clanker
d5651c2c18 Decompile fn_45411 (CreateApplicationWindow)
Batch #14674 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_45411 CreateApplicationWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 17:38:13 +00:00
ragnarok-clanker
52113818f9 Maintenance: Behaviour fix in ReadConnectionInfo (fn_45390, sub_3DE8027): clientinfo GM list tags were inverted. The original reads o
Batch #14703 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 1 compiled unit(s).
2026-11-07 14:59:02 +00:00
ragnarok-clanker
ff3d9792bb Decompile fn_24380 (COMDAT)
Batch #13931 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_24380 COMDAT: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 01:14:13 +00:00
ragnarok-clanker
90e0ca7360 Decompile fn_24370 (InitializeManagers)
Batch #13605 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24370 InitializeManagers: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 20:38:29 +00:00
ragnarok-clanker
087a98ab81 Decompile fn_07779 (CTokenizer::operator[])
Batch #13554 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_07779 CTokenizer::operator[]: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 20:08:08 +00:00
ragnarok-clanker
1a87e6eeaf Decompile fn_17827 (ShowErrorDialog)
Batch #13416 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_17827 ShowErrorDialog: logic confirmed by peer review

Peer-reviewed-by: eAthena, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 19:54:04 +00:00
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
3b17e798a4 Maintenance: New unit Source/Client/Application/ClientInfo.cpp: the clientinfo.xml start-up loader that the target binary runs from W
Batch #13345 by ragnarok-clanker: forced by an admin (0 lower score(s), 13 changed function(s)); checked with 96 compiled unit(s), including every includer of Source/Client/Application/ClientInfo.h, Source/Contents/Configuration/ServiceConfiguration.h.
Adds to the build: Source/Client/Application/ClientInfo.cpp
2026-11-06 13:44:06 +00:00
ragnarok-clanker
fec919b88e Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
0e2e431e10 Decompile fn_04704 (CleanupUnhandledExceptionHandler)
Batch #13096 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_04704 CleanupUnhandledExceptionHandler: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 05:08:55 +00:00
ragnarok-clanker
cae23e43db Decompile fn_24358 (ShutdownManagers)
Batch #12918 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_24358 ShutdownManagers: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 03:06:40 +00:00
ragnarok-clanker
67e6de9604 Decompile 2 functions in Source/Client/Application/Launcher.cpp
Batch #12908 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_24362 sub_E58100: logic confirmed by peer review
- fn_24371 ReplaceClientExecutable: logic confirmed by peer review

Peer-reviewed-by: aDw, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 03:01:07 +00:00
ragnarok-clanker
d8525e63e3 Decompile fn_24365 (ApplyAiPatch)
Batch #12906 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24365 ApplyAiPatch: logic confirmed by peer review

Peer-reviewed-by: aDw, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 03:00:44 +00:00
ragnarok-clanker
a6f761c4b3 Decompile 7 functions in Source/Client/Application/Launcher.cpp
Batch #12588 by Yommy: 7 byte-identical, 0 confirmed by peer review.

- fn_24336 CreateToolhelp32SnapshotName::operator(): byte-identical
- fn_24338 AdventurerAgencyCreateInstanceName::operator(): byte-identical
- fn_24339 RequestJoinPartyCreateInstanceName::operator(): byte-identical
- fn_24340 AdventureGuideCreateInstanceName::operator(): byte-identical
- fn_24343 EnumProcessModulesName::operator(): byte-identical
- fn_24345 GetModuleBaseNameAName::operator(): byte-identical
- fn_24363 RestartFromCommandLine: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 22:18:59 +00:00
ragnarok-clanker
2048a5eb46 Decompile fn_24363 (RestartFromCommandLine)
Batch #11417 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_24363 RestartFromCommandLine: logic confirmed by peer review

Peer-reviewed-by: Yommy, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 00:10:45 +00:00
ragnarok-clanker
ef04ed513a Decompile 3 functions in Source/Client/Application/UnhandledExceptionHandler.cpp
Batch #11096 by cremane: 1 byte-identical, 2 confirmed by peer review.

- fn_04703 InitUnhandledExceptionHandler: logic confirmed by peer review
- fn_04705 DialogFunc: byte-identical
- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review

Peer-reviewed-by: Yommy, kyoshi, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 23:24:51 +00:00
ragnarok-clanker
07897c8bea Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
e20b198c62 Decompile fn_04731 (CMouse::Message)
Batch #10993 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_04731 CMouse::Message: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 18:41:54 +00:00
ragnarok-clanker
68c8d0dc48 Decompile 4 functions in Source/Render/DX9/BackBufferDX9.cpp, Source/Render/DX9/RendererDX9.cpp, ...
Batch #10843 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_45506 DeviceOwnerDX9::CaptureBackBuffer: byte-identical (annotation added to existing code)
- fn_45507 DeviceOwnerDX9::RestoreBackBuffer: byte-identical (annotation added to existing code)
- fn_45508 ReleaseApplicationCursor: logic confirmed by peer review
- fn_06367 ApplyServiceOptionCursorClip: logic confirmed by peer review

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 18:23:10 +00:00
ragnarok-clanker
6a2a80e18e Maintenance: Resubmission of the alias fold (10419 returned: it changed compiled code of fn_24380, fn_09591, fn_12755). The 7 aliases
Batch #10430 by ragnarok-clanker: no function's compiled code changes; checked with 530 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/RenderObject.h, Source/Contents/ClientState.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Messenger/MessengerMember.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/UIBartermarketWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindowMgr.h.
2026-11-03 23:00:04 +00:00
ragnarok-clanker
ff96272c89 Decompile fn_24372 (sub_E5C430)
Batch #10323 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_24372 sub_E5C430: logic confirmed by peer review

Peer-reviewed-by: tester, System4z, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-03 19:54:20 +00:00
ragnarok-clanker
7773c2fd73 Maintenance: [forced, user-approved] Family V2: remove the invented view structs SessionItemLists and SessionMessengerContext. Both w
Batch #10278 by ragnarok-clanker: forced by an admin (0 lower score(s), 68 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
2026-11-03 15:58:10 +00:00
ragnarok-clanker
39e062645b Maintenance: [forced, user-approved] Family S4: type CSession+0x7FB4 as AutomaticSkills m_automaticSkills (was unsigned char unknown_
Batch #10275 by ragnarok-clanker: forced by an admin (1 lower score(s), 1 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
2026-11-03 15:21:49 +00:00
ragnarok-clanker
8a04248e21 Maintenance: [forced, user-approved] Family G22: remove StoreBackupData, ItemTagRetirement/ItemTagRemoval, SoundMgrContext, JobInheri
Batch #10242 by ragnarok-clanker: forced by an admin (7 lower score(s), 33 changed function(s)); checked with 260 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Jobs/JobInheritance.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/Store/MCStoreInfoBackup.h, Source/UI/Edit/ItemTagRetirement.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/Contents/Configuration/OptionWriter.h, Source/Contents/Store/StoreBackupData.h.
Deletes: Source/Contents/Configuration/OptionWriter.h, Source/Contents/Store/StoreBackupData.h
2026-11-03 11:44:08 +00:00
ragnarok-clanker
e757db50e0 Maintenance: [forced, user-approved] Family G15: remove ScriptOptions (reference view over g_session.m_hotkeyScript) and the unused G
Batch #10221 by ragnarok-clanker: forced by an admin (3 lower score(s), 7 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Configuration/GraphicsConfiguration.h.
Deletes: Source/Contents/Configuration/GraphicsConfiguration.h
2026-11-03 00:44:20 +00:00
ragnarok-clanker
bf37a5bd1f Maintenance: [forced, user-approved] CLanguage step 1 (resubmit of #10178): g_serverLanguage (0x16D3B0C) points to CLanguage with a 1
Batch #10179 by ragnarok-clanker: forced by an admin (0 lower score(s), 2 changed function(s)); checked with 55 compiled unit(s), including every includer of Source/Client/Input/InputCharset.h, Source/Client/Input/LanguageTC.h.
2026-11-02 19:20:05 +00:00
ragnarok-clanker
d842cee831 Maintenance: [forced, user-approved] Collapse the Browser port's adapter structs into the original code (follow-up to 30cdd441). Evid
Batch #10110 by ragnarok-clanker: forced by an admin (0 lower score(s), 40 changed function(s)); checked with 495 compiled unit(s), including every includer of Source/Client/Application/ApplicationActivation.h, Source/Client/Application/Launcher.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Browser/WebBrowser.h, Source/Client/Browser/WebEventReceiver.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeTooltip.h, Source/UI/Window/UIWindowMgr.h, Source/Client/Browser/BrowserAddressBar.h, Source/Client/Browser/BrowserAddressEdit.h, Source/Client/Browser/BrowserClose.h, Source/Client/Browser/BrowserCreation.h, Source/Client/Browser/BrowserCursor.h, Source/Client/Browser/BrowserFactory.h, Source/Client/Browser/BrowserFrame.h, Source/Client/Browser/BrowserHostWindow.h, Source/Client/Browser/BrowserInputHandoff.h, Source/Client/Browser/BrowserInterface.h, Source/Client/Browser/BrowserMessages.h, Source/Client/Browser/BrowserRegistry.h, Source/Client/Browser/BrowserSiteAttachment.h, Source/Client/Browser/BrowserWindowSizing.h, Source/UI/Window/WindowFrameUpdate.h.
Deletes: Source/Client/Browser/BrowserAddressBar.h, Source/Client/Browser/BrowserAddressEdit.h, Source/Client/Browser/BrowserClose.h, Source/Client/Browser/BrowserCreation.h, Source/Client/Browser/BrowserCursor.h, Source/Client/Browser/BrowserFactory.h, Source/Client/Browser/BrowserFrame.h, Source/Client/Browser/BrowserHostWindow.h, Source/Client/Browser/BrowserInputHandoff.h, Source/Client/Browser/BrowserInterface.h, Source/Client/Browser/BrowserMessages.h, Source/Client/Browser/BrowserRegistry.h, Source/Client/Browser/BrowserSiteAttachment.h, Source/Client/Browser/BrowserWindowSizing.h, Source/UI/Window/WindowFrameUpdate.h
2026-11-02 16:41:37 +00:00
ragnarok-clanker
30cdd441a1 Maintenance: [forced, admin decision] Resubmission of returned batch 10026 rebased on c246e79d: also renames the CMode+0x10 write in
Batch #10033 by ragnarok-clanker: forced by an admin (0 lower score(s), 6 changed function(s)); checked with 479 compiled unit(s), including every includer of Source/Client/Application/ApplicationMessages.h, Source/Client/Application/Launcher.h, Source/Client/Mode/CMode.h, Source/Client/ModeFade.h, Source/UI/Window/UIWindowMgr.h.
2026-11-02 14:34:46 +00:00
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
e0b9084805 Decompile fn_24362 (sub_E58100)
Batch #9993 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_24362 sub_E58100: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, cremane
Reviewed-by: ragnarok-clanker
2026-11-02 13:50:16 +00:00
ragnarok-clanker
7524af1cc2 Decompile fn_24380 (COMDAT)
Batch #9612 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.

- fn_24380 COMDAT: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, secret, tayoba, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 17:11:39 +00:00
ragnarok-clanker
7a7f70953a Maintenance: Make CStoveMgr a real polymorphic class instead of a void* vtable field set to 0x0110C63C: CStoveMgr derives from Single
Batch #9473 by ragnarok-clanker: forced by an admin (1 lower score(s), 2 changed function(s)); checked with 4 compiled unit(s), including every includer of Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h.
2026-11-01 14:17:34 +00:00
ragnarok-clanker
48a5e62a7c Decompile fn_24358 (ShutdownManagers)
Batch #9112 by Bielhp: 0 byte-identical, 1 confirmed by peer review.

- fn_24358 ShutdownManagers: logic confirmed by peer review

Peer-reviewed-by: youko, vinnyamancio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 03:04:23 +00:00
ragnarok-clanker
af01a4fcd4 Decompile fn_24371 (ReplaceClientExecutable)
Batch #8061 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24371 ReplaceClientExecutable: logic confirmed by peer review

Peer-reviewed-by: eAthena, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 13:52:51 +00:00
ragnarok-clanker
fa26ae4cf5 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.h, ...
Batch #6406 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23793 CSession::GetPetTargetAid: logic confirmed by peer review
- fn_24365 ApplyAiPatch: logic confirmed by peer review
- fn_21743 CGameMode::ReceiveEquipWindowMicroscope: logic confirmed by peer review
- fn_21919 UIItemStoreWnd::SetTitle: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeEquipWindow.cpp, Source/UI/Item/UIItemStoreWnd.cpp
2026-10-31 00:51:56 +00:00
ragnarok-clanker
1b49fa24e5 Decompile fn_24361 (StartClientProcess)
Batch #6337 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24361 StartClientProcess: logic confirmed by peer review

Peer-reviewed-by: alisonrag, KWDev, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 22:04:36 +00:00
ragnarok-clanker
eb60399755 Decompile 20 functions in Source/Client/Application/Launcher.cpp
Batch #3474 by youko: 20 byte-identical, 0 confirmed by peer review.

- fn_24310 EncryptedName<5,2636340703>::Text: byte-identical (annotation added to existing code)
- fn_24311 EncryptedName<19,3954909511>::Text: byte-identical (annotation added to existing code)
- fn_24312 EncryptedName<19,255010611>::Text: byte-identical (annotation added to existing code)
- fn_24313 EncryptedName<25,1829175591>::Text: byte-identical (annotation added to existing code)
- fn_24314 EncryptedName<37,2669800313>::Text: byte-identical (annotation added to existing code)
- fn_24315 EncryptedName<39,1771676419>::Text: byte-identical (annotation added to existing code)
- fn_24316 EncryptedName<40,-1578422415>::Text: byte-identical (annotation added to existing code)
- fn_24317 EncryptedName<11,-849934409>::Text: byte-identical (annotation added to existing code)
- fn_24318 EncryptedName<11,3617537441>::Text: byte-identical (annotation added to existing code)
- fn_24319 EncryptedName<11,2079562721>::Text: byte-identical (annotation added to existing code)
- fn_24320 EncryptedName<11,220694015>::Text: byte-identical (annotation added to existing code)
- fn_24321 EncryptedName<13,-178652815>::Text: byte-identical (annotation added to existing code)
- fn_24322 EncryptedName<13,1095357917>::Text: byte-identical (annotation added to existing code)
- fn_24323 EncryptedName<13,2739266413>::Text: byte-identical (annotation added to existing code)
- fn_24324 EncryptedName<13,1642035979>::Text: byte-identical (annotation added to existing code)
- fn_24325 EncryptedName<14,-3536493715>::Text: byte-identical (annotation added to existing code)
- fn_24326 EncryptedName<14,3686137173>::Text: byte-identical (annotation added to existing code)
- fn_24327 EncryptedName<14,2500022231>::Text: byte-identical (annotation added to existing code)
- fn_24328 EncryptedName<15,-2696435447>::Text: byte-identical (annotation added to existing code)
- fn_24329 EncryptedName<15,3888984351>::Text: byte-identical (annotation added to existing code)

Merged automatically: every function is byte-identical to the original.
2026-10-29 22:37:59 +00:00
ragnarok-clanker
ac82f3e6da Decompile 26 functions in Source/Archive/GPak.cpp, Source/Archive/GPakUpdate.h, ...
Batch #3333 by youko: 0 byte-identical, 26 confirmed by peer review.

- fn_24308 myGPack::CGPakUpdate::`scalar deleting destructor': logic confirmed by peer review (annotation added to existing code)
- fn_24309 myGPack::CNotifier::~CNotifier: logic confirmed by peer review (annotation added to existing code)
- fn_24331 AdtestexeProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24332 RagexeMProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24333 SakexeMProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24334 Kernel32LibraryName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24335 PsapiLibraryName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24336 CreateToolhelp32SnapshotName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24337 EnumProcessesName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24338 AdventurerAgencyCreateInstanceName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24339 RequestJoinPartyCreateInstanceName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24340 AdventureGuideCreateInstanceName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24341 GoodResultName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24342 Process32FirstName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24343 EnumProcessModulesName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24344 Process32NextName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24345 GetModuleBaseNameAName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24346 RagexeModuleName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24347 RagexeProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24348 SakexeModuleName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24349 SakexeProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24350 RagexereModuleName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24351 RagexereProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24352 RagtestexeProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24353 SaktestexeProcessName::operator(): logic confirmed by peer review (annotation added to existing code)
- fn_24359 RemovePath: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, alisonrag, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:27:49 +00:00
ragnarok-clanker
f96efc54e0 Decompile fn_24330 (EncryptedName<15,2409437649>::Text)
Batch #3255 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_24330 EncryptedName<15,2409437649>::Text: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 21:05:39 +00:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
e67abcb458 Rename TextInputBuffer -> CLanguage, TraditionalKeyInput -> CLanguageTC (DHXJ); files -> Language.{h,cpp}, LanguageTC.{h,cpp}. Pure rename, codegen unchanged (382/382 functions identical with includers). 2026-10-29 12:21:53 +01:00