Commit graph

7 commits

Author SHA1 Message Date
ragnarok-clanker
dab70b8cd8 Maintenance: [forced, user-approved] Family G28: remove EmblemCache (inventory row 71). Its fields are CGuildMgr members (g_guildMgr
Batch #10253 by ragnarok-clanker: forced by an admin (2 lower score(s), 8 changed function(s)); checked with 24 compiled unit(s), including every includer of Source/Contents/GuildMgr.h, Source/Contents/Emblems/EmblemCache.h.
Deletes: Source/Contents/Emblems/EmblemCache.h
2026-11-03 12:45:41 +00:00
ragnarok-clanker
b538c3a695 Maintenance: Consolidate the guild state into its real owner. The original has one GuildInfo object at 0x16D4400 (static ctor 0x4A887
Batch #10011 by ragnarok-clanker: forced by an admin (8 lower score(s), 43 changed function(s)); checked with 137 compiled unit(s), including every includer of Source/Contents/Actors/RenderObject.h, Source/Contents/GuildInfo.h, Source/Contents/GuildMgr.h.
2026-11-02 13:42:03 +00:00
ragnarok-clanker
e111a16b63 Decompile fn_21307 (CGameMode::OpenActorMenu)
Batch #8359 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_21307 CGameMode::OpenActorMenu: logic confirmed by peer review

Peer-reviewed-by: eAthena, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:04:15 +00:00
ragnarok-clanker
532d1085a5 Decompile fn_23620 (CSession::StoreEmblem)
Batch #1967 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23620 CSession::StoreEmblem: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/EmblemCacheRaw.cpp
2026-10-29 09:01:23 +00:00
ragnarok-clanker
5056537cdf Decompile fn_05174 (CGuildMgr::GetEmblemFilename)
Batch #1892 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_05174 CGuildMgr::GetEmblemFilename: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/GuildEmblemLookup.cpp
2026-10-28 23:26:42 +00:00
ragnarok-clanker
a182e716f4 Decompile fn_05179 (CGuildMgr::UpdateEmblemRequests)
Batch #1561 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_05179 CGuildMgr::UpdateEmblemRequests: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 18:57:54 +00:00
ragnarok-clanker
7541fbec29 Decompile 6 functions in Source/Contents/GuildMgr.cpp, Source/Contents/GuildMgr.h, ...
Batch #889 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_05147 CGuild::CGuild: logic confirmed by peer review
- fn_05148 CGuild::~CGuild: logic confirmed by peer review
- fn_05172 CGuildMgr::Create: logic confirmed by peer review
- fn_05173 CGuildMgr::Destroy: logic confirmed by peer review
- fn_05175 CGuildMgr::GetEmblemVersion: logic confirmed by peer review
- fn_05181 CGuildMgr::SetEmblemVersion: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/GuildMgr.cpp, Source/Contents/GuildEmblemState.cpp
2026-10-26 21:46:02 +00:00