Commit graph

16 commits

Author SHA1 Message Date
ragnarok-clanker
52e798249c Decompile 4 functions in Source/Utility/JsonCppLoader.cpp
Batch #14910 by SapitoSucio: 0 byte-identical, 4 confirmed by peer review.

- fn_00886 JsonCppLoader::GetIntValue: logic confirmed by peer review
- fn_00887 JsonCppLoader::GetStringValue: logic confirmed by peer review
- fn_00891 JsonCppLoader::GetMapStringBoolValue: logic confirmed by peer review
- fn_00893 JsonCppLoader::GetBoolValue: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, raiken, Stingor
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-08 11:53:11 +00:00
ragnarok-clanker
ffbeee0f2a Maintenance: Forced maintainer submission (resubmission of 14678 after td sync to 8deac7a3; replaces 14460 and 14473). Native-run fix
Batch #14681 by ragnarok-clanker: forced by an admin (6 lower score(s), 70 changed function(s)); checked with 555 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObject.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/CartCannon.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Ground/GroundGeometry.h, Source/Network/Connection/Connection.h, Source/Resource/Audio/WaveResource.h, Source/Resource/Bitmap/BitmapResource.h, Source/Resource/EZeffectResource.h, Source/Resource/EmblemResource.h, Source/Resource/GifResource.h, Source/Resource/ImfResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelResource.h, Source/Resource/PaletteResource.h, Source/Resource/RmaResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/Sprites/SpriteResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/TerrainResource.h, Source/Resource/World/WorldResource.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UITextButton.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UINewSelectCharWnd.h.
2026-11-07 14:05:21 +00:00
ragnarok-clanker
fac804ac6d Decompile fn_00337 (JsonCppLoader::JsonCppLoader)
Batch #13914 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_00337 JsonCppLoader::JsonCppLoader: logic confirmed by peer review

Peer-reviewed-by: eAthena, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 04:09:16 +00:00
ragnarok-clanker
78400d137c Maintenance: Forced (maintainer policy, as 13484/13494: small score loss accepted for correct behaviour). JsonCppLoader had no constr
Batch #13820 by ragnarok-clanker: forced by an admin (2 lower score(s), 9 changed function(s)); checked with 6 compiled unit(s), including every includer of Source/Utility/JsonCppLoader.h.
2026-11-06 22:56:52 +00:00
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
1ba8ac9de3 Decompile fn_00486 (JsonCppLoader::sub_4F3C70)
Batch #12773 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_00486 JsonCppLoader::sub_4F3C70: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 00:42:23 +00:00
ragnarok-clanker
2fd7f99070 Decompile 4 functions in Source/Utility/JsonCppLoader.cpp
Batch #12197 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_00487 JsonCppLoader::sub_4F3CC0: logic confirmed by peer review
- fn_00488 JsonCppLoader::sub_4F3DF0: logic confirmed by peer review
- fn_00489 JsonCppLoader::sub_4F3ED0: logic confirmed by peer review
- fn_00490 JsonCppLoader::sub_4F4040: logic confirmed by peer review

Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:13:11 +00:00
ragnarok-clanker
e18477a710 Decompile fn_00891 (JsonCppLoader::GetMapStringBoolValue)
Batch #11523 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_00891 JsonCppLoader::GetMapStringBoolValue: logic confirmed by peer review

Peer-reviewed-by: KWDev, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:19:00 +00:00
ragnarok-clanker
46cd201493 Decompile 2 functions in Source/Utility/JsonCppLoader.cpp
Batch #9780 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_00487 JsonCppLoader::sub_4F3CC0: logic confirmed by peer review
- fn_00489 JsonCppLoader::sub_4F3ED0: logic confirmed by peer review

Peer-reviewed-by: KWDev, Romain, vinnyamancio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 23:26:58 +00:00
ragnarok-clanker
58acfea9a6 Decompile fn_00488 (JsonCppLoader::sub_4F3DF0)
Batch #9602 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_00488 JsonCppLoader::sub_4F3DF0: logic confirmed by peer review

Peer-reviewed-by: secret, gordaoprogramas, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 16:25:05 +00:00
ragnarok-clanker
dc3e6a4b86 Decompile fn_00490 (JsonCppLoader::sub_4F4040)
Batch #9601 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_00490 JsonCppLoader::sub_4F4040: logic confirmed by peer review

Peer-reviewed-by: secret, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 16:24:24 +00:00
ragnarok-clanker
acd76a3373 Decompile fn_00486 (JsonCppLoader::sub_4F3C70)
Batch #8381 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.

- fn_00486 JsonCppLoader::sub_4F3C70: logic confirmed by peer review

Peer-reviewed-by: eAthena, Romain, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 17:23:24 +00:00
ragnarok-clanker
2c60cb7cbd Decompile 2 functions in Source/Utility/JsonCppLoader.cpp, Source/Utility/JsonCppLoader.h
Batch #7612 by secret: 0 byte-identical, 2 confirmed by peer review.

- fn_00889 JsonCppLoader::GetMapStringStringValue: logic confirmed by peer review
- fn_00890 JsonCppLoader::GetMapStringIntVectorValue: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:52:49 +00:00
ragnarok-clanker
73454eaa71 Decompile 5 functions in Source/Utility/JsonCppLoader.cpp, Source/Utility/JsonCppLoader.h
Batch #7629 by secret: 0 byte-identical, 5 confirmed by peer review.

- fn_00886 JsonCppLoader::GetIntValue: logic confirmed by peer review
- fn_00887 JsonCppLoader::GetStringValue: logic confirmed by peer review
- fn_00888 JsonCppLoader::GetMapStringIntValue: logic confirmed by peer review
- fn_00892 JsonCppLoader::GetIntVectorValue: logic confirmed by peer review
- fn_00893 JsonCppLoader::GetBoolValue: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:51:43 +00:00
ragnarok-clanker
8c138913bf Decompile fn_00891 (JsonCppLoader::GetMapStringBoolValue)
Batch #6817 by superintelligence: 0 byte-identical, 1 confirmed by peer review.

- fn_00891 JsonCppLoader::GetMapStringBoolValue: logic confirmed by peer review

Peer-reviewed-by: alisonrag, KWDev, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:56:31 +00:00
ragnarok-clanker
1a932eeed3 Decompile fn_00491 (JsonCppLoader::Fail)
Batch #5769 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_00491 JsonCppLoader::Fail: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Utility/JsonCppLoader.cpp
2026-10-30 15:42:46 +00:00