Commit graph

9 commits

Author SHA1 Message Date
ragnarok-clanker
521b52384c Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
d7bed33373 Decompile fn_23737 (CSession::ToggleTrackedAchievement)
Batch #14024 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23737 CSession::ToggleTrackedAchievement: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:13:00 +00:00
ragnarok-clanker
43cfc2e5f2 Decompile fn_23737 (CSession::ToggleTrackedAchievement)
Batch #13157 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_23737 CSession::ToggleTrackedAchievement: logic confirmed by peer review

Peer-reviewed-by: Tanke, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 14:59:41 +00:00
ragnarok-clanker
5729896478 Decompile fn_23736 (CSession::AddUnknown6160)
Batch #12508 by unna: 0 byte-identical, 1 confirmed by peer review.

- fn_23736 CSession::AddUnknown6160: logic confirmed by peer review

Peer-reviewed-by: Yommy, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 20:11:23 +00:00
ragnarok-clanker
36814c4f61 Decompile fn_23735 (JobTitleLess::operator())
Batch #11308 by Toshiro: 0 byte-identical, 1 confirmed by peer review.

- fn_23735 JobTitleLess::operator(): logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 23:44:21 +00:00
ragnarok-clanker
bce88e1d9b Decompile fn_23737 (CSession::ToggleTrackedAchievement)
Batch #8247 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23737 CSession::ToggleTrackedAchievement: logic confirmed by peer review

Peer-reviewed-by: System4z, Toshiro, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 16:28:18 +00:00
ragnarok-clanker
0d154eea0b Decompile fn_23735 (JobTitleLess::operator())
Batch #7365 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.

- fn_23735 JobTitleLess::operator(): logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:45:25 +00:00
ragnarok-clanker
bbbf7a7d86 Decompile fn_23736 (CSession::AddUnknown6160)
Batch #6165 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23736 CSession::AddUnknown6160: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/SessionAchievements.cpp
2026-10-30 22:20:22 +00:00