ragnarok-clanker
854a0e32fb
Maintenance: Name numeric switch case labels with enum constants (identifier-only; no code change). 13,500+ case labels across 70 uni
...
Batch #14886 by ragnarok-clanker: no function's compiled code changes; checked with 225 compiled unit(s), including every includer of Source/Contents/Combat/CombatTypes.h, Source/Contents/Effects/EffectMessageId.h, Source/Contents/Items/InventoryType.h, Source/Contents/Items/ItemId.h, Source/Contents/Jobs/JobId.h, Source/Contents/MessageTable.h, Source/Contents/Skills/SkillId.h, Source/Contents/Skills/SkillUnitId.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/GameSettings/TalkType.h, Source/UI/Window/WindowId.h.
2026-11-07 23:58:37 +00:00
ragnarok-clanker
83d9e1274d
Decompile 5 functions in Source/Contents/Actors/Skill.cpp, Source/Contents/Actors/GroundScope.cpp, ...
...
Batch #7753 by Yommy: 0 byte-identical, 5 confirmed by peer review.
- fn_24252 CGraffiSkill::CGraffiSkill: logic confirmed by peer review
- fn_24253 CGroundScope::CGroundScope: logic confirmed by peer review
- fn_24254 CMandraAttackEffect::CMandraAttackEffect: logic confirmed by peer review
- fn_24255 CMsgEffect::CMsgEffect: logic confirmed by peer review
- fn_24256 CSkill::CSkill: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, eAthena, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 11:43:05 +00:00
ragnarok-clanker
c5802826d4
Decompile 11 functions in Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GraffiSkill.cpp, ...
...
Batch #5431 by Yommy: 1 byte-identical, 10 confirmed by peer review.
- fn_24290 CEffectMaker::Render: byte-identical
- fn_24291 CGraffiSkill::Render: logic confirmed by peer review
- fn_24292 CGroundScope::Render: logic confirmed by peer review
- fn_24293 CMsgEffect::Render: logic confirmed by peer review
- fn_24295 CArrowEffect::SendMsg: logic confirmed by peer review
- fn_24296 CDummyEffectLauncher::SendMsg: logic confirmed by peer review
- fn_24297 CEffectMaker::SendMsg: logic confirmed by peer review
- fn_24298 CGraffiSkill::SendMsg: logic confirmed by peer review
- fn_24299 CGroundScope::SendMsg: logic confirmed by peer review
- fn_24300 CMandraAttackEffect::SendMsg: logic confirmed by peer review
- fn_24301 CMsgEffect::SendMsg: logic confirmed by peer review
Peer-reviewed-by: ntrl, bigodeira, willerthal, Snow, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:56:17 +00:00
ragnarok-clanker
05be22bdcf
Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...
...
Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.
- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review
Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp
2026-10-30 06:43:59 +00:00
