Commit graph

58 commits

Author SHA1 Message Date
ragnarok-clanker
f14d528cb7 Decompile fn_07713 (UIMessengerGroupWnd::Slot25)
Batch #6094 by alisonrag: 0 byte-identical, 1 confirmed by peer review.

- fn_07713 UIMessengerGroupWnd::Slot25: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Lumen, superintelligence, kyoshi, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:46:34 +00:00
ragnarok-clanker
c98925aa4d Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #6053 by superintelligence: 0 byte-identical, 2 confirmed by peer review.

- fn_23832 FindGroupedSkill: logic confirmed by peer review
- fn_06287 GetSkillLevel: logic confirmed by peer review

Peer-reviewed-by: eAthena, Lumen, meitogi, willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:21:14 +00:00
ragnarok-clanker
e25efe0708 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #6043 by superintelligence: 0 byte-identical, 4 confirmed by peer review.

- fn_05621 EquipmentProperties::CEquipmentWearable::UpdateActive: logic confirmed by peer review
- fn_06206 EquipmentProperties::CEquipmentPropertiesMgr::RefreshShop: logic confirmed by peer review
- fn_23398 FindShop: logic confirmed by peer review
- fn_23485 FindShopId: logic confirmed by peer review

Peer-reviewed-by: eAthena, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:34:56 +00:00
ragnarok-clanker
017a85fd3e Decompile 2 functions in Source/UI/Party/UIMiniPartyWnd.cpp, Source/UI/Party/UIMiniPartyWnd.h, ...
Batch #6026 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_07732 UIMiniPartyInfoWnd::Slot31: logic confirmed by peer review
- fn_07734 UIMiniPartyInfoWnd::Slot33: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:34:32 +00:00
ragnarok-clanker
17b5315a58 Decompile fn_17262 (UIWindowMgr::RetireTransientWindow)
Batch #5862 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_17262 UIWindowMgr::RetireTransientWindow: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 16:54:27 +00:00
ragnarok-clanker
46872f095e Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Mode/CGameMode.h
Batch #5846 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_21271 CGameMode::GetClosestValidCell: logic confirmed by peer review
- fn_21295 CGameMode::IsValidCell: logic confirmed by peer review
- fn_06187 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0114: logic confirmed by peer review

Peer-reviewed-by: willerthal, SapitoSucio, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 16:45:14 +00:00
ragnarok-clanker
25321ae8a6 Decompile 4 functions in Source/Contents/Actors/GameActor.cpp, Source/Contents/Actors/GameActor.h, ...
Batch #5758 by Yommy: 1 byte-identical, 3 confirmed by peer review.

- fn_17210 CGameActor::HasUnknown0310Entry: byte-identical
- fn_17211 WindowDialogs::AddMessageBox: logic confirmed by peer review
- fn_17212 WindowDialogs::RunModal: logic confirmed by peer review
- fn_17213 UIWindowMgr::MoveTransient: logic confirmed by peer review

Peer-reviewed-by: willerthal, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 16:03:04 +00:00
ragnarok-clanker
4357dde4b3 Decompile 4 functions in Source/Contents/Messenger/MessengerMember.cpp, Source/UI/Party/UIMiniPartyWnd.h
Batch #5601 by Yommy: 0 byte-identical, 4 confirmed by peer review.

- fn_07719 UIMessengerGroupWnd::Slot11: logic confirmed by peer review
- fn_07726 UIMiniPartyInfoWnd::UIMiniPartyInfoWnd: logic confirmed by peer review
- fn_07728 UIMiniPartyWnd::GetMember: logic confirmed by peer review
- fn_07729 UIMiniPartyInfoWnd::Slot15: logic confirmed by peer review

Peer-reviewed-by: youko, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:46:42 +00:00
ragnarok-clanker
63b4c6652c Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h
Batch #5324 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_06284 GetPetRelationship: logic confirmed by peer review
- fn_06288 GetPlayerValue: logic confirmed by peer review

Peer-reviewed-by: meitogi, Millenium, Snow, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 11:38:40 +00:00
ragnarok-clanker
e4633483ee Decompile 2 functions in Source/Contents/Messenger/MessengerMember.cpp
Batch #5274 by meitogi: 0 byte-identical, 2 confirmed by peer review.

- fn_07697 MiniPartyInfoEntry::MiniPartyInfoEntry: logic confirmed by peer review
- fn_07710 UIMessengerGroupWnd::Slot31: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 10:09:58 +00:00
ragnarok-clanker
138838f24c Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #5095 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_06168 EquipmentProperties::CEquipmentPropertiesMgr::ApplyProperty: logic confirmed by peer review (annotation added to existing code)
- fn_06169 EquipmentProperties::CEquipmentPropertiesMgr::EquipItem: logic confirmed by peer review (annotation added to existing code)
- fn_06171 EquipmentProperties::CEquipmentPropertiesMgr::UnequipItem: logic confirmed by peer review (annotation added to existing code)
- fn_06182 EquipmentProperties::CEquipmentPropertiesMgr::GetDescriptions: logic confirmed by peer review (annotation added to existing code)
- fn_06277 GetEquipArmorLv: logic confirmed by peer review (annotation added to existing code)
- fn_06280 GetEquipWeaponLv: logic confirmed by peer review (annotation added to existing code)
- fn_06289 GetWeaponClass: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:29:45 +00:00
ragnarok-clanker
efb38781a2 Decompile 6 functions in Source/UI/Window/WindowAncestry.cpp, Source/UI/MiniPartyManager.cpp, ...
Batch #5179 by eAthena: 2 byte-identical, 4 confirmed by peer review.

- fn_16989 UIWindow::BroadcastMsg4: byte-identical
- fn_16990 UIWindow::BroadcastMsg3: byte-identical
- fn_16924 UIWindow::PropagateMsg: logic confirmed by peer review
- fn_17214 UIWindowMgr::ArrangeMiniPartyWindows: logic confirmed by peer review
- fn_17164 UIWindowMgr::FindItemWindow: logic confirmed by peer review
- fn_17230 UIWindowMgr::NotifyMemberWindows: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:23:29 +00:00
ragnarok-clanker
a92d988fa7 Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #5186 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_06185 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown01BC: logic confirmed by peer review (annotation added to existing code)
- fn_06200 EquipmentProperties::CEquipmentPropertiesMgr::AddExpansion: logic confirmed by peer review (annotation added to existing code)
- fn_06204 EquipmentProperties::CEquipmentPropertiesMgr::RefreshExpansion: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:16:18 +00:00
ragnarok-clanker
dfc9404c53 Decompile 17 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #5152 by youko: 0 byte-identical, 17 confirmed by peer review.

- fn_05620 EquipmentProperties::CEquipment::AddProperty: logic confirmed by peer review (annotation added to existing code)
- fn_05634 EquipmentProperties::CEquipmentAttachable::Load: logic confirmed by peer review (annotation added to existing code)
- fn_05635 EquipmentProperties::CEquipmentCombiitem::Load: logic confirmed by peer review (annotation added to existing code)
- fn_05636 EquipmentProperties::CEquipmentExpansion::Load: logic confirmed by peer review (annotation added to existing code)
- fn_05639 EquipmentProperties::CEquipmentCombiitem::Clear: logic confirmed by peer review (annotation added to existing code)
- fn_05640 EquipmentProperties::CEquipmentExpansion::Clear: logic confirmed by peer review (annotation added to existing code)
- fn_05641 EquipmentProperties::CEquipmentWearable::Clear: logic confirmed by peer review (annotation added to existing code)
- fn_05643 EquipmentProperties::CEquipment::NotifyProperties: logic confirmed by peer review (annotation added to existing code)
- fn_05769 EquipmentPropertyStore::operator+=: logic confirmed by peer review (annotation added to existing code)
- fn_05770 EquipmentPropertyStore::operator+=: logic confirmed by peer review (annotation added to existing code)
- fn_05782 EquipmentProperties::CEquipmentProperties::Describe: logic confirmed by peer review (annotation added to existing code)
- fn_05783 EquipmentPropertyStore::RemoveDuplicateNames: logic confirmed by peer review (annotation added to existing code)
- fn_06183 EquipmentProperties::CEquipmentPropertiesMgr::FindDefinition: logic confirmed by peer review (annotation added to existing code)
- fn_06202 EquipmentProperties::CEquipmentPropertiesMgr::RemoveExpansion: logic confirmed by peer review (annotation added to existing code)
- fn_06207 EquipmentProperties::CEquipmentPropertiesMgr::Rebuild: logic confirmed by peer review (annotation added to existing code)
- fn_06208 EquipmentProperties::CEquipmentPropertiesMgr::SetCurrentEquipment: logic confirmed by peer review (annotation added to existing code)
- fn_06211 EquipmentProperties::CEquipmentPropertiesMgr::RefreshPretend: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: Yommy, alisonrag, OvoKore
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 08:55:58 +00:00
ragnarok-clanker
cef9fb8317 Decompile 3 functions in Source/Contents/Messenger/MessengerMember.cpp, Source/UI/Gauges/UIPcGage.h
Batch #5065 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_07715 UIMessengerGroupWnd::UpdateScroll: logic confirmed by peer review
- fn_07716 UIMessengerGroupWnd::LayoutButtons: logic confirmed by peer review
- fn_07717 UIMessengerGroupWnd::UpdateGauges: logic confirmed by peer review

Peer-reviewed-by: youko, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 08:55:32 +00:00
ragnarok-clanker
d6927491ac Decompile fn_05771 (EquipmentPropertyStore::Clear)
Batch #5098 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:46:39 +00:00
ragnarok-clanker
cb439d8c47 Decompile 5 functions in Source/Contents/Messenger/MessengerMember.cpp, Source/UI/Gauges/UIPcGage.h
Batch #5083 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_07705 UIMessengerGroupWnd::MemberAtIndex: logic confirmed by peer review
- fn_07708 UIMessengerGroupWnd::Slot26: logic confirmed by peer review
- fn_07712 UIMessengerGroupWnd::Slot27: logic confirmed by peer review
- fn_07714 UIMessengerGroupWnd::Slot35: logic confirmed by peer review
- fn_11596 UIGage::SetColor: logic confirmed by peer review

Peer-reviewed-by: youko, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:34:32 +00:00
ragnarok-clanker
05be22bdcf Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...
Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.

- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp
2026-10-30 06:43:59 +00:00
ragnarok-clanker
c8363bd3af Decompile 15 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Script/LuaInstance.h, ...
Batch #4203 by Yommy: 2 byte-identical, 13 confirmed by peer review.

- fn_05609 EquipmentProperties::CEquipmentProperties2Dim::`scalar deleting destructor': logic confirmed by peer review
- fn_05610 EquipmentProperties::CEquipmentProperties1Dim::`scalar deleting destructor': logic confirmed by peer review
- fn_05924 CLuaInstance::GetFieldInt: logic confirmed by peer review
- fn_05925 CLuaInstance::GetFieldUIntArray: logic confirmed by peer review
- fn_05926 CLuaInstance::GetFieldString: logic confirmed by peer review
- fn_05927 CLuaInstance::GetFieldStringArray: logic confirmed by peer review
- fn_05928 CLuaInstance::GetFieldUIntMap: logic confirmed by peer review
- fn_05929 CLuaInstance::GetFieldStringMap: logic confirmed by peer review
- fn_05930 CLuaInstance::GetInt: logic confirmed by peer review
- fn_06054 MessengerIntrusiveLink::Unlink6A6220: byte-identical
- fn_06055 MessengerIntrusiveLink::Unlink6A6240: byte-identical
- fn_21291 CGameMode::IsAllowedPair: logic confirmed by peer review
- fn_21292 CGameMode::IsWithinRange: logic confirmed by peer review
- fn_21293 CGameMode::IsRegisterCell: logic confirmed by peer review
- fn_21294 CGameMode::HasUnknown01A4: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, youko, eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:09:29 +00:00
ragnarok-clanker
a30154a0f3 Decompile 6 functions in Source/UI/Gauges/UIPetInfoBarGraph.cpp, Source/UI/UIBarGraph.h, ...
Batch #4012 by eAthena: 0 byte-identical, 6 confirmed by peer review.

- fn_11564 UIBarGraph4::SetValues: logic confirmed by peer review
- fn_11566 UIINT64BarGraph::SetValues: logic confirmed by peer review
- fn_11575 UIListBoxNavi::SetDefaultLineColor: logic confirmed by peer review
- fn_11585 UIChatHisBox::Show: logic confirmed by peer review
- fn_11586 UIPcGage::SetLimits: logic confirmed by peer review
- fn_11591 UIEditCtrl_Custom::Trim: logic confirmed by peer review

Peer-reviewed-by: Yommy, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:35:21 +00:00
ragnarok-clanker
519897f39c Decompile 11 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Contents/Configuration/ServiceOptions.cpp
Batch #3991 by eAthena: 0 byte-identical, 11 confirmed by peer review.

- fn_06282 GetLocation: logic confirmed by peer review
- fn_06283 GetMapName: logic confirmed by peer review
- fn_06285 GetPureJob: logic confirmed by peer review
- fn_06290 IsPremiumPcCafe: logic confirmed by peer review
- fn_06291 C_Logger: logic confirmed by peer review
- fn_06299 CGameSettingsMgr::CGameSettingsMgr: logic confirmed by peer review
- fn_06312 CGameSettingsMgr::sub_6C0C40: logic confirmed by peer review
- fn_06313 CGameSettingsMgr::RunFunction: logic confirmed by peer review
- fn_06314 FindServiceOption: logic confirmed by peer review
- fn_06315 CGameSettingsMgr::FindOption: logic confirmed by peer review
- fn_06316 CGameSettingsMgr::GetOptionIds: logic confirmed by peer review

Peer-reviewed-by: willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:25:49 +00:00
ragnarok-clanker
8e0c9338c2 Decompile fn_07670 (UIDragMiniPartyWnd::Paint)
Batch #3555 by bigodeira: 0 byte-identical, 1 confirmed by peer review.

- fn_07670 UIDragMiniPartyWnd::Paint: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:46:25 +00:00
ragnarok-clanker
eadfed23ac Decompile fn_06190 (EquipmentProperties::CEquipmentPropertiesMgr::HasUnknown0194)
Batch #3437 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06190 EquipmentProperties::CEquipmentPropertiesMgr::HasUnknown0194: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:32:20 +00:00
ragnarok-clanker
bc42630e18 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3306 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_06181 GetNormalThirdJob: logic confirmed by peer review
- fn_06186 GetEquipLocationIndex: logic confirmed by peer review
- fn_06275 CheckJobGroup2: logic confirmed by peer review
- fn_06276 GetCategoryJob: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:18:37 +00:00
ragnarok-clanker
2854886158 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3297 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_06180 GetNormalJob: logic confirmed by peer review
- fn_06187 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0114: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:17:19 +00:00
ragnarok-clanker
3ea6c404f6 Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3296 by eAthena: 0 byte-identical, 7 confirmed by peer review.

- fn_06210 EquipmentProperties::CEquipmentPropertiesMgr::SetWindow: logic confirmed by peer review
- fn_06172 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown0134: logic confirmed by peer review
- fn_06175 EquipmentProperties::CEquipmentPropertiesMgr::FindProperty1: logic confirmed by peer review
- fn_06176 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0094: logic confirmed by peer review
- fn_06177 GetEquipLocationMask: logic confirmed by peer review
- fn_06179 GetFirstJob: logic confirmed by peer review
- fn_06184 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown0174: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:17:02 +00:00
ragnarok-clanker
fb1b1398a3 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3009 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_05600 EquipmentProperties::CEquipmentCombiitem::CEquipmentCombiitem: logic confirmed by peer review
- fn_05601 EquipmentProperties::CEquipmentExpansion::CEquipmentExpansion: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:16:46 +00:00
ragnarok-clanker
2564c10e3a Decompile 6 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3158 by superintelligence: 6 byte-identical, 0 confirmed by peer review.

- fn_05647 ClientMessengerSelf::Self68D5B0: byte-identical
- fn_05648 ClientMessengerSelf::Self68D5C0: byte-identical
- fn_05786 ClientMessengerSelf::Self69ACB0: byte-identical
- fn_05787 ClientMessengerSelf::Self69ACC0: byte-identical
- fn_05656 sub_68DAF0: byte-identical
- fn_06015 sub_6A2170: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:39:36 +00:00
ragnarok-clanker
a3fe0d284a Decompile 11 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Archive/GPak.cpp
Batch #3121 by superintelligence: 11 byte-identical, 0 confirmed by peer review.

- fn_05611 MessengerIntrusiveLink::Unlink68B6A0: byte-identical
- fn_06045 MessengerIntrusiveLink::Unlink6A6100: byte-identical
- fn_06046 MessengerIntrusiveLink::Unlink6A6120: byte-identical
- fn_06047 MessengerIntrusiveLink::Unlink6A6140: byte-identical
- fn_06048 MessengerIntrusiveLink::Unlink6A6160: byte-identical
- fn_06049 MessengerIntrusiveLink::Unlink6A6180: byte-identical
- fn_06050 MessengerIntrusiveLink::Unlink6A61A0: byte-identical
- fn_06051 MessengerIntrusiveLink::Unlink6A61C0: byte-identical
- fn_06052 MessengerIntrusiveLink::Unlink6A61E0: byte-identical
- fn_06053 MessengerIntrusiveLink::Unlink6A6200: byte-identical
- fn_05092 PakIntrusiveLink::Unlink657820: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:33:13 +00:00
ragnarok-clanker
490be6d791 Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2987 by eAthena: 3 byte-identical, 0 confirmed by peer review.

- fn_06174 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown001C: byte-identical
- fn_06178 EquipmentProperties::CEquipmentPropertiesMgr::GetScript: byte-identical
- fn_06188 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown019C: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:09:25 +00:00
ragnarok-clanker
0bccb17819 Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2894 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_05738 EquipmentProperties::CEquipmentProperties::CEquipmentProperties: logic confirmed by peer review
- fn_05767 EquipmentProperties::CEquipmentProperties2Dim::Accumulate: logic confirmed by peer review
- fn_05772 EquipmentProperties::CEquipmentProperties1Dim::Clone: logic confirmed by peer review
- fn_05773 EquipmentProperties::CEquipmentProperties2Dim::Clone: logic confirmed by peer review
- fn_05774 EquipmentProperties::CEquipmentProperties::Clone: logic confirmed by peer review
- fn_05779 EquipmentProperties::CEquipmentProperties2Dim::SetValue: logic confirmed by peer review
- fn_05766 EquipmentProperties::CEquipmentProperties1Dim::Accumulate: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:05:50 +00:00
ragnarok-clanker
b6913fda3c Decompile fn_07669 (UIDragMiniPartyWnd::Slot15)
Batch #2782 by bigodeira: 0 byte-identical, 1 confirmed by peer review.

- fn_07669 UIDragMiniPartyWnd::Slot15: logic confirmed by peer review

Peer-reviewed-by: willerthal, youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 18:59:09 +00:00
ragnarok-clanker
e83bd02c0b Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2679 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_05778 EquipmentProperties::CEquipmentProperties1Dim::SetValue: logic confirmed by peer review
- fn_05626 EquipmentProperties::CEquipmentExpansion::GetSuffix: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Reviewed-by: ragnarok-clanker
2026-10-29 18:33:12 +00:00
ragnarok-clanker
c0f51e0c22 Decompile 8 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2685 by youko: 8 byte-identical, 0 confirmed by peer review.

- fn_05775 EquipmentPropertyStore::GetProperties: byte-identical
- fn_05776 EquipmentPropertyStore::GetCount: byte-identical
- fn_05777 EquipmentPropertyStore::GetNames: byte-identical
- fn_05808 EquipmentPropertyGroup::GetName: byte-identical
- fn_05809 EquipmentPropertyGroup::GetDefinitions: byte-identical
- fn_05623 EquipmentProperties::CEquipmentWearable::GetAttachables: byte-identical
- fn_05625 EquipmentProperties::CEquipmentAttachable::GetOwner: byte-identical
- fn_05627 EquipmentProperties::CEquipmentWearable::IsActive: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 18:24:41 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
a55864a825 Decompile 2 functions in Source/Contents/Messenger/MessengerMember.cpp, Source/UI/Gauges/UIPcGage.h
Batch #2101 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_07673 UIDragMiniPartyWnd::SetGaugeValues: logic confirmed by peer review
- fn_11577 UIPcGage::SetValues: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 10:13:36 +00:00
ragnarok-clanker
4640388907 Decompile fn_13630 (FriendOptionWndInfo::IsValid)
Batch #2078 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_13630 FriendOptionWndInfo::IsValid: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 09:56:11 +00:00
ragnarok-clanker
bf62e1d8ca Decompile fn_05766 (EquipmentProperties::CEquipmentProperties1Dim::Accumulate)
Batch #1988 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_05766 EquipmentProperties::CEquipmentProperties1Dim::Accumulate: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:53 +00:00
ragnarok-clanker
891500760e Decompile fn_07683 (UIFriendOptionWnd::SendMsg)
Batch #1962 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_07683 UIFriendOptionWnd::SendMsg: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:31 +00:00
ragnarok-clanker
42fd7a215e Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1981 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_05739 EquipmentProperties::CEquipmentProperties::CEquipmentProperties: logic confirmed by peer review
- fn_05736 EquipmentProperties::CEquipmentProperties1Dim::CEquipmentProperties1Dim: logic confirmed by peer review
- fn_05737 EquipmentProperties::CEquipmentProperties2Dim::CEquipmentProperties2Dim: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:24 +00:00
ragnarok-clanker
7e716e8506 Decompile fn_05768 (EquipmentProperties::CEquipmentProperties::Accumulate)
Batch #1982 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_05768 EquipmentProperties::CEquipmentProperties::Accumulate: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 00:46:29 +00:00
ragnarok-clanker
835fb15cc9 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1979 by ragnarok-clanker: 4 byte-identical, 0 confirmed by peer review.

- fn_05629 EquipmentProperties::CEquipmentAttachable::GetType: byte-identical
- fn_05630 EquipmentProperties::CEquipmentCombiitem::GetType: byte-identical
- fn_05631 EquipmentProperties::CEquipmentExpansion::GetType: byte-identical
- fn_05632 EquipmentProperties::CEquipmentWearable::GetType: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 00:39:49 +00:00
ragnarok-clanker
75bc9ea504 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1845 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05654 EquipmentProperties::CEquipmentPropertiesMgr::GetInstance: logic confirmed by peer review
- fn_05622 EquipmentProperties::CEquipment::CallOnStartEquip: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:50:33 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
720a876789 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1813 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05612 EquipmentProperties::CEquipment::`scalar deleting destructor': logic confirmed by peer review
- fn_05624 EquipmentProperties::CEquipment::GetValue: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:37:12 +00:00
ragnarok-clanker
97e174c6b0 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1817 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_05628 EquipmentProperties::CEquipment::GetId: byte-identical
- fn_05633 EquipmentProperties::CEquipment::GetProperties: byte-identical
- fn_05638 EquipmentProperties::CEquipment::Clear: byte-identical
- fn_05642 EquipmentProperties::CEquipment::IsPretend: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 22:37:01 +00:00
ragnarok-clanker
3616ad5aa8 Decompile 2 functions in Source/Contents/Messenger/MessengerMember.cpp
Batch #1717 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_07682 UIFriendOptionWnd::Paint: logic confirmed by peer review
- fn_07687 UIJobIconButton::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:55:32 +00:00
ragnarok-clanker
320e545705 Decompile fn_06044 (EquipmentProperties::CEquipmentPropertiesMgr::~CEquipmentPropertiesMgr)
Batch #1709 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06044 EquipmentProperties::CEquipmentPropertiesMgr::~CEquipmentPropertiesMgr: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:47:48 +00:00