Batch #11011 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_14408 CUIBasicButton::SetAutoWidth: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10921 by StrawberrysherbetIX: 0 byte-identical, 1 confirmed by peer review.
- fn_11791 UIMessageBox::Slot19: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10813 by kyoshi: 0 byte-identical, 1 confirmed by peer review.
- fn_12778 UIRoMapWnd::DrawKafraMarkers: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10798 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.
- fn_03557 UINavigationV4Wnd::DrawMapTexture: logic confirmed by peer review (already on main)
- fn_03586 UIListBox_NaviSearch::Paint: logic confirmed by peer review (already on main)
- fn_03588 UINavigationV4Wnd::Paint: logic confirmed by peer review (already on main)
- fn_03589 UINavigationroadiconWnd::Paint: logic confirmed by peer review (already on main)
- fn_03587 UINavigationRuideWnd::Paint: logic confirmed by peer review (already on main)
Peer-reviewed-by: Tanke, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10774 by kyoshi: 2 byte-identical, 0 confirmed by peer review.
- fn_09589 UIWindowMgr::HasModalWindow: byte-identical
- fn_17332 UIWindowMgr::IsHoverOnWindow01C8Button: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10735 by kyoshi: 1 byte-identical, 0 confirmed by peer review.
- fn_12622 UIRoMapWnd::ClearRecords: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10684 by kyoshi: 0 byte-identical, 2 confirmed by peer review.
- fn_16978 UIWindow::FitVerticalDisplayText: logic confirmed by peer review
- fn_16997 UIWindow::RemoveChild: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10691 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_17171 UIWindowMgr::HitTestWindows: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10685 by kyoshi: 3 byte-identical, 0 confirmed by peer review.
- fn_17226 UIWindowMgr::DeferDeletion: byte-identical
- fn_17130 UIWindowMgr::ForgetWindowReferences: byte-identical
- fn_16985 UIWindow::IsDescendantOf: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10634 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_17235 UIWindowMgr::DismissTransient: byte-identical (already on main)
Merged automatically: every function is byte-identical to the original.
Batch #10502 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_11768 UIMessageBox::Paint: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, vinnyamancio, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10534 by cremane: 4 byte-identical, 0 confirmed by peer review.
- fn_03622 UIListBox_NaviSearch::Resize: byte-identical (already on main)
- fn_16998 UIWindow::Resize: byte-identical
- fn_16927 UIWindow::ClearSurface: byte-identical
- fn_16929 UIWindow::SetSize: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #10453 by Toshiro: 0 byte-identical, 1 confirmed by peer review.
- fn_17207 UIWindowMgr::sub_A978D0: logic confirmed by peer review
Peer-reviewed-by: secret, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10444 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_21595 CGameMode::sub_D08910: logic confirmed by peer review
Peer-reviewed-by: secret, willerthal, KWDev, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10442 by cremane: 0 byte-identical, 1 confirmed by peer review.
- fn_22297 CLoginMode::Slot7: logic confirmed by peer review
Peer-reviewed-by: willerthal, KWDev, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10434 by ragnarok-clanker: no function's compiled code changes; checked with 266 compiled unit(s), including every includer of Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Window/UISeekPartyWnd.h.
Batch #10430 by ragnarok-clanker: no function's compiled code changes; checked with 530 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/RenderObject.h, Source/Contents/ClientState.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Messenger/MessengerMember.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/UIBartermarketWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindowMgr.h.
Batch #10425 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12939 UIBalloonOpenBtn::SendMsg: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, cremane, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10414 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10403 by ragnarok-clanker: no function's compiled code changes; checked with 508 compiled unit(s), including every includer of Source/UI/Window/UIWindowMgr.h.
Batch #10400 by ragnarok-clanker: no function's compiled code changes; checked with 13 compiled unit(s), including every includer of Source/UI/Window/UINavigationWnd.h.
Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10391 by ragnarok-clanker: no function's compiled code changes; checked with 8 compiled unit(s), including every includer of Source/Contents/Sound/SoundMaker.h.
Batch #10377 by dori: 0 byte-identical, 2 confirmed by peer review.
- fn_17221 UIWindowMgr::sub_AA35F0: logic confirmed by peer review
- fn_12582 UINewChatWnd::ToggleInput: logic confirmed by peer review (already on main)
Peer-reviewed-by: gordaoprogramas, Toshiro, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10388 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_17216 ToggleGameSettingsTab4: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, Toshiro, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10367 by ragnarok-clanker: no function's compiled code changes; checked with 507 compiled unit(s), including every includer of Source/UI/Edit/UIEditCtrl.h, Source/UI/Window/UIWindowMgr.h.
Batch #10366 by Lumen: 0 byte-identical, 1 confirmed by peer review.
- fn_11805 UILoginWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: youko, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #10280 by ragnarok-clanker: forced by an admin (0 lower score(s), 115 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/ClientItemLists.h.
Deletes: Source/Contents/ClientItemLists.h
Batch #10279 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10275 by ragnarok-clanker: forced by an admin (1 lower score(s), 1 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h.
Batch #10269 by ragnarok-clanker: forced by an admin (2 lower score(s), 6 changed function(s)); checked with 102 compiled unit(s), including every includer of Source/Script/LuaScript.h.
Batch #10268 by ragnarok-clanker: forced by an admin (17 lower score(s), 85 changed function(s)); checked with 222 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Camera/CameraFrame.h, Source/Contents/Ground/TerrainHeight.h, Source/Contents/World/World.h, Source/Resource/World/TerrainResource.h.
Batch #10261 by ragnarok-clanker: forced by an admin (1 lower score(s), 9 changed function(s)); checked with 57 compiled unit(s), including every includer of Source/Client/Replay.h, Source/Client/ReplayPacketRecorder.h.
Deletes: Source/Client/ReplayPacketRecorder.h
Batch #10255 by ragnarok-clanker: forced by an admin (0 lower score(s), 0 changed function(s)); checked with 5 compiled unit(s), including every includer of Source/UI/Window/WindowMouseHit.h.
Deletes: Source/UI/Window/WindowMouseHit.h
Batch #10246 by ragnarok-clanker: forced by an admin (0 lower score(s), 3 changed function(s)); checked with 58 compiled unit(s), including every includer of Source/UI/Lists/UIListBox.h, Source/UI/Edit/EditTextState.h, Source/UI/Edit/EditViewport.h, Source/UI/Window/FrameFocus.h.
Deletes: Source/UI/Edit/EditTextState.h, Source/UI/Edit/EditViewport.h, Source/UI/Window/FrameFocus.h
Batch #10245 by ragnarok-clanker: forced by an admin (3 lower score(s), 19 changed function(s)); checked with 397 compiled unit(s), including every includer of Source/Client/ReplayPacketRecorder.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Window/UIWindow.h.
Batch #10243 by ragnarok-clanker: forced by an admin (11 lower score(s), 21 changed function(s)); checked with 4 compiled unit(s), including every includer of Source/UI/Acceptance/UIJoinPartyAcceptWnd.h.
Batch #10237 by ragnarok-clanker: forced by an admin (0 lower score(s), 90 changed function(s)); checked with 262 compiled unit(s), including every includer of Source/Client/Mode/CMode.h.
Batch #10231 by ragnarok-clanker: forced by an admin (5 lower score(s), 39 changed function(s)); checked with 495 compiled unit(s), including every includer of Source/Client/Mode/ModeTooltip.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Lists/UIDropDownBox.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
Deletes: Source/UI/Window/WindowOrdering.h
Batch #10230 by ragnarok-clanker: forced by an admin (9 lower score(s), 42 changed function(s)); checked with 339 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/UIBasicCtrl.h, Source/Network/Packets/SkillUpdatePacket.h.
Deletes: Source/Network/Packets/SkillUpdatePacket.h
Batch #10224 by ragnarok-clanker: forced by an admin (0 lower score(s), 2 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/UI/Window/UIWindowMgr.inl, Source/UI/Shortcuts/ShortcutVisibility.h.
Deletes: Source/UI/Shortcuts/ShortcutVisibility.h
Batch #10222 by ragnarok-clanker: forced by an admin (7 lower score(s), 45 changed function(s)); checked with 230 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/Messenger/ClientMessenger.h.
