Commit graph

15 commits

Author SHA1 Message Date
ragnarok-clanker
2ba833f291 Decompile 2 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #2985 by eAthena: 2 byte-identical, 0 confirmed by peer review.

- fn_24180 CSession::IsEffectRenderEnabled: byte-identical
- fn_24194 CSession::ResetUnknownState: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:09:59 +00:00
ragnarok-clanker
c38c98066c Decompile 7 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.cpp, ...
Batch #2718 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_23853 CSession::IsBabyJob: logic confirmed by peer review
- fn_23873 CSession::IsMercenaryJob: logic confirmed by peer review
- fn_23874 CSession::IsNewMercenaryJob: logic confirmed by peer review
- fn_23889 CSession::GetSceneUnknown004C: logic confirmed by peer review
- fn_23891 CSession::IsSuperNovice2Job: logic confirmed by peer review
- fn_23894 CSession::IsExpandedJob: logic confirmed by peer review
- fn_24188 CSession::IsCostumeJob: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:27:53 +00:00
ragnarok-clanker
14c5a7b063 Decompile 4 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2472 by meitogi: 0 byte-identical, 4 confirmed by peer review.

- fn_23422 CSession::FindRecord0734: logic confirmed by peer review
- fn_23423 CSession::GetBgmFileName: logic confirmed by peer review
- fn_23565 CSession::HasItem17D4: logic confirmed by peer review
- fn_23566 CSession::IsFriendName: logic confirmed by peer review

Peer-reviewed-by: alisonrag, bigodeira, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 17:17:44 +00:00
ragnarok-clanker
b4c06be357 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2503 by meitogi: 0 byte-identical, 3 confirmed by peer review.

- fn_23355 CSession::GatName2RswName: logic confirmed by peer review
- fn_23415 CSession::FindItem1760ByItemId: logic confirmed by peer review
- fn_23417 CSession::GetItem1760QuantityByItemId: logic confirmed by peer review

Peer-reviewed-by: alisonrag, bigodeira, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 17:17:20 +00:00
ragnarok-clanker
5a54d550c0 Decompile 2 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2168 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23563 CSession::HasItem1718: logic confirmed by peer review
- fn_23564 CSession::HasExchangeItem: logic confirmed by peer review

Peer-reviewed-by: ntrl
Reviewed-by: ragnarok-clanker
2026-10-29 15:07:33 +00:00
ragnarok-clanker
574f7ad757 Decompile 18 functions in Source/Client/Session.cpp, Source/Client/Session.h
Batch #2146 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_23402 CSession::FindItem1768: logic confirmed by peer review
- fn_23403 CSession::GetItem1768At: logic confirmed by peer review
- fn_23404 CSession::GetItem1768Quantity: logic confirmed by peer review
- fn_23405 CSession::FindItem1740: logic confirmed by peer review
- fn_23406 CSession::GetItem1740At: logic confirmed by peer review
- fn_23407 CSession::GetItem1740Quantity: logic confirmed by peer review
- fn_23408 CSession::FindItem1750: logic confirmed by peer review
- fn_23409 CSession::GetItem1750At: logic confirmed by peer review
- fn_23410 CSession::GetItem1750Quantity: logic confirmed by peer review
- fn_23411 CSession::FindItem1758: logic confirmed by peer review
- fn_23412 CSession::FindItem1758ByItemId: logic confirmed by peer review
- fn_23413 CSession::GetItem1758At: logic confirmed by peer review
- fn_23414 CSession::FindItem1760: logic confirmed by peer review
- fn_23416 CSession::GetItem1760At: logic confirmed by peer review
- fn_23418 CSession::GetItem1760Quantity: logic confirmed by peer review
- fn_23419 CSession::FindItem1770: logic confirmed by peer review
- fn_23420 CSession::GetItem1760Total: logic confirmed by peer review
- fn_23421 CSession::GetItem1748At: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 14:39:01 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
3ec1742a36 Decompile fn_23562 (CSession::IsExchangeItemListFull)
Batch #1887 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23562 CSession::IsExchangeItemListFull: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:16:52 +00:00
ragnarok-clanker
b677bdbc59 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #1704 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_24179 CSession::IsDoramJob: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review
- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:33:49 +00:00
ragnarok-clanker
ee280b667b Decompile fn_23401 (CSession::MercSkillLevel)
Batch #1324 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23401 CSession::MercSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:06:46 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
92886d28ca Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1329 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23633 CSession::ClearItemSelection: logic confirmed by peer review
- fn_17254 UIWindowMgr::NotifyMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 10:30:24 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
308cefc066 Decompile fn_23826 (CSession::SyncUnknown0E98)
Batch #1325 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23826 CSession::SyncUnknown0E98: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:10:19 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00