Commit graph

15 commits

Author SHA1 Message Date
ragnarok-clanker
3d1d975150 Decompile fn_06589 (ItemInfo::Refine)
Batch #1445 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06589 ItemInfo::Refine: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:58:47 +00:00
ragnarok-clanker
79c8823d57 Decompile fn_06602 (IsNumericText)
Batch #1373 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_06602 IsNumericText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:05:19 +00:00
ragnarok-clanker
dc2307a00e Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h
Batch #1368 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_06601 ItemInfo::IsForgeMaterial: logic confirmed by peer review
- fn_06604 ItemInfo::IsElementalStone: logic confirmed by peer review
- fn_06605 ItemInfo::IsAboveItemId600: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:10 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
82a645387c Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h
Batch #1209 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_06571 ItemInfo::operator<: logic confirmed by peer review
- fn_06609 ItemInfo::SetName: logic confirmed by peer review
- fn_06610 ItemInfo::SetItemId: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:09:14 +00:00
ragnarok-clanker
d9f91eec12 Decompile 6 functions in Source/Contents/Items/ItemNaming.cpp
Batch #1197 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_06583 ItemNamingContext::Element: logic confirmed by peer review
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review
- fn_06591 ItemResourcePath: logic confirmed by peer review
- fn_06592 ItemSlotsCount: logic confirmed by peer review
- fn_06594 ItemUnidentifiedName: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:08:08 +00:00
ragnarok-clanker
8694e9a749 🔥 refactor(ItemNaming): removed unused cstdio include
(cherry picked from commit e426bd95cc)
2026-10-27 14:43:03 +00:00
ragnarok-clanker
9ac3d05245 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 2: Items, Models, Movies, Skills,
Batch #1063 by ragnarok-clanker: no function's compiled code changes; checked with 62 compiled unit(s), including every includer of Source/Contents/Items/ItemNaming.h, Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelRendering.h, Source/Contents/Models/ModelSpatial.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/Movies/BinkMovies.h, Source/Contents/PlayerNameDictionary.h, Source/Contents/Skills/AutomaticSkills.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/WorldModelLoading.h, Source/Contents/World/WorldModelView.h, Source/Contents/World/WorldRayQuery.h.
2026-10-27 13:52:05 +00:00
ragnarok-clanker
3dbd276311 📚 docs(inlining): marked inlined functions across modules 2026-10-27 10:21:57 +01:00
ragnarok-clanker
5aafb686cc 🛠️ refactor(strings): wrote CP949 Korean literals as UTF-8 Hangul with /source-charset:utf-8 /execution-charset:.949 2026-10-27 09:42:20 +01:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00
ragnarok-clanker
5bd1a554b0 Decompile 3 functions in Source/Contents/Items/ItemDescription.cpp, Source/Contents/Items/ItemDescription.h
Batch #930 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_06546 EnsureItemCardName: logic confirmed by peer review
- fn_06547 EnsureItemDescriptionLines: logic confirmed by peer review
- fn_06579 FindItemDescription: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-26 21:46:27 +00:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00