clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
782 commits 1 branch 0 tags 28 MiB
Commit graph

19 commits

Author SHA1 Message Date
ragnarok-clanker
b046bd4a25 Decompile fn_23578 (CSession::IsNavigationAllowed) 
Batch #2634 by alisonrag: 0 byte-identical, 1 confirmed by peer review.

- fn_23578 CSession::IsNavigationAllowed: logic confirmed by peer review

Peer-reviewed-by: meitogi, willerthal, youko
Reviewed-by: ragnarok-clanker
 2026-10-29 18:11:54 +00:00
ragnarok-clanker
b2589563e0 Decompile 2 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #2545 by alisonrag: 0 byte-identical, 2 confirmed by peer review.

- fn_23577 ValidateCharacterName: logic confirmed by peer review
- fn_23579 IsNavigationActive: logic confirmed by peer review

Peer-reviewed-by: ntrl, meitogi, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-29 17:52:21 +00:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
5b51184749 Decompile 20 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #2111 by ragnarok-clanker: 0 byte-identical, 20 confirmed by peer review.

- fn_21042 CGameActor::GetEffectiveJob: logic confirmed by peer review
- fn_03042 CGameActor::Slot62: logic confirmed by peer review
- fn_03046 CGameActor::GetExtent: logic confirmed by peer review
- fn_03048 CGameActor::Slot45: logic confirmed by peer review
- fn_03054 CGameActor::Slot48: logic confirmed by peer review
- fn_03062 CGameActor::Slot47: logic confirmed by peer review
- fn_21040 CGameActor::Slot55: logic confirmed by peer review
- fn_21048 CGameActor::Slot51: logic confirmed by peer review
- fn_21052 CGameActor::Slot53: logic confirmed by peer review
- fn_21135 CGameActor::Slot49: logic confirmed by peer review
- fn_23576 CSession::IsNpcJob: logic confirmed by peer review
- fn_23792 CSession::GetPairValue: logic confirmed by peer review
- fn_23872 CSession::IsGuardianJob: logic confirmed by peer review
- fn_23887 CSession::IsPlayerJobId: logic confirmed by peer review
- fn_22615 CGrannyPc::Slot40: logic confirmed by peer review
- fn_22616 CPc::Slot40: logic confirmed by peer review
- fn_22621 CGrannyPc::Slot41: logic confirmed by peer review
- fn_22622 CPc::Slot41: logic confirmed by peer review
- fn_22625 CPc::Slot47: logic confirmed by peer review
- fn_22383 CPc::Slot35: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 10:59:31 +00:00
ragnarok-clanker
7f8b1faa57 Decompile 18 functions in Source/Contents/Actors/RenderObject.cpp, Source/Contents/Actors/GameActor.h, ... 
Batch #2112 by ragnarok-clanker: 18 byte-identical, 0 confirmed by peer review.

- fn_03043 CGameActor::Slot46: byte-identical
- fn_03044 CGameActor::Slot13: byte-identical
- fn_03045 CGameActor::Slot50: byte-identical
- fn_03047 CGameActor::Slot58: byte-identical
- fn_03049 CGameActor::Slot56: byte-identical
- fn_03050 CGameActor::Slot42: byte-identical
- fn_03051 CGameActor::Slot35: byte-identical
- fn_03057 CGameActor::Slot40: byte-identical
- fn_03059 CGameActor::Slot59: byte-identical
- fn_03060 CGameActor::Slot57: byte-identical
- fn_03061 CGameActor::Slot41: byte-identical
- fn_03068 CGameActor::Slot60: byte-identical
- fn_03071 CGameActor::Slot43: byte-identical
- fn_22636 CPc::Slot60: byte-identical
- fn_22378 CPc::Slot46: byte-identical
- fn_22380 CPc::Slot58: byte-identical
- fn_22381 CPc::Slot56: byte-identical
- fn_22382 CPc::Slot42: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-29 10:36:51 +00:00
ragnarok-clanker
e4be8f4190 Decompile 18 functions in Source/Client/Application/UnhandledExceptionHandler.cpp, Source/Client/Session.h, ... 
Batch #2077 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review (already on main)
- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_09315 UIRequestJoinPartyWnd::SendMsg: logic confirmed by peer review
- fn_19761 EffectParticle::EffectParticle: logic confirmed by peer review
- fn_19768 EffectParticle::InitializeRecords: logic confirmed by peer review
- fn_20007 AttachedEffect::AttachedEffect: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20991 CRenderObject::CRenderObject: logic confirmed by peer review
- fn_21069 ?CreatePartyEffect@?A0xba063134@@YAPAUAttachedEffect@@AAUEffectActor@@AAUPartyEffectMode@@@Z: logic confirmed by peer review
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_23396 CSession::GetJobName: logic confirmed by peer review
- fn_23495 CSession::InitJobNameTable: logic confirmed by peer review
- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_20987 EffectActor::EffectActor: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-29 09:48:08 +00:00
ragnarok-clanker
ef21913c3f Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.h, ... 
Batch #1842 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23837 CSession::GetWeaponActName: logic confirmed by peer review
- fn_23838 CSession::GetWeaponEffectActName: logic confirmed by peer review
- fn_23839 CSession::GetWeaponEffectSprName: logic confirmed by peer review
- fn_23840 CSession::GetWeaponSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 22:51:51 +00:00
ragnarok-clanker
018dee6278 Decompile 15 functions in Source/Client/Session.h, Source/Client/Replay.cpp, ... 
Batch #1712 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.

- fn_06570 ItemInfo::AssignBasic: logic confirmed by peer review
- fn_06607 SearchItemIds: logic confirmed by peer review
- fn_06608 MatchItemName: logic confirmed by peer review
- fn_06582 FindMetalProcessItems: logic confirmed by peer review
- fn_06590 ItemInfo::Serialize: logic confirmed by peer review
- fn_06544 FindItemCardName: logic confirmed by peer review
- fn_23291 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23297 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review
- fn_23588 CSession::IsSlotItemIdentity: logic confirmed by peer review
- fn_23589 CSession::HasInventoryItem: logic confirmed by peer review
- fn_23591 CSession::HasItemId: logic confirmed by peer review
- fn_23592 CSession::HasItemCount: logic confirmed by peer review
- fn_23582 IsScreenShakeActive: logic confirmed by peer review
- fn_23908 CSession::SetPlayerNameKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 20:47:17 +00:00
ragnarok-clanker
8125ad1ce1 Decompile fn_06623 (BuildReplayTaggedRecord) 
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 20:43:04 +00:00
ragnarok-clanker
3863fe6f3c Decompile 6 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #1478 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_23898 GetDualWieldWeaponType: logic confirmed by peer review
- fn_23583 IsJobWeaponAllowed: logic confirmed by peer review
- fn_23836 GetJobTitleString: logic confirmed by peer review
- fn_23909 CSession::InsertPair: logic confirmed by peer review
- fn_23911 CSession::SetHotkeyEntry: logic confirmed by peer review
- fn_23912 CSession::SetFlag: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:38:29 +00:00
ragnarok-clanker
447fa8b9f6 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #1470 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23590 IsVisibleJob: logic confirmed by peer review
- fn_23841 GetWeaponViewValue: logic confirmed by peer review
- fn_23906 ResetHotkeySlots: logic confirmed by peer review
- fn_23910 CSession::SetPairValue: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 14:13:00 +00:00
ragnarok-clanker
5aafb686cc 🛠️ refactor(strings): wrote CP949 Korean literals as UTF-8 Hangul with /source-charset:utf-8 /execution-charset:.949 2026-10-27 09:42:20 +01:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance 
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
 2026-10-26 23:41:07 +01:00
ragnarok-clanker
6f8a35191a Decompile 2 functions in Source/Contents/Jobs/JobNames.cpp 
Batch #929 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_24165 JobNames::BaseJob: logic confirmed by peer review
- fn_23396 JobNames::Lookup: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:45:07 +00:00
ragnarok-clanker
1122aa7c98 Decompile 7 functions in Source/Contents/Jobs/JobId.h, Source/Contents/Jobs/JobInheritance.cpp, ... 
Batch #921 by ragnarok-clanker: 0 byte-identical, 7 confirmed by peer review.

- fn_23461 GetRealWeaponId: logic confirmed by peer review
- fn_23585 ?IsTreeGroupTwo@?A0x66373c89@@YA_NH@Z: logic confirmed by peer review
- fn_23586 ?IsTreeGroupThree@?A0x66373c89@@YA_NH@Z: logic confirmed by peer review
- fn_23587 IsPlayerJob: logic confirmed by peer review
- fn_23907 JobInheritance::InitializeSkillTree: logic confirmed by peer review
- fn_23495 JobNames::Initialize: logic confirmed by peer review
- fn_23444 AttackMotionLength: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-26 21:33:33 +00:00
ragnarok-clanker
ab4f30f7b0 Maintenance: Remove unused cstdint and string includes from JobNames.h; types and declarations unchanged. Checked exact header payloa 
Batch #912 by ragnarok-clanker: no function's compiled code changes; checked with 4 compiled unit(s), including every includer of Source/Contents/Jobs/JobNames.h.
 2026-10-26 20:58:39 +00:00
ragnarok-clanker
e168b4e4a6 Restore translation-unit ownership and publish verified source corrections 
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.

449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
 2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems 
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
 2026-10-25 07:42:41 +00:00