Commit graph

30 commits

Author SHA1 Message Date
ragnarok-clanker
c932ad6499 Maintenance: Resubmission of 15134 without the 12 struct/type renames (their new names changed mangled symbols in 17 functions). Rena
Batch #15141 by ragnarok-clanker: no function's compiled code changes; checked with 537 compiled unit(s), including every includer of Source/Client/Input/LanguageTC.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/Pc.h, Source/Contents/EnchantMgr.h, Source/Contents/GuildInfo.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TableMng.h, Source/Contents/World/SkyBox.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl.
2026-11-09 12:21:09 +00:00
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
9f656a33ad Confirm fn_23400 (CSession::GetPartyMemberAid)
Batch #14458 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.

- fn_23400 CSession::GetPartyMemberAid: logic confirmed by peer review (already on main)

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 09:46:06 +00:00
ragnarok-clanker
fee4c482ac Decompile 2 functions in Source/Contents/ClientTiming.cpp
Batch #14282 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_23492 CSession::LoadFogParameters: logic confirmed by peer review
- fn_23643 CSession::AddShopName: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:12:40 +00:00
ragnarok-clanker
5f0ce087aa Decompile 2 functions in Source/Contents/ClientTiming.cpp
Batch #14236 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_19425 CNavi_Object::CNavi_Object: logic confirmed by peer review
- fn_19629 CNavigationManager::LoadScript: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, secret, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:27:09 +00:00
ragnarok-clanker
3856627bad Decompile 3 functions in Source/Contents/ClientTiming.cpp
Batch #13781 by eAthena: 3 byte-identical, 0 confirmed by peer review.

- fn_19372 CNaviData::AddDestination: byte-identical
- fn_19373 CNaviData::AddObject: byte-identical
- fn_19426 CNavi_Object::CNavi_Object: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 22:01:02 +00:00
ragnarok-clanker
09401ddd3c Decompile fn_08216 (CNProtectGameGuardMgr::GameName)
Batch #12604 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_08216 CNProtectGameGuardMgr::GameName: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 22:37:01 +00:00
ragnarok-clanker
b020c43174 Decompile fn_23644 (CSession::LoadNavigationScripts)
Batch #11965 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_23644 CSession::LoadNavigationScripts: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 05:49:25 +00:00
ragnarok-clanker
1c33924a74 Decompile fn_23638 (CSession::SetHotkeyDescription)
Batch #10839 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:32:22 +00:00
ragnarok-clanker
d16f28bf7b Decompile fn_23490 (CSession::LoadDamageSkinSettings)
Batch #10079 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_23490 CSession::LoadDamageSkinSettings: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, cremane, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-02 15:26:15 +00:00
ragnarok-clanker
4fd6cd3ad7 Maintenance: Resubmission of batch 9115 rebased onto main (it conflicted with 9108's CommonObject.cpp change, which it already contai
Batch #9132 by ragnarok-clanker: forced by an admin (2 lower score(s), 13 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/Contents/ForbiddenWords.h, Source/Contents/Party/PartyInvitation.h, Source/File/CommonObject.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIPetInfoWnd.h.
2026-11-01 02:10:48 +00:00
ragnarok-clanker
2ecbed35ef Decompile fn_23916 (CSession::RefreshTrackedAchievement)
Batch #8617 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_23916 CSession::RefreshTrackedAchievement: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Lumen, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 19:49:12 +00:00
ragnarok-clanker
7b97f37567 Decompile fn_19423 (CNavi_Link::CNavi_Link)
Batch #7807 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19423 CNavi_Link::CNavi_Link: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 13:02:01 +00:00
ragnarok-clanker
824c188f5f Decompile fn_23491 (CSession::LoadExceptionMinimapNameTable)
Batch #7837 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23491 CSession::LoadExceptionMinimapNameTable: logic confirmed by peer review

Peer-reviewed-by: Yommy, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 12:03:51 +00:00
ragnarok-clanker
05e9c6314f Decompile fn_23492 (CSession::LoadFogParameters)
Batch #7219 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23492 CSession::LoadFogParameters: logic confirmed by peer review

Peer-reviewed-by: meitogi, gordaoprogramas, Lumen, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:30:01 +00:00
ragnarok-clanker
158c77e1fe Decompile fn_19329 (Replay::CachePacket)
Batch #7224 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19329 Replay::CachePacket: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 05:01:50 +00:00
ragnarok-clanker
eb1adea5b9 Decompile fn_23400 (CSession::GetPartyMemberAid)
Batch #7077 by aDw: 0 byte-identical, 1 confirmed by peer review.

- fn_23400 CSession::GetPartyMemberAid: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:48:41 +00:00
ragnarok-clanker
5b90f5716e Decompile fn_23399 (CSession::GetMapDisplayName)
Batch #6968 by aDw: 0 byte-identical, 1 confirmed by peer review.

- fn_23399 CSession::GetMapDisplayName: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 02:55:07 +00:00
ragnarok-clanker
383263b4ca Decompile 3 functions in Source/Contents/ClientTiming.cpp, Source/Contents/ClientState.cpp, ...
Batch #6071 by eAthena: 1 byte-identical, 2 confirmed by peer review.

- fn_23490 CSession::LoadDamageSkinSettings: logic confirmed by peer review
- fn_23493 CSession::ClearHomunStatus: byte-identical
- fn_24208 CSession::ReadReplayEntryQueue: logic confirmed by peer review

Peer-reviewed-by: superintelligence, Snow, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:41:02 +00:00
ragnarok-clanker
ea3e7e439e Decompile fn_19427 (NaviUnknownBlock::NaviUnknownBlock)
Batch #4492 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_19427 NaviUnknownBlock::NaviUnknownBlock: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 03:29:48 +00:00
ragnarok-clanker
030e3024a2 Decompile fn_19629 (CNavigationManager::LoadScript)
Batch #4228 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_19629 CNavigationManager::LoadScript: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, OrangeCat
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:50:56 +00:00
ragnarok-clanker
312b52ecda Decompile 3 functions in Source/Client/Session.h, Source/Contents/BodyResources.cpp, ...
Batch #3351 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_23915 CSession::SetHotkeySkillLevel: logic confirmed by peer review
- fn_23940 CSession::IsPetAccessory: logic confirmed by peer review
- fn_23949 EncryptedName<14,-3700222477>::EncryptedName<14,-3700222477>: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:33:58 +00:00
ragnarok-clanker
916e21db3c Decompile fn_23914 (CSession::SetHotkeyDescription)
Batch #3347 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_23914 CSession::SetHotkeyDescription: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:32:43 +00:00
ragnarok-clanker
c77bf2f4d8 Decompile fn_23359 (CSession::GetUnknown8134)
Batch #3307 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_23359 CSession::GetUnknown8134: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 21:20:13 +00:00
ragnarok-clanker
428e3835e9 Decompile 55 functions in Source/Client/Session.h, Source/Contents/BodyResources.cpp, ...
Batch #3212 by youko: 55 byte-identical, 0 confirmed by peer review.

- fn_23950 EncryptedName<10,-1315859149>::Text: byte-identical
- fn_23951 EncryptedName<10,-979039381>::Text: byte-identical
- fn_23952 EncryptedName<10,-617908319>::Text: byte-identical
- fn_23953 EncryptedName<10,-3263989789>::Text: byte-identical
- fn_23954 EncryptedName<10,-1682334759>::Text: byte-identical
- fn_23955 EncryptedName<10,898467589>::Text: byte-identical
- fn_23956 EncryptedName<10,2204305161>::Text: byte-identical
- fn_23957 EncryptedName<10,3344639417>::Text: byte-identical
- fn_23958 EncryptedName<10,199223703>::Text: byte-identical
- fn_23959 EncryptedName<10,4261389595>::Text: byte-identical
- fn_23960 EncryptedName<10,4123116959>::Text: byte-identical
- fn_23961 EncryptedName<10,561237833>::Text: byte-identical
- fn_23962 EncryptedName<16,-1980669487>::Text: byte-identical
- fn_23963 EncryptedName<16,-113271841>::Text: byte-identical
- fn_23964 EncryptedName<16,-1517315221>::Text: byte-identical
- fn_23965 EncryptedName<16,1739409375>::Text: byte-identical
- fn_23966 EncryptedName<16,3417698647>::Text: byte-identical
- fn_23967 EncryptedName<18,-2999633023>::Text: byte-identical
- fn_23968 EncryptedName<18,-1585628829>::Text: byte-identical
- fn_23969 EncryptedName<18,-3124629243>::Text: byte-identical
- fn_23970 EncryptedName<18,-3401353789>::Text: byte-identical
- fn_23971 EncryptedName<18,-3305026235>::Text: byte-identical
- fn_23972 EncryptedName<18,-2753699959>::Text: byte-identical
- fn_23973 EncryptedName<18,-2090247411>::Text: byte-identical
- fn_23974 EncryptedName<18,-1108884035>::Text: byte-identical
- fn_23975 EncryptedName<18,2174745559>::Text: byte-identical
- fn_23976 EncryptedName<18,2916963279>::Text: byte-identical
- fn_23977 EncryptedName<18,1037158757>::Text: byte-identical
- fn_23978 EncryptedName<18,2544074191>::Text: byte-identical
- fn_23979 EncryptedName<18,3947304279>::Text: byte-identical
- fn_23980 EncryptedName<18,957680539>::Text: byte-identical
- fn_23981 EncryptedName<18,459105731>::Text: byte-identical
- fn_23982 EncryptedName<18,2006784475>::Text: byte-identical
- fn_23983 EncryptedName<18,1697449919>::Text: byte-identical
- fn_23984 EncryptedName<18,1069021477>::Text: byte-identical
- fn_23985 EncryptedName<18,2669800313>::Text: byte-identical
- fn_23986 EncryptedName<20,-372429951>::Text: byte-identical
- fn_23987 EncryptedName<20,595816843>::Text: byte-identical
- fn_23988 EncryptedName<20,3849141641>::Text: byte-identical
- fn_23989 EncryptedName<20,665307127>::Text: byte-identical
- fn_23990 EncryptedName<22,-1343680015>::Text: byte-identical
- fn_23991 EncryptedName<22,-3203960915>::Text: byte-identical
- fn_23992 EncryptedName<22,3944978353>::Text: byte-identical
- fn_23993 EncryptedName<22,2745126827>::Text: byte-identical
- fn_23994 EncryptedName<22,2030259687>::Text: byte-identical
- fn_23995 EncryptedName<23,-2258505739>::Text: byte-identical
- fn_23996 EncryptedName<23,3914540533>::Text: byte-identical
- fn_23997 EncryptedName<23,935698863>::Text: byte-identical
- fn_23998 EncryptedName<24,2401333041>::Text: byte-identical
- fn_23999 EncryptedName<24,937134379>::Text: byte-identical
- fn_24000 EncryptedName<24,1105683737>::Text: byte-identical
- fn_24001 EncryptedName<25,-4062891603>::Text: byte-identical
- fn_24002 EncryptedName<25,58020621>::Text: byte-identical
- fn_24003 EncryptedName<25,1696325589>::Text: byte-identical
- fn_24004 EncryptedName<25,3542311337>::Text: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:57:52 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
ef13e565dd Decompile 2 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h, ...
Batch #1897 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23644 CSession::LoadNavigationScripts: logic confirmed by peer review
- fn_23645 CSession::LoadRobeAlpha: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:27:26 +00:00
ragnarok-clanker
9d7fe49b7e Decompile 10 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h
Batch #1466 by ragnarok-clanker: 0 byte-identical, 10 confirmed by peer review.

- fn_23639 CSession::AddItemSlot: logic confirmed by peer review
- fn_23640 CSession::GetShop: logic confirmed by peer review
- fn_23641 CSession::SetShopFlag: logic confirmed by peer review
- fn_23642 CSession::SetShopItem: logic confirmed by peer review
- fn_23643 CSession::AddShopName: logic confirmed by peer review
- fn_23646 CSession::SetUnknown8134: logic confirmed by peer review
- fn_23647 CSession::ClearUnknown1710: logic confirmed by peer review
- fn_23648 CSession::ClearUnknown1740: logic confirmed by peer review
- fn_23649 CSession::ClearUnknown1738: logic confirmed by peer review
- fn_23650 CSession::SyncServerTime: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 15:38:10 +00:00
ragnarok-clanker
c351db5d57 Decompile 4 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h
Batch #1467 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23466 CSession::GetServerTime: logic confirmed by peer review
- fn_23605 CSession::AddPingSample: logic confirmed by peer review
- fn_23637 CSession::SetServerTime: logic confirmed by peer review
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/ClientTiming.cpp
2026-10-28 14:02:41 +00:00