Commit graph

27 commits

Author SHA1 Message Date
ragnarok-clanker
dc3d5ce1a5 Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
c5af0fda1c Decompile fn_19638 (CNavigationManager::UpdateGround)
Batch #13824 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19638 CNavigationManager::UpdateGround: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 06:44:58 +00:00
ragnarok-clanker
77bf4c2b26 Decompile fn_19484 (CNavi_Object::GetCell)
Batch #12932 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_19484 CNavi_Object::GetCell: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 03:16:32 +00:00
ragnarok-clanker
01e049c494 Decompile fn_19420 (FindNaviObjectByName)
Batch #11948 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_19420 FindNaviObjectByName: logic confirmed by peer review

Peer-reviewed-by: KWDev, SapitoSucio, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:00:56 +00:00
ragnarok-clanker
10b0641ec7 Decompile fn_19472 (CNaviInfo::FindMobByIndex)
Batch #11952 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_19472 CNaviInfo::FindMobByIndex: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 05:43:33 +00:00
ragnarok-clanker
31f13791e5 Decompile fn_19387 (CNaviData::SetDestination)
Batch #11009 by StrawberrysherbetIX: 1 byte-identical, 0 confirmed by peer review.

- fn_19387 CNaviData::SetDestination: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-04 18:44:35 +00:00
ragnarok-clanker
c5a687e68c Decompile 2 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h, ...
Batch #6697 by eAthena: 1 byte-identical, 1 confirmed by peer review.

- fn_19486 CNaviInfo::GetNameLength: byte-identical
- fn_20392 CRagConnection::GetPacketType: logic confirmed by peer review

Peer-reviewed-by: superintelligence, KWDev, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 01:41:48 +00:00
ragnarok-clanker
b5d118fdad Decompile 2 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h
Batch #5655 by zindokar: 0 byte-identical, 2 confirmed by peer review.

- fn_19630 CNavigationManager::SetViewMode: logic confirmed by peer review
- fn_19631 CNavigationManager::BuildGridLabels: logic confirmed by peer review

Peer-reviewed-by: Yommy, willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 15:25:09 +00:00
ragnarok-clanker
6ad48c31b5 Decompile fn_19622 (CNavigationManager::SetViewIcon)
Batch #5676 by zindokar: 0 byte-identical, 1 confirmed by peer review.

- fn_19622 CNavigationManager::SetViewIcon: logic confirmed by peer review

Peer-reviewed-by: Yommy, Millenium, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 14:29:52 +00:00
ragnarok-clanker
bba41f34f1 Decompile 3 functions in Source/Contents/NavigationManager.h, Source/Contents/NavigationRequest.cpp, ...
Batch #3874 by eAthena: 3 byte-identical, 0 confirmed by peer review.

- fn_19639 CNavigationManager::StateCount: byte-identical
- fn_19640 CNavigationManager::NodeCount: byte-identical
- fn_19669 CEntryQueueMgr::ResetCurrent: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/EntryQueueMgr.cpp
2026-10-29 23:47:14 +00:00
ragnarok-clanker
a3d77e5632 Decompile 2 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h
Batch #3191 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_19420 FindNaviObjectByName: logic confirmed by peer review
- fn_19470 CNaviInfo::FindMobByName: logic confirmed by peer review

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:06:57 +00:00
ragnarok-clanker
0b0da323bc Decompile fn_19506 (CNaviInfo::SearchNpcs)
Batch #2734 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_19506 CNaviInfo::SearchNpcs: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:42:06 +00:00
ragnarok-clanker
50fc096c11 Decompile fn_19504 (CNaviInfo::SearchMobs)
Batch #2839 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_19504 CNaviInfo::SearchMobs: logic confirmed by peer review

Peer-reviewed-by: meitogi, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:31:43 +00:00
ragnarok-clanker
92942e14c5 Decompile fn_19502 (CNaviInfo::SearchMap)
Batch #2838 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_19502 CNaviInfo::SearchMap: logic confirmed by peer review

Peer-reviewed-by: meitogi, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:31:24 +00:00
ragnarok-clanker
e15436b8f1 Decompile fn_19499 (CNaviInfo::Search)
Batch #2784 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_19499 CNaviInfo::Search: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 18:59:37 +00:00
ragnarok-clanker
1a340dd48e Decompile 11 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h
Batch #2703 by youko: 3 byte-identical, 8 confirmed by peer review.

- fn_19435 NavigationTarget::operator>: logic confirmed by peer review
- fn_19459 CNaviInfo::GetType: byte-identical
- fn_19468 CNaviInfo::Links: byte-identical
- fn_19469 CNaviInfo::FindMob: logic confirmed by peer review
- fn_19471 CNaviInfo::Mobs: byte-identical
- fn_19472 CNaviInfo::FindMobByIndex: logic confirmed by peer review
- fn_19482 CNavi_Object::CopyLinks: logic confirmed by peer review
- fn_19503 CNaviInfo::IsSearchable: logic confirmed by peer review
- fn_19500 CNaviInfo::CollectTargets: logic confirmed by peer review
- fn_19501 CNaviInfo::CollectMobsInRange: logic confirmed by peer review
- fn_19505 CNaviInfo::CollectMobsByTitle: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 18:35:09 +00:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
e4647a1535 Decompile fn_19598 (CNavigationManager::RequestRoute)
Batch #1781 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19598 CNavigationManager::RequestRoute: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:37:25 +00:00
ragnarok-clanker
a5a9051638 Decompile fn_19465 (CNaviInfo::FindMatchingLink)
Batch #1735 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19465 CNaviInfo::FindMatchingLink: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 21:57:46 +00:00
ragnarok-clanker
3be87414c2 Decompile 3 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h
Batch #1728 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_19464 CNaviInfo::FindLink: logic confirmed by peer review
- fn_19478 CNaviInfo::FindNpc: logic confirmed by peer review
- fn_19479 CNaviInfo::FindNpcAt: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 21:46:17 +00:00
ragnarok-clanker
37d909cfee Decompile 3 functions in Source/Contents/NavigationRequest.cpp, Source/Contents/NavigationManager.h
Batch #1729 by ragnarok-clanker: 3 byte-identical, 0 confirmed by peer review.

- fn_19462 CNaviInfo::GetCellY: byte-identical
- fn_19463 CNaviInfo::GetIndex: byte-identical
- fn_19480 CNaviInfo::Npcs: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 21:45:53 +00:00
ragnarok-clanker
5b8f2cfb1f Decompile 12 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1554 by ragnarok-clanker: 0 byte-identical, 12 confirmed by peer review.

- fn_21278 CGameMode::WorldCell: logic confirmed by peer review (already on main)
- fn_19599 CNavigationManager::LoadStates: logic confirmed by peer review (annotation added to existing code)
- fn_19394 CNaviData::ResetLinkDepths: logic confirmed by peer review (annotation added to existing code)
- fn_19390 CNaviData::FindRoute: logic confirmed by peer review (annotation added to existing code)
- fn_19508 CNavi_Link::SetDepth: logic confirmed by peer review (annotation added to existing code)
- fn_19456 CNavi_Link::LinkedEnd: logic confirmed by peer review (annotation added to existing code)
- fn_19444 CNavi_Link::LinkedBegin: logic confirmed by peer review (annotation added to existing code)
- fn_19466 CNaviInfo::LinksBegin: logic confirmed by peer review (annotation added to existing code)
- fn_19467 CNaviInfo::LinksEnd: logic confirmed by peer review (annotation added to existing code)
- fn_19509 CNaviInfo::SetVisited: logic confirmed by peer review (annotation added to existing code)
- fn_19581 CNavigationManager::PlayerCell: logic confirmed by peer review (annotation added to existing code)
- fn_21282 CGameMode::PlayerCell: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
2026-10-28 18:50:46 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
2026-10-28 18:48:31 +00:00
ragnarok-clanker
4c1960b206 Decompile 14 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ...
Batch #1540 by ragnarok-clanker: 0 byte-identical, 14 confirmed by peer review.

- fn_19436 CNavi_Link::`scalar deleting destructor': logic confirmed by peer review
- fn_19483 CNavi_Link::GetCell: logic confirmed by peer review
- fn_19497 CNavi_Link::GetInfo: logic confirmed by peer review
- fn_19387 CNaviData::SetDestination: logic confirmed by peer review
- fn_19638 CNavigationManager::UpdateGround: logic confirmed by peer review
- fn_19364 CNaviData::CNaviData: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review
- fn_19429 CNaviInfo::~CNaviInfo: logic confirmed by peer review
- fn_19551 CNavigationManager::CNavigationManager: logic confirmed by peer review
- fn_19574 CNavigationManager::ClearRouteNodes: logic confirmed by peer review
- fn_19575 CNavigationManager::ClearNodePaths: logic confirmed by peer review
- fn_19593 CNavigationManager::Reset: logic confirmed by peer review
- fn_45448 CNavigationManager::~CNavigationManager: logic confirmed by peer review
- fn_45452 CNavigationManager::GetLinkedPlayerInfo: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 17:40:11 +00:00
ragnarok-clanker
dfadb24ce5 Decompile 5 functions in Source/Contents/NavigationLink.cpp, Source/Contents/NavigationManager.h, ...
Batch #1541 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_19473 CNavi_Link::GetTitle: byte-identical
- fn_19475 CNavi_Link::GetName: byte-identical
- fn_19487 CNavi_Link::GetIndex: byte-identical
- fn_19492 CNavi_Link::GetType: byte-identical
- fn_19494 CNavi_Link::GetId: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/NavigationLink.cpp
2026-10-28 17:38:51 +00:00
ragnarok-clanker
3c5e940a6d Decompile 31 functions in Source/Contents/NavigationManager.h, Source/Contents/NavigationRequest.cpp, ...
Batch #1503 by ragnarok-clanker: 12 byte-identical, 19 confirmed by peer review.

- fn_19461 CNavi_Object::GetFlag: logic confirmed by peer review
- fn_19474 CNavi_Object::GetTitle: byte-identical
- fn_19476 CNaviInfo::GetTitle: byte-identical
- fn_19477 CNavi_Object::GetName: byte-identical
- fn_19484 CNavi_Object::GetCell: logic confirmed by peer review
- fn_19485 CNaviInfo::GetName: byte-identical
- fn_19488 CNavi_Object::GetIndex: byte-identical
- fn_19493 CNavi_Object::GetType: byte-identical
- fn_19495 CNavi_Object::GetId: byte-identical
- fn_19498 CNavi_Object::GetInfo: byte-identical
- fn_19376 CNavigationManager::FindObject: logic confirmed by peer review
- fn_19378 CNaviData::GetCell: logic confirmed by peer review
- fn_19380 CNaviData::GetInfo: byte-identical
- fn_19430 CNavi_Object::~CNavi_Object: logic confirmed by peer review
- fn_19434 CNaviInfo::HasName: logic confirmed by peer review
- fn_19604 CNavigationManager::SelectedNodeText: logic confirmed by peer review
- fn_19605 CNavigationManager::SubDestinationText: logic confirmed by peer review
- fn_19606 CNavigationManager::DestinationText: logic confirmed by peer review
- fn_19607 CNavigationManager::DestinationTitle: logic confirmed by peer review
- fn_19613 CNavigationManager::LoadSettings: logic confirmed by peer review
- fn_19618 CNavigationManager::FitToSquare: logic confirmed by peer review
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19588 CNavigationManager::GetCurrentTarget: logic confirmed by peer review
- fn_19589 CNavigationManager::GetCurrentTargetName: logic confirmed by peer review
- fn_19590 CNavigationManager::GetSavedTarget: logic confirmed by peer review
- fn_19591 CNavigationManager::GetDestinationInfo: byte-identical
- fn_19592 CNavigationManager::GetDestinationCell: logic confirmed by peer review
- fn_19594 CNavigationManager::ClearData: logic confirmed by peer review
- fn_19596 CNavigationManager::IsCurrentTarget: logic confirmed by peer review
- fn_19597 CNavigationManager::GetCurrentTargetType: byte-identical
- fn_19635 CNavigationManager::SaveCurrentTarget: byte-identical

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/NavigationRequest.cpp
2026-10-28 17:20:17 +00:00