Merged directly by the admin, bypassing peer review, because part of the
original function was overwritten by the client's protector and can never
match. Task 16009 is marked done on purpose; do not resubmit it.
- Jump table 0xAD29E4: modes 0/1 go to 0xAD1E58, now "jmp 0x027AB0FE" into
an empty protector stub. Bytes 0xAD1E58..0xAD237D are garbage.
- The rest of case 0/1 survives from 0xAD237E (g_serviceFlag07 = 29,
strstr(g_launchServerName, "QmSakray"), key/address pair, StringFormat
into g_serviceAddress, then the admin/monster-job tail); ported as is.
- Live WinDbg run (servertype=primary): 0xAD1C90 is never called; the
protector loader in .data6 (sub_3DE8027) replaces it at runtime.
- Based on attempt 57915 (batch 10359), with g_session.unknown_58FA replaced
by g_launchServerName (same address, 0x1737F32). Key/string decryption
verified against the binary. td check --includers: no errors.
Batch #10183 by ragnarok-clanker: forced by an admin (6 lower score(s), 50 changed function(s)); checked with 115 compiled unit(s), including every includer of Source/Client/Input/InputCharset.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/UI/Chat/ChatNotifications.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Text/TextWrapping.h, Source/Client/Input/ImeInput.h.
Deletes: Source/Client/Input/ImeInput.h
Batch #9151 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_17811 InitializeLanguage: logic confirmed by peer review
Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #9132 by ragnarok-clanker: forced by an admin (2 lower score(s), 13 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/Contents/ForbiddenWords.h, Source/Contents/Party/PartyInvitation.h, Source/File/CommonObject.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIPetInfoWnd.h.
Batch #8613 by youko: 0 byte-identical, 1 confirmed by peer review.
- fn_17818 ReadClientInfo: logic confirmed by peer review
Peer-reviewed-by: eAthena, Tanke
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #5836 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_17810 sub_AD1270: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, KWDev, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #5870 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_17809 LoadLoadingScreens: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, KWDev, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #5400 by Yommy: 1 byte-identical, 3 confirmed by peer review.
- fn_45450 SuggestChatCommand: logic confirmed by peer review
- fn_17806 SubACFCE0: byte-identical
- fn_17807 GetLicenceText: logic confirmed by peer review
- fn_17808 InitializeServiceStrings: logic confirmed by peer review
Peer-reviewed-by: willerthal, SapitoSucio, ragnarok-clanker, tayoba, bigodeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #1570 by ragnarok-clanker: no function's compiled code changes; checked with 5 compiled unit(s), including every includer of Source/Client/Application/Launcher.h, Source/Client/Input/InputCharset.h.
Batch #1019 by ragnarok-clanker: no function's compiled code changes; checked with 1 compiled unit(s), including every includer of Source/Contents/Configuration/ServiceConfiguration.h.
Adds to the build: Source/Contents/Configuration/ServiceConfiguration.cpp
