Commit graph

11 commits

Author SHA1 Message Date
ragnarok-clanker
8ba9c6719a Maintenance: [forced, user-approved] Family F2a (first half of UIWindowContext removal; coordinator-approved bridge split because F2
Batch #10217 by ragnarok-clanker: forced by an admin (236 lower score(s), 885 changed function(s)); checked with 558 compiled unit(s), including every includer of Source/Client/Mode/ModeTooltip.h, Source/Contents/SignBoard/SignBoard.h, Source/UI/Acceptance/UIJoinPartyAcceptWnd.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBasicButton.h, Source/UI/Buttons/UIBitmapButton.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UINoneVisibleButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIRadioButton.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIDisconnectedServerMsgWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UINoticeConfirmWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIPetTamingDeceiveWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIToolTipWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Dialogs/UIWaitWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Enchant/EnchantUI.h, Source/UI/EntryQueue/UIEntryQueueWnd.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UINotifyItemObtainWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBox.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIComboBoxEx.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIComboBoxWnd.h, Source/UI/Lists/UIDropDownBox.h, Source/UI/Lists/UIItemStoreComboBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxNavi.h, Source/UI/Lists/UIListBoxNaviSearch.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UIPackageBoxNameList.h, Source/UI/Lists/UIReplayListBox.h, Source/UI/Lists/UIScrollBar.h, Source/UI/Lists/UIScrollBarNavi.h, Source/UI/Lists/UIScrollBarVariants.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UIThumb.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIMiniPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRecommendedQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantItemWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shop/UInCash_CallWnd.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UICharInfoBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIStaticText_LF.h, Source/UI/Text/UIString.h, Source/UI/Text/UITagTextViewer.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITextViewerControl.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UIRoundBoxTooltipWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMessageBoxAutoreturn.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINormalMB.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPadding.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIResizer.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UITab.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWordDisplayWnd.h.
2026-11-03 00:23:34 +00:00
ragnarok-clanker
d95073881e Maintenance: [forced, user-approved] Family D4: ConvertChat (fn_12605, 0x91B800, kept in UITextViewerLinks.cpp) is a UINewChatWnd met
Batch #10205 by ragnarok-clanker: forced by an admin (1 lower score(s), 12 changed function(s)); checked with 29 compiled unit(s), including every includer of Source/UI/Chat/UINewChatWnd.h, Source/UI/Text/UITextViewer.h.
2026-11-02 22:16:40 +00:00
ragnarok-clanker
0029665586 Maintenance: Stage 0 resubmit (identical to #10090; that and #10084 failed only on Source/Client/Session.cpp with an empty log, consi
Batch #10096 by ragnarok-clanker: forced by an admin (72 lower score(s), 364 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/UI/Window/UIWindow.h.
2026-11-02 16:03:53 +00:00
ragnarok-clanker
d6bc9836d7 Maintenance: [forced, admin decision] Collapse the WindowManagerWindows adapter into UIWindowMgr, stage 1 of 2 (project decision: por
Batch #10019 by ragnarok-clanker: forced by an admin (23 lower score(s), 187 changed function(s)); checked with 447 compiled unit(s), including every includer of Source/Client/Input/Language.h, Source/Client/Mode/ModeDragState.h, Source/Contents/Async/AsyncWorkMgr.h, Source/Contents/Emblems/EmblemCache.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/Party/AgencyRequestContext.h, Source/Contents/Party/ChangePartyMasterAsyncWork.h, Source/Contents/Party/LoadMyPartyAsyncWork.h, Source/Contents/Party/LoadPartyInfoAsyncWork.h, Source/Contents/Party/LoadPartyListAsyncWork.h, Source/Contents/Party/PartyInvitation.h, Source/Contents/Party/RegisterPartyAsyncWork.h, Source/Contents/Party/StopRecruitingAsyncWork.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/UserData/CharacterConfigLoad.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Chat/ChatSuggestions.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Lists/UIListBox.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shortcuts/NormalItemSlotLoad.h, Source/UI/Shortcuts/ShortcutDetails.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/UIBasicCtrl.h, Source/UI/UIStaticItem.h, Source/UI/Window/FrameFocus.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/WindowManagerWindows.h, Source/UI/Window/WindowMouseHit.h, Source/UI/Window/WindowOrdering.h.
2026-11-02 14:09:20 +00:00
ragnarok-clanker
50558b0a31 Decompile fn_12911 (UIQuestDisplay::Paint)
Batch #8567 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_12911 UIQuestDisplay::Paint: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, superintelligence, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 22:46:54 +00:00
ragnarok-clanker
0c10747096 Decompile 12 functions in Source/UI/Quest/UIQuestDisplay.cpp, Source/UI/Quest/UIQuestDisplay.h, ...
Batch #7711 by secret: 0 byte-identical, 12 confirmed by peer review.

- fn_12846 UIAccountLimitedToolWnd::UIAccountLimitedToolWnd: logic confirmed by peer review
- fn_12847 UIBalloonOpenBtn::UIBalloonOpenBtn: logic confirmed by peer review
- fn_12848 UIDebuffRemoveWnd::UIDebuffRemoveWnd: logic confirmed by peer review
- fn_12850 UIMileageWnd::UIMileageWnd: logic confirmed by peer review
- fn_12852 UINoteWnd::UINoteWnd: logic confirmed by peer review
- fn_12853 UIOpenMailBoxWnd::UIOpenMailBoxWnd: logic confirmed by peer review
- fn_12854 UIOpenRoulletteWnd::UIOpenRoulletteWnd: logic confirmed by peer review
- fn_12855 UIQuestDisplay::UIQuestDisplay: logic confirmed by peer review
- fn_12856 UIRPImageWnd2::UIRPImageWnd2: logic confirmed by peer review
- fn_12857 UISecondCostumeWnd::UISecondCostumeWnd: logic confirmed by peer review
- fn_12858 UIShowWarpWnd::UIShowWarpWnd: logic confirmed by peer review
- fn_12859 UITransMenuWnd::UITransMenuWnd: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 11:28:47 +00:00
ragnarok-clanker
3b90ef136e Decompile fn_12887 (UIQuestDisplay::Slot08)
Batch #5413 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_12887 UIQuestDisplay::Slot08: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-30 11:22:34 +00:00
ragnarok-clanker
805dfefac4 Decompile 2 functions in Source/UI/Window/UINormalMB.cpp, Source/UI/Window/UINormalMB.h, ...
Batch #4883 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_12880 UINormalMB::Create: logic confirmed by peer review
- fn_12881 UIQuestDisplay::Create: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 05:35:47 +00:00
ragnarok-clanker
1ff6ad3bf7 Decompile 23 functions in Source/UI/Quest/UIQuestDisplay.cpp, Source/UI/Quest/UIQuestDisplay.h, ...
Batch #4400 by youko: 8 byte-identical, 15 confirmed by peer review.

- fn_12912 UIRPImageWnd2::Paint: logic confirmed by peer review
- fn_12914 UIShowWarpWnd::Paint: byte-identical
- fn_12916 UITransMenuWnd::Paint: logic confirmed by peer review
- fn_12917 UIDebuffRemoveWnd::Slot25: byte-identical
- fn_12918 UIMileageWnd::Slot25: byte-identical
- fn_12919 UINoteWnd_Scroll::Slot25: logic confirmed by peer review
- fn_12920 UIStaticText_LF::Slot25: logic confirmed by peer review
- fn_12921 UITransMenuWnd::Slot25: logic confirmed by peer review
- fn_12922 UIDebuffRemoveWnd::Slot31: byte-identical
- fn_12923 UIMileageWnd::Slot31: logic confirmed by peer review
- fn_12924 UINoteWnd_Scroll::Slot31: logic confirmed by peer review
- fn_12925 UIStaticText_LF::Slot31: logic confirmed by peer review
- fn_12926 UIMileageWnd::Slot28: logic confirmed by peer review
- fn_12927 UIOpenMailBoxWnd::Slot53: byte-identical
- fn_12928 UIDebuffRemoveWnd::Slot27: byte-identical
- fn_12929 UIMileageWnd::Slot27: byte-identical
- fn_12930 UITransMenuWnd::Slot27: logic confirmed by peer review
- fn_12932 UIMileageWnd::Slot19: logic confirmed by peer review
- fn_12933 UIOpenRoulletteWnd::Slot19: byte-identical
- fn_12934 UIQuestDisplay::Slot33: logic confirmed by peer review
- fn_12935 UINoteWnd_Scroll::Slot35: logic confirmed by peer review
- fn_12936 UIStaticText_LF::Slot35: logic confirmed by peer review
- fn_12937 UITransMenuWnd::Resize: logic confirmed by peer review

Peer-reviewed-by: eAthena, KWDev
Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/Text/UIStaticText_LF.cpp, Source/UI/Window/UINoteWnd.cpp, Source/UI/Window/UIRPImageWnd2.cpp, Source/UI/Window/UIShowWarpWnd.cpp
2026-10-30 03:41:58 +00:00
ragnarok-clanker
ece826f671 Decompile fn_12947 (UIQuestDisplay::SendMsg)
Batch #4113 by bigodeira: 0 byte-identical, 1 confirmed by peer review.

- fn_12947 UIQuestDisplay::SendMsg: logic confirmed by peer review

Peer-reviewed-by: youko, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:04:29 +00:00
ragnarok-clanker
25829488c2 Decompile 10 functions in Source/UI/Guild/UIGuild_Storage_Log.cpp, Source/UI/Guild/UIGuild_Storage_Log.h, ...
Batch #3603 by youko: 0 byte-identical, 10 confirmed by peer review.

- fn_12940 UIDebuffRemoveWnd::SendMsg: logic confirmed by peer review
- fn_12941 UIGuild_Storage_Log::SendMsg: logic confirmed by peer review
- fn_12942 UIMileageWnd::SendMsg: logic confirmed by peer review
- fn_12943 UINormalMB::SendMsg: logic confirmed by peer review
- fn_12945 UIOpenMailBoxWnd::SendMsg: logic confirmed by peer review
- fn_12946 UIOpenRoulletteWnd::SendMsg: logic confirmed by peer review
- fn_12948 UISecondCostumeWnd::SendMsg: logic confirmed by peer review
- fn_12950 UITransMenuWnd::SendMsg: logic confirmed by peer review
- fn_12952 UISecondCostumeWnd::RefreshList: logic confirmed by peer review
- fn_12953 UIQuestDisplay::Slot11: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence, jessip
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Guild/UIGuild_Storage_Log.cpp, Source/UI/Quest/UIQuestDisplay.cpp, Source/UI/Window/UIDebuffRemoveWnd.cpp, Source/UI/Window/UIMileageWnd.cpp, Source/UI/Window/UINormalMB.cpp, Source/UI/Window/UIOpenMailBoxWnd.cpp, Source/UI/Window/UIOpenRoulletteWnd.cpp, Source/UI/Window/UISecondCostumeWnd.cpp, Source/UI/Window/UITransMenuWnd.cpp
2026-10-29 22:57:13 +00:00