Commit graph

10 commits

Author SHA1 Message Date
ragnarok-clanker
648ae44d9d Decompile 2 functions in Source/Contents/AdventureGuideMgr.cpp, Source/Contents/AdventureGuideMgr.h, ...
Batch #1377 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05237 CAdventureGuideMgr::GetEpisodeList: logic confirmed by peer review
- fn_05238 CAdventureGuideMgr::GetContentsList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:06:16 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems)
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
2026-10-28 11:42:30 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
308cefc066 Decompile fn_23826 (CSession::SyncUnknown0E98)
Batch #1325 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23826 CSession::SyncUnknown0E98: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:10:19 +00:00
ragnarok-clanker
d7bd31b4a6 Decompile 5 functions in Source/Contents/PetStatus.cpp, Source/Client/Session.h
Batch #1190 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_23806 CSession::GetPetActionNumber: logic confirmed by peer review
- fn_23808 CSession::GetPetFriendlyState: logic confirmed by peer review
- fn_23809 CSession::GetPetFriendlyStateString: logic confirmed by peer review
- fn_23810 CSession::GetPetHungryState: logic confirmed by peer review
- fn_23817 CSession::GetPetEmotionNumber: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStatus.cpp
2026-10-27 21:08:12 +00:00
ragnarok-clanker
22ebefe099 Decompile 4 functions in Source/Contents/PetStrings.cpp, Source/Client/Session.h
Batch #1192 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23807 CSession::GetPetFood: logic confirmed by peer review
- fn_23812 CSession::GetPetIllustName: logic confirmed by peer review
- fn_23813 CSession::GetPetJobByEggItem: logic confirmed by peer review
- fn_23816 CSession::GetPetString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStrings.cpp
2026-10-27 21:07:55 +00:00
ragnarok-clanker
ab4477de24 Decompile 7 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h
Batch #1179 by eAthena: 7 byte-identical, 0 confirmed by peer review.

- fn_23754 CSession::ClearItemQuantities: byte-identical
- fn_23755 CSession::ResetItems3500: byte-identical
- fn_23756 CSession::ClearSlots06EB: byte-identical
- fn_23757 CSession::ClearShortcutSlots: byte-identical
- fn_23758 CSession::ClearSecondaryShortcutSlots: byte-identical
- fn_23759 CSession::ClearUnknown0420: byte-identical
- fn_23774 CSession::CountItems5C68: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:58:12 +00:00
ragnarok-clanker
4d9d775cc8 Decompile 3 functions in Source/Contents/World/WorldSpatialTree.cpp, Source/Contents/World/WorldSpatialTree.h, ...
Batch #995 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_17651 WorldScene::WorldScene: logic confirmed by peer review
- fn_17654 WorldScene::~WorldScene: logic confirmed by peer review
- fn_17704 WorldSpatialTree::RefreshModelBounds: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:51:12 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00