clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
444 commits 1 branch 0 tags 11 MiB
Commit graph

22 commits

Author SHA1 Message Date
ragnarok-clanker
c934fe7820 Decompile 2 functions in Source/UI/Shortcuts/ShortcutCooldowns.cpp, Source/Client/Session.h 
Batch #1653 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23876 CSession::IsSkillIdInRange6018: logic confirmed by peer review
- fn_23877 CSession::IsSkillIdInRange6001: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
 2026-10-28 19:47:58 +00:00
ragnarok-clanker
4bce141e4c Decompile fn_23811 (CSession::GetPetHungryStateString) 
Batch #1625 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23811 CSession::GetPetHungryStateString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 19:45:56 +00:00
ragnarok-clanker
6ebe295226 Decompile fn_23814 (CSession::GetPetTalkName) 
Batch #1621 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23814 CSession::GetPetTalkName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetTalkNames.cpp
 2026-10-28 19:45:23 +00:00
ragnarok-clanker
499d5b8558 Decompile 2 functions in Source/Contents/MonsterResources.cpp, Source/Client/Session.h 
Batch #1608 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23790 CSession::GetMonsterSprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterResources.cpp
 2026-10-28 19:44:03 +00:00
ragnarok-clanker
b496a618dc Decompile 2 functions in Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp, ... 
Batch #1582 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23486 CSession::GetRobeAlpha: logic confirmed by peer review
- fn_24176 CSession::IsTopLayerRobe: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp
 2026-10-28 19:10:37 +00:00
ragnarok-clanker
3d4b2c79dc Decompile 2 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UIMerInfoWnd.h, ... 
Batch #1553 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11712 UIBank_NewWnd::TransactionAmount: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 18:50:35 +00:00
ragnarok-clanker
943d22d0b8 Decompile fn_11762 (UICntWnd::Paint) 
Batch #1544 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_11762 UICntWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 17:58:13 +00:00
ragnarok-clanker
16b72c624f Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ... 
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 15:32:17 +00:00
ragnarok-clanker
447fa8b9f6 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ... 
Batch #1470 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23590 IsVisibleJob: logic confirmed by peer review
- fn_23841 GetWeaponViewValue: logic confirmed by peer review
- fn_23906 ResetHotkeySlots: logic confirmed by peer review
- fn_23910 CSession::SetPairValue: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 14:13:00 +00:00
ragnarok-clanker
c351db5d57 Decompile 4 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h 
Batch #1467 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23466 CSession::GetServerTime: logic confirmed by peer review
- fn_23605 CSession::AddPingSample: logic confirmed by peer review
- fn_23637 CSession::SetServerTime: logic confirmed by peer review
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/ClientTiming.cpp
 2026-10-28 14:02:41 +00:00
ragnarok-clanker
b9474e7c82 Decompile fn_23379 (CSession::HomunSkillLevel) 
Batch #1465 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23379 CSession::HomunSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 13:55:33 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ... 
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
 2026-10-28 12:59:53 +00:00
ragnarok-clanker
648ae44d9d Decompile 2 functions in Source/Contents/AdventureGuideMgr.cpp, Source/Contents/AdventureGuideMgr.h, ... 
Batch #1377 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05237 CAdventureGuideMgr::GetEpisodeList: logic confirmed by peer review
- fn_05238 CAdventureGuideMgr::GetContentsList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:06:16 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems) 
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
 2026-10-28 11:42:30 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ... 
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-28 10:35:18 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard) 
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 10:19:34 +00:00
ragnarok-clanker
308cefc066 Decompile fn_23826 (CSession::SyncUnknown0E98) 
Batch #1325 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23826 CSession::SyncUnknown0E98: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 10:10:19 +00:00
ragnarok-clanker
d7bd31b4a6 Decompile 5 functions in Source/Contents/PetStatus.cpp, Source/Client/Session.h 
Batch #1190 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_23806 CSession::GetPetActionNumber: logic confirmed by peer review
- fn_23808 CSession::GetPetFriendlyState: logic confirmed by peer review
- fn_23809 CSession::GetPetFriendlyStateString: logic confirmed by peer review
- fn_23810 CSession::GetPetHungryState: logic confirmed by peer review
- fn_23817 CSession::GetPetEmotionNumber: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStatus.cpp
 2026-10-27 21:08:12 +00:00
ragnarok-clanker
22ebefe099 Decompile 4 functions in Source/Contents/PetStrings.cpp, Source/Client/Session.h 
Batch #1192 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23807 CSession::GetPetFood: logic confirmed by peer review
- fn_23812 CSession::GetPetIllustName: logic confirmed by peer review
- fn_23813 CSession::GetPetJobByEggItem: logic confirmed by peer review
- fn_23816 CSession::GetPetString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStrings.cpp
 2026-10-27 21:07:55 +00:00
ragnarok-clanker
ab4477de24 Decompile 7 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h 
Batch #1179 by eAthena: 7 byte-identical, 0 confirmed by peer review.

- fn_23754 CSession::ClearItemQuantities: byte-identical
- fn_23755 CSession::ResetItems3500: byte-identical
- fn_23756 CSession::ClearSlots06EB: byte-identical
- fn_23757 CSession::ClearShortcutSlots: byte-identical
- fn_23758 CSession::ClearSecondaryShortcutSlots: byte-identical
- fn_23759 CSession::ClearUnknown0420: byte-identical
- fn_23774 CSession::CountItems5C68: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 20:58:12 +00:00
ragnarok-clanker
4d9d775cc8 Decompile 3 functions in Source/Contents/World/WorldSpatialTree.cpp, Source/Contents/World/WorldSpatialTree.h, ... 
Batch #995 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_17651 WorldScene::WorldScene: logic confirmed by peer review
- fn_17654 WorldScene::~WorldScene: logic confirmed by peer review
- fn_17704 WorldSpatialTree::RefreshModelBounds: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 08:51:12 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals 
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
 2026-10-26 18:34:25 +00:00