Commit graph

7 commits

Author SHA1 Message Date
ragnarok-clanker
854a0e32fb Maintenance: Name numeric switch case labels with enum constants (identifier-only; no code change). 13,500+ case labels across 70 uni
Batch #14886 by ragnarok-clanker: no function's compiled code changes; checked with 225 compiled unit(s), including every includer of Source/Contents/Combat/CombatTypes.h, Source/Contents/Effects/EffectMessageId.h, Source/Contents/Items/InventoryType.h, Source/Contents/Items/ItemId.h, Source/Contents/Jobs/JobId.h, Source/Contents/MessageTable.h, Source/Contents/Skills/SkillId.h, Source/Contents/Skills/SkillUnitId.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/GameSettings/TalkType.h, Source/UI/Window/WindowId.h.
2026-11-07 23:58:37 +00:00
ragnarok-clanker
3fa014f408 Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp
Batch #11585 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review.

- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18383 PacketLengths::PacketLengths: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, cremane, KWDev, Tanke, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 03:42:59 +00:00
ragnarok-clanker
68442f7e23 Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp
Batch #11407 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_20391 PacketLengths::FixedLength: byte-identical (already on main)
- fn_18388 PacketLengths::Lookup: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 00:04:46 +00:00
ragnarok-clanker
04662f3c3e Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp
Batch #11222 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_18385 PacketLengths::Register: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 22:34:40 +00:00
ragnarok-clanker
6f3ef794d3 Decompile 2 functions in Source/Network/Packets/PacketLengths.cpp, Source/Network/Packets/PacketLengths.h
Batch #1603 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_18384 PacketLengths::~PacketLengths: logic confirmed by peer review
- fn_18385 PacketLengths::Register: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:43:09 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ...
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:45:10 +00:00
ragnarok-clanker
a47d20f8be Reconstruct readable C++ and organize cohesive source subsystems
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.

Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00
Renamed from Source/Network/PacketLengths.cpp (Browse further)