TableMng.cpp redeclared a partial, mismatched YExcel API (CompoundDocument
instead of YCompoundFiles::CompoundFile, SetIntegerAlt/SetWStringAlt instead
of BasicExcelCell::Set(int)/Set(const wchar_t*), non-const getters, int
GetTotalRows/GetTotalCols, New(size_t)), so nothing could define it. The
YExcel span was already skipped as runtime_library code.
- ThirdParty/BasicExcel: Yap Chun Wei's public-domain BasicExcel 1.14.
Matches the binary: sizeof(CompoundFile)=0x330, workbook_ at 0x330,
worksheets_ at 0x488, yesheets_ at 0x494, BasicExcelCell 0x28, Workbook()
BOF constants 0x50600/0x7CD19A0/0xC0C9/0x306. Local changes:
- BasicExcel gains unknown_04A0[0x108]: all four operator new calls in
the original allocate 0x5A8, no code reads the tail.
- the default constructor is defined by TableMng.cpp (fn_20498).
- operator<<(wchar_t*) keeps its pre-C++20 overload explicitly.
- TableMng.cpp includes the real header; scores of its 13 functions are
unchanged (td check).
- data/compile.json: shape 4 gets -I ThirdParty/BasicExcel; the library is
shape 11 (shape 8 without the jsoncpp defines/include).
CRC32, FileSignatureVerifier, GGHash, MD5 and Hash/MD5 are the objects at 0x401000-0x403960, built by an older compiler: 0 of 152 functions there use an ebp frame and all 21 /GS cookies use the esp form, with /EHs-style FuncInfo. Shape 10 is shape 0 without /Oy- and with /EHsc. Dry run on the server compilers: 40 functions, mean 48.3% -> 60.2%, 27 up, 3 down (fn_00144 0.53 -> 0.25, fn_00116, fn_00117 by < 0.011), exact unchanged.
Main is clean (07897c8b): every FUNCTION line has its address right
above it. offsetAnnotations makes the submission gate keep it that way.
CODING_RULES section 2: OFFSET goes on the line directly above each
FUNCTION line, never without one, with no blank line in the block;
several IDs on one body only for template instances.
Batch #10386 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.
- fn_12750 UINewChatWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: dori, cremane, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Chat/UINewChatWnd.cpp
Batch #8978 by youko: 0 byte-identical, 2 confirmed by peer review.
- fn_11300 UIChatHisBox::ResolvePlayerTags: logic confirmed by peer review
- fn_11581 UIChatHisBox::sub_89C080: logic confirmed by peer review
Peer-reviewed-by: gordaoprogramas, pedrao, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Lists/UIChatHisBox.cpp
Batch #8533 by youko: 0 byte-identical, 3 confirmed by peer review.
- fn_03536 UINavigationRuideWnd::UINavigationRuideWnd: logic confirmed by peer review
- fn_03537 UINavigationV4Wnd::UINavigationV4Wnd: logic confirmed by peer review
- fn_03538 UINavigationroadiconWnd::UINavigationroadiconWnd: logic confirmed by peer review
Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Navigation/UINavigationV4Wnd.cpp
Batch #8482 by youko: 0 byte-identical, 1 confirmed by peer review.
- fn_17682 CWorld::LoadMapEffects: logic confirmed by peer review
Peer-reviewed-by: KWDev, Romain, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/World/WorldEffects.cpp
fn_20088 (0x00C2CF20) is CRagEffect::OnProcess, the 415-value effect-type dispatch (CRagEffect vtable slot 1).
PartyEffect.cpp held only its case 160 as a free function UpdatePartyEffect with an invented signature
(score 0.4%, nothing called it). Removed so the function is open work again instead of counting as done.
Batch #8103 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_17119 UIWindowMgr::AddMiniPartyWindow: logic confirmed by peer review
Peer-reviewed-by: Yommy, secret, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIWindowFactory.cpp
Batch #7979 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_10664 UIEditCtrl_OldList::UIEditCtrl_OldList: logic confirmed by peer review
- fn_10681 UIWhisperEditCtrl::UIWhisperEditCtrl: logic confirmed by peer review
Peer-reviewed-by: eAthena, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Edit/UIEditCtrl_OldList.cpp, Source/UI/Edit/UIWhisperEditCtrl.cpp
Batch #7690 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_21275 CGameMode::BuildActorEntryPacket: logic confirmed by peer review
Peer-reviewed-by: Yommy, secret, Snow, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/EntityInit.cpp
Batch #7832 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_14008 AdventureGuide::CUISubTab::Slot15: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Yommy, secret, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UILocaleTextWnd.cpp
Batch #7802 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_12525 UISeekPartyWnd::UISeekPartyWnd: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, Yommy, secret
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UISerachStoreInfoWnd.cpp
Batch #7764 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_11068 UIRPImageWnd::UIRPImageWnd: logic confirmed by peer review
Peer-reviewed-by: Yommy, secret, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIRPImageWnd.cpp
Batch #7474 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_10104 CCharacterRender::RenderRobe: logic confirmed by peer review
- fn_10105 CCharacterRender::RenderRobeCommands: logic confirmed by peer review
Peer-reviewed-by: secret, meitogi, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/SpriteRobe.cpp, Source/Contents/SpriteRobeCommands.cpp
Batch #7443 by eAthena: 0 byte-identical, 3 confirmed by peer review.
- fn_21289 CGameMode::RefreshActorJobEffects: logic confirmed by peer review
- fn_13737 UIWindowMgr::ResetUIRectInfo: logic confirmed by peer review
- fn_11325 UIItemStoreComboBoxWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, superintelligence, kyoshi, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeActorEffects.cpp, Source/UI/Lists/UIItemStoreComboBox.cpp
Batch #7433 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_13804 UINewSkillListWnd::SkillIndexAt: logic confirmed by peer review
Peer-reviewed-by: meitogi, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UINewSkillListWndHitTest.cpp
Batch #7426 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.
- fn_21831 CGameMode::ReceiveEquipListPart: logic confirmed by peer review
Peer-reviewed-by: eAthena, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeItemLists.cpp
Batch #7225 by aDw: 0 byte-identical, 2 confirmed by peer review.
- fn_12891 UIBalloonOpenBtn::Slot15: logic confirmed by peer review
- fn_12892 UIDebuffRemoveWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: eAthena, alisonrag, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIZeroChatWnd.cpp
Batch #6883 by alisonrag: 0 byte-identical, 1 confirmed by peer review.
- fn_12451 UIPasswordWnd::sub_90C970: logic confirmed by peer review
Peer-reviewed-by: eAthena, superintelligence, Landruca
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Dialogs/UIPasswordWnd.cpp
Batch #6691 by Montyla: 0 byte-identical, 2 confirmed by peer review.
- fn_11543 UIComboBox::SendMsg: logic confirmed by peer review
- fn_11546 UIComboBoxID::SendMsg: logic confirmed by peer review
Peer-reviewed-by: eAthena, Tanke, superintelligence, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Lists/UIComboBox.cpp
Batch #6531 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.
- fn_07746 RDamageVar::~RDamageVar: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/RDamageVar.cpp
Batch #6510 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.
- fn_12758 UISelCharForUServerWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, superintelligence, kyoshi, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UISelCharForUServerWnd.cpp
Batch #6507 by Montyla: 0 byte-identical, 2 confirmed by peer review.
- fn_17199 CUIRegisterMgr::sub_A970A0: logic confirmed by peer review
- fn_17205 UIWindowMgr::sub_A97580: logic confirmed by peer review
Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIRegisterMgr.cpp
Batch #6494 by Montyla: 0 byte-identical, 2 confirmed by peer review.
- fn_11947 UIItemParamChangeDisplayWnd::UIItemParamChangeDisplayWnd: logic confirmed by peer review
- fn_11954 UIMinimapZoomWnd::UIMinimapZoomWnd: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, superintelligence, SapitoSucio, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Items/UIItemParamChangeDisplayWnd.cpp, Source/UI/Dialogs/UIMinimapZoomWnd.cpp
Batch #6406 by eAthena: 0 byte-identical, 4 confirmed by peer review.
- fn_23793 CSession::GetPetTargetAid: logic confirmed by peer review
- fn_24365 ApplyAiPatch: logic confirmed by peer review
- fn_21743 CGameMode::ReceiveEquipWindowMicroscope: logic confirmed by peer review
- fn_21919 UIItemStoreWnd::SetTitle: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeEquipWindow.cpp, Source/UI/Item/UIItemStoreWnd.cpp
Batch #6367 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_23498 CSession::LoadMapNameTable: logic confirmed by peer review
Peer-reviewed-by: alisonrag, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/MapNameTable.cpp
Batch #6229 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_10902 UIEditCtrl3::UpdateScrollBar: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Edit/UIEditCtrl3.cpp
Batch #6218 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_21368 CGameMode::UpdateReplayPause: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeReplay.cpp
Batch #6425 by eAthena: 0 byte-identical, 3 confirmed by peer review.
- fn_19997 CEffectPrim::RenderLaunchEffects: logic confirmed by peer review
- fn_19998 CEffectPrim::RenderGroundSprite: logic confirmed by peer review
- fn_19999 CEffectPrim::RenderSegmentSpriteTrail: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Effects/EffectPrimitiveSprites.cpp
Batch #6165 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_23736 CSession::AddUnknown6160: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/SessionAchievements.cpp
Batch #6347 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_11993 CSecondPwdRandom::~CSecondPwdRandom: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Security/SecondPwdRandom.cpp
Batch #6139 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_24173 CSession::LoadSkillDelayList: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, superintelligence, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/SessionState.cpp
Batch #6309 by gordaoprogramas: 0 byte-identical, 1 confirmed by peer review.
- fn_11919 MaxInt64: logic confirmed by peer review
Peer-reviewed-by: alisonrag, superintelligence, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Utility/Math/Int64Math.cpp
Batch #6306 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_11244 UIComboBoxID::Configure: logic confirmed by peer review
- fn_11247 UIListBoxID::Configure: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Lists/UIListBoxID.cpp
Batch #6288 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_18416 TigerCompress: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, superintelligence, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Utility/Cipher/Tiger.cpp
Batch #6137 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_21828 ShortcutCooldowns::LoadRecords: logic confirmed by peer review
- fn_21830 CGameMode::ReceiveSound: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, superintelligence, KWDev, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/GameModeSounds.cpp
Batch #6225 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_12341 UIEmailAddressWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, superintelligence, KWDev, Romain
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Dialogs/UIEmailAddressWnd.cpp
Batch #6205 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_12833 UISeekPartyWnd::SetJobs: logic confirmed by peer review
- fn_12834 UIJobListWnd::RefreshJobs: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, System4z, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UISeekPartyWnd.cpp
Batch #6151 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_22311 CLoginMode::ReceiveBillingInfo: logic confirmed by peer review
- fn_22312 CLoginMode::ReceiveNotifyBan: logic confirmed by peer review
Peer-reviewed-by: alisonrag, superintelligence, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Client/Mode/LoginModeNotices.cpp
Batch #6244 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_19996 CEffectPrim::RenderTwinGlowSquares: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Effects/EffectPrimitiveGlowSquares.cpp
Batch #6239 by eAthena: 0 byte-identical, 3 confirmed by peer review.
- fn_19995 CEffectPrim::RenderFoldingRibbon: logic confirmed by peer review
- fn_20002 CEffectPrim::RenderStandingPanels: logic confirmed by peer review
- fn_20003 CEffectPrim::RenderHoverSquares: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, Wizi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Effects/EffectPrimitivePanels.cpp
Batch #6233 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_11995 UIChooseWnd::`scalar deleting destructor': logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Dialogs/UIChooseWnd.cpp
Batch #6224 by eAthena: 0 byte-identical, 2 confirmed by peer review.
- fn_11794 UILoginWnd::OpenWebPage: logic confirmed by peer review
- fn_11795 UINoticeWnd::LoadNotice: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UILoginWnd.cpp, Source/UI/Window/UINoticeWnd.cpp
Batch #6204 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_23602 PreloadCommonSprites: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Resource/ResourcePreload.cpp
Batch #6130 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_12174 UIGraffiStrboxWnd::Slot15: logic confirmed by peer review
Peer-reviewed-by: alisonrag, Lumen, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Dialogs/UIGraffiStrboxWnd.cpp
