Commit graph

5 commits

Author SHA1 Message Date
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
7007feef0c Decompile fn_21595 (CGameMode::sub_D08910)
Batch #10444 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_21595 CGameMode::sub_D08910: logic confirmed by peer review

Peer-reviewed-by: secret, willerthal, KWDev, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 03:23:10 +00:00
ragnarok-clanker
e83c4def7d Maintenance: [forced, user-approved] Family V3: remove the invented view struct ClientItemLists (a copy of CSession's layout, declare
Batch #10280 by ragnarok-clanker: forced by an admin (0 lower score(s), 115 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Client/Session.h, Source/Contents/ClientItemLists.h.
Deletes: Source/Contents/ClientItemLists.h
2026-11-03 16:16:06 +00:00
ragnarok-clanker
946e920cf2 Decompile 3 functions in Source/Client/Mode/GameModePackets.cpp, Source/Client/Mode/CGameMode.h, ...
Batch #9711 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_23325 CSession::ClearPartyMembers: logic confirmed by peer review
- fn_21579 CGameMode::ChangeZoneServer: logic confirmed by peer review
- fn_21684 CGameMode::ReceivePartyMemberLeft: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag, youko, System4z, gordaoprogramas, Lumen, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 19:07:16 +00:00
ragnarok-clanker
11b441389e Decompile fn_17119 (UIWindowMgr::AddMiniPartyWindow)
Batch #8103 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17119 UIWindowMgr::AddMiniPartyWindow: logic confirmed by peer review

Peer-reviewed-by: Yommy, secret, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/UI/Window/UIWindowFactory.cpp
2026-10-31 14:04:10 +00:00