ragnarok-clanker
5ad8e0c58c
Maintenance: Resubmission of 16340 over main 047268c0 (conflict in UICashEmotionPack::GetPriceText resolved keeping main's new body).
...
Batch #16351 by ragnarok-clanker: no function's compiled code changes; checked with 784 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Browser/BrowserCommandTarget.h, Source/Client/Browser/BrowserDocumentUI.h, Source/Client/Browser/BrowserInPlace.h, Source/Client/Browser/WebBrowser.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Input/Mouse.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StovePCSDK.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClanInfo.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/ArrowEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/DummyEffectLauncher.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/EffectTypes.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MandraAttackEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/WhirlwindEffect.h, Source/Contents/EnchantMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/GuildInfo.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/RuneSystem.h, Source/Contents/MapSkyMgr.h, Source/Contents/Models/ModelActor.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/NavigationManager.h, Source/Contents/Party/PartyBookingMgr.h, Source/Contents/PetEvolutionMgr.h, Source/Contents/RenewQuestMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/Schedule/Schedule.h, Source/Contents/Schedule/ShutDownSchedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/WorldView/WorldViewData.h, Source/Network/Connection/Connection.h, Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Text/EmbedFont.h, Source/Render/Text/TextContext.h, Source/Render/Textures/Texture.h, Source/Resource/BinkRuntime.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/ResourceMgr.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Security/NProtectGameGuardMgr.h, Source/Security/ReassemblyPacketMgr.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowId.h, Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/JsonCppLoader.h, Source/Utility/Lexicon/LexiconSerializer.h, Source/Utility/NFileLog.h, Source/Utility/Threading/NThread.h.
2026-11-10 17:38:25 +00:00
ragnarok-clanker
4a79e63e7a
Decompile 2 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #15301 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_06594 ItemUnidentifiedName: logic confirmed by peer review
- fn_06583 ITEM_INFO::Element: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:41:47 +00:00
ragnarok-clanker
1856c8d930
Decompile 3 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #15300 by Yommy: 0 byte-identical, 3 confirmed by peer review.
- fn_06595 ITEM_INFO::HasCards: logic confirmed by peer review
- fn_06588 ITEM_INFO::Prefixes: logic confirmed by peer review
- fn_06587 ITEM_INFO::Suffixes: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, alisonrag, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 20:41:21 +00:00
ragnarok-clanker
c37707b8ac
Decompile 2 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #15103 by Yommy: 2 byte-identical, 0 confirmed by peer review.
- fn_06585 ITEM_INFO::Creator: byte-identical
- fn_06584 ITEM_INFO::Star: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-11-09 10:06:36 +00:00
ragnarok-clanker
c98aa49a75
Decompile 6 functions in Source/Render/DX9/TextureDX9.cpp, Source/Contents/Items/SelectPackageItemMgr.cpp, ...
...
Batch #15026 by KWDev: 6 byte-identical, 0 confirmed by peer review.
- fn_02476 CTextureDX9::CTextureDX9: byte-identical
- fn_04445 CSelectPackageItemMgr::AddTab: byte-identical
- fn_06577 ITEM_INFO::Grade: byte-identical
- fn_08121 CRuneSystemMgr::GetTagByIndex: byte-identical
- fn_23760 CSession::EraseUnknownKey: byte-identical
- fn_23794 CSession::GetAccessoryName: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-11-09 06:06:41 +00:00
ragnarok-clanker
dc3d5ce1a5
Maintenance: Resubmission of 14942 (gate: three existing in-class helpers whose lines changed lacked an annotation; marked // INLINED
...
Batch #14943 by ragnarok-clanker: no function's compiled code changes; checked with 741 compiled unit(s), including every includer of Source/ActorPickNode.h, Source/Client/Browser/BrowserClientSite.h, Source/Client/Browser/BrowserPopupDispatch.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Mode/CMode.h, Source/Client/Mode/ModeDragState.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Contents/AchievementMgr.h, Source/Contents/ActorNameCard.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/GroundScope.h, Source/Contents/Actors/Item.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/Camera/Camera.h, Source/Contents/Camera/CameraState.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AMachineEffect.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CaneOfEvilEyeEffect.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/CloudKillEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectMaker.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/FuumaShouakuEffect.h, Source/Contents/Effects/GravityControlEffect.h, Source/Contents/Effects/HealSpEffect.h, Source/Contents/Effects/Level99Effect.h, Source/Contents/Effects/MapChainEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/NyanggrassEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RectUpEffect.h, Source/Contents/Effects/ShadowExceedEffect.h, Source/Contents/Effects/SkillEffects.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StormCannonEffect.h, Source/Contents/Effects/ThrowEffects.h, Source/Contents/EntryQueueMgr.h, Source/Contents/EquipmentResourceMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/GuildInfo.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/MapSkyMgr.h, Source/Contents/Messenger/MessengerWindows.h, Source/Contents/Models/ModelNode.h, Source/Contents/NavigationManager.h, Source/Contents/Party/AdventurerAgencyMgr.h, Source/Contents/RDamageVar.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/RouletteMgr.h, Source/Contents/Schedule/Schedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/ClientSkills.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Skills/SkillInfo.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/TipBoxTitles.h, Source/Contents/UserData/AccountLinkedUserDataMgr.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/World/World.h, Source/Contents/WorldView/WorldViewData.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/Textures/SpritePixels.h, Source/Render/Textures/Texture.h, Source/Resource/EZeffectResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Sprites/ActionResource.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Resource/XmlNode.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/CashEmotion/UICashEmotionPack.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomMakeWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UISubChatMiniWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIBookWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIEditCtrl_Currency.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Exchange/UIExchangeUI.h, Source/UI/FrameSkin.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Gauges/UIPcGage.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIEquipmentPropertiesWnd.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Item/UIItemPurchaseWnd.h, Source/UI/Item/UIItemSellWnd2.h, Source/UI/Item/UIItemShopWnd.h, Source/UI/Item/UIItemShopWnd2.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Item/UIItemWnd.h, Source/UI/Item/UIMerchantItemLogWnd.h, Source/UI/Item/UIParaItemShopWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIGameItem.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemIdentifyWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Layout/WindowGeometry.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UIComboBoxV2Wnd.h, Source/UI/Lists/UIImgMenu.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITagListBox.h, Source/UI/Lists/UITreeView.h, Source/UI/Menu/UIMenuIconWnd.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIQuestDisplay.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Rodex/UIRodexInboxWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantItemPurchaseWnd.h, Source/UI/Shop/UIMerchantItemShopWnd.h, Source/UI/Shop/UIMerchantMirrorItemWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Skill/UISkillDescribeWnd.h, Source/UI/Skill/UISkillListWnd.h, Source/UI/SkillDelayInfo/SkillDelayInfo.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIBalloonText.h, Source/UI/Text/UINameBalloonText.h, Source/UI/Text/UIStaticTextControl.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBarGraph.h, Source/UI/UIBartermarketWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroReport.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIScrollWnd.h, Source/UI/UISlotBitmap.h, Source/UI/Window/FuncDrawWNDChar.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/UIWindowMgr.inl, Source/Utility/Lexicon/LexiconSerializer.h.
2026-11-08 16:44:36 +00:00
ragnarok-clanker
521b52384c
Maintenance: Replace LookupMessage(<integer>) with the existing MSGSTRINGID constant of the same value (3596 sites, 162 files; each v
...
Batch #14938 by ragnarok-clanker: no function's compiled code changes; checked with 162 compiled unit(s).
2026-11-08 14:19:01 +00:00
ragnarok-clanker
858265cc69
Maintenance: Second pass: name remaining numeric switch case labels (identifier-only; no code change). ~3,500 more labels across 150
...
Batch #14936 by ragnarok-clanker: no function's compiled code changes; checked with 158 compiled unit(s), including every includer of Source/Client/Mode/GameModeEnums.h, Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Contents/Actors/PetEnums.h, Source/Contents/Combat/CombatTypes.h, Source/Contents/Configuration/ServiceEnums.h, Source/Contents/Effects/EffectPrimId.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemId.h, Source/Contents/Items/ItemType.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 12:37:46 +00:00
ragnarok-clanker
dfbbcb5504
Decompile fn_06575 (ItemCardColor)
...
Batch #14624 by secret: 1 byte-identical, 0 confirmed by peer review.
- fn_06575 ItemCardColor: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-11-07 11:58:46 +00:00
ragnarok-clanker
e877e0016e
Confirm fn_06598 (IsBookItem)
...
Batch #14400 by SapitoSucio: 0 byte-identical, 1 confirmed by peer review.
- fn_06598 IsBookItem: logic confirmed by peer review (already on main)
Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 09:47:13 +00:00
ragnarok-clanker
0e58374ff7
Decompile 2 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #14229 by Yommy: 0 byte-identical, 2 confirmed by peer review.
- fn_06575 ItemCardColor: logic confirmed by peer review
- fn_06581 ITEM_INFO::DisplayName: logic confirmed by peer review
Peer-reviewed-by: secret, KWDev, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 08:30:42 +00:00
ragnarok-clanker
2cae2485cf
Decompile fn_06596 (LoadItemNameTables)
...
Batch #12659 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_06596 LoadItemNameTables: logic confirmed by peer review
Peer-reviewed-by: eAthena, Tanke, aDw, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 04:18:07 +00:00
ragnarok-clanker
3f8411389e
Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
...
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
2026-11-06 16:08:47 +00:00
ragnarok-clanker
fec919b88e
Maintenance: Link-completeness fixes so the whole client links into one executable (all units in data/compile.json plus exe-only thir
...
Batch #13186 by ragnarok-clanker: forced by an admin (40 lower score(s), 206 changed function(s)); checked with 620 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Session.h, Source/Client/Stove/StoveMgr.h, Source/Client/Stove/StovePCSDK.h, Source/Client/Timer.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Configuration/ServiceOptions.h, Source/Contents/Skills/SkillTreeScript.h, Source/Render/DX9/D3DX9Runtime.h, Source/Resource/GifResource.h, Source/UI/AdventureGuide/UIAdventureGuide.h, Source/UI/Cooldowns/CooldownOwner.h, Source/UI/Edit/UIEditBoxEx.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UITextViewerControl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIReputeWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISelCharForUServerWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/EncryptedName.h.
2026-11-06 10:56:48 +00:00
ragnarok-clanker
5d88f29a00
Decompile 2 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #12951 by cremane: 2 byte-identical, 0 confirmed by peer review.
- fn_06586 ITEM_INFO::Apprentice: byte-identical
- fn_06589 ITEM_INFO::Refine: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-11-06 03:30:59 +00:00
ragnarok-clanker
e2df9c0157
Decompile 2 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #12419 by cremane: 0 byte-identical, 2 confirmed by peer review.
- fn_06593 ITEM_INFO::Slots: logic confirmed by peer review
- fn_06581 ITEM_INFO::DisplayName: logic confirmed by peer review (already on main)
Peer-reviewed-by: Yommy, dori, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 15:43:01 +00:00
ragnarok-clanker
d6146e692a
Decompile 9 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #12279 by eAthena: 0 byte-identical, 9 confirmed by peer review.
- fn_06577 ITEM_INFO::Grade: logic confirmed by peer review
- fn_06580 FindItemMoveInfo: logic confirmed by peer review (already on main)
- fn_06581 ITEM_INFO::DisplayName: logic confirmed by peer review
- fn_06583 ITEM_INFO::Element: logic confirmed by peer review
- fn_06586 ITEM_INFO::Apprentice: logic confirmed by peer review
- fn_06587 ITEM_INFO::Suffixes: logic confirmed by peer review
- fn_06588 ITEM_INFO::Prefixes: logic confirmed by peer review
- fn_06591 ItemResourcePath: logic confirmed by peer review
- fn_45456 FindItemMoveInfo: logic confirmed by peer review
Peer-reviewed-by: Yommy, Tanke, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:54:07 +00:00
ragnarok-clanker
4f16e9bfe0
Decompile 3 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #12239 by eAthena: 1 byte-identical, 2 confirmed by peer review.
- fn_06544 FindItemCardName: byte-identical
- fn_06584 ITEM_INFO::Star: logic confirmed by peer review
- fn_06594 ItemUnidentifiedName: logic confirmed by peer review
Peer-reviewed-by: Yommy, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 12:30:43 +00:00
ragnarok-clanker
07897c8bea
Maintenance: Annotation cleanup, no code change (resubmission of 10984). Every // FUNCTION: line now has // OFFSET: <its address from
...
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
2026-11-04 21:29:46 +00:00
ragnarok-clanker
08dab536be
Confirm fn_06574 (FindItemCardName)
...
Batch #10723 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_06574 FindItemCardName: logic confirmed by peer review (already on main)
Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 17:04:38 +00:00
ragnarok-clanker
873905f518
Decompile fn_06597 (Equipment)
...
Batch #10357 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_06597 Equipment: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-03 20:46:19 +00:00
ragnarok-clanker
c7049dceac
Decompile fn_12346 (UIItemCollectionWnd::SendMsg)
...
Batch #10363 by dori: 0 byte-identical, 1 confirmed by peer review.
- fn_12346 UIItemCollectionWnd::SendMsg: logic confirmed by peer review
Peer-reviewed-by: Lumen, KWDev, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-03 20:44:51 +00:00
ragnarok-clanker
3659ac2f71
Maintenance: [forced, user-approved] Family D7 (resubmit of #10212 , returned only for conflicts with newer main; regenerated on e6188
...
Batch #10213 by ragnarok-clanker: forced by an admin (38 lower score(s), 147 changed function(s)); checked with 352 compiled unit(s), including every includer of Source/Client/Mode/ModeDragState.h, Source/Client/Session.h, Source/Contents/Items/ItemDescription.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/ItemLink.h, Source/Contents/Items/ItemResources.h, Source/UI/Shop/ItemDrawing.h, Source/UI/Shortcuts/ShortcutPainting.h, Source/UI/Shortcuts/ShortcutPress.h, Source/UI/Shortcuts/UIQuickSlotWnd.h, Source/UI/Text/TextWrapping.h, Source/UI/Text/UIBalloonText.h, Source/UI/UIStaticItem.h.
2026-11-02 23:43:46 +00:00
ragnarok-clanker
ae35da0248
Maintenance: [forced, user-approved] Family D2: remove fabricated ItemNaming / ItemNamingContext reference structs; their methods are
...
Batch #10201 by ragnarok-clanker: forced by an admin (14 lower score(s), 95 changed function(s)); checked with 256 compiled unit(s), including every includer of Source/Contents/Items/ItemInfo.h, Source/Contents/Items/ItemNaming.h, Source/UI/Shortcuts/ShortcutTooltip.h, Source/UI/Shortcuts/ShortcutUse.h, Source/UI/Text/ItemLinkDisplay.h, Source/UI/Text/UITextViewer.h, Source/UI/UIBasicCtrl.h.
2026-11-02 22:03:09 +00:00
ragnarok-clanker
1311b75bf7
Decompile fn_13265 (UIMerchantShopMakeWnd::PrintSellList)
...
Batch #9135 by youko: 0 byte-identical, 1 confirmed by peer review.
- fn_13265 UIMerchantShopMakeWnd::PrintSellList: logic confirmed by peer review
Peer-reviewed-by: Lumen, dori, doczeira
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-01 02:12:04 +00:00
ragnarok-clanker
4fd6cd3ad7
Maintenance: Resubmission of batch 9115 rebased onto main (it conflicted with 9108's CommonObject.cpp change, which it already contai
...
Batch #9132 by ragnarok-clanker: forced by an admin (2 lower score(s), 13 changed function(s)); checked with 22 compiled unit(s), including every includer of Source/Contents/ForbiddenWords.h, Source/Contents/Party/PartyInvitation.h, Source/File/CommonObject.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIPetInfoWnd.h.
2026-11-01 02:10:48 +00:00
ragnarok-clanker
60868bf39d
Decompile 2 functions in Source/Contents/Items/ItemNaming.cpp, Source/Contents/Items/ItemNaming.h
...
Batch #6897 by aDw: 0 byte-identical, 2 confirmed by peer review.
- fn_45456 FindItemMoveInfo: logic confirmed by peer review
- fn_06580 FindItemMoveInfo: logic confirmed by peer review
Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 02:16:35 +00:00
ragnarok-clanker
92eab59af9
Decompile fn_06567 (sub_6D5150)
...
Batch #6658 by System4z: 1 byte-identical, 0 confirmed by peer review.
- fn_06567 sub_6D5150: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-10-31 01:33:02 +00:00
ragnarok-clanker
e1bb2b8a40
Decompile fn_06575 (ItemCardColor)
...
Batch #5452 by tayoba: 0 byte-identical, 1 confirmed by peer review.
- fn_06575 ItemCardColor: logic confirmed by peer review
Peer-reviewed-by: Yommy, bigodeira, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 11:55:24 +00:00
ragnarok-clanker
41e29dee49
Decompile 4 functions in Source/Contents/Items/ItemNaming.cpp, Source/Contents/Effects/EffectLists.cpp, ...
...
Batch #4201 by willerthal: 0 byte-identical, 4 confirmed by peer review.
- fn_06596 LoadItemNameTables: logic confirmed by peer review
- fn_18776 CreateEffectMgr: logic confirmed by peer review
- fn_18561 ?ThunderingOrbName@@YAAAV?$EncryptedName@$0EE@$0CPILAPDHBBINBFHP@@?A0xb1221624@@XZ: logic confirmed by peer review
- fn_18655 ?Create@?$CEffectAllocator@VCThunderingOrb@?A0xb1221624@@@?A0xb1221624@@UAEPAVCEffect@@XZ: logic confirmed by peer review
Peer-reviewed-by: Yommy, superintelligence, OrangeCat
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 01:47:23 +00:00
ragnarok-clanker
efe93ce1fe
Decompile fn_03873 (ItemDisplayName)
...
Batch #3943 by willerthal: 0 byte-identical, 1 confirmed by peer review.
- fn_03873 ItemDisplayName: logic confirmed by peer review
Peer-reviewed-by: eAthena, superintelligence, jessip
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:12:21 +00:00
ragnarok-clanker
9d42b95e16
Decompile 3 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
...
Batch #3508 by youko: 0 byte-identical, 3 confirmed by peer review.
- fn_06599 IsItemCard: logic confirmed by peer review
- fn_06611 ITEM_INFO::SetOption: logic confirmed by peer review
- fn_06613 ITEM_INFO::SetCard: logic confirmed by peer review
Peer-reviewed-by: meitogi, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:45:23 +00:00
ragnarok-clanker
68913b02eb
Decompile fn_06598 (IsBookItem)
...
Batch #3227 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_06598 IsBookItem: logic confirmed by peer review
Peer-reviewed-by: eAthena, meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:41:48 +00:00
ragnarok-clanker
48b81a54c0
Decompile 2 functions in Source/Contents/Items/ItemDescription.cpp, Source/Contents/Items/ItemDescription.h, ...
...
Batch #2856 by youko: 0 byte-identical, 2 confirmed by peer review.
- fn_06574 FindItemCardName: logic confirmed by peer review
- fn_06580 FindItemMoveInfo: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 19:36:31 +00:00
ragnarok-clanker
f6ddf78090
Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers).
2026-10-29 12:30:02 +01:00
ragnarok-clanker
018dee6278
Decompile 15 functions in Source/Client/Session.h, Source/Client/Replay.cpp, ...
...
Batch #1712 by ragnarok-clanker: 0 byte-identical, 15 confirmed by peer review.
- fn_06570 ItemInfo::AssignBasic: logic confirmed by peer review
- fn_06607 SearchItemIds: logic confirmed by peer review
- fn_06608 MatchItemName: logic confirmed by peer review
- fn_06582 FindMetalProcessItems: logic confirmed by peer review
- fn_06590 ItemInfo::Serialize: logic confirmed by peer review
- fn_06544 FindItemCardName: logic confirmed by peer review
- fn_23291 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23297 ClientItemLists::AddItem1718: logic confirmed by peer review
- fn_23584 CSession::HasRequiredItems: logic confirmed by peer review
- fn_23588 CSession::IsSlotItemIdentity: logic confirmed by peer review
- fn_23589 CSession::HasInventoryItem: logic confirmed by peer review
- fn_23591 CSession::HasItemId: logic confirmed by peer review
- fn_23592 CSession::HasItemCount: logic confirmed by peer review
- fn_23582 IsScreenShakeActive: logic confirmed by peer review
- fn_23908 CSession::SetPlayerNameKey: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 20:47:17 +00:00
ragnarok-clanker
8125ad1ce1
Decompile fn_06623 (BuildReplayTaggedRecord)
...
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:43:04 +00:00
ragnarok-clanker
838c0044d2
Decompile 70 functions in Source/Client/Browser/BrowserFactory.cpp, Source/Contents/Emblems/EmblemUpload.cpp, ...
...
Batch #1665 by ragnarok-clanker: 0 byte-identical, 70 confirmed by peer review.
- fn_10904 UIEditCtrl::UpdateLinks: logic confirmed by peer review
- fn_10905 EditViewport::Synchronize: logic confirmed by peer review
- fn_10950 UIBalloonText::SetText: logic confirmed by peer review
- fn_11216 ItemLinkDisplay::Convert: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review (already on main)
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review (already on main)
- fn_11366 UIListBox::Paint: logic confirmed by peer review
- fn_11367 UIListBoxEx::Paint: logic confirmed by peer review
- fn_11392 UITextButton::Paint: logic confirmed by peer review
- fn_11394 UITextViewer::Paint: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review (already on main)
- fn_11471 UITextButton::Slot27: logic confirmed by peer review (already on main)
- fn_11494 UITextButton::Slot33: logic confirmed by peer review (already on main)
- fn_11562 UITextViewer::SendMsg: logic confirmed by peer review (already on main)
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review (already on main)
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review (already on main)
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review (already on main)
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review (already on main)
- fn_12680 ShortcutPainting::Paint: logic confirmed by peer review
- fn_13829 WrapPlainText: logic confirmed by peer review
- fn_13833 WrapRichText: logic confirmed by peer review
- fn_16941 UIWindow::DrawAmount: logic confirmed by peer review
- fn_16971 UIWindow::TextHeight: logic confirmed by peer review
- fn_16972 UIWindow::VerticalTextHeight: logic confirmed by peer review
- fn_16973 UIWindow::TextSize: logic confirmed by peer review
- fn_16974 UIWindow::VerticalTextSize: logic confirmed by peer review
- fn_16975 UIWindow::TextWidth: logic confirmed by peer review
- fn_16993 WrapPixelText: logic confirmed by peer review
- fn_17007 FitText: logic confirmed by peer review
- fn_17009 UIWindow::DrawTextAt: logic confirmed by peer review
- fn_17013 DrawOutlinedColoredText: logic confirmed by peer review
- fn_17014 DrawStyledColoredText: logic confirmed by peer review
- fn_17015 DrawColoredText: logic confirmed by peer review
- fn_17016 DrawOutlinedText: logic confirmed by peer review
- fn_17136 BrowserFactory::Create: logic confirmed by peer review
- fn_18376 LookupMessage: logic confirmed by peer review
- fn_01934 TextContext::TextContext: logic confirmed by peer review
- fn_01957 TextContext::Marker: logic confirmed by peer review
- fn_01961 TextContext::Measure: logic confirmed by peer review
- fn_01966 TextContext::SetFont: logic confirmed by peer review
- fn_01970 TextContext::DrawPair: logic confirmed by peer review
- fn_01971 TextContext::Draw: logic confirmed by peer review
- fn_01983 TextContext::MeasurePart: logic confirmed by peer review
- fn_01984 TextContext::DrawPart: logic confirmed by peer review
- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review
- fn_24191 EmotionHotkeys::LoadDefaults: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03666 CAdventurerAgencyMgr::CompleteRegistration: logic confirmed by peer review
- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_04239 CMCStoreInfoBackup::CompleteSave: logic confirmed by peer review
- fn_04262 CPlayerNameDictionary::Lookup: logic confirmed by peer review
- fn_06581 ItemNaming::DisplayName: logic confirmed by peer review (already on main)
- fn_06583 ItemNamingContext::Element: logic confirmed by peer review (already on main)
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review (already on main)
- fn_06585 ItemNaming::Creator: logic confirmed by peer review (already on main)
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review (already on main)
- fn_06587 ItemNaming::Suffixes: logic confirmed by peer review (already on main)
- fn_06588 ItemNaming::Prefixes: logic confirmed by peer review (already on main)
- fn_09299 UIApplyForPartyWnd::Slot15: logic confirmed by peer review
- fn_09300 UIRegisterPartyWnd::Slot15: logic confirmed by peer review
- fn_09301 UIRequestJoinPartyWnd::Slot15: logic confirmed by peer review
- fn_09303 UIApplyForPartyWnd::Paint: logic confirmed by peer review
- fn_09304 UIPartyInfoWnd::Paint: logic confirmed by peer review
- fn_10748 UIEditCtrl::RemoveInvalidLink: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review (already on main)
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review (already on main)
- fn_10794 UIBasicButton::Paint: logic confirmed by peer review
- fn_10799 UIBmpTextButton::Paint: logic confirmed by peer review
- fn_10823 UITransBalloonText::Paint: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 19:35:29 +00:00
ragnarok-clanker
3d1d975150
Decompile fn_06589 (ItemInfo::Refine)
...
Batch #1445 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_06589 ItemInfo::Refine: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 12:58:47 +00:00
ragnarok-clanker
d9f91eec12
Decompile 6 functions in Source/Contents/Items/ItemNaming.cpp
...
Batch #1197 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.
- fn_06583 ItemNamingContext::Element: logic confirmed by peer review
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review
- fn_06591 ItemResourcePath: logic confirmed by peer review
- fn_06592 ItemSlotsCount: logic confirmed by peer review
- fn_06594 ItemUnidentifiedName: logic confirmed by peer review
Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 21:08:08 +00:00
ragnarok-clanker
8694e9a749
🔥 refactor(ItemNaming): removed unused cstdio include
...
(cherry picked from commit e426bd95cc0084f0c4f90dfc0ead142c65a1dc1c)
2026-10-27 14:43:03 +00:00
ragnarok-clanker
3dbd276311
📚 docs(inlining): marked inlined functions across modules
2026-10-27 10:21:57 +01:00
ragnarok-clanker
e168b4e4a6
Restore translation-unit ownership and publish verified source corrections
...
Owner-authorized source migration: 31 helper-only translation units were merged into their callers or existing inline headers; both build manifests updated. Includes the preserved source payload, Lua configuration matching wowdecomp, and exact malloca expansion without diagnostic pragmas.
449 native units compiled locally and 449 staged units compiled by the pinned server toolchain. No previously byte-matched function regressed. Compiler mapping diagnostics remain recorded as needs_cleanup, not accepted or peer-confirmed. Existing independent review records are preserved. README.md is intentionally unchanged.
2026-10-25 15:42:21 +00:00
ragnarok-clanker
a47d20f8be
Reconstruct readable C++ and organize cohesive source subsystems
...
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.
Previous head: 35d2a8cb36
Payload SHA256: 592f016d2730c5593bb653aa054c1e5f76a6df72c8f5a09e66f74876e2e33dee
2026-10-25 07:42:41 +00:00