Commit graph

22 commits

Author SHA1 Message Date
ragnarok-clanker
5ad8e0c58c Maintenance: Resubmission of 16340 over main 047268c0 (conflict in UICashEmotionPack::GetPriceText resolved keeping main's new body).
Batch #16351 by ragnarok-clanker: no function's compiled code changes; checked with 784 compiled unit(s), including every includer of Source/Archive/GPak.h, Source/Client/Browser/BrowserCommandTarget.h, Source/Client/Browser/BrowserDocumentUI.h, Source/Client/Browser/BrowserInPlace.h, Source/Client/Browser/WebBrowser.h, Source/Client/Input/Language.h, Source/Client/Input/LanguageTC.h, Source/Client/Input/Mouse.h, Source/Client/Mode/CGameMode.h, Source/Client/Mode/CLoginMode.h, Source/Client/Replay.h, Source/Client/Session.h, Source/Client/Stove/StovePCSDK.h, Source/Contents/AchievementMgr.h, Source/Contents/Actors/CharacterRender.h, Source/Contents/Actors/EffectActors.h, Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GndRiser.h, Source/Contents/Actors/GrannyGameActor.h, Source/Contents/Actors/MousePointer.h, Source/Contents/Actors/Npc.h, Source/Contents/Actors/Pc.h, Source/Contents/Actors/RenderObjectState.h, Source/Contents/Actors/Skill.h, Source/Contents/AdventureGuideMgr.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClanInfo.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/EffectResourceSwitcher.h, Source/Contents/Effects/AcidifiedThrow.h, Source/Contents/Effects/ArrowEffect.h, Source/Contents/Effects/AxeBoomerang.h, Source/Contents/Effects/BlastForge.h, Source/Contents/Effects/CharacterParticleBundle.h, Source/Contents/Effects/DummyEffectLauncher.h, Source/Contents/Effects/EZ2STREffectEx.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectEmitter.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Effects/EffectTypes.h, Source/Contents/Effects/ElectricEffect.h, Source/Contents/Effects/EmitterEffect.h, Source/Contents/Effects/FortuneKissEffect.h, Source/Contents/Effects/MagicFloorEffect.h, Source/Contents/Effects/MandraAttackEffect.h, Source/Contents/Effects/MonsterSkillEffects.h, Source/Contents/Effects/MsgEffect.h, Source/Contents/Effects/Particle.h, Source/Contents/Effects/RagEffectState.h, Source/Contents/Effects/RichManKim.h, Source/Contents/Effects/SpriteParticle.h, Source/Contents/Effects/StarEffect.h, Source/Contents/Effects/WhirlwindEffect.h, Source/Contents/EnchantMgr.h, Source/Contents/FlyingShipRouteInfo.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/GuildInfo.h, Source/Contents/Hotkeys/InterfaceHotkey.h, Source/Contents/Items/ItemInfo.h, Source/Contents/Items/RuneSystem.h, Source/Contents/MapSkyMgr.h, Source/Contents/Models/ModelActor.h, Source/Contents/Movies/BinkMovie.h, Source/Contents/NavigationManager.h, Source/Contents/Party/PartyBookingMgr.h, Source/Contents/PetEvolutionMgr.h, Source/Contents/RenewQuestMgr.h, Source/Contents/RodexMailStore.h, Source/Contents/Schedule/Schedule.h, Source/Contents/Schedule/ShutDownSchedule.h, Source/Contents/SignBoard/SignBoard.h, Source/Contents/Skills/PlayerSkillBundle.h, Source/Contents/Sound/SoundMgr.h, Source/Contents/SpriteLayerDrawing.h, Source/Contents/Store/MCStoreInfoBackupAsyncWork.h, Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.h, Source/Contents/UserData/NormalItemSlots.h, Source/Contents/WorldView/WorldViewData.h, Source/Network/Connection/Connection.h, Source/Render/DX7/DeviceOwnerDX7.h, Source/Render/DX7/DirectDrawEnumeration.h, Source/Render/DX9/DeviceOwnerDX9.h, Source/Render/Primitives/LightmappedPrimitive.h, Source/Render/Primitives/RenderPrimitive.h, Source/Render/Renderer.h, Source/Render/RendererDX7.h, Source/Render/Text/EmbedFont.h, Source/Render/Text/TextContext.h, Source/Render/Textures/Texture.h, Source/Resource/BinkRuntime.h, Source/Resource/GifResource.h, Source/Resource/Models/AnimatedModelResource.h, Source/Resource/Models/GrannyModelResource.h, Source/Resource/Models/ModelMesh.h, Source/Resource/ResourceMgr.h, Source/Resource/World/GroundResource.h, Source/Resource/World/WorldResource.h, Source/Security/NProtectGameGuardMgr.h, Source/Security/ReassemblyPacketMgr.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITextureButton.h, Source/UI/Chat/UINewChatWnd.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Dialogs/UILoadingWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISayDialogWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Enchant/EnchantUI.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Item/UIItemStoreFindWnd.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Item/UIItemStoreWnd.h, Source/UI/Items/UIEquipWnd.h, Source/UI/Items/UIExchangeWnd.h, Source/UI/Items/UIItemCollectionWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/TableBox.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/Lists/UIListBoxID.h, Source/UI/Lists/UIListBoxTemplate.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Lists/UIVScrollBar.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyWnd.h, Source/UI/ProbabilityTable/UIProbabilityTable.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/RuneSystem/UIRuneSystemWindows.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemMyShopWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/CreateLineInfo.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UIString.h, Source/UI/Text/UITextViewer.h, Source/UI/Text/UITransBalloonText.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UIMacroDetectorWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UICollectionSystemWnd.h, Source/UI/Window/UIControl.h, Source/UI/Window/UIHotKeyWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRoMapWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/UI/Window/WindowId.h, Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObjectPoolMgr.h, Source/Utility/JsonCppLoader.h, Source/Utility/Lexicon/LexiconSerializer.h, Source/Utility/NFileLog.h, Source/Utility/Threading/NThread.h.
2026-11-10 17:38:25 +00:00
ragnarok-clanker
9508353044 Decompile 2 functions in Source/Utility/Cipher/CipherPrimitives.cpp
Batch #16327 by youko: 2 byte-identical, 0 confirmed by peer review.

- fn_18399 StoreLittleEndian32: byte-identical
- fn_18400 LoadLittleEndian32: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 16:52:42 +00:00
ragnarok-clanker
fd222d9fa9 Decompile 6 functions in Source/Utility/Cipher/Rijndael.cpp, Source/Utility/Cipher/Rijndael.h
Batch #15566 by Yommy: 6 byte-identical, 0 confirmed by peer review.

- fn_04405 CRijndael::EncryptBlock: byte-identical
- fn_04406 CRijndael::DefEncryptBlock: byte-identical
- fn_04407 CRijndael::DefDecryptBlock: byte-identical
- fn_04408 CRijndael::DecryptBlock: byte-identical
- fn_04409 CRijndael::MakeKey: byte-identical
- fn_04410 CRijndael::Xor: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 06:53:37 +00:00
ragnarok-clanker
97bcf8e00c Decompile 5 functions in Source/Utility/Cipher/AES.cpp
Batch #15559 by Yommy: 5 byte-identical, 0 confirmed by peer review.

- fn_18394 CAES::DecryptBlock: byte-identical
- fn_18395 CAES::DefDecryptBlock: byte-identical
- fn_18396 CAES::DefEncryptBlock: byte-identical
- fn_18397 CAES::EncryptBlock: byte-identical
- fn_18398 CAES::Xor: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-10 06:40:44 +00:00
ragnarok-clanker
7cbbd2c80f Decompile 2 functions in Source/Utility/Cipher/CipherPrimitives.cpp
Batch #14306 by secret: 0 byte-identical, 2 confirmed by peer review.

- fn_18406 CryptonSetKey: logic confirmed by peer review
- fn_18413 BuildSboxLookup: logic confirmed by peer review

Peer-reviewed-by: Yommy, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 10:27:11 +00:00
ragnarok-clanker
77dd49c297 Decompile 2 functions in Source/Utility/Cipher/AES.cpp
Batch #12494 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_18395 CAES::DefDecryptBlock: logic confirmed by peer review
- fn_18396 CAES::DefEncryptBlock: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 15:54:48 +00:00
ragnarok-clanker
358fea2db0 Decompile 3 functions in Source/Utility/Cipher/CipherPrimitives.cpp
Batch #11906 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_18407 FealF: byte-identical
- fn_18408 MistyFL: byte-identical (already on main)
- fn_18409 MistyFO: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 05:22:38 +00:00
ragnarok-clanker
f133c060e6 Confirm 2 functions in Source/Utility/Cipher/Rijndael.cpp
Batch #10621 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04399 DecryptRijndael192: logic confirmed by peer review (already on main)
- fn_04400 DecryptRijndael256: logic confirmed by peer review (already on main)

Peer-reviewed-by: dori, cremane, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:59:21 +00:00
ragnarok-clanker
10023ef9d0 Decompile fn_18406 (CryptonSetKey)
Batch #10697 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_18406 CryptonSetKey: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, dori, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 16:51:21 +00:00
ragnarok-clanker
ac999c3d59 Decompile fn_18416 (TigerCompress)
Batch #6288 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_18416 TigerCompress: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, superintelligence, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Utility/Cipher/Tiger.cpp
2026-10-30 21:38:39 +00:00
ragnarok-clanker
d19d5d6bb0 Decompile fn_18399 (StoreLittleEndian32)
Batch #6271 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_18399 StoreLittleEndian32: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, alisonrag, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 21:27:36 +00:00
ragnarok-clanker
4b762e2221 Decompile 2 functions in Source/Utility/Cipher/CipherPrimitives.cpp
Batch #6188 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_18414 KeyedBoxFeistel: logic confirmed by peer review
- fn_18415 SealGenerate: logic confirmed by peer review

Peer-reviewed-by: alisonrag, gordaoprogramas, KWDev, Romain, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 20:58:56 +00:00
ragnarok-clanker
e539c02e28 Decompile 4 functions in Source/Utility/Cipher/AES.cpp
Batch #5925 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_18394 CAES::DecryptBlock: logic confirmed by peer review
- fn_18395 CAES::DefDecryptBlock: logic confirmed by peer review
- fn_18396 CAES::DefEncryptBlock: logic confirmed by peer review
- fn_18397 CAES::EncryptBlock: logic confirmed by peer review

Peer-reviewed-by: ntrl, superintelligence, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 17:47:17 +00:00
ragnarok-clanker
a4f6673df8 Decompile 3 functions in Source/Utility/Cipher/CipherPrimitives.cpp
Batch #5893 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_18404 Ripemd128Transform: logic confirmed by peer review
- fn_18405 CryptonEncryptBlock: logic confirmed by peer review
- fn_18406 CryptonSetKey: logic confirmed by peer review

Peer-reviewed-by: KWDev, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 17:16:54 +00:00
ragnarok-clanker
5f49b00de7 Decompile 11 functions in Source/Utility/Cipher/CipherPrimitives.cpp
Batch #5692 by Yommy: 0 byte-identical, 11 confirmed by peer review.

- fn_18400 LoadLittleEndian32: logic confirmed by peer review
- fn_18401 FealRotate2: logic confirmed by peer review
- fn_18402 FealS0: logic confirmed by peer review
- fn_18403 FealS1: logic confirmed by peer review
- fn_18407 FealF: logic confirmed by peer review
- fn_18408 MistyFL: logic confirmed by peer review
- fn_18409 MistyFO: logic confirmed by peer review
- fn_18410 ShaTransform: logic confirmed by peer review
- fn_18411 BuildKeyedBoxes: logic confirmed by peer review
- fn_18412 SboxEncryptBlock: logic confirmed by peer review
- fn_18413 BuildSboxLookup: logic confirmed by peer review

Peer-reviewed-by: willerthal, Snow, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Utility/Cipher/CipherPrimitives.cpp
2026-10-30 14:51:07 +00:00
ragnarok-clanker
3839dc2444 Decompile fn_18393 (DecryptAES)
Batch #5360 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_18393 DecryptAES: logic confirmed by peer review

Peer-reviewed-by: eAthena, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 10:38:07 +00:00
ragnarok-clanker
d6928200bc Decompile 2 functions in Source/Utility/Cipher/AES.cpp, Source/Utility/Cipher/AES.h
Batch #5208 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_18391 CAES::~CAES: logic confirmed by peer review
- fn_18398 CAES::Xor: logic confirmed by peer review

Peer-reviewed-by: eAthena, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:26:43 +00:00
ragnarok-clanker
4e88a94675 Decompile fn_18390 (CAES::CAES)
Batch #5102 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_18390 CAES::CAES: logic confirmed by peer review

Peer-reviewed-by: youko, Bruwuno
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Utility/Cipher/AES.cpp
2026-10-30 07:56:48 +00:00
ragnarok-clanker
1b8deb39b1 Decompile 2 functions in Source/Utility/Cipher/Rijndael.cpp, Source/Utility/Cipher/Rijndael.h
Batch #1234 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04399 DecryptRijndael192: logic confirmed by peer review
- fn_04400 DecryptRijndael256: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-27 22:32:59 +00:00
ragnarok-clanker
10629c8c31 Decompile 2 functions in Source/Utility/Cipher/Rijndael.cpp, Source/Utility/Cipher/Rijndael.h
Batch #1232 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_04399 DecryptAes192: logic confirmed by peer review
- fn_04400 DecryptAes256: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-27 22:13:46 +00:00
ragnarok-clanker
add868efe7 ♻️ refactor(source): removed unused includes and add INLINE comments 2026-10-27 10:09:10 +01:00
ragnarok-clanker
bf6a44c117 Group Utility units into subsystem folders and require OFFSET provenance
Move Lexicon*, Text (TextTokens, TextEscapes, Base64), Math/RadialGrid, Hash (MD5, XxHash32) and Cipher (Rijndael, XorBytes) into Source/Utility subfolders; update includes, guards, compile.json and CMakeLists.txt. Backfill // OFFSET: above every standalone // FUNCTION: block (89 IDs, addresses from the symbol database) and make it mandatory in CODING_RULES.md and AGENTS.md. Remove the MatchLexicon cast chain.
2026-10-26 23:41:07 +01:00