clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
321 commits 1 branch 0 tags 28 MiB
Commit graph

55 commits

Author SHA1 Message Date
ragnarok-clanker
dcecaa8a09 Decompile 5 functions in Source/UI/WindowTitlebar.cpp, Source/UI/WindowBackground.cpp, ... 
Batch #1396 by Yommy: 0 byte-identical, 5 confirmed by peer review.

- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/WindowTitlebar.cpp, Source/UI/WindowBackground.cpp
 2026-10-28 12:16:43 +00:00
ragnarok-clanker
b684478589 Decompile fn_12631 (UINewChatWnd::Move) 
Batch #1390 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_12631 UINewChatWnd::Move: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:12:31 +00:00
ragnarok-clanker
dd7b67cbe3 Decompile 2 functions in Source/UI/Edit/UIEditCtrl.cpp, Source/UI/Edit/UIEditCtrl.h, ... 
Batch #1333 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_10977 UIEditCtrl::MoveCandidateWindow: logic confirmed by peer review
- fn_10978 UIEditCtrl::MoveReadingWindow: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 12:08:44 +00:00
ragnarok-clanker
b55f4ca4c5 Decompile 3 functions in Source/UI/Buttons/UITextButton.cpp, Source/UI/Lists/UITreeView.h, ... 
Batch #1386 by Yommy: 1 byte-identical, 2 confirmed by peer review.

- fn_11446 UITreeView::Slot31: logic confirmed by peer review
- fn_11455 UIItemTagButton::Slot28: logic confirmed by peer review
- fn_11459 UIStaticItem_Illust::Slot28: byte-identical

Reviewed-by: ragnarok-clanker
 2026-10-28 12:08:06 +00:00
ragnarok-clanker
9176a8bc81 Decompile fn_11250 (UIScrollBar::Configure) 
Batch #1334 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_11250 UIScrollBar::Configure: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
 2026-10-28 12:07:33 +00:00
ragnarok-clanker
294159cd14 Decompile 2 functions in Source/UI/Window/WindowBorder.cpp, Source/UI/Window/WindowBorder.h 
Batch #1383 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_16943 DrawFilledRoundedBorder: logic confirmed by peer review
- fn_16946 FillTriangle: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 12:06:20 +00:00
ragnarok-clanker
1ad3634553 Decompile 2 functions in Source/UI/UILapineScrollBar.cpp, Source/UI/UIIngredientInfoWnd.h 
Batch #1375 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_04149 UIIngredientInfoWnd::Slot10: logic confirmed by peer review
- fn_04152 UIIngredientInfoWnd::Move: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/UILapineScrollBar.cpp
 2026-10-28 12:05:50 +00:00
ragnarok-clanker
bb3895d424 Decompile 4 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UINoticeWnd.h, ... 
Batch #1379 by Yommy: 4 byte-identical, 0 confirmed by peer review.

- fn_11757 UINoticeWnd::Slot18: byte-identical
- fn_11758 UISelectReplayDataWnd::Slot18: byte-identical
- fn_11759 UISelectServerWnd::Slot18: byte-identical
- fn_11765 UILoginWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 11:58:47 +00:00
ragnarok-clanker
3cdd0a82d7 Decompile 2 functions in Source/UI/Window/UIFrameWnd.cpp, Source/UI/Lists/UIReplayListBox.h, ... 
Batch #1370 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_11780 UIReplayListBox::Slot25: logic confirmed by peer review
- fn_11735 UIFrameWnd::Move: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-28 11:45:27 +00:00
ragnarok-clanker
c689e0ab5c Decompile fn_11785 (UINoticeWnd::Slot28) 
Batch #1371 by Yommy: 1 byte-identical, 0 confirmed by peer review.

- fn_11785 UINoticeWnd::Slot28: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 11:44:41 +00:00
ragnarok-clanker
1c377a8040 Decompile fn_03597 (UINavigationroadiconWnd::Slot31) 
Batch #1364 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03597 UINavigationroadiconWnd::Slot31: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:44:39 +00:00
ragnarok-clanker
2bd9f525a3 Decompile 2 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h 
Batch #1369 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_03555 UINavigationV4Wnd::ClearRouteTexts: logic confirmed by peer review
- fn_03604 UINavigationV4Wnd::Slot19: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:44:06 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems) 
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
 2026-10-28 11:42:30 +00:00
ragnarok-clanker
69232871b3 Decompile fn_20960 (CreateCooldownOwner) 
Batch #1355 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_20960 CreateCooldownOwner: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 11:08:09 +00:00
ragnarok-clanker
92886d28ca Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ... 
Batch #1329 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23633 CSession::ClearItemSelection: logic confirmed by peer review
- fn_17254 UIWindowMgr::NotifyMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-28 10:30:24 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard) 
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 10:19:34 +00:00
ragnarok-clanker
f3c3aba1be Decompile fn_07651 (Nullsub228) 
Batch #1318 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_07651 Nullsub228: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 09:45:24 +00:00
ragnarok-clanker
2c9f3270f9 Decompile 2 functions in Source/UI/MiniPartyPlacement.cpp, Source/UI/MiniPartyPlacement.h 
Batch #1206 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_07650 CMiniPartyWndSortArea::CMiniPartyWndSortArea: logic confirmed by peer review
- fn_07658 CMiniPartyWndSortArea::GetCells: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/MiniPartyPlacement.cpp
 2026-10-27 21:09:35 +00:00
ragnarok-clanker
26d8de6f32 Decompile fn_11281 (UIScrollBar::Position) 
Batch #1171 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_11281 UIScrollBar::Position: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 21:06:37 +00:00
ragnarok-clanker
32f5266595 Decompile fn_14637 (CUIControl::IsPointInside) 
Batch #1168 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_14637 CUIControl::IsPointInside: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 21:06:22 +00:00
ragnarok-clanker
610551894c Decompile 2 functions in Source/UI/Edit/UIEditCtrl.cpp, Source/UI/Edit/UIEditCtrl.h 
Batch #1158 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 21:06:17 +00:00
ragnarok-clanker
7c6781f4d9 Decompile 3 functions in Source/UI/Window/UIWindow.cpp, Source/UI/Navigation/UINavigationV4Wnd.h, ... 
Batch #1147 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_03575 UINavigationV4Wnd::LayoutWithoutDetails: logic confirmed by peer review
- fn_03577 UINavigationV4Wnd::LayoutWithDetails: logic confirmed by peer review
- fn_03639 UINavigationV4Wnd::Slot11: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-27 21:05:52 +00:00
ragnarok-clanker
ad68d437d0 Decompile fn_03605 (UIPrivateAirplaneWnd::Slot19) 
Batch #1148 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_03605 UIPrivateAirplaneWnd::Slot19: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 20:30:00 +00:00
ragnarok-clanker
052f7dcfd5 Decompile fn_03593 (UIListBox_NaviSearch::Slot26) 
Batch #1144 by eAthena: 1 byte-identical, 0 confirmed by peer review.

- fn_03593 UIListBox_NaviSearch::Slot26: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 20:27:17 +00:00
ragnarok-clanker
e9b6837e97 Decompile 2 functions in Source/UI/Buttons/UIBasicButton.cpp, Source/UI/Buttons/UIBitmapButton.cpp, ... 
Batch #1102 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_16953 UIWindow::Root: byte-identical
- fn_16983 UIWindow::Invalidate: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
 2026-10-27 18:04:02 +00:00
ragnarok-clanker
cb8da61c98 Decompile fn_17154 (UIWindowMgr::ProcessDialogKey) 
Batch #1078 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17154 UIWindowMgr::ProcessDialogKey: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 16:05:51 +00:00
ragnarok-clanker
0c214b1e62 Decompile 2 functions in Source/UI/Window/WindowOrdering.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1075 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17184 UIWindowMgr::InvalidateAll: logic confirmed by peer review
- fn_17189 UIWindowMgr::UpdateSnapRectangles: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 15:28:25 +00:00
ragnarok-clanker
a55dd8b8e5 Decompile 4 functions in Source/UI/Window/WindowOrdering.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1076 by ragnarok-clanker: 4 byte-identical, 0 confirmed by peer review.

- fn_17185 UIWindowMgr::RefreshClanWnd: byte-identical
- fn_17186 UIWindowMgr::RefreshGuildWindows: byte-identical
- fn_17187 UIWindowMgr::RefreshRouletteWnd: byte-identical
- fn_17188 UIWindowMgr::EnableRouletteWnd: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 15:19:07 +00:00
ragnarok-clanker
2800d0fdc0 Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to UI headers 
Batch #1065 by ragnarok-clanker: no function's compiled code changes; checked with 92 compiled unit(s), including every includer of Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Chat/ChatNotifications.h, Source/UI/Cooldowns/CooldownDrawing.h, Source/UI/Cooldowns/CooldownState.h, Source/UI/Edit/ItemTagRetirement.h, Source/UI/Layout/SnapRectangle.h, Source/UI/Lists/UIListBoxEx.h, Source/UI/MiniPartyGrid.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIRequestJoinPartyMgr.h, Source/UI/Shop/PriceColor.h, Source/UI/Shortcuts/ShortcutCooldowns.h, Source/UI/Shortcuts/ShortcutGrid.h, Source/UI/Text/TextMarkup.h, Source/UI/Text/UITransBalloonText.h, Source/UI/Window/FrameTextCache.h, Source/UI/Window/UIWindow.h, Source/UI/Window/WindowAncestry.h, Source/UI/Window/WindowRegistration.h.
 2026-10-27 13:55:58 +00:00
ragnarok-clanker
4e5f7335ff Decompile fn_17124 (UIWindowMgr::RegisterNamedWindow) 
Batch #1049 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17124 UIWindowMgr::RegisterNamedWindow: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 12:14:55 +00:00
ragnarok-clanker
fbdc231444 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1048 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_17219 UIWindowMgr::Schedule: logic confirmed by peer review
- fn_17235 UIWindowMgr::DismissTransient: logic confirmed by peer review
- fn_17237 UIWindowMgr::Destroy: logic confirmed by peer review
- fn_17833 ModeTooltip::Clear: logic confirmed by peer review
- fn_17843 ModeTooltip::Expire: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-27 12:07:15 +00:00
ragnarok-clanker
44f60ba6ca Decompile 6 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1038 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_07649 CMiniPartyWndAreaMgr::CMiniPartyWndAreaMgr: logic confirmed by peer review
- fn_17099 UIWindowMgr::~UIWindowMgr: logic confirmed by peer review
- fn_17233 UIWindowMgr::Shutdown: logic confirmed by peer review
- fn_09716 CSnapMgr::MoveEdge: logic confirmed by peer review
- fn_06318 ServiceOptions::Get: logic confirmed by peer review (already on main)
- fn_06325 ServiceOptions::Set: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-27 11:01:30 +00:00
ragnarok-clanker
f3ceb09e9d Merge commit '6c40a36577' 2026-10-27 10:06:35 +00:00
ragnarok-clanker
51e57d4b27 Decompile 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1031 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17086 UIWindowMgr::UIWindowMgr: logic confirmed by peer review
- fn_17209 UIWindowMgr::ResetWindows: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 10:04:52 +00:00
ragnarok-clanker
6d6e55e3f2 Decompile 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1030 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_17179 UIWindowMgr::InitializeWindowPolicy: logic confirmed by peer review
- fn_17227 UIWindowMgr::LookupWindow: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 10:04:20 +00:00
ragnarok-clanker
07d2f8441c 📝 docs(headers): added inlined comments to method definitions 2026-10-27 10:46:28 +01:00
ragnarok-clanker
ff15df90ad 📝 docs(annotations): marked inlined functions across modules 2026-10-27 10:42:13 +01:00
ragnarok-clanker
d73c3c1296 Decompile 5 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1025 by ragnarok-clanker: 5 byte-identical, 0 confirmed by peer review.

- fn_17831 CWorld::ActiveGameMode: byte-identical
- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)
- fn_17835 CMode::Slot7: byte-identical
- fn_17838 CMode::Slot5: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-27 09:38:13 +00:00
ragnarok-clanker
0d7e98ce6d Confirm 2 functions in Source/UI/Window/UIWindowMgr.cpp, Source/UI/Window/UIWindowMgr.h, ... 
Batch #1011 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_19302 ReplaySection::ReplaySection: byte-identical (already on main)
- fn_19306 ReplaySection::~ReplaySection: byte-identical (already on main)

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/UI/Window/UIWindowMgr.cpp
 2026-10-27 09:02:57 +00:00
ragnarok-clanker
98e3d7fa17 🎨 style(shortcuts): annotated inlined helper functions and updated stdio include 2026-10-27 10:02:55 +01:00
ragnarok-clanker
5aafb686cc 🛠️ refactor(strings): wrote CP949 Korean literals as UTF-8 Hangul with /source-charset:utf-8 /execution-charset:.949 2026-10-27 09:42:20 +01:00
ragnarok-clanker
9434616b2b 🎨 style(UIShortCutWnd): updated include to stdio.h and added function annotation comment 2026-10-27 09:07:49 +01:00
ragnarok-clanker
353cbdcce8 Confirm fn_14417 (CUIDropDownBox::HasChild) 
Batch #973 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_14417 CUIDropDownBox::HasChild: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-27 00:21:44 +00:00
ragnarok-clanker
f7a74bf6bd Decompile 2 functions in Source/UI/Lists/UIListBoxEx.cpp 
Batch #972 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11419 UIListBoxEx::Slot25: logic confirmed by peer review (already on main)
- fn_11157 UIListBoxEx::~UIListBoxEx: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
 2026-10-27 00:21:38 +00:00
ragnarok-clanker
11bd25e013 Decompile 2 functions in Source/UI/Lists/UIComboBoxDefWnd.cpp 
Batch #969 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11133 UIComboBoxDef2Wnd::~UIComboBoxDef2Wnd: logic confirmed by peer review (annotation added to existing code)
- fn_11134 UIComboBoxDefWnd::~UIComboBoxDefWnd: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
 2026-10-27 00:21:23 +00:00
ragnarok-clanker
e0c7070795 Decompile fn_11136 (UIComboBoxEx::~UIComboBoxEx) 
Batch #983 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_11136 UIComboBoxEx::~UIComboBoxEx: logic confirmed by peer review (annotation added to existing code)

Reviewed-by: ragnarok-clanker
 2026-10-27 00:21:17 +00:00
ragnarok-clanker
b2d111d403 Decompile fn_09295 (?Digits@?A0x28e614d0@@YA_NV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) 
Batch #953 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_09295 ?Digits@?A0x28e614d0@@YA_NV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
 2026-10-27 00:02:27 +00:00
ragnarok-clanker
99f060e6a2 Confirm fn_10691 (UICheckBox::~UICheckBox) 
Batch #946 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_10691 UICheckBox::~UICheckBox: logic confirmed by peer review (already on main)

Reviewed-by: ragnarok-clanker
 2026-10-27 00:00:54 +00:00
ragnarok-clanker
2c7250f0c8 Decompile fn_00161 (PriceCommission) 
Batch #898 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_00161 PriceCommission: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/PriceCommission.cpp
 2026-10-26 22:56:16 +00:00
ragnarok-clanker
fa6f84f567 Decompile 4 functions in Source/UI/MiniPartyGrid.cpp, Source/UI/MiniPartyGrid.h 
Batch #847 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_07659 MiniPartyGrid::GetCellPosition: logic confirmed by peer review
- fn_07660 MiniPartyGrid::GetWindowPosition: logic confirmed by peer review
- fn_07661 MiniPartyGrid::FindCell: logic confirmed by peer review
- fn_07662 MiniPartyGrid::BuildAvailableCells: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/UI/MiniPartyGrid.cpp
 2026-10-26 22:51:41 +00:00