Batch #15553 by Yommy: 0 byte-identical, 1 confirmed by peer review.
- fn_20938 CTableMng::WriteEntryQueueXls: logic confirmed by peer review
Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #15556 by Yommy: 2 byte-identical, 1 confirmed by peer review.
- fn_20933 CTableMng::ReadEntryQueueXls: logic confirmed by peer review
- fn_20934 CTableMng::ReadEntryQueueBinary: byte-identical
- fn_20936 CTableMng::AddEntryQueueInfo: byte-identical
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #13011 by cremane: 1 byte-identical, 0 confirmed by peer review.
- fn_20935 CTableMng::Clear: byte-identical
Merged automatically: every function is byte-identical to the original.
TableMng.cpp redeclared a partial, mismatched YExcel API (CompoundDocument
instead of YCompoundFiles::CompoundFile, SetIntegerAlt/SetWStringAlt instead
of BasicExcelCell::Set(int)/Set(const wchar_t*), non-const getters, int
GetTotalRows/GetTotalCols, New(size_t)), so nothing could define it. The
YExcel span was already skipped as runtime_library code.
- ThirdParty/BasicExcel: Yap Chun Wei's public-domain BasicExcel 1.14.
Matches the binary: sizeof(CompoundFile)=0x330, workbook_ at 0x330,
worksheets_ at 0x488, yesheets_ at 0x494, BasicExcelCell 0x28, Workbook()
BOF constants 0x50600/0x7CD19A0/0xC0C9/0x306. Local changes:
- BasicExcel gains unknown_04A0[0x108]: all four operator new calls in
the original allocate 0x5A8, no code reads the tail.
- the default constructor is defined by TableMng.cpp (fn_20498).
- operator<<(wchar_t*) keeps its pre-C++20 overload explicitly.
- TableMng.cpp includes the real header; scores of its 13 functions are
unchanged (td check).
- data/compile.json: shape 4 gets -I ThirdParty/BasicExcel; the library is
shape 11 (shape 8 without the jsoncpp defines/include).
Batch #11163 by ragnarok-clanker: no function's compiled code changes; checked with 226 compiled unit(s), including every includer of Source/Client/Application/UnhandledExceptionHandler.h, Source/Contents/ReputeMgrLoad.inl, Source/Render/RenderSystemBase.h, Source/UI/Lists/UIListBoxTemplate.h, Source/Utility/Async/NRecycleObject.h.
Batch #9211 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_20498 YExcel::BasicExcel::BasicExcel: logic confirmed by peer review
Peer-reviewed-by: secret, superintelligence, seumadruga
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #7158 by Lumen: 0 byte-identical, 2 confirmed by peer review.
- fn_20931 CTableMng::ReadEntryQueue: logic confirmed by peer review (already on main)
- fn_20932 CTableMng::ReadEntryQueueFromXls: logic confirmed by peer review (already on main)
Peer-reviewed-by: eAthena, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #7146 by Lumen: 0 byte-identical, 1 confirmed by peer review.
- fn_20938 CTableMng::WriteEntryQueueXls: logic confirmed by peer review
Peer-reviewed-by: eAthena, Bielhp
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #6348 by KWDev: 0 byte-identical, 1 confirmed by peer review.
- fn_20933 CTableMng::ReadEntryQueueXls: logic confirmed by peer review
Peer-reviewed-by: eAthena, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #5329 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_19673 CEntryQueueMgr::OnResultNotice: logic confirmed by peer review
Peer-reviewed-by: meitogi, alisonrag, tayoba
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #5126 by Yommy: 1 byte-identical, 0 confirmed by peer review.
- fn_20928 CTableMng::ResetTables: byte-identical
Merged automatically: every function is byte-identical to the original.
Batch #5023 by Yommy: 0 byte-identical, 5 confirmed by peer review.
- fn_20925 CTableMng::CTableMng: logic confirmed by peer review
- fn_20929 CTableMng::GetEntryQueueInfo: logic confirmed by peer review
- fn_20934 CTableMng::ReadEntryQueueBinary: logic confirmed by peer review
- fn_20935 CTableMng::Clear: logic confirmed by peer review
- fn_20936 CTableMng::AddEntryQueueInfo: logic confirmed by peer review
Peer-reviewed-by: youko, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Batch #4967 by Yommy: 2 byte-identical, 0 confirmed by peer review.
- fn_20930 CTableMng::Init: byte-identical
- fn_20937 CTableMng::Release: byte-identical
Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/TableMng.cpp
