Commit graph

60 commits

Author SHA1 Message Date
ragnarok-clanker
e2adea64ff Maintenance: Replace raw address calls in SessionMessengerContext::sub_DD9D50 with declared functions (all unported, single caller, s
Batch #8904 by ragnarok-clanker: forced by an admin (0 lower score(s), 1 changed function(s)); checked with 4 compiled unit(s), including every includer of Source/Contents/SimpleStringMgr.h, Source/Contents/Configuration/GameSettingsMgr.h.
2026-10-31 23:01:41 +00:00
ragnarok-clanker
f447e4bf19 Decompile 18 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #8832 by dori: 0 byte-identical, 18 confirmed by peer review.

- fn_06131 sub_6A9A90: logic confirmed by peer review
- fn_06132 sub_6A9B50: logic confirmed by peer review
- fn_06133 sub_6A9C10: logic confirmed by peer review
- fn_06134 sub_6A9CD0: logic confirmed by peer review
- fn_06135 sub_6A9D90: logic confirmed by peer review
- fn_06136 sub_6A9E50: logic confirmed by peer review
- fn_06137 sub_6A9F10: logic confirmed by peer review
- fn_06138 sub_6A9FD0: logic confirmed by peer review
- fn_06139 sub_6AA090: logic confirmed by peer review
- fn_06140 sub_6AA150: logic confirmed by peer review
- fn_06141 sub_6AA210: logic confirmed by peer review
- fn_06142 sub_6AA2D0: logic confirmed by peer review
- fn_06143 sub_6AA390: logic confirmed by peer review
- fn_06144 sub_6AA450: logic confirmed by peer review
- fn_06145 sub_6AA510: logic confirmed by peer review
- fn_06146 sub_6AA5D0: logic confirmed by peer review
- fn_06147 sub_6AA690: logic confirmed by peer review
- fn_06148 sub_6AA750: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 22:59:12 +00:00
ragnarok-clanker
5c0457cf47 Decompile fn_06130 (sub_6A99D0)
Batch #8844 by dori: 0 byte-identical, 1 confirmed by peer review.

- fn_06130 sub_6A99D0: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, System4z, Montyla
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 21:53:02 +00:00
ragnarok-clanker
cd9eba458f Decompile fn_06129 (sub_6A9910)
Batch #8827 by System4z: 0 byte-identical, 1 confirmed by peer review.

- fn_06129 sub_6A9910: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, KWDev, pedrao
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 21:46:13 +00:00
ragnarok-clanker
60af7916a7 Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #8748 by System4z: 0 byte-identical, 7 confirmed by peer review.

- fn_06159 sub_6AAF90: logic confirmed by peer review
- fn_06160 sub_6AB050: logic confirmed by peer review
- fn_06161 sub_6AB110: logic confirmed by peer review
- fn_06162 sub_6AB1D0: logic confirmed by peer review
- fn_06163 sub_6AB290: logic confirmed by peer review
- fn_06164 sub_6AB350: logic confirmed by peer review
- fn_06165 sub_6AB410: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Lumen, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:49:00 +00:00
ragnarok-clanker
b4b279c70d Decompile 10 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #8728 by System4z: 0 byte-identical, 10 confirmed by peer review.

- fn_06149 sub_6AA810: logic confirmed by peer review
- fn_06150 sub_6AA8D0: logic confirmed by peer review
- fn_06151 sub_6AA990: logic confirmed by peer review
- fn_06152 sub_6AAA50: logic confirmed by peer review
- fn_06153 sub_6AAB10: logic confirmed by peer review
- fn_06154 sub_6AABD0: logic confirmed by peer review
- fn_06155 sub_6AAC90: logic confirmed by peer review
- fn_06156 sub_6AAD50: logic confirmed by peer review
- fn_06157 sub_6AAE10: logic confirmed by peer review
- fn_06158 sub_6AAED0: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Lumen, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:43:35 +00:00
ragnarok-clanker
b6ef70736b Decompile 10 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #8718 by System4z: 0 byte-identical, 10 confirmed by peer review.

- fn_06119 sub_6A9190: logic confirmed by peer review
- fn_06120 sub_6A9250: logic confirmed by peer review
- fn_06121 sub_6A9310: logic confirmed by peer review
- fn_06122 sub_6A93D0: logic confirmed by peer review
- fn_06123 sub_6A9490: logic confirmed by peer review
- fn_06124 sub_6A9550: logic confirmed by peer review
- fn_06125 sub_6A9610: logic confirmed by peer review
- fn_06126 sub_6A96D0: logic confirmed by peer review
- fn_06127 sub_6A9790: logic confirmed by peer review
- fn_06128 sub_6A9850: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:28:09 +00:00
ragnarok-clanker
06e49abe76 Decompile 8 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #8698 by System4z: 0 byte-identical, 8 confirmed by peer review.

- fn_06099 sub_6A8290: logic confirmed by peer review
- fn_06100 sub_6A8350: logic confirmed by peer review
- fn_06102 sub_6A84D0: logic confirmed by peer review
- fn_06103 sub_6A8590: logic confirmed by peer review
- fn_06104 sub_6A8650: logic confirmed by peer review
- fn_06106 sub_6A87D0: logic confirmed by peer review
- fn_06107 sub_6A8890: logic confirmed by peer review
- fn_06108 sub_6A8950: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:15:37 +00:00
ragnarok-clanker
a191089c9e Decompile 10 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #8648 by System4z: 0 byte-identical, 10 confirmed by peer review.

- fn_06059 sub_6A6490: logic confirmed by peer review
- fn_06060 sub_6A6550: logic confirmed by peer review
- fn_06061 sub_6A6610: logic confirmed by peer review
- fn_06062 sub_6A66D0: logic confirmed by peer review
- fn_06063 sub_6A6790: logic confirmed by peer review
- fn_06064 sub_6A6850: logic confirmed by peer review
- fn_06065 sub_6A6910: logic confirmed by peer review
- fn_06066 sub_6A69D0: logic confirmed by peer review
- fn_06067 sub_6A6A90: logic confirmed by peer review
- fn_06068 sub_6A6B50: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 20:01:54 +00:00
ragnarok-clanker
fafc6d3cf8 Decompile fn_06205 (EquipmentProperties::CEquipmentPropertiesMgr::RefreshWearable)
Batch #8598 by Montyla: 0 byte-identical, 1 confirmed by peer review.

- fn_06205 EquipmentProperties::CEquipmentPropertiesMgr::RefreshWearable: logic confirmed by peer review

Peer-reviewed-by: youko, System4z, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 19:36:47 +00:00
ragnarok-clanker
8983aa27ca Decompile fn_06203 (EquipmentProperties::CEquipmentPropertiesMgr::UnequipWearable)
Batch #8543 by Montyla: 0 byte-identical, 1 confirmed by peer review.

- fn_06203 EquipmentProperties::CEquipmentPropertiesMgr::UnequipWearable: logic confirmed by peer review

Peer-reviewed-by: Yommy, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 18:55:54 +00:00
ragnarok-clanker
ebcefad752 Maintenance: Remove the duplicate definition of gl_24635 g_inputSuggestionsEnabled (kept the one in UIEditCtrl.cpp, which the header
Batch #8293 by ragnarok-clanker: no function's compiled code changes; checked with 2 compiled unit(s).
2026-10-31 16:15:58 +00:00
ragnarok-clanker
362e2ce41f Decompile 5 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #7677 by secret: 0 byte-identical, 5 confirmed by peer review.

- fn_05780 EquipmentProperties::CEquipmentProperties1Dim::Describe: logic confirmed by peer review
- fn_05781 EquipmentProperties::CEquipmentProperties2Dim::Describe: logic confirmed by peer review
- fn_06195 EquipmentProperties::CEquipmentPropertiesMgr::LoadGradeBonus: logic confirmed by peer review
- fn_06196 EquipmentProperties::CEquipmentPropertiesMgr::LoadIgnoreEquipmentProperties: logic confirmed by peer review
- fn_06198 EquipmentProperties::CEquipmentPropertiesMgr::LoadRefiningBonus: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 11:05:37 +00:00
ragnarok-clanker
f758447dc1 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #7615 by secret: 0 byte-identical, 2 confirmed by peer review.

- fn_06176 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0094: logic confirmed by peer review
- fn_06184 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown0174: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 10:44:51 +00:00
ragnarok-clanker
91ba72ec70 Decompile fn_05637 (EquipmentProperties::CEquipmentWearable::Load)
Batch #7489 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_05637 EquipmentProperties::CEquipmentWearable::Load: logic confirmed by peer review

Peer-reviewed-by: secret, meitogi, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 09:53:07 +00:00
ragnarok-clanker
04dd6ee701 Decompile fn_21742 (CGameMode::Zc_Mer_Par_Change)
Batch #7439 by aDw: 0 byte-identical, 1 confirmed by peer review.

- fn_21742 CGameMode::Zc_Mer_Par_Change: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 07:18:59 +00:00
ragnarok-clanker
fb63cd1811 Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Mode/CGameMode.h
Batch #7338 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_06173 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown01DC: logic confirmed by peer review
- fn_06292 SetEquipTempValue: logic confirmed by peer review
- fn_21741 CGameMode::Zc_Mer_Init: logic confirmed by peer review

Peer-reviewed-by: meitogi, gordaoprogramas, aDw
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:50:19 +00:00
ragnarok-clanker
ce1518afd6 Decompile fn_06279 (GetEquipTempValue)
Batch #7340 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_06279 GetEquipTempValue: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 06:19:36 +00:00
ragnarok-clanker
193e024ae3 Decompile fn_22148 (CGameMode::ReceiveShopItemList)
Batch #6882 by Romain: 0 byte-identical, 1 confirmed by peer review.

- fn_22148 CGameMode::ReceiveShopItemList: logic confirmed by peer review

Peer-reviewed-by: superintelligence, Snow, Landruca
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 03:08:29 +00:00
ragnarok-clanker
fea23c1e0d Decompile fn_06293 (EquipmentPropertyDefinition::IsTwoDimensional)
Batch #6541 by gordaoprogramas: 1 byte-identical, 0 confirmed by peer review.

- fn_06293 EquipmentPropertyDefinition::IsTwoDimensional: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-31 01:15:00 +00:00
ragnarok-clanker
b38f380adc Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #6333 by superintelligence: 0 byte-identical, 3 confirmed by peer review.

- fn_06278 GetEquipGrade: logic confirmed by peer review
- fn_06281 GetEquipItemId: logic confirmed by peer review
- fn_06286 GetEquipRefine: logic confirmed by peer review

Peer-reviewed-by: eAthena, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 22:04:07 +00:00
ragnarok-clanker
c98925aa4d Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #6053 by superintelligence: 0 byte-identical, 2 confirmed by peer review.

- fn_23832 FindGroupedSkill: logic confirmed by peer review
- fn_06287 GetSkillLevel: logic confirmed by peer review

Peer-reviewed-by: eAthena, Lumen, meitogi, willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 19:21:14 +00:00
ragnarok-clanker
e25efe0708 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #6043 by superintelligence: 0 byte-identical, 4 confirmed by peer review.

- fn_05621 EquipmentProperties::CEquipmentWearable::UpdateActive: logic confirmed by peer review
- fn_06206 EquipmentProperties::CEquipmentPropertiesMgr::RefreshShop: logic confirmed by peer review
- fn_23398 FindShop: logic confirmed by peer review
- fn_23485 FindShopId: logic confirmed by peer review

Peer-reviewed-by: eAthena, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 18:34:56 +00:00
ragnarok-clanker
46872f095e Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Mode/CGameMode.h
Batch #5846 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_21271 CGameMode::GetClosestValidCell: logic confirmed by peer review
- fn_21295 CGameMode::IsValidCell: logic confirmed by peer review
- fn_06187 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0114: logic confirmed by peer review

Peer-reviewed-by: willerthal, SapitoSucio, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 16:45:14 +00:00
ragnarok-clanker
63b4c6652c Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h
Batch #5324 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_06284 GetPetRelationship: logic confirmed by peer review
- fn_06288 GetPlayerValue: logic confirmed by peer review

Peer-reviewed-by: meitogi, Millenium, Snow, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 11:38:40 +00:00
ragnarok-clanker
138838f24c Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #5095 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_06168 EquipmentProperties::CEquipmentPropertiesMgr::ApplyProperty: logic confirmed by peer review (annotation added to existing code)
- fn_06169 EquipmentProperties::CEquipmentPropertiesMgr::EquipItem: logic confirmed by peer review (annotation added to existing code)
- fn_06171 EquipmentProperties::CEquipmentPropertiesMgr::UnequipItem: logic confirmed by peer review (annotation added to existing code)
- fn_06182 EquipmentProperties::CEquipmentPropertiesMgr::GetDescriptions: logic confirmed by peer review (annotation added to existing code)
- fn_06277 GetEquipArmorLv: logic confirmed by peer review (annotation added to existing code)
- fn_06280 GetEquipWeaponLv: logic confirmed by peer review (annotation added to existing code)
- fn_06289 GetWeaponClass: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:29:45 +00:00
ragnarok-clanker
efb38781a2 Decompile 6 functions in Source/UI/Window/WindowAncestry.cpp, Source/UI/MiniPartyManager.cpp, ...
Batch #5179 by eAthena: 2 byte-identical, 4 confirmed by peer review.

- fn_16989 UIWindow::BroadcastMsg4: byte-identical
- fn_16990 UIWindow::BroadcastMsg3: byte-identical
- fn_16924 UIWindow::PropagateMsg: logic confirmed by peer review
- fn_17214 UIWindowMgr::ArrangeMiniPartyWindows: logic confirmed by peer review
- fn_17164 UIWindowMgr::FindItemWindow: logic confirmed by peer review
- fn_17230 UIWindowMgr::NotifyMemberWindows: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:23:29 +00:00
ragnarok-clanker
a92d988fa7 Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #5186 by youko: 0 byte-identical, 3 confirmed by peer review.

- fn_06185 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown01BC: logic confirmed by peer review (annotation added to existing code)
- fn_06200 EquipmentProperties::CEquipmentPropertiesMgr::AddExpansion: logic confirmed by peer review (annotation added to existing code)
- fn_06204 EquipmentProperties::CEquipmentPropertiesMgr::RefreshExpansion: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 09:16:18 +00:00
ragnarok-clanker
dfc9404c53 Decompile 17 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #5152 by youko: 0 byte-identical, 17 confirmed by peer review.

- fn_05620 EquipmentProperties::CEquipment::AddProperty: logic confirmed by peer review (annotation added to existing code)
- fn_05634 EquipmentProperties::CEquipmentAttachable::Load: logic confirmed by peer review (annotation added to existing code)
- fn_05635 EquipmentProperties::CEquipmentCombiitem::Load: logic confirmed by peer review (annotation added to existing code)
- fn_05636 EquipmentProperties::CEquipmentExpansion::Load: logic confirmed by peer review (annotation added to existing code)
- fn_05639 EquipmentProperties::CEquipmentCombiitem::Clear: logic confirmed by peer review (annotation added to existing code)
- fn_05640 EquipmentProperties::CEquipmentExpansion::Clear: logic confirmed by peer review (annotation added to existing code)
- fn_05641 EquipmentProperties::CEquipmentWearable::Clear: logic confirmed by peer review (annotation added to existing code)
- fn_05643 EquipmentProperties::CEquipment::NotifyProperties: logic confirmed by peer review (annotation added to existing code)
- fn_05769 EquipmentPropertyStore::operator+=: logic confirmed by peer review (annotation added to existing code)
- fn_05770 EquipmentPropertyStore::operator+=: logic confirmed by peer review (annotation added to existing code)
- fn_05782 EquipmentProperties::CEquipmentProperties::Describe: logic confirmed by peer review (annotation added to existing code)
- fn_05783 EquipmentPropertyStore::RemoveDuplicateNames: logic confirmed by peer review (annotation added to existing code)
- fn_06183 EquipmentProperties::CEquipmentPropertiesMgr::FindDefinition: logic confirmed by peer review (annotation added to existing code)
- fn_06202 EquipmentProperties::CEquipmentPropertiesMgr::RemoveExpansion: logic confirmed by peer review (annotation added to existing code)
- fn_06207 EquipmentProperties::CEquipmentPropertiesMgr::Rebuild: logic confirmed by peer review (annotation added to existing code)
- fn_06208 EquipmentProperties::CEquipmentPropertiesMgr::SetCurrentEquipment: logic confirmed by peer review (annotation added to existing code)
- fn_06211 EquipmentProperties::CEquipmentPropertiesMgr::RefreshPretend: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: Yommy, alisonrag, OvoKore
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 08:55:58 +00:00
ragnarok-clanker
d6927491ac Decompile fn_05771 (EquipmentPropertyStore::Clear)
Batch #5098 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:46:39 +00:00
ragnarok-clanker
c8363bd3af Decompile 15 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Script/LuaInstance.h, ...
Batch #4203 by Yommy: 2 byte-identical, 13 confirmed by peer review.

- fn_05609 EquipmentProperties::CEquipmentProperties2Dim::`scalar deleting destructor': logic confirmed by peer review
- fn_05610 EquipmentProperties::CEquipmentProperties1Dim::`scalar deleting destructor': logic confirmed by peer review
- fn_05924 CLuaInstance::GetFieldInt: logic confirmed by peer review
- fn_05925 CLuaInstance::GetFieldUIntArray: logic confirmed by peer review
- fn_05926 CLuaInstance::GetFieldString: logic confirmed by peer review
- fn_05927 CLuaInstance::GetFieldStringArray: logic confirmed by peer review
- fn_05928 CLuaInstance::GetFieldUIntMap: logic confirmed by peer review
- fn_05929 CLuaInstance::GetFieldStringMap: logic confirmed by peer review
- fn_05930 CLuaInstance::GetInt: logic confirmed by peer review
- fn_06054 MessengerIntrusiveLink::Unlink6A6220: byte-identical
- fn_06055 MessengerIntrusiveLink::Unlink6A6240: byte-identical
- fn_21291 CGameMode::IsAllowedPair: logic confirmed by peer review
- fn_21292 CGameMode::IsWithinRange: logic confirmed by peer review
- fn_21293 CGameMode::IsRegisterCell: logic confirmed by peer review
- fn_21294 CGameMode::HasUnknown01A4: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, youko, eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 02:09:29 +00:00
ragnarok-clanker
519897f39c Decompile 11 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Contents/Configuration/ServiceOptions.cpp
Batch #3991 by eAthena: 0 byte-identical, 11 confirmed by peer review.

- fn_06282 GetLocation: logic confirmed by peer review
- fn_06283 GetMapName: logic confirmed by peer review
- fn_06285 GetPureJob: logic confirmed by peer review
- fn_06290 IsPremiumPcCafe: logic confirmed by peer review
- fn_06291 C_Logger: logic confirmed by peer review
- fn_06299 CGameSettingsMgr::CGameSettingsMgr: logic confirmed by peer review
- fn_06312 CGameSettingsMgr::sub_6C0C40: logic confirmed by peer review
- fn_06313 CGameSettingsMgr::RunFunction: logic confirmed by peer review
- fn_06314 FindServiceOption: logic confirmed by peer review
- fn_06315 CGameSettingsMgr::FindOption: logic confirmed by peer review
- fn_06316 CGameSettingsMgr::GetOptionIds: logic confirmed by peer review

Peer-reviewed-by: willerthal, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 00:25:49 +00:00
ragnarok-clanker
eadfed23ac Decompile fn_06190 (EquipmentProperties::CEquipmentPropertiesMgr::HasUnknown0194)
Batch #3437 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06190 EquipmentProperties::CEquipmentPropertiesMgr::HasUnknown0194: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 22:32:20 +00:00
ragnarok-clanker
bc42630e18 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3306 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_06181 GetNormalThirdJob: logic confirmed by peer review
- fn_06186 GetEquipLocationIndex: logic confirmed by peer review
- fn_06275 CheckJobGroup2: logic confirmed by peer review
- fn_06276 GetCategoryJob: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:18:37 +00:00
ragnarok-clanker
2854886158 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3297 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_06180 GetNormalJob: logic confirmed by peer review
- fn_06187 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0114: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:17:19 +00:00
ragnarok-clanker
3ea6c404f6 Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3296 by eAthena: 0 byte-identical, 7 confirmed by peer review.

- fn_06210 EquipmentProperties::CEquipmentPropertiesMgr::SetWindow: logic confirmed by peer review
- fn_06172 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown0134: logic confirmed by peer review
- fn_06175 EquipmentProperties::CEquipmentPropertiesMgr::FindProperty1: logic confirmed by peer review
- fn_06176 EquipmentProperties::CEquipmentPropertiesMgr::FindUnknown0094: logic confirmed by peer review
- fn_06177 GetEquipLocationMask: logic confirmed by peer review
- fn_06179 GetFirstJob: logic confirmed by peer review
- fn_06184 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown0174: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:17:02 +00:00
ragnarok-clanker
fb1b1398a3 Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3009 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_05600 EquipmentProperties::CEquipmentCombiitem::CEquipmentCombiitem: logic confirmed by peer review
- fn_05601 EquipmentProperties::CEquipmentExpansion::CEquipmentExpansion: logic confirmed by peer review

Peer-reviewed-by: meitogi, superintelligence
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:16:46 +00:00
ragnarok-clanker
2564c10e3a Decompile 6 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #3158 by superintelligence: 6 byte-identical, 0 confirmed by peer review.

- fn_05647 ClientMessengerSelf::Self68D5B0: byte-identical
- fn_05648 ClientMessengerSelf::Self68D5C0: byte-identical
- fn_05786 ClientMessengerSelf::Self69ACB0: byte-identical
- fn_05787 ClientMessengerSelf::Self69ACC0: byte-identical
- fn_05656 sub_68DAF0: byte-identical
- fn_06015 sub_6A2170: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:39:36 +00:00
ragnarok-clanker
a3fe0d284a Decompile 11 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Archive/GPak.cpp
Batch #3121 by superintelligence: 11 byte-identical, 0 confirmed by peer review.

- fn_05611 MessengerIntrusiveLink::Unlink68B6A0: byte-identical
- fn_06045 MessengerIntrusiveLink::Unlink6A6100: byte-identical
- fn_06046 MessengerIntrusiveLink::Unlink6A6120: byte-identical
- fn_06047 MessengerIntrusiveLink::Unlink6A6140: byte-identical
- fn_06048 MessengerIntrusiveLink::Unlink6A6160: byte-identical
- fn_06049 MessengerIntrusiveLink::Unlink6A6180: byte-identical
- fn_06050 MessengerIntrusiveLink::Unlink6A61A0: byte-identical
- fn_06051 MessengerIntrusiveLink::Unlink6A61C0: byte-identical
- fn_06052 MessengerIntrusiveLink::Unlink6A61E0: byte-identical
- fn_06053 MessengerIntrusiveLink::Unlink6A6200: byte-identical
- fn_05092 PakIntrusiveLink::Unlink657820: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:33:13 +00:00
ragnarok-clanker
490be6d791 Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2987 by eAthena: 3 byte-identical, 0 confirmed by peer review.

- fn_06174 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown001C: byte-identical
- fn_06178 EquipmentProperties::CEquipmentPropertiesMgr::GetScript: byte-identical
- fn_06188 EquipmentProperties::CEquipmentPropertiesMgr::GetUnknown019C: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 20:09:25 +00:00
ragnarok-clanker
0bccb17819 Decompile 7 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2894 by youko: 0 byte-identical, 7 confirmed by peer review.

- fn_05738 EquipmentProperties::CEquipmentProperties::CEquipmentProperties: logic confirmed by peer review
- fn_05767 EquipmentProperties::CEquipmentProperties2Dim::Accumulate: logic confirmed by peer review
- fn_05772 EquipmentProperties::CEquipmentProperties1Dim::Clone: logic confirmed by peer review
- fn_05773 EquipmentProperties::CEquipmentProperties2Dim::Clone: logic confirmed by peer review
- fn_05774 EquipmentProperties::CEquipmentProperties::Clone: logic confirmed by peer review
- fn_05779 EquipmentProperties::CEquipmentProperties2Dim::SetValue: logic confirmed by peer review
- fn_05766 EquipmentProperties::CEquipmentProperties1Dim::Accumulate: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 20:05:50 +00:00
ragnarok-clanker
e83bd02c0b Decompile 2 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2679 by youko: 0 byte-identical, 2 confirmed by peer review.

- fn_05778 EquipmentProperties::CEquipmentProperties1Dim::SetValue: logic confirmed by peer review
- fn_05626 EquipmentProperties::CEquipmentExpansion::GetSuffix: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Reviewed-by: ragnarok-clanker
2026-10-29 18:33:12 +00:00
ragnarok-clanker
c0f51e0c22 Decompile 8 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #2685 by youko: 8 byte-identical, 0 confirmed by peer review.

- fn_05775 EquipmentPropertyStore::GetProperties: byte-identical
- fn_05776 EquipmentPropertyStore::GetCount: byte-identical
- fn_05777 EquipmentPropertyStore::GetNames: byte-identical
- fn_05808 EquipmentPropertyGroup::GetName: byte-identical
- fn_05809 EquipmentPropertyGroup::GetDefinitions: byte-identical
- fn_05623 EquipmentProperties::CEquipmentWearable::GetAttachables: byte-identical
- fn_05625 EquipmentProperties::CEquipmentAttachable::GetOwner: byte-identical
- fn_05627 EquipmentProperties::CEquipmentWearable::IsActive: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 18:24:41 +00:00
ragnarok-clanker
f6ddf78090 Rename ItemInfo -> ITEM_INFO (DHXJ). Pure rename, codegen unchanged (1109/1109 functions identical with includers). 2026-10-29 12:30:02 +01:00
ragnarok-clanker
d9580bfeda Rename CWorld -> CModeMgr (g_world -> g_modeMgr, ActiveGameMode.{h,cpp} -> ModeMgr.{h,cpp}) and WorldScene -> CWorld (WorldScene.h -> World.h), as in DHXJ. Pure rename, codegen unchanged (707/707 functions identical with includers). 2026-10-29 12:27:01 +01:00
ragnarok-clanker
385c906a98 Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers). 2026-10-29 12:09:28 +01:00
ragnarok-clanker
bf62e1d8ca Decompile fn_05766 (EquipmentProperties::CEquipmentProperties1Dim::Accumulate)
Batch #1988 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_05766 EquipmentProperties::CEquipmentProperties1Dim::Accumulate: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:53 +00:00
ragnarok-clanker
42fd7a215e Decompile 3 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1981 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_05739 EquipmentProperties::CEquipmentProperties::CEquipmentProperties: logic confirmed by peer review
- fn_05736 EquipmentProperties::CEquipmentProperties1Dim::CEquipmentProperties1Dim: logic confirmed by peer review
- fn_05737 EquipmentProperties::CEquipmentProperties2Dim::CEquipmentProperties2Dim: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-29 08:58:24 +00:00
ragnarok-clanker
7e716e8506 Decompile fn_05768 (EquipmentProperties::CEquipmentProperties::Accumulate)
Batch #1982 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_05768 EquipmentProperties::CEquipmentProperties::Accumulate: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 00:46:29 +00:00
ragnarok-clanker
835fb15cc9 Decompile 4 functions in Source/Contents/Messenger/ClientMessenger.cpp
Batch #1979 by ragnarok-clanker: 4 byte-identical, 0 confirmed by peer review.

- fn_05629 EquipmentProperties::CEquipmentAttachable::GetType: byte-identical
- fn_05630 EquipmentProperties::CEquipmentCombiitem::GetType: byte-identical
- fn_05631 EquipmentProperties::CEquipmentExpansion::GetType: byte-identical
- fn_05632 EquipmentProperties::CEquipmentWearable::GetType: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 00:39:49 +00:00