Commit graph

76 commits

Author SHA1 Message Date
ragnarok-clanker
faae91cc6d Decompile fn_17826 (CMode::DrawTexture)
Batch #1600 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17826 CMode::DrawTexture: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:49:26 +00:00
ragnarok-clanker
c934fe7820 Decompile 2 functions in Source/UI/Shortcuts/ShortcutCooldowns.cpp, Source/Client/Session.h
Batch #1653 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23876 CSession::IsSkillIdInRange6018: logic confirmed by peer review
- fn_23877 CSession::IsSkillIdInRange6001: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 19:47:58 +00:00
ragnarok-clanker
94649ccac7 Decompile 5 functions in Source/Client/ReplayPacketRecorder.cpp, Source/Client/ReplayPacketRecorder.h, ...
Batch #1630 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_17000 WindowReplayRecorder::RecordDrop: logic confirmed by peer review
- fn_17001 WindowReplayRecorder::RecordData: logic confirmed by peer review
- fn_17002 WindowReplayRecorder::RecordValues: logic confirmed by peer review
- fn_17003 WindowReplayRecorder::RecordText: logic confirmed by peer review
- fn_19331 Replay::RecordPacket: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:46:26 +00:00
ragnarok-clanker
4bce141e4c Decompile fn_23811 (CSession::GetPetHungryStateString)
Batch #1625 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23811 CSession::GetPetHungryStateString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:45:56 +00:00
ragnarok-clanker
6ebe295226 Decompile fn_23814 (CSession::GetPetTalkName)
Batch #1621 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23814 CSession::GetPetTalkName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetTalkNames.cpp
2026-10-28 19:45:23 +00:00
ragnarok-clanker
96c3974f4c Decompile fn_17830 (SanitizeScreenshotName)
Batch #1616 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17830 SanitizeScreenshotName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeScreenshot.cpp
2026-10-28 19:44:47 +00:00
ragnarok-clanker
4f43f6132f Decompile fn_17829 (ShowErrorDialog)
Batch #1611 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_17829 ShowErrorDialog: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:44:24 +00:00
ragnarok-clanker
4f48baf914 Decompile 2 functions in Source/Client/ModeTransitions.cpp, Source/Client/Mode/ActiveGameMode.h
Batch #1610 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_17845 CWorld::Quit: logic confirmed by peer review
- fn_17851 CWorld::Switch: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Client/ModeTransitions.cpp
2026-10-28 19:44:21 +00:00
ragnarok-clanker
499d5b8558 Decompile 2 functions in Source/Contents/MonsterResources.cpp, Source/Client/Session.h
Batch #1608 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23790 CSession::GetMonsterSprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterResources.cpp
2026-10-28 19:44:03 +00:00
ragnarok-clanker
c3fe24e020 Decompile 2 functions in Source/Contents/ActorMovementRoute.cpp, Source/Contents/Actors/GameActor.h, ...
Batch #1601 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_19317 Replay::DelayScale: logic confirmed by peer review
- fn_21028 CGameActor::FindRoute: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ActorMovementRoute.cpp
2026-10-28 19:42:58 +00:00
ragnarok-clanker
1ebead0e33 Decompile fn_21632 (CGameMode::ReceiveActorNameAll)
Batch #1591 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_21632 CGameMode::ReceiveActorNameAll: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Network/ActorNamePacket.cpp
2026-10-28 19:42:41 +00:00
ragnarok-clanker
838c0044d2 Decompile 70 functions in Source/Client/Browser/BrowserFactory.cpp, Source/Contents/Emblems/EmblemUpload.cpp, ...
Batch #1665 by ragnarok-clanker: 0 byte-identical, 70 confirmed by peer review.

- fn_10904 UIEditCtrl::UpdateLinks: logic confirmed by peer review
- fn_10905 EditViewport::Synchronize: logic confirmed by peer review
- fn_10950 UIBalloonText::SetText: logic confirmed by peer review
- fn_11216 ItemLinkDisplay::Convert: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review (already on main)
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review (already on main)
- fn_11366 UIListBox::Paint: logic confirmed by peer review
- fn_11367 UIListBoxEx::Paint: logic confirmed by peer review
- fn_11392 UITextButton::Paint: logic confirmed by peer review
- fn_11394 UITextViewer::Paint: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review (already on main)
- fn_11471 UITextButton::Slot27: logic confirmed by peer review (already on main)
- fn_11494 UITextButton::Slot33: logic confirmed by peer review (already on main)
- fn_11562 UITextViewer::SendMsg: logic confirmed by peer review (already on main)
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review (already on main)
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review (already on main)
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review (already on main)
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review (already on main)
- fn_12680 ShortcutPainting::Paint: logic confirmed by peer review
- fn_13829 WrapPlainText: logic confirmed by peer review
- fn_13833 WrapRichText: logic confirmed by peer review
- fn_16941 UIWindow::DrawAmount: logic confirmed by peer review
- fn_16971 UIWindow::TextHeight: logic confirmed by peer review
- fn_16972 UIWindow::VerticalTextHeight: logic confirmed by peer review
- fn_16973 UIWindow::TextSize: logic confirmed by peer review
- fn_16974 UIWindow::VerticalTextSize: logic confirmed by peer review
- fn_16975 UIWindow::TextWidth: logic confirmed by peer review
- fn_16993 WrapPixelText: logic confirmed by peer review
- fn_17007 FitText: logic confirmed by peer review
- fn_17009 UIWindow::DrawTextAt: logic confirmed by peer review
- fn_17013 DrawOutlinedColoredText: logic confirmed by peer review
- fn_17014 DrawStyledColoredText: logic confirmed by peer review
- fn_17015 DrawColoredText: logic confirmed by peer review
- fn_17016 DrawOutlinedText: logic confirmed by peer review
- fn_17136 BrowserFactory::Create: logic confirmed by peer review
- fn_18376 LookupMessage: logic confirmed by peer review
- fn_01934 TextContext::TextContext: logic confirmed by peer review
- fn_01957 TextContext::Marker: logic confirmed by peer review
- fn_01961 TextContext::Measure: logic confirmed by peer review
- fn_01966 TextContext::SetFont: logic confirmed by peer review
- fn_01970 TextContext::DrawPair: logic confirmed by peer review
- fn_01971 TextContext::Draw: logic confirmed by peer review
- fn_01983 TextContext::MeasurePart: logic confirmed by peer review
- fn_01984 TextContext::DrawPart: logic confirmed by peer review
- fn_21788 ReceivePartyJoinResult: logic confirmed by peer review
- fn_24191 EmotionHotkeys::LoadDefaults: logic confirmed by peer review
- fn_03664 CAdventurerAgencyMgr::CompletePartyInfo: logic confirmed by peer review
- fn_03666 CAdventurerAgencyMgr::CompleteRegistration: logic confirmed by peer review
- fn_03668 CAdventurerAgencyMgr::CompleteStopRecruiting: logic confirmed by peer review
- fn_03976 CEmblemDataMgr::CompleteUpload: logic confirmed by peer review
- fn_04239 CMCStoreInfoBackup::CompleteSave: logic confirmed by peer review
- fn_04262 CPlayerNameDictionary::Lookup: logic confirmed by peer review
- fn_06581 ItemNaming::DisplayName: logic confirmed by peer review (already on main)
- fn_06583 ItemNamingContext::Element: logic confirmed by peer review (already on main)
- fn_06584 ItemNamingContext::Star: logic confirmed by peer review (already on main)
- fn_06585 ItemNaming::Creator: logic confirmed by peer review (already on main)
- fn_06586 ItemNamingContext::Apprentice: logic confirmed by peer review (already on main)
- fn_06587 ItemNaming::Suffixes: logic confirmed by peer review (already on main)
- fn_06588 ItemNaming::Prefixes: logic confirmed by peer review (already on main)
- fn_09299 UIApplyForPartyWnd::Slot15: logic confirmed by peer review
- fn_09300 UIRegisterPartyWnd::Slot15: logic confirmed by peer review
- fn_09301 UIRequestJoinPartyWnd::Slot15: logic confirmed by peer review
- fn_09303 UIApplyForPartyWnd::Paint: logic confirmed by peer review
- fn_09304 UIPartyInfoWnd::Paint: logic confirmed by peer review
- fn_10748 UIEditCtrl::RemoveInvalidLink: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review (already on main)
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review (already on main)
- fn_10794 UIBasicButton::Paint: logic confirmed by peer review
- fn_10799 UIBmpTextButton::Paint: logic confirmed by peer review
- fn_10823 UITransBalloonText::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:35:29 +00:00
ragnarok-clanker
f464cd3f17 Decompile 41 functions in Source/Client/Input/InputCharset.cpp, Source/Client/Input/InputCharset.h, ...
Batch #1607 by ragnarok-clanker: 0 byte-identical, 41 confirmed by peer review.

- fn_11718 DrawItemIconById: logic confirmed by peer review
- fn_11719 DrawItemSlotBackground: logic confirmed by peer review
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review
- fn_12089 UIWindow::DrawButtonBarAt: logic confirmed by peer review
- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12120 UIWindow::LoadStyledBitmap: logic confirmed by peer review
- fn_12219 UIDisconnectedServerMsgWnd::Paint: logic confirmed by peer review
- fn_12233 UINoticeConfirmWnd::Paint: logic confirmed by peer review
- fn_12245 UIQuitWnd::Paint: logic confirmed by peer review
- fn_12246 UIRestartWnd::Paint: logic confirmed by peer review
- fn_12258 UIWaitWnd::Paint: logic confirmed by peer review
- fn_14470 CUIFrameWnd::RefreshSkinColors: logic confirmed by peer review
- fn_14471 CUIFrameWnd::Paint: logic confirmed by peer review
- fn_14472 CUIFrameWnd::SetSkinColors: logic confirmed by peer review
- fn_14635 CUIControl::LoadBitmapResource: logic confirmed by peer review
- fn_17781 InputCharset::Prefix: logic confirmed by peer review
- fn_17788 InputCharset::ServiceName: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_18378 Resolve: logic confirmed by peer review
- fn_02111 RendererDX7Operations::SaveLogo: logic confirmed by peer review
- fn_09446 UICashEmotionPack::Paint: logic confirmed by peer review
- fn_09453 UICashEmotionPack::SetSaleBadge: logic confirmed by peer review
- fn_09483 UICashEmotionPiece::Paint: logic confirmed by peer review
- fn_45445 CSkinMgr::CSkinMgr: logic confirmed by peer review
- fn_09681 CSkinMgr::~CSkinMgr: logic confirmed by peer review
- fn_09683 CSkinMgr::Prepare: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review
- fn_09686 CSkinMgr::Name: logic confirmed by peer review
- fn_09687 CSkinMgr::Prefix: logic confirmed by peer review
- fn_09688 CSkinMgr::Name: logic confirmed by peer review
- fn_09690 CSkinMgr::Selected: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SkinMgr.cpp
2026-10-28 19:13:07 +00:00
ragnarok-clanker
b496a618dc Decompile 2 functions in Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp, ...
Batch #1582 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23486 CSession::GetRobeAlpha: logic confirmed by peer review
- fn_24176 CSession::IsTopLayerRobe: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp
2026-10-28 19:10:37 +00:00
ragnarok-clanker
9312817430 Maintenance: Define two globals that main reads but never defines. g_applicationDirectory (gl_24584, 0x173AD78, char[0x80]) has one w
Batch #1570 by ragnarok-clanker: no function's compiled code changes; checked with 5 compiled unit(s), including every includer of Source/Client/Application/Launcher.h, Source/Client/Input/InputCharset.h.
2026-10-28 18:59:30 +00:00
ragnarok-clanker
3d4b2c79dc Decompile 2 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UIMerInfoWnd.h, ...
Batch #1553 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11712 UIBank_NewWnd::TransactionAmount: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 18:50:35 +00:00
ragnarok-clanker
4cf3413524 Decompile 4 functions in Source/Client/Mode/CGameMode.h, Source/Contents/Ground/TerrainCoordinates.cpp, ...
Batch #1556 by ragnarok-clanker: 2 byte-identical, 2 confirmed by peer review.

- fn_19489 CNavi_Link::GetLinkedInfo: byte-identical
- fn_19481 CNaviInfo::IsVisited: byte-identical
- fn_45449 CNaviData::Clear: logic confirmed by peer review
- fn_19371 CNaviData::~CNaviData: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/NavigationDestinations.cpp, Source/Contents/NavigationGraph.cpp, Source/Contents/WorldNavigation.cpp
2026-10-28 18:48:31 +00:00
ragnarok-clanker
943d22d0b8 Decompile fn_11762 (UICntWnd::Paint)
Batch #1544 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_11762 UICntWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 17:58:13 +00:00
ragnarok-clanker
d525ec0c0a Maintenance: Define the window handle global hWnd (gl_24399, 0x173AD68, 4 bytes, zero-initialized .data with no file backing). Its on
Batch #1489 by ragnarok-clanker: no function's compiled code changes; checked with 3 compiled unit(s), including every includer of Source/Client/Application/ApplicationWindow.h.
2026-10-28 16:47:41 +00:00
ragnarok-clanker
63b1377599 Decompile 5 functions in Source/Client/ReplayPacketRecorder.h, Source/Contents/Emblems/EmblemUpload.h, ...
Batch #1488 by ragnarok-clanker: 0 byte-identical, 5 confirmed by peer review.

- fn_18386 PacketLengths::IsRecorded: logic confirmed by peer review
- fn_18387 PacketLengths::Initialize: logic confirmed by peer review
- fn_18388 PacketLengths::Lookup: logic confirmed by peer review
- fn_20391 PacketLengths::FixedLength: logic confirmed by peer review
- fn_18171 ResourceFailures::Report: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 16:45:10 +00:00
ragnarok-clanker
16b72c624f Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ...
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 15:32:17 +00:00
ragnarok-clanker
447fa8b9f6 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ...
Batch #1470 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23590 IsVisibleJob: logic confirmed by peer review
- fn_23841 GetWeaponViewValue: logic confirmed by peer review
- fn_23906 ResetHotkeySlots: logic confirmed by peer review
- fn_23910 CSession::SetPairValue: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 14:13:00 +00:00
ragnarok-clanker
c351db5d57 Decompile 4 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h
Batch #1467 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23466 CSession::GetServerTime: logic confirmed by peer review
- fn_23605 CSession::AddPingSample: logic confirmed by peer review
- fn_23637 CSession::SetServerTime: logic confirmed by peer review
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/ClientTiming.cpp
2026-10-28 14:02:41 +00:00
ragnarok-clanker
b9474e7c82 Decompile fn_23379 (CSession::HomunSkillLevel)
Batch #1465 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23379 CSession::HomunSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 13:55:33 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ...
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
2026-10-28 12:59:53 +00:00
ragnarok-clanker
4595841b32 Decompile fn_17789 (TextInputBuffer::AdvanceCursor)
Batch #1387 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17789 TextInputBuffer::AdvanceCursor: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:36:28 +00:00
ragnarok-clanker
26ff979bde Decompile 3 functions in Source/UI/Window/UIWindow.cpp, Source/Client/Mode/CGameMode.h, ...
Batch #1400 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_03560 UIWindow::Slot44: logic confirmed by peer review
- fn_03565 CGameMode::MapName: logic confirmed by peer review
- fn_03568 UINavigationV4Wnd::IsListShown: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:35:57 +00:00
ragnarok-clanker
ee280b667b Decompile fn_23401 (CSession::MercSkillLevel)
Batch #1324 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23401 CSession::MercSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 12:06:46 +00:00
ragnarok-clanker
648ae44d9d Decompile 2 functions in Source/Contents/AdventureGuideMgr.cpp, Source/Contents/AdventureGuideMgr.h, ...
Batch #1377 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05237 CAdventureGuideMgr::GetEpisodeList: logic confirmed by peer review
- fn_05238 CAdventureGuideMgr::GetContentsList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:06:16 +00:00
ragnarok-clanker
e541c278b4 Decompile fn_17786 (TextInputBuffer::SetFlag8C)
Batch #1372 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17786 TextInputBuffer::SetFlag8C: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:44:54 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems)
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
2026-10-28 11:42:30 +00:00
ragnarok-clanker
0880609085 Decompile fn_17827 (ShowErrorDialog)
Batch #1352 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17827 ShowErrorDialog: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 11:06:57 +00:00
ragnarok-clanker
241c913563 Decompile fn_17790 (TextInputBuffer::RetreatCursor)
Batch #1343 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_17790 TextInputBuffer::RetreatCursor: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 11:01:42 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
92886d28ca Decompile 2 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1329 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23633 CSession::ClearItemSelection: logic confirmed by peer review
- fn_17254 UIWindowMgr::NotifyMode: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 10:30:24 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
308cefc066 Decompile fn_23826 (CSession::SyncUnknown0E98)
Batch #1325 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23826 CSession::SyncUnknown0E98: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:10:19 +00:00
ragnarok-clanker
097ad1eee0 Maintenance: Add data-only CGameMode and CView layout headers (no methods; worker versions declared 6-7 methods with no definitions).
Batch #1320 by ragnarok-clanker: no function's compiled code changes; checked with 0 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Contents/Camera/Camera.h.
2026-10-28 09:47:03 +00:00
ragnarok-clanker
967adbbc52 Decompile 2 functions in Source/Client/Mode/ActiveGameMode.cpp
Batch #1293 by ragnarok-clanker: 2 byte-identical, 0 confirmed by peer review.

- fn_17836 CMode::End: byte-identical
- fn_17837 CMode::Initialize: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 06:32:11 +00:00
ragnarok-clanker
79a9d02fdd Decompile fn_19305 (ReplaySection::Clear)
Batch #1254 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19305 ReplaySection::Clear: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 23:25:36 +00:00
ragnarok-clanker
d7cf6f94ac Decompile fn_19301 (ReplayCachedPacket::ReplayCachedPacket)
Batch #1253 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19301 ReplayCachedPacket::ReplayCachedPacket: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 23:25:26 +00:00
ragnarok-clanker
c71e8bb7c9 Decompile fn_19334 (Replay::SetBaseFrame)
Batch #1242 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19334 Replay::SetBaseFrame: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 22:54:52 +00:00
ragnarok-clanker
7f5dfda450 Decompile fn_19335 (Replay::UpdateDuration)
Batch #1241 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19335 Replay::UpdateDuration: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-27 22:54:34 +00:00
ragnarok-clanker
297c30c825 Decompile 4 functions in Source/Client/Browser/BrowserClientSite.cpp
Batch #1235 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_17335 CCmdTargetEx::CCmdTargetEx: logic confirmed by peer review
- fn_17336 CIDispatchEx::CIDispatchEx: logic confirmed by peer review
- fn_17337 CIDocHostUIHandlerEx::CIDocHostUIHandlerEx: logic confirmed by peer review
- fn_17338 CIOleInPlaceFrameEx::CIOleInPlaceFrameEx: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 22:53:38 +00:00
ragnarok-clanker
1166cbf0fd Decompile fn_17774 (SubACDD10)
Batch #1239 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_17774 SubACDD10: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 22:51:21 +00:00
ragnarok-clanker
d7bd31b4a6 Decompile 5 functions in Source/Contents/PetStatus.cpp, Source/Client/Session.h
Batch #1190 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_23806 CSession::GetPetActionNumber: logic confirmed by peer review
- fn_23808 CSession::GetPetFriendlyState: logic confirmed by peer review
- fn_23809 CSession::GetPetFriendlyStateString: logic confirmed by peer review
- fn_23810 CSession::GetPetHungryState: logic confirmed by peer review
- fn_23817 CSession::GetPetEmotionNumber: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStatus.cpp
2026-10-27 21:08:12 +00:00
ragnarok-clanker
22ebefe099 Decompile 4 functions in Source/Contents/PetStrings.cpp, Source/Client/Session.h
Batch #1192 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23807 CSession::GetPetFood: logic confirmed by peer review
- fn_23812 CSession::GetPetIllustName: logic confirmed by peer review
- fn_23813 CSession::GetPetJobByEggItem: logic confirmed by peer review
- fn_23816 CSession::GetPetString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStrings.cpp
2026-10-27 21:07:55 +00:00
ragnarok-clanker
ab4477de24 Decompile 7 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h
Batch #1179 by eAthena: 7 byte-identical, 0 confirmed by peer review.

- fn_23754 CSession::ClearItemQuantities: byte-identical
- fn_23755 CSession::ResetItems3500: byte-identical
- fn_23756 CSession::ClearSlots06EB: byte-identical
- fn_23757 CSession::ClearShortcutSlots: byte-identical
- fn_23758 CSession::ClearSecondaryShortcutSlots: byte-identical
- fn_23759 CSession::ClearUnknown0420: byte-identical
- fn_23774 CSession::CountItems5C68: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:58:12 +00:00
ragnarok-clanker
7b701e5bc4 Decompile fn_19333 (Replay::WriteFinalSection)
Batch #1155 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_19333 Replay::WriteFinalSection: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:40:03 +00:00
ragnarok-clanker
5bc5660a42 ♻️ refactor(replay): replaced magic packet IDs with named constants and added replay record options
(cherry picked from commit 22cea43ea3)
2026-10-27 14:43:03 +00:00