Commit graph

11 commits

Author SHA1 Message Date
ragnarok-clanker
854a0e32fb Maintenance: Name numeric switch case labels with enum constants (identifier-only; no code change). 13,500+ case labels across 70 uni
Batch #14886 by ragnarok-clanker: no function's compiled code changes; checked with 225 compiled unit(s), including every includer of Source/Contents/Combat/CombatTypes.h, Source/Contents/Effects/EffectMessageId.h, Source/Contents/Items/InventoryType.h, Source/Contents/Items/ItemId.h, Source/Contents/Jobs/JobId.h, Source/Contents/MessageTable.h, Source/Contents/Skills/SkillId.h, Source/Contents/Skills/SkillUnitId.h, Source/Network/Packets/ModeResultEnums.h, Source/Network/Packets/NoticeEnums.h, Source/Network/Packets/PacketId.h, Source/UI/GameSettings/TalkType.h, Source/UI/Window/WindowId.h.
2026-11-07 23:58:37 +00:00
ragnarok-clanker
64e08b8a89 Decompile 2 functions in Source/Contents/HeadResources.cpp, Source/Contents/RobeResources.cpp
Batch #14315 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_19750 EquipmentResourceMgr::GetHeadPalName: logic confirmed by peer review
- fn_19757 EquipmentResourceMgr::GetShieldResourceName: logic confirmed by peer review

Peer-reviewed-by: secret, KWDev, StrawberrysherbetIX
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-07 07:11:28 +00:00
ragnarok-clanker
225db9ad24 Decompile fn_23374 (CSession::GetPlayerHeadActName)
Batch #13644 by SapitoSucio: 1 byte-identical, 0 confirmed by peer review.

- fn_23374 CSession::GetPlayerHeadActName: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-06 21:04:14 +00:00
ragnarok-clanker
826eb4319f Decompile fn_23336 (CSession::NormalizeHead)
Batch #13120 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_23336 CSession::NormalizeHead: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Toshiro, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-06 05:39:32 +00:00
ragnarok-clanker
d2c7bc368e Decompile fn_23397 (CSession::GetBodySprName)
Batch #6397 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23397 CSession::GetBodySprName: logic confirmed by peer review

Peer-reviewed-by: Lumen, superintelligence, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-31 00:48:23 +00:00
ragnarok-clanker
1f664e3a48 Decompile fn_23378 (CSession::GetPlayerHeadSprName)
Batch #3745 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23378 CSession::GetPlayerHeadSprName: logic confirmed by peer review

Peer-reviewed-by: eAthena, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 23:20:08 +00:00
ragnarok-clanker
1c14776d3d Decompile fn_23380 (CSession::GetImfName)
Batch #3746 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23380 CSession::GetImfName: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 23:14:23 +00:00
ragnarok-clanker
c77bf2f4d8 Decompile fn_23359 (CSession::GetUnknown8134)
Batch #3307 by youko: 1 byte-identical, 0 confirmed by peer review.

- fn_23359 CSession::GetUnknown8134: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-29 21:20:13 +00:00
ragnarok-clanker
e03bf43bd4 Decompile fn_19750 (EquipmentResourceMgr::GetHeadPalName)
Batch #1966 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_19750 EquipmentResourceMgr::GetHeadPalName: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Reviewed-by: ragnarok-clanker
2026-10-29 08:57:31 +00:00
ragnarok-clanker
2d264e43ba Decompile 2 functions in Source/Contents/HeadResources.cpp
Batch #1806 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23393 CSession::GetDisplayJob: logic confirmed by peer review
- fn_23336 CSession::NormalizeHead: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 22:39:25 +00:00
ragnarok-clanker
34541f64a8 Decompile 6 functions in Source/Contents/HeadResources.cpp, Source/Client/Session.h, ...
Batch #1721 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19751 EquipmentResourceMgr::GetHeadName: logic confirmed by peer review
- fn_23373 CSession::GetHeadActName: logic confirmed by peer review
- fn_23374 CSession::GetPlayerHeadActName: logic confirmed by peer review
- fn_23375 CSession::GetHeadPalName: logic confirmed by peer review
- fn_23376 CSession::GetPlayerHeadPalName: logic confirmed by peer review
- fn_23377 CSession::GetHeadSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/HeadResources.cpp
2026-10-28 21:11:05 +00:00