Commit graph

4 commits

Author SHA1 Message Date
ragnarok-clanker
c5802826d4 Decompile 11 functions in Source/Contents/Actors/GameActor.h, Source/Contents/Actors/GraffiSkill.cpp, ...
Batch #5431 by Yommy: 1 byte-identical, 10 confirmed by peer review.

- fn_24290 CEffectMaker::Render: byte-identical
- fn_24291 CGraffiSkill::Render: logic confirmed by peer review
- fn_24292 CGroundScope::Render: logic confirmed by peer review
- fn_24293 CMsgEffect::Render: logic confirmed by peer review
- fn_24295 CArrowEffect::SendMsg: logic confirmed by peer review
- fn_24296 CDummyEffectLauncher::SendMsg: logic confirmed by peer review
- fn_24297 CEffectMaker::SendMsg: logic confirmed by peer review
- fn_24298 CGraffiSkill::SendMsg: logic confirmed by peer review
- fn_24299 CGroundScope::SendMsg: logic confirmed by peer review
- fn_24300 CMandraAttackEffect::SendMsg: logic confirmed by peer review
- fn_24301 CMsgEffect::SendMsg: logic confirmed by peer review

Peer-reviewed-by: ntrl, bigodeira, willerthal, Snow, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 13:56:17 +00:00
ragnarok-clanker
05be22bdcf Decompile 22 functions in Source/Client/Session.h, Source/Contents/Actors/GroundScope.cpp, ...
Batch #4990 by youko: 3 byte-identical, 19 confirmed by peer review.

- fn_24228 ReadMessengerMembers: logic confirmed by peer review
- fn_24229 ReadItemList: logic confirmed by peer review
- fn_24230 ReadItemArray: logic confirmed by peer review
- fn_24232 CSession::SetUnknown5BC0: logic confirmed by peer review
- fn_24236 MessengerMember::Deserialize: logic confirmed by peer review
- fn_24247 ClientItemLists::SetItems1750: logic confirmed by peer review
- fn_24249 AppendBytes: logic confirmed by peer review
- fn_24258 CMsgEffect::~CMsgEffect: logic confirmed by peer review
- fn_24259 CSkill::~CSkill: logic confirmed by peer review
- fn_24267 CGroundScope::SkillScopeType: logic confirmed by peer review
- fn_24268 CSkill::GetTrapModelName: logic confirmed by peer review
- fn_24269 CSkill::ReleaseModel: logic confirmed by peer review
- fn_24270 CMsgEffect::UsesMsgEffect: logic confirmed by peer review
- fn_24275 CGraffiSkill::ReleaseTexture: byte-identical
- fn_24277 CArrowEffect::Reset: logic confirmed by peer review
- fn_24278 CEffectMaker::Reset: byte-identical
- fn_24279 CGraffiSkill::BuildTexture: logic confirmed by peer review
- fn_24280 CArrowEffect::OnProcess: logic confirmed by peer review
- fn_24281 CDummyEffectLauncher::OnProcess: logic confirmed by peer review
- fn_24282 CEffectMaker::OnProcess: logic confirmed by peer review
- fn_24283 CGraffiSkill::OnProcess: byte-identical
- fn_24285 CMandraAttackEffect::OnProcess: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Actors/GraffiSkill.cpp, Source/Contents/Effects/ArrowEffect.cpp, Source/Contents/Effects/DummyEffectLauncher.cpp, Source/Contents/Effects/MandraAttackEffect.cpp, Source/Contents/Effects/MsgEffect.cpp
2026-10-30 06:43:59 +00:00
ragnarok-clanker
e4be8f4190 Decompile 18 functions in Source/Client/Application/UnhandledExceptionHandler.cpp, Source/Client/Session.h, ...
Batch #2077 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.

- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review (already on main)
- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_09315 UIRequestJoinPartyWnd::SendMsg: logic confirmed by peer review
- fn_19761 EffectParticle::EffectParticle: logic confirmed by peer review
- fn_19768 EffectParticle::InitializeRecords: logic confirmed by peer review
- fn_20007 AttachedEffect::AttachedEffect: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20991 CRenderObject::CRenderObject: logic confirmed by peer review
- fn_21069 ?CreatePartyEffect@?A0xba063134@@YAPAUAttachedEffect@@AAUEffectActor@@AAUPartyEffectMode@@@Z: logic confirmed by peer review
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_23396 CSession::GetJobName: logic confirmed by peer review
- fn_23495 CSession::InitJobNameTable: logic confirmed by peer review
- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_20987 EffectActor::EffectActor: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 09:48:08 +00:00
ragnarok-clanker
6ffc82d2d0 Decompile fn_24251 (CEffectMaker::CEffectMaker)
Batch #1563 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/Effects/EffectMaker.cpp
2026-10-28 19:10:23 +00:00