Commit graph

5 commits

Author SHA1 Message Date
ragnarok-clanker
2dde3611dd Decompile fn_07447 (CShowEffect::Close)
Batch #15724 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_07447 CShowEffect::Close: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-10 09:32:01 +00:00
ragnarok-clanker
1ce26069f6 Decompile fn_07446 (CShowEffect::Add)
Batch #14966 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_07446 CShowEffect::Add: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, ntrl, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-09 11:53:35 +00:00
ragnarok-clanker
780c281aa2 Maintenance: Name window messaging constants: literal window ids (LookupWindow/EnsureWindow/CloseWindow/... -> WindowId), UIWindowMgr
Batch #14937 by ragnarok-clanker: no function's compiled code changes; checked with 251 compiled unit(s), including every includer of Source/Client/Mode/ModeMessage.h, Source/Contents/Actors/ActorEnums.h, Source/Network/Packets/PartyJoinPacket.h, Source/UI/Window/UIEnums.h, Source/UI/Window/WindowId.h.
2026-11-08 13:56:42 +00:00
ragnarok-clanker
6ff177839d Decompile 2 functions in Source/Contents/Effects/ShowEffect.cpp
Batch #11367 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_07447 CShowEffect::Close: logic confirmed by peer review
- fn_07449 CShowEffect::Remove: logic confirmed by peer review

Peer-reviewed-by: Yommy, kyoshi, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-04 23:39:22 +00:00
ragnarok-clanker
15bf92aa77 Decompile 5 functions in Source/Contents/Effects/ShowEffect.cpp, Source/Contents/Effects/ShowEffect.h
Batch #5940 by ntrl: 1 byte-identical, 4 confirmed by peer review.

- fn_07441 CShowEffect::CShowEffect: logic confirmed by peer review
- fn_07446 CShowEffect::Add: logic confirmed by peer review
- fn_07447 CShowEffect::Close: logic confirmed by peer review
- fn_07448 CShowEffect::Count: byte-identical
- fn_07449 CShowEffect::Remove: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, superintelligence, Snow, KWDev
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Effects/ShowEffect.cpp
2026-10-30 17:57:20 +00:00