Commit graph

8 commits

Author SHA1 Message Date
ragnarok-clanker
3f8411389e Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13406 by ragnarok-clanker: no function's compiled code changes; checked with 124 compiled unit(s), including every includer of Source/Contents/Effects/RagEffect.h, Source/Contents/Effects/PowderingEffect.h, Source/Contents/Effects/SpriteParticle.h, Source/UI/Enchant/EnchantUI.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/Contents/Actors/Skill.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/Contents/Effects/HealEffect.h, Source/Contents/AchievementMgr.h, Source/UI/Window/UISecondCostumeWnd.h, Source/Contents/Effects/LightSphereEffect.h, Source/Contents/Effects/BlastForge.h, Source/Security/NProtectGameGuardMgr.h, Source/Contents/Effects/MapChainEffect.h, Source/Utility/Math/Int64Math.h.
2026-11-06 16:08:47 +00:00
ragnarok-clanker
802f7e26fa Decompile 3 functions in Source/Contents/Effects/PowderingEffect.cpp, Source/Contents/Effects/PowderingEffect.h
Batch #12153 by cremane: 0 byte-identical, 3 confirmed by peer review.

- fn_07089 CPowderingEffect::Slot01: logic confirmed by peer review
- fn_07090 CPowderingEffect::sub_709570: logic confirmed by peer review
- fn_07094 CPowderingEffect::Slot03: logic confirmed by peer review

Peer-reviewed-by: Yommy, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-11-05 14:42:36 +00:00
ragnarok-clanker
3b9a060674 Decompile fn_07095 (CPowderingEffect::Slot04)
Batch #12156 by cremane: 1 byte-identical, 0 confirmed by peer review.

- fn_07095 CPowderingEffect::Slot04: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-11-05 11:55:26 +00:00
ragnarok-clanker
22c2951e3b Decompile 2 functions in Source/Contents/Effects/PowderingEffect.cpp, Source/Contents/Effects/PowderingEffect.h
Batch #5032 by Lumen: 0 byte-identical, 2 confirmed by peer review.

- fn_07092 CPowderingEffect::sub_7096B0: logic confirmed by peer review
- fn_07094 CPowderingEffect::Slot03: logic confirmed by peer review

Peer-reviewed-by: Yommy, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 07:06:20 +00:00
ragnarok-clanker
0793f4d8af Decompile 2 functions in Source/Contents/Effects/PowderingEffect.cpp, Source/Contents/Effects/PowderingEffect.h
Batch #4717 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_07093 CPowderingEffect::Slot06: logic confirmed by peer review
- fn_07095 CPowderingEffect::Slot04: logic confirmed by peer review

Peer-reviewed-by: alisonrag, youko
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 04:41:22 +00:00
ragnarok-clanker
e5e355cc70 Decompile 3 functions in Source/Contents/Effects/PowderingEffect.cpp, Source/Contents/Effects/PowderingEffect.h
Batch #4562 by Lumen: 1 byte-identical, 2 confirmed by peer review.

- fn_07088 CPowderingEffect::Close: byte-identical
- fn_07089 CPowderingEffect::Slot01: logic confirmed by peer review
- fn_07090 CPowderingEffect::sub_709570: logic confirmed by peer review

Peer-reviewed-by: eAthena, willerthal, Snow
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 03:48:08 +00:00
ragnarok-clanker
5ec6770e2b Decompile 9 functions in Source/Contents/Effects/ClimaxEffect.cpp, Source/Contents/Effects/ClimaxEffect.h, ...
Batch #3164 by youko: 0 byte-identical, 9 confirmed by peer review.

- fn_07040 CJupitelThunderStormEffect::CJupitelThunderStormEffect: logic confirmed by peer review (annotation added to existing code)
- fn_07047 CClimaxEffect::CClimaxEffect: logic confirmed by peer review (annotation added to existing code)
- fn_07070 CNyanggrassEffect::CNyanggrassEffect: logic confirmed by peer review (annotation added to existing code)
- fn_07077 CCompetentia::CCompetentia: logic confirmed by peer review (annotation added to existing code)
- fn_07085 CPowderingEffect::CPowderingEffect: logic confirmed by peer review (annotation added to existing code)
- fn_07091 CPowderingEffect::Slot12: logic confirmed by peer review (annotation added to existing code)
- fn_07096 CRectUpEffect::CRectUpEffect: logic confirmed by peer review (annotation added to existing code)
- fn_07100 CRectUpEffect::Slot12: logic confirmed by peer review (annotation added to existing code)
- fn_07106 CCresciveBolt::CCresciveBolt: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: eAthena, meitogi
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-29 21:14:21 +00:00
ragnarok-clanker
de30fb0fcd Decompile 2 functions in Source/Contents/Effects/ClimaxEffect.cpp, Source/Contents/Effects/ClimaxEffect.h, ...
Batch #3177 by youko: 2 byte-identical, 0 confirmed by peer review.

- fn_07057 CMeteorEffect::Slot06: byte-identical
- fn_07081 CCompetentia::Slot06: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/Effects/ClimaxEffect.cpp, Source/Contents/Effects/Competentia.cpp, Source/Contents/Effects/CresciveBolt.cpp, Source/Contents/Effects/JupitelThunderStormEffect.cpp, Source/Contents/Effects/MeteorEffect.cpp, Source/Contents/Effects/NyanggrassEffect.cpp, Source/Contents/Effects/PowderingEffect.cpp, Source/Contents/Effects/RectUpEffect.cpp
2026-10-29 20:43:19 +00:00