Commit graph

4 commits

Author SHA1 Message Date
ragnarok-clanker
f8d3e8622d Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
2026-11-06 16:30:12 +00:00
ragnarok-clanker
48f165ab21 Decompile fn_04723 (CEmotionSaleExpireSchedule::Process)
Batch #6291 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_04723 CEmotionSaleExpireSchedule::Process: logic confirmed by peer review

Peer-reviewed-by: alisonrag, Romain, SapitoSucio
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 21:38:47 +00:00
ragnarok-clanker
3288cd4862 Decompile 2 functions in Source/Contents/Schedule/EmotionSchedule.cpp, Source/Contents/CashEmotionMgr.h
Batch #4914 by Millenium: 0 byte-identical, 2 confirmed by peer review.

- fn_04717 CEmotionPurchaseExpireSchedule::Process: logic confirmed by peer review
- fn_04720 CEmotionPurchaseUseableTimeUISchedule::Process: logic confirmed by peer review

Peer-reviewed-by: youko, Lumen
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-30 06:09:50 +00:00
ragnarok-clanker
4813b73e91 Decompile 6 functions in Source/Contents/Schedule/CaptchaUploadSchedule.cpp, Source/Contents/Schedule/CaptchaUploadSchedule.h, ...
Batch #4629 by gordaoprogramas: 0 byte-identical, 6 confirmed by peer review.

- fn_04710 CCaptchaUploadSchedule::CCaptchaUploadSchedule: logic confirmed by peer review
- fn_04711 CSchedule::~CSchedule: logic confirmed by peer review
- fn_04714 CCaptchaUploadSchedule::Process: logic confirmed by peer review
- fn_04715 CEmotionPurchaseExpireSchedule::CEmotionPurchaseExpireSchedule: logic confirmed by peer review
- fn_04718 CEmotionPurchaseUseableTimeUISchedule::CEmotionPurchaseUseableTimeUISchedule: logic confirmed by peer review
- fn_04721 CEmotionSaleExpireSchedule::CEmotionSaleExpireSchedule: logic confirmed by peer review

Peer-reviewed-by: youko, Millenium, Qwenkler3.8, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/Schedule/CaptchaUploadSchedule.cpp, Source/Contents/Schedule/EmotionSchedule.cpp
2026-10-30 04:15:57 +00:00